Richard Spiegel has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/28033 )
Change subject: vendorcode/amd/pi/00670F00/Lib: Validate AccessWidth
......................................................................
Abandoned
This lib has been removed by other CL.
--
To view, visit https://review.coreboot.org/c/coreboot/+/28033
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic54e0010ad5dbb1f87221357b919cf680cb3d84c
Gerrit-Change-Number: 28033
Gerrit-PatchSet: 1
Gerrit-Owner: Richard Spiegel <richard.spiegel(a)silverbackltd.com>
Gerrit-CC: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-MessageType: abandon
Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/28033 )
Change subject: vendorcode/amd/pi/00670F00/Lib: Validate AccessWidth
......................................................................
Patch Set 1:
This PS is out of date now.
--
To view, visit https://review.coreboot.org/c/coreboot/+/28033
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic54e0010ad5dbb1f87221357b919cf680cb3d84c
Gerrit-Change-Number: 28033
Gerrit-PatchSet: 1
Gerrit-Owner: Richard Spiegel <richard.spiegel(a)silverbackltd.com>
Gerrit-CC: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Comment-Date: Tue, 27 Nov 2018 19:08:37 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Richard Spiegel has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/29870
Change subject: mb/google/kahlee: Modify Kconfig for aleena
......................................................................
mb/google/kahlee: Modify Kconfig for aleena
The aleena board uses a display that's not compatible with current VBIOS.
A VBIOS specific for aleena has been merged into blobs, so modify Kconfig
so that it loads the new VBIOS when building aleena, but load original VBIOS
for all other boards under kahlee folder.
BUG=b:112618193
TEST=Build each board under kahlee, one at a time. After each build, opened
build/config.h and searched VGA_BIOS_FILE to verify that the string only
changed for aleena, all other boards remained with original string.
Change-Id: Iccd0853692680908d951edd142a2d8e13a561391
Signed-off-by: Richard Spiegel <richard.spiegel(a)silverbackltd.com>
---
M src/mainboard/google/kahlee/Kconfig
1 file changed, 8 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/70/29870/1
diff --git a/src/mainboard/google/kahlee/Kconfig b/src/mainboard/google/kahlee/Kconfig
index a8592b2..c1a63df 100644
--- a/src/mainboard/google/kahlee/Kconfig
+++ b/src/mainboard/google/kahlee/Kconfig
@@ -52,6 +52,14 @@
string
default google/kahlee
+if BOARD_GOOGLE_ALEENA
+
+config VGA_BIOS_FILE
+ string
+ default "3rdparty/blobs/mainboard/google/kahlee/aleena/VBIOS_015_049_000_018.bin"
+
+endif
+
config VGA_BIOS_FILE
string
default "3rdparty/blobs/mainboard/google/kahlee/VBIOS_015_049_000_017.bin"
--
To view, visit https://review.coreboot.org/c/coreboot/+/29870
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iccd0853692680908d951edd142a2d8e13a561391
Gerrit-Change-Number: 29870
Gerrit-PatchSet: 1
Gerrit-Owner: Richard Spiegel <richard.spiegel(a)silverbackltd.com>
Gerrit-MessageType: newchange
Richard Spiegel has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/29869
Change subject: 3rdparty/blobs: Add new blob
......................................................................
3rdparty/blobs: Add new blob
New VBIOS code has been added to blobs/mainboard/google/kahlee. It has been
merged, so now coreboot needs to use latest blob.
BUG=b:112618193
TEST=none
Change-Id: If430ee06f03e0f20806bf8fd2b649814251ffcf5
Signed-off-by: Richard Spiegel <richard.spiegel(a)silverbackltd.com>
---
M 3rdparty/blobs
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/29869/1
diff --git a/3rdparty/blobs b/3rdparty/blobs
index dd00ad1..be390ff 160000
--- a/3rdparty/blobs
+++ b/3rdparty/blobs
@@ -1 +1 @@
-Subproject commit dd00ad1260ef1dc0ba8c55c06ab10c7639dc3eb1
+Subproject commit be390ffb5b2cce76a563f4516c58a49f1af90229
--
To view, visit https://review.coreboot.org/c/coreboot/+/29869
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If430ee06f03e0f20806bf8fd2b649814251ffcf5
Gerrit-Change-Number: 29869
Gerrit-PatchSet: 1
Gerrit-Owner: Richard Spiegel <richard.spiegel(a)silverbackltd.com>
Gerrit-MessageType: newchange
Hello Patrick Rudolph, Philipp Deppenwiese, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/29868
to look at the new patch set (#2).
Change subject: src/drivers: Remove duplicated '&' on ptr's function
......................................................................
src/drivers: Remove duplicated '&' on ptr's function
Change-Id: I7a99d0dcbc8ea1362a12a68fa519c49058d30a05
Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr>
---
M src/drivers/generic/adau7002/adau7002.c
M src/drivers/generic/generic/generic.c
M src/drivers/generic/gpio_keys/gpio_keys.c
M src/drivers/generic/gpio_regulator/gpio_regulator.c
M src/drivers/generic/max98357a/max98357a.c
M src/drivers/i2c/da7219/da7219.c
M src/drivers/i2c/generic/generic.c
M src/drivers/i2c/hid/hid.c
M src/drivers/i2c/max98373/max98373.c
M src/drivers/i2c/max98927/max98927.c
M src/drivers/i2c/nau8825/nau8825.c
M src/drivers/i2c/rt5663/rt5663.c
M src/drivers/i2c/sx9310/sx9310.c
M src/drivers/i2c/tpm/chip.c
M src/drivers/intel/mipi_camera/camera.c
M src/drivers/intel/wifi/wifi.c
M src/drivers/lenovo/hybrid_graphics/hybrid_graphics.c
M src/drivers/net/r8168.c
M src/drivers/pc80/tpm/tis.c
M src/drivers/ricoh/rce822/rce822.c
M src/drivers/spi/acpi/acpi.c
M src/drivers/usb/acpi/usb_acpi.c
22 files changed, 62 insertions(+), 62 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/68/29868/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/29868
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7a99d0dcbc8ea1362a12a68fa519c49058d30a05
Gerrit-Change-Number: 29868
Gerrit-PatchSet: 2
Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr>
Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-MessageType: newpatchset
Hello Patrick Rudolph, David Guckian, Vanessa Eusebio, York Yang, Philipp Deppenwiese, build bot (Jenkins), David Guckian,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/29862
to look at the new patch set (#6).
Change subject: soc/{amd,intel}: Remove duplicated '&' on ptr's function
......................................................................
soc/{amd,intel}: Remove duplicated '&' on ptr's function
Change-Id: I7a59fd2f370d2b0d830ca83be9a9bc1abe2750f5
Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr>
---
M src/soc/amd/stoneyridge/chip.c
M src/soc/intel/apollolake/chip.c
M src/soc/intel/broadwell/adsp.c
M src/soc/intel/broadwell/ehci.c
M src/soc/intel/broadwell/sata.c
M src/soc/intel/broadwell/smbus.c
M src/soc/intel/broadwell/systemagent.c
M src/soc/intel/broadwell/xhci.c
M src/soc/intel/common/block/dsp/dsp.c
M src/soc/intel/common/block/hda/hda.c
M src/soc/intel/common/block/i2c/i2c.c
M src/soc/intel/common/block/pmc/pmc.c
M src/soc/intel/common/block/sata/sata.c
M src/soc/intel/common/block/scs/sd.c
M src/soc/intel/common/block/smbus/smbus.c
M src/soc/intel/common/block/spi/spi.c
M src/soc/intel/common/block/systemagent/systemagent.c
M src/soc/intel/common/block/uart/uart.c
M src/soc/intel/common/block/xdci/xdci.c
M src/soc/intel/common/block/xhci/xhci.c
M src/soc/intel/denverton_ns/chip.c
M src/soc/intel/denverton_ns/systemagent.c
M src/soc/intel/fsp_broadwell_de/smbus.c
M src/soc/intel/quark/lpc.c
M src/soc/intel/quark/northcluster.c
M src/soc/intel/quark/uart.c
26 files changed, 106 insertions(+), 106 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/62/29862/6
--
To view, visit https://review.coreboot.org/c/coreboot/+/29862
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7a59fd2f370d2b0d830ca83be9a9bc1abe2750f5
Gerrit-Change-Number: 29862
Gerrit-PatchSet: 6
Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr>
Gerrit-Reviewer: David Guckian
Gerrit-Reviewer: David Guckian <david.guckian(a)intel.com>
Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com>
Gerrit-Reviewer: Vanessa Eusebio <vanessa.f.eusebio(a)intel.com>
Gerrit-Reviewer: York Yang <york.yang(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-MessageType: newpatchset
Hello Patrick Rudolph, David Guckian, Vanessa Eusebio, build bot (Jenkins), David Guckian,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/29862
to look at the new patch set (#5).
Change subject: soc/{amd,intel}: Remove duplicated '&' on ptr's function
......................................................................
soc/{amd,intel}: Remove duplicated '&' on ptr's function
Change-Id: I7a59fd2f370d2b0d830ca83be9a9bc1abe2750f5
Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr>
---
M src/soc/amd/stoneyridge/chip.c
M src/soc/intel/apollolake/chip.c
M src/soc/intel/broadwell/adsp.c
M src/soc/intel/broadwell/ehci.c
M src/soc/intel/broadwell/sata.c
M src/soc/intel/broadwell/smbus.c
M src/soc/intel/broadwell/systemagent.c
M src/soc/intel/broadwell/xhci.c
M src/soc/intel/common/block/dsp/dsp.c
M src/soc/intel/common/block/hda/hda.c
M src/soc/intel/common/block/i2c/i2c.c
M src/soc/intel/common/block/pmc/pmc.c
M src/soc/intel/common/block/sata/sata.c
M src/soc/intel/common/block/scs/sd.c
M src/soc/intel/common/block/smbus/smbus.c
M src/soc/intel/common/block/spi/spi.c
M src/soc/intel/common/block/systemagent/systemagent.c
M src/soc/intel/common/block/uart/uart.c
M src/soc/intel/common/block/xdci/xdci.c
M src/soc/intel/common/block/xhci/xhci.c
M src/soc/intel/denverton_ns/chip.c
M src/soc/intel/denverton_ns/systemagent.c
M src/soc/intel/fsp_broadwell_de/smbus.c
M src/soc/intel/quark/lpc.c
M src/soc/intel/quark/northcluster.c
M src/soc/intel/quark/uart.c
26 files changed, 108 insertions(+), 108 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/62/29862/5
--
To view, visit https://review.coreboot.org/c/coreboot/+/29862
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7a59fd2f370d2b0d830ca83be9a9bc1abe2750f5
Gerrit-Change-Number: 29862
Gerrit-PatchSet: 5
Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr>
Gerrit-Reviewer: David Guckian
Gerrit-Reviewer: David Guckian <david.guckian(a)intel.com>
Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Vanessa Eusebio <vanessa.f.eusebio(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-MessageType: newpatchset
Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29863 )
Change subject: cpu/intel/fit: Make FIT microcode updates selectable
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/29863/2//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/29863/2//COMMIT_MSG@7
PS2, Line 7: Make FIT microcode updates selectable
> What is the rationale behind this?
Support for more FIT features like Boot Guard and TXT
--
To view, visit https://review.coreboot.org/c/coreboot/+/29863
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7da926943aef89e49e98d0b990ab46f5f8200e6e
Gerrit-Change-Number: 29863
Gerrit-PatchSet: 2
Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Comment-Date: Tue, 27 Nov 2018 14:47:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-MessageType: comment