coreboot-gerrit November 2018

coreboot-gerrit@coreboot.org

1 participants
1699 discussions

Change in ...coreboot[master]: siemens/mc_apl5: Enable SDCARD
by Mario Scheithauer (Code Review) 28 Nov '18

28 Nov '18

Mario Scheithauer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/29879 Change subject: siemens/mc_apl5: Enable SDCARD ...................................................................... siemens/mc_apl5: Enable SDCARD This mainboard also has a SD slot. Change-Id: I969e8ecb27aee4c8be212e67dfe6bd807ecd3b2f Signed-off-by: Mario Scheithauer <mario.scheithauer(a)siemens.com> --- M src/mainboard/siemens/mc_apl1/variants/mc_apl5/devicetree.cb 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/79/29879/1 diff --git a/src/mainboard/siemens/mc_apl1/variants/mc_apl5/devicetree.cb b/src/mainboard/siemens/mc_apl1/variants/mc_apl5/devicetree.cb index 7dbeea1..dfdfd55 100644 --- a/src/mainboard/siemens/mc_apl1/variants/mc_apl5/devicetree.cb +++ b/src/mainboard/siemens/mc_apl1/variants/mc_apl5/devicetree.cb @@ -109,7 +109,7 @@ device pci 19.1 off end # - SPI 1 device pci 19.2 off end # - SPI 2 device pci 1a.0 off end # - PWM - device pci 1b.0 off end # - SDCARD + device pci 1b.0 on end # - SDCARD device pci 1c.0 on end # - eMMC device pci 1d.0 off end # - UFS device pci 1e.0 off end # - SDIO -- To view, visit https://review.coreboot.org/c/coreboot/+/29879 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I969e8ecb27aee4c8be212e67dfe6bd807ecd3b2f Gerrit-Change-Number: 29879 Gerrit-PatchSet: 1 Gerrit-Owner: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-MessageType: newchange

1 0

Change in ...coreboot[master]: mb/siemens/mc_{apl1, tcu3}: [test] Fix sizeof on array function
by Werner Zeh (Code Review) 28 Nov '18

28 Nov '18

Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29858 ) Change subject: mb/siemens/mc_{apl1,tcu3}: [test] Fix sizeof on array function ...................................................................... Patch Set 1: Code-Review-1 (1 comment) https://review.coreboot.org/#/c/29858/1/src/mainboard/siemens/mc_apl1/romst… File src/mainboard/siemens/mc_apl1/romstage.c: https://review.coreboot.org/#/c/29858/1/src/mainboard/siemens/mc_apl1/romst… PS1, Line 51: if (hwilib_get_field(SPD, spd, sizeof(*spd)) != sizeof(*spd)) { Hmmm..no clue what you are after. What I need here is the size of the whole array spd in bytes. And this is what I get with the current code (sizeof(spd)). Your change would provide the size of the first element of the array which would be 1 byte. And this is not what I need here. What is your motivation for suggesting this change? -- To view, visit https://review.coreboot.org/c/coreboot/+/29858 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I982a7a9baf22998503da0e94952fbb30124dfe28 Gerrit-Change-Number: 29858 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 28 Nov 2018 07:07:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: arch/x86/Makefile.inc: Fix typo
by Patrick Rudolph (Code Review) 28 Nov '18

28 Nov '18

Hello Patrick Georgi, Martin Roth, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/29878 to look at the new patch set (#2). Change subject: arch/x86/Makefile.inc: Fix typo ...................................................................... arch/x86/Makefile.inc: Fix typo Link 32bit ramstage if CONFIG_ARCH_RAMSTAGE_X86_32 is set. Required for 64bit ramstage support. Change-Id: Ib0c06f494dcc035d182ab9034e910ceceb236198 Signed-off-by: Patrick Rudolph <siro(a)das-labor.org> --- M src/arch/x86/Makefile.inc 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/29878/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/29878 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib0c06f494dcc035d182ab9034e910ceceb236198 Gerrit-Change-Number: 29878 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in ...coreboot[master]: util/xcompile/xcompile: Enable x86_64 support
by Patrick Rudolph (Code Review) 28 Nov '18

28 Nov '18

Hello Patrick Georgi, Martin Roth, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/29877 to look at the new patch set (#2). Change subject: util/xcompile/xcompile: Enable x86_64 support ...................................................................... util/xcompile/xcompile: Enable x86_64 support Compile for nocona on x86_64. Required for 64bit support. Change-Id: Ied28f98f89610a748be8d66cf35814e9112a4407 Signed-off-by: Patrick Rudolph <siro(a)das-labor.org> --- M util/xcompile/xcompile 1 file changed, 7 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/77/29877/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/29877 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ied28f98f89610a748be8d66cf35814e9112a4407 Gerrit-Change-Number: 29877 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in ...coreboot[master]: cpu/x86/pae: Fix pointer casts
by Patrick Rudolph (Code Review) 28 Nov '18

28 Nov '18

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/29876 to look at the new patch set (#2). Change subject: cpu/x86/pae: Fix pointer casts ...................................................................... cpu/x86/pae: Fix pointer casts Required to compile the code in x86_64, even though it's never used. Change-Id: I2be8ad8805804e4da52bdb02ab43cb833402f999 Signed-off-by: Patrick Rudolph <siro(a)das-labor.org> --- M src/cpu/x86/pae/pgtbl.c 1 file changed, 4 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/76/29876/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/29876 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2be8ad8805804e4da52bdb02ab43cb833402f999 Gerrit-Change-Number: 29876 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in ...coreboot[master]: sb/intel: Fix pointer casts
by Patrick Rudolph (Code Review) 28 Nov '18

28 Nov '18

Hello Arthur Heymans, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/29875 to look at the new patch set (#2). Change subject: sb/intel: Fix pointer casts ...................................................................... sb/intel: Fix pointer casts Fix some compiler warnings due to pointer to integer conversions with different size. Required for 64bit ramstage. Change-Id: Ibfb3cacf25adfb4a242d38e4ea290fdc3929a684 Signed-off-by: Patrick Rudolph <siro(a)das-labor.org> --- M src/southbridge/intel/common/smi.c M src/southbridge/intel/i82801ix/hdaudio.c M src/southbridge/intel/i82801ix/lpc.c M src/southbridge/intel/i82801ix/sata.c 4 files changed, 9 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/75/29875/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/29875 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibfb3cacf25adfb4a242d38e4ea290fdc3929a684 Gerrit-Change-Number: 29875 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-MessageType: newpatchset

1 0

Change in ...coreboot[master]: util/cbfstool: Support AMD64 rmodules
by Patrick Rudolph (Code Review) 28 Nov '18

28 Nov '18

Patrick Rudolph has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/29874 ) Change subject: util/cbfstool: Support AMD64 rmodules ...................................................................... util/cbfstool: Support AMD64 rmodules Add support for 64bit rmodule, as required for relocatable ramstage on x86_64. Change-Id: I7fbb3b4c0f76ce82c090b5f16f67a728b6bf94a5 Signed-off-by: Patrick Rudolph <siro(a)das-labor.org> --- M util/cbfstool/elf.h M util/cbfstool/elfheaders.c M util/cbfstool/rmodule.c 3 files changed, 72 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/74/29874/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/29874 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7fbb3b4c0f76ce82c090b5f16f67a728b6bf94a5 Gerrit-Change-Number: 29874 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-MessageType: newpatchset

1 0

Change in ...coreboot[master]: arch/x86/Makefile.inc: Fix typo
by Patrick Rudolph (Code Review) 28 Nov '18

28 Nov '18

Patrick Rudolph has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/29878 Change subject: arch/x86/Makefile.inc: Fix typo ...................................................................... arch/x86/Makefile.inc: Fix typo Link 32bit ramstage if CONFIG_ARCH_RAMSTAGE_X86_32 is set. Required for 64bit ramstage support. Change-Id: Ib0c06f494dcc035d182ab9034e910ceceb236198 Signed-off-by: Patrick Rudolph <siro(a)das-labor.org> --- M src/arch/x86/Makefile.inc 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/29878/1 diff --git a/src/arch/x86/Makefile.inc b/src/arch/x86/Makefile.inc index fcc57c5..c5cf625 100644 --- a/src/arch/x86/Makefile.inc +++ b/src/arch/x86/Makefile.inc @@ -398,7 +398,7 @@ $(objgenerated)/ramstage.o: $$(ramstage-objs) $(COMPILER_RT_ramstage) $$(ramstage-libs) @printf " CC $(subst $(obj)/,,$(@))\n" -ifeq ($(CONFIG_ARCH_ROMSTAGE_X86_32),y) +ifeq ($(CONFIG_ARCH_RAMSTAGE_X86_32),y) $(LD_ramstage) -m elf_i386 -r -o $@ $(COMPILER_RT_FLAGS_ramstage) --whole-archive --start-group $(filter-out %.ld,$(ramstage-objs)) $(ramstage-libs) --no-whole-archive $(COMPILER_RT_ramstage) --end-group else $(LD_ramstage) -m elf_x86_64 -r -o $@ $(COMPILER_RT_FLAGS_ramstage) --whole-archive --start-group $(filter-out %.ld,$(ramstage-objs)) $(ramstage-libs) --no-whole-archive $(COMPILER_RT_ramstage) --end-group -- To view, visit https://review.coreboot.org/c/coreboot/+/29878 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib0c06f494dcc035d182ab9034e910ceceb236198 Gerrit-Change-Number: 29878 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-MessageType: newchange

1 0

Change in ...coreboot[master]: util/xcompile/xcompile: Enable x86_64 support
by Patrick Rudolph (Code Review) 28 Nov '18

28 Nov '18

Patrick Rudolph has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/29877 Change subject: util/xcompile/xcompile: Enable x86_64 support ...................................................................... util/xcompile/xcompile: Enable x86_64 support Compile for nocona on x86_64. Required for 64bit support. Change-Id: Ied28f98f89610a748be8d66cf35814e9112a4407 Signed-off-by: Patrick Rudolph <siro(a)das-labor.org> --- M util/xcompile/xcompile 1 file changed, 7 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/77/29877/1 diff --git a/util/xcompile/xcompile b/util/xcompile/xcompile index 6d82a4d..90e8ec5 100755 --- a/util/xcompile/xcompile +++ b/util/xcompile/xcompile @@ -236,7 +236,13 @@ # The Quark processor doesn't support the instructions # introduced with the Pentium 6 architecture, so allow it # to use i586 instead. -if [ "${TARCH}" = "x86_64" ] || [ "${TARCH}" = "x86_32" ]; then +if [ "${TARCH}" = "x86_64" ]; then +cat <<EOF + GCC_CFLAGS_${TARCH} += -march=nocona +EOF +fi + +if [ "${TARCH}" = "x86_32" ]; then cat <<EOF ifneq (\$(CONFIG_USE_MARCH_586)\$(CONFIG_LP_USE_MARCH_586),) -- To view, visit https://review.coreboot.org/c/coreboot/+/29877 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ied28f98f89610a748be8d66cf35814e9112a4407 Gerrit-Change-Number: 29877 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-MessageType: newchange

1 0

Change in ...coreboot[master]: cpu/x86/pae: Fix pointer casts
by Patrick Rudolph (Code Review) 28 Nov '18

28 Nov '18

Patrick Rudolph has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/29876 Change subject: cpu/x86/pae: Fix pointer casts ...................................................................... cpu/x86/pae: Fix pointer casts Required to compile the code in x86_64, even though it's never used. Change-Id: I2be8ad8805804e4da52bdb02ab43cb833402f999 --- M src/cpu/x86/pae/pgtbl.c 1 file changed, 4 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/76/29876/1 diff --git a/src/cpu/x86/pae/pgtbl.c b/src/cpu/x86/pae/pgtbl.c index 728135d..2cc9ba6 100644 --- a/src/cpu/x86/pae/pgtbl.c +++ b/src/cpu/x86/pae/pgtbl.c @@ -135,10 +135,10 @@ memset(&pgtbl[index].pdp, 0, sizeof(pgtbl[index].pdp)); pd = pgtbl[index].pd; pdp = pgtbl[index].pdp; - pdp[0].addr_lo = ((uint32_t)&pd[512*0])|1; - pdp[1].addr_lo = ((uint32_t)&pd[512*1])|1; - pdp[2].addr_lo = ((uint32_t)&pd[512*2])|1; - pdp[3].addr_lo = ((uint32_t)&pd[512*3])|1; + pdp[0].addr_lo = ((uintptr_t)&pd[512*0])|1; + pdp[1].addr_lo = ((uintptr_t)&pd[512*1])|1; + pdp[2].addr_lo = ((uintptr_t)&pd[512*2])|1; + pdp[3].addr_lo = ((uintptr_t)&pd[512*3])|1; /* The first half of the page table is identity mapped */ for (i = 0; i < 1024; i++) { -- To view, visit https://review.coreboot.org/c/coreboot/+/29876 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2be8ad8805804e4da52bdb02ab43cb833402f999 Gerrit-Change-Number: 29876 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-MessageType: newchange

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2018