coreboot-gerrit November 2018

coreboot-gerrit@coreboot.org

1 participants
1699 discussions

Change in coreboot[master]: Linuxboot: gitignore build directory
by Jonathan Neuschäfer (Code Review) 04 Nov '18

04 Nov '18

Jonathan Neuschäfer has posted comments on this change. ( https://review.coreboot.org/29444 ) Change subject: Linuxboot: gitignore build directory ...................................................................... Patch Set 1: (1 comment) Other payloads' source/build directories are so far ignored in the top-level .gitgnore https://review.coreboot.org/#/c/29444/1/payloads/external/LinuxBoot/.gitign… File payloads/external/LinuxBoot/.gitignore: https://review.coreboot.org/#/c/29444/1/payloads/external/LinuxBoot/.gitign… PS1, Line 1: linuxboot/* The star (*) is probably not necessary here -- To view, visit https://review.coreboot.org/29444 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic11311e2de544a334043a55eda42643d9df3374d Gerrit-Change-Number: 29444 Gerrit-PatchSet: 1 Gerrit-Owner: Marcello Sylvester Bauer <info(a)marcellobauer.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Comment-Date: Sun, 04 Nov 2018 20:07:36 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: util/abuild: Use absolute paths for (failed|passed)_boards
by Nico Huber (Code Review) 04 Nov '18

04 Nov '18

Nico Huber has posted comments on this change. ( https://review.coreboot.org/29451 ) Change subject: util/abuild: Use absolute paths for (failed|passed)_boards ...................................................................... Patch Set 1: Code-Review-2 needs refinement, `realpath` seems to be non-standard and ${TARGET} has to be created first -- To view, visit https://review.coreboot.org/29451 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ief00e28e09a4714b0106c35ad4f4e9c696f6aad4 Gerrit-Change-Number: 29451 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 04 Nov 2018 20:02:27 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: util/docker: Use common .ccache for local builds
by Nico Huber (Code Review) 04 Nov '18

04 Nov '18

Nico Huber has removed build bot (Jenkins) from this change. ( https://review.coreboot.org/29457 ) Change subject: util/docker: Use common .ccache for local builds ...................................................................... Removed reviewer build bot (Jenkins) with the following votes: * Verified+1 by build bot (Jenkins) <no-reply(a)coreboot.org> -- To view, visit https://review.coreboot.org/29457 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: deleteReviewer Gerrit-Change-Id: I7d0bdb3861ac56361cacfa74aaf8b45c4f135e5c Gerrit-Change-Number: 29457 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>

1 0

Change in coreboot[master]: coreboot-sdk: Prefer gnat package over gnat-6
by Nico Huber (Code Review) 04 Nov '18

04 Nov '18

Nico Huber has uploaded a new patch set (#2). ( https://review.coreboot.org/29454 ) Change subject: coreboot-sdk: Prefer gnat package over gnat-6 ...................................................................... coreboot-sdk: Prefer gnat package over gnat-6 The choice of `gnat-6` was originally an optimization because the meta- package `gnat` installs not only the current GNAT version but also other unwanted (and hard to explain) dependencies. Later it was necessary because GCC 8 couldn't compile our older crossgcc. Now that we switched crossgcc to GCC 8.1, `gnat` should be fine. Change-Id: Ica8a1f9d6d71a74ffc4ec76aa0cfbe4b604cde1b Signed-off-by: Nico Huber <nico.h(a)gmx.de> --- M util/docker/coreboot-sdk/Dockerfile 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/29454/2 -- To view, visit https://review.coreboot.org/29454 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ica8a1f9d6d71a74ffc4ec76aa0cfbe4b604cde1b Gerrit-Change-Number: 29454 Gerrit-PatchSet: 2 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>

1 0

Change in coreboot[master]: util/docker: Rename _CONTAINER_VERSION => _IMAGE_TAG
by Nico Huber (Code Review) 04 Nov '18

04 Nov '18

Nico Huber has uploaded this change for review. ( https://review.coreboot.org/29458 Change subject: util/docker: Rename _CONTAINER_VERSION => _IMAGE_TAG ...................................................................... util/docker: Rename _CONTAINER_VERSION => _IMAGE_TAG This is so confusing, let's name it what it is ;) Change-Id: I6f87e2f6912d886e241e03998fb4136fb28bc7b1 Signed-off-by: Nico Huber <nico.h(a)gmx.de> --- M util/docker/Makefile 1 file changed, 12 insertions(+), 12 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/58/29458/1 diff --git a/util/docker/Makefile b/util/docker/Makefile index eb43c98..6925b57 100644 --- a/util/docker/Makefile +++ b/util/docker/Makefile @@ -26,7 +26,7 @@ export COREBOOT_JENKINS_CONTAINER?=coreboot_jenkins # Version of the jenkins / sdk container -export COREBOOT_CONTAINER_VERSION?=$(crossgcc_version) +export COREBOOT_IMAGE_TAG?=$(crossgcc_version) # Commit id to build from export DOCKER_COMMIT?=$(shell git log -n 1 --pretty=%h) @@ -55,21 +55,21 @@ @echo "Building coreboot SDK $(crossgcc_version) from commit $(DOCKER_COMMIT)" cat coreboot-sdk/Dockerfile | \ sed "s/{{DOCKER_COMMIT}}/$(DOCKER_COMMIT)/" | \ - sed "s/{{SDK_VERSION}}/$(COREBOOT_CONTAINER_VERSION)/" | \ + sed "s/{{SDK_VERSION}}/$(COREBOOT_IMAGE_TAG)/" | \ sed "s/{{CROSSGCC_PARAM}}/$(COREBOOT_CROSSGCC_PARAM)/" | \ - $(DOCKER) build -t coreboot/coreboot-sdk:$(COREBOOT_CONTAINER_VERSION) - + $(DOCKER) build -t coreboot/coreboot-sdk:$(COREBOOT_IMAGE_TAG) - upload-coreboot-sdk: test-docker-login - $(DOCKER) push coreboot/coreboot-sdk:$(COREBOOT_CONTAINER_VERSION) + $(DOCKER) push coreboot/coreboot-sdk:$(COREBOOT_IMAGE_TAG) coreboot-jenkins-node: test-docker cat coreboot-jenkins-node/Dockerfile | \ - sed "s/{{SDK_VERSION}}/$(COREBOOT_CONTAINER_VERSION)/" | \ + sed "s/{{SDK_VERSION}}/$(COREBOOT_IMAGE_TAG)/" | \ sed "s|{{SSH_KEY}}|$$(cat coreboot-jenkins-node/authorized_keys)|" | \ - $(DOCKER) build -t coreboot/coreboot-jenkins-node:$(COREBOOT_CONTAINER_VERSION) - + $(DOCKER) build -t coreboot/coreboot-jenkins-node:$(COREBOOT_IMAGE_TAG) - upload-coreboot-jenkins-node: test-docker-login - $(DOCKER) push coreboot/coreboot-jenkins-node:$(COREBOOT_CONTAINER_VERSION) + $(DOCKER) push coreboot/coreboot-jenkins-node:$(COREBOOT_IMAGE_TAG) docker-killall: test-docker @if [ -n "$$($(DOCKER) ps | grep 'coreboot')" ]; then \ @@ -107,7 +107,7 @@ --volume $(top):/home/coreboot/coreboot \ --env HOME=/home/coreboot \ --user $(UID):$(GID) \ - coreboot/coreboot-sdk:$(COREBOOT_CONTAINER_VERSION) \ + coreboot/coreboot-sdk:$(COREBOOT_IMAGE_TAG) \ /bin/bash -c 'cd $${HOME}/coreboot && $(DOCKER_RUN_LOCAL)' docker-build-coreboot: docker-run-local @@ -138,7 +138,7 @@ -p $(COREBOOT_JENKINS_PORT):49151 \ -v $(COREBOOT_JENKINS_CACHE_DIR):/data/cache \ --name=$(COREBOOT_JENKINS_CONTAINER) \ - coreboot/coreboot-jenkins-node:$(COREBOOT_CONTAINER_VERSION) + coreboot/coreboot-jenkins-node:$(COREBOOT_IMAGE_TAG) docker-jenkins-shell: test-docker @if [ ! -d $(COREBOOT_JENKINS_CACHE_DIR) ]; then printf "\nError: %s does not exist.\nPlease run:\nsudo mkdir -p %s\n\n" "$(COREBOOT_JENKINS_CACHE_DIR)" "$(COREBOOT_JENKINS_CACHE_DIR)"; false; fi @@ -148,7 +148,7 @@ -v $(top):/home/coreboot/coreboot \ -v $(COREBOOT_JENKINS_CACHE_DIR):/data/cache \ --name=$(COREBOOT_JENKINS_CONTAINER) \ - --rm coreboot/coreboot-jenkins-node:$(COREBOOT_CONTAINER_VERSION) + --rm coreboot/coreboot-jenkins-node:$(COREBOOT_IMAGE_TAG) docker-shell: USER=coreboot docker-shell: test-docker @@ -156,7 +156,7 @@ -e COLUMNS=$(shell tput cols) -e LINES=$(shell tput lines) -e TERM=$(TERM) \ -w /home/coreboot/coreboot \ -v $(top):/home/coreboot/coreboot \ - --rm coreboot/coreboot-sdk:$(COREBOOT_CONTAINER_VERSION) \ + --rm coreboot/coreboot-sdk:$(COREBOOT_IMAGE_TAG) \ /bin/bash -l docker-jenkins-attach: USER=root @@ -191,7 +191,7 @@ @echo " COREBOOT_JENKINS_PORT=$(COREBOOT_JENKINS_PORT)" @echo " COREBOOT_JENKINS_CACHE_DIR=$(COREBOOT_JENKINS_CACHE_DIR)" @echo " COREBOOT_JENKINS_CONTAINER=$(COREBOOT_JENKINS_CONTAINER)" - @echo " COREBOOT_CONTAINER_VERSION=$(COREBOOT_CONTAINER_VERSION)" + @echo " COREBOOT_IMAGE_TAG=$(COREBOOT_IMAGE_TAG)" @echo " DOCKER_COMMIT=$(DOCKER_COMMIT)" .PHONY: test-docker test-docker-login -- To view, visit https://review.coreboot.org/29458 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I6f87e2f6912d886e241e03998fb4136fb28bc7b1 Gerrit-Change-Number: 29458 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>

1 0

Change in coreboot[master]: util/docker: Use common .ccache for local builds
by Nico Huber (Code Review) 04 Nov '18

04 Nov '18

Nico Huber has uploaded this change for review. ( https://review.coreboot.org/29457 Change subject: util/docker: Use common .ccache for local builds ...................................................................... util/docker: Use common .ccache for local builds Bind a volume for .ccache to the `docker-run-local` targets. By default the current user's $(HOME)/.ccache will be used, it can be overridden via the DOCKER_CCACHE variable. Also rearrange some docker parameters to keep the target readable. Change-Id: I7d0bdb3861ac56361cacfa74aaf8b45c4f135e5c Signed-off-by: Nico Huber <nico.h(a)gmx.de> --- M util/docker/Makefile 1 file changed, 13 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/57/29457/1 diff --git a/util/docker/Makefile b/util/docker/Makefile index 32714fc..eb43c98 100644 --- a/util/docker/Makefile +++ b/util/docker/Makefile @@ -31,6 +31,9 @@ # Commit id to build from export DOCKER_COMMIT?=$(shell git log -n 1 --pretty=%h) +# .ccache dir to use +export DOCKER_CCACHE?=$(HOME)/.ccache + # SDK architecture export COREBOOT_CROSSGCC_PARAM?=all_without_gdb @@ -95,11 +98,17 @@ $(DOCKER) rmi $$($(DOCKER) images | grep -v "REPOSITORY" | tr -s ' ' | cut -f3 -d ' '); \ fi -docker-run-local: test-docker - $(DOCKER) run -u root -it -v $(top):/home/coreboot/coreboot \ +$(DOCKER_CCACHE): + @mkdir -p $@ + +docker-run-local: test-docker $(DOCKER_CCACHE) + $(DOCKER) run -it --rm \ + --volume $(DOCKER_CCACHE):/home/coreboot/.ccache \ + --volume $(top):/home/coreboot/coreboot \ + --env HOME=/home/coreboot \ --user $(UID):$(GID) \ - --rm coreboot/coreboot-sdk:$(COREBOOT_CONTAINER_VERSION) \ - /bin/bash -c "cd /home/coreboot/coreboot && $(DOCKER_RUN_LOCAL)" + coreboot/coreboot-sdk:$(COREBOOT_CONTAINER_VERSION) \ + /bin/bash -c 'cd $${HOME}/coreboot && $(DOCKER_RUN_LOCAL)' docker-build-coreboot: docker-run-local docker-build-coreboot: override DOCKER_RUN_LOCAL := \ -- To view, visit https://review.coreboot.org/29457 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I7d0bdb3861ac56361cacfa74aaf8b45c4f135e5c Gerrit-Change-Number: 29457 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>

1 0

Change in coreboot[master]: util/docker: Unify local build targets
by Nico Huber (Code Review) 04 Nov '18

04 Nov '18

Nico Huber has uploaded this change for review. ( https://review.coreboot.org/29456 Change subject: util/docker: Unify local build targets ...................................................................... util/docker: Unify local build targets Add a `docker-run-local` target that is used as a template for the local build targets (`docker-build-coreboot`, `docker-abuild`, and `docker-what-jenkins-does`). Note this changes the user for `docker-what-jenkins-does` which has (ccache) issues if it's not `root`. Will be fixed in a follow-up. Change-Id: I9088fb9211726cddc37b17ddf70170c2c382679e Signed-off-by: Nico Huber <nico.h(a)gmx.de> --- M util/docker/Makefile 1 file changed, 12 insertions(+), 18 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/56/29456/1 diff --git a/util/docker/Makefile b/util/docker/Makefile index beb2a7e..32714fc 100644 --- a/util/docker/Makefile +++ b/util/docker/Makefile @@ -95,29 +95,23 @@ $(DOCKER) rmi $$($(DOCKER) images | grep -v "REPOSITORY" | tr -s ' ' | cut -f3 -d ' '); \ fi -docker-build-coreboot: test-docker +docker-run-local: test-docker $(DOCKER) run -u root -it -v $(top):/home/coreboot/coreboot \ --user $(UID):$(GID) \ --rm coreboot/coreboot-sdk:$(COREBOOT_CONTAINER_VERSION) \ - /bin/bash -c "cd /home/coreboot/coreboot && \ - make clean && \ - make $(BUILD_CMD); \ - rm .xcompile" + /bin/bash -c "cd /home/coreboot/coreboot && $(DOCKER_RUN_LOCAL)" -docker-abuild: test-docker - $(DOCKER) run -u root -it -v $(top):/home/coreboot/coreboot \ - --user $(UID):$(GID) \ - --rm coreboot/coreboot-sdk:$(COREBOOT_CONTAINER_VERSION) \ - /bin/bash -c "cd /home/coreboot/coreboot && \ - make clean && \ - util/abuild/abuild $(ABUILD_ARGS); \ - rm -f .xcompile" +docker-build-coreboot: docker-run-local +docker-build-coreboot: override DOCKER_RUN_LOCAL := \ + make clean && make $(BUILD_CMD); rm -f .xcompile -docker-what-jenkins-does: test-docker - $(DOCKER) run -u root -it -v $(top):/home/coreboot/coreboot \ - --rm coreboot/coreboot-sdk:$(COREBOOT_CONTAINER_VERSION) \ - /bin/bash -c "cd /home/coreboot/coreboot && \ - make clean && make what-jenkins-does CPUS=$(CPUS)" +docker-abuild: docker-run-local +docker-abuild: override DOCKER_RUN_LOCAL := \ + make clean && util/abuild/abuild $(ABUILD_ARGS); rm -f .xcompile + +docker-what-jenkins-does: docker-run-local +docker-what-jenkins-does: override DOCKER_RUN_LOCAL := \ + make clean && make what-jenkins-does CPUS=$(CPUS) docker-jenkins-server: test-docker @if [ ! -d "$(COREBOOT_JENKINS_CACHE_DIR)" ]; then \ -- To view, visit https://review.coreboot.org/29456 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I9088fb9211726cddc37b17ddf70170c2c382679e Gerrit-Change-Number: 29456 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>

1 0

Change in coreboot[master]: coreboot-sdk: Build Clang first in a separate step
by Nico Huber (Code Review) 04 Nov '18

04 Nov '18

Nico Huber has uploaded this change for review. ( https://review.coreboot.org/29455 Change subject: coreboot-sdk: Build Clang first in a separate step ...................................................................... coreboot-sdk: Build Clang first in a separate step If we build one of the `all*` targets, build Clang first. Compiling Clang (just for the host arch, I assume) takes more than half of the time of the default build. When run as a separate step, we can make use of Docker's cache if any step after Clang fails. Change-Id: If67b458cde656f1dc6774215f6a575a48d12b797 Signed-off-by: Nico Huber <nico.h(a)gmx.de> --- M util/docker/coreboot-sdk/Dockerfile 1 file changed, 12 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/55/29455/1 diff --git a/util/docker/coreboot-sdk/Dockerfile b/util/docker/coreboot-sdk/Dockerfile index bdfbf4a..739e0d1 100644 --- a/util/docker/coreboot-sdk/Dockerfile +++ b/util/docker/coreboot-sdk/Dockerfile @@ -74,12 +74,19 @@ RUN \ cd /root && \ git clone https://review.coreboot.org/coreboot && \ - cd coreboot/util/crossgcc && \ - git checkout {{DOCKER_COMMIT}} && \ - make {{CROSSGCC_PARAM}} \ + cd coreboot && \ + git checkout {{DOCKER_COMMIT}} + +RUN \ + if echo {{CROSSGCC_PARAM}} | grep -q ^all; then \ + make -C/root/coreboot/util/crossgcc/ build_clang \ + BUILD_LANGUAGES=c,ada CPUS=$(nproc) DEST=/opt/xgcc; \ + fi + +RUN \ + make -C/root/coreboot/util/crossgcc/ {{CROSSGCC_PARAM}} \ BUILD_LANGUAGES=c,ada CPUS=$(nproc) DEST=/opt/xgcc && \ - cd /root && \ - rm -rf coreboot + rm -rf /root/coreboot RUN mkdir /home/coreboot/.ccache && \ chown coreboot:coreboot /home/coreboot/.ccache && \ -- To view, visit https://review.coreboot.org/29455 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: If67b458cde656f1dc6774215f6a575a48d12b797 Gerrit-Change-Number: 29455 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>

1 0

Change in coreboot[master]: coreboot-sdk: Prever gnat package over gnat-6
by Nico Huber (Code Review) 04 Nov '18

04 Nov '18

Nico Huber has uploaded this change for review. ( https://review.coreboot.org/29454 Change subject: coreboot-sdk: Prever gnat package over gnat-6 ...................................................................... coreboot-sdk: Prever gnat package over gnat-6 The choice of `gnat-6` was originally an optimization because the meta- package `gnat` installs not only the current GNAT version but also other unwanted (and hard to explain) dependencies. Later it was necessary because GCC 8 couldn't compile our older crossgcc. Now that we switched crossgcc to GCC 8.1, `gnat` should be fine. Change-Id: Ica8a1f9d6d71a74ffc4ec76aa0cfbe4b604cde1b Signed-off-by: Nico Huber <nico.h(a)gmx.de> --- M util/docker/coreboot-sdk/Dockerfile 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/29454/1 diff --git a/util/docker/coreboot-sdk/Dockerfile b/util/docker/coreboot-sdk/Dockerfile index 44682f8..bdfbf4a 100644 --- a/util/docker/coreboot-sdk/Dockerfile +++ b/util/docker/coreboot-sdk/Dockerfile @@ -34,7 +34,7 @@ gawk \ gcc \ git \ - gnat-6 \ + gnat \ graphviz \ libfreetype6-dev \ libftdi-dev \ -- To view, visit https://review.coreboot.org/29454 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ica8a1f9d6d71a74ffc4ec76aa0cfbe4b604cde1b Gerrit-Change-Number: 29454 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>

1 0

Change in coreboot[master]: coreboot-sdk: Don't install libelf-dev
by Nico Huber (Code Review) 04 Nov '18

04 Nov '18

Nico Huber has uploaded this change for review. ( https://review.coreboot.org/29452 Change subject: coreboot-sdk: Don't install libelf-dev ...................................................................... coreboot-sdk: Don't install libelf-dev As by afda56e1ad (buildgcc: Drop libelf/elfutils), it's not used (atm). Change-Id: I3124cb6db5975c21e635636babe700adb0f8cd8b Signed-off-by: Nico Huber <nico.h(a)gmx.de> --- M util/docker/coreboot-sdk/Dockerfile 1 file changed, 0 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/29452/1 diff --git a/util/docker/coreboot-sdk/Dockerfile b/util/docker/coreboot-sdk/Dockerfile index 412362f..4410e5b 100644 --- a/util/docker/coreboot-sdk/Dockerfile +++ b/util/docker/coreboot-sdk/Dockerfile @@ -36,7 +36,6 @@ git \ gnat-6 \ graphviz \ - libelf-dev \ libfreetype6-dev \ libftdi-dev \ libftdi1-dev \ -- To view, visit https://review.coreboot.org/29452 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I3124cb6db5975c21e635636babe700adb0f8cd8b Gerrit-Change-Number: 29452 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2018