coreboot-gerrit November 2018

coreboot-gerrit@coreboot.org

1 participants
1699 discussions

Change in coreboot[master]: mb/lenovo/x220: Add x1 as a variant
by Bill XIE (Code Review) 04 Nov '18

04 Nov '18

Hello Patrick Rudolph, Angel Pons, build bot (Jenkins), Nico Huber, I'd like you to reexamine a change. Please visit https://review.coreboot.org/29434 to look at the new patch set (#6). Change subject: mb/lenovo/x220: Add x1 as a variant ...................................................................... mb/lenovo/x220: Add x1 as a variant ThinkPad X1 ( https://www.thinkwiki.org/wiki/Category:X1 ) is nearly a clone of X220, with additional USB3 controller on pci-e (as i7 variant of x220), and a powered ESATA port wired to ata4 (Linux' annotation). Documentation added. Tested: - CPU i5-2520M - Slotted DIMM 8GiB - Camera - Mini pci-e on wlan slot - Msata on wwan slot - On board SDHCI connected to pci-e - USB3 controller connected to pci-e - NVRAM options for North and South bridges - S3 - TPM1 on LPC - Linux 4.9.110-3 within Debian GNU/Linux stable, loaded from SeaBIOS, or Linux payload (Heads) Not tested: - Fingerprint reader on USB2 - Onboard USB2 interfaces (wlan slot, wwan slot) Change-Id: Ibbc45f22c63b77ac95c188db825d0d7e2b03d2d1 Signed-off-by: Bill XIE <persmule(a)gmail.com> --- M Documentation/mainboard/index.md M Documentation/mainboard/lenovo/t4xx_series.md A Documentation/mainboard/lenovo/thinkpad_hmm.md A Documentation/mainboard/lenovo/x1.md A Documentation/mainboard/lenovo/x2xx_series.md M src/mainboard/lenovo/x220/Kconfig M src/mainboard/lenovo/x220/Kconfig.name M src/mainboard/lenovo/x220/Makefile.inc M src/mainboard/lenovo/x220/devicetree.cb A src/mainboard/lenovo/x220/variants/x1/gpio.c A src/mainboard/lenovo/x220/variants/x1/overridetree.cb R src/mainboard/lenovo/x220/variants/x220/gpio.c A src/mainboard/lenovo/x220/variants/x220/overridetree.cb 13 files changed, 399 insertions(+), 7 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/34/29434/6 -- To view, visit https://review.coreboot.org/29434 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ibbc45f22c63b77ac95c188db825d0d7e2b03d2d1 Gerrit-Change-Number: 29434 Gerrit-PatchSet: 6 Gerrit-Owner: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: intel/nb/*/gma: Use new common PMBASE API
by Nico Huber (Code Review) 04 Nov '18

04 Nov '18

Nico Huber has posted comments on this change. ( https://review.coreboot.org/29439 ) Change subject: intel/nb/*/gma: Use new common PMBASE API ...................................................................... Patch Set 4: why not use a common gma_setup_swsci()? -- To view, visit https://review.coreboot.org/29439 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6b5977b10d1e38b45e09530e9dcabbd5f42facb2 Gerrit-Change-Number: 29439 Gerrit-PatchSet: 4 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 04 Nov 2018 13:36:41 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: src/mb/asus/p5qc/gpio.c: Use a per-variant gpio.c
by Nico Huber (Code Review) 04 Nov '18

04 Nov '18

Nico Huber has posted comments on this change. ( https://review.coreboot.org/29447 ) Change subject: src/mb/asus/p5qc/gpio.c: Use a per-variant gpio.c ...................................................................... Patch Set 2: Code-Review-1 Please do not duplicate the file, you can point to the correct one in Kconfig. e.g. config ... string default "variants/p5qc/gpio.c" if PRO default "variants/$(VARIANT_DIR)/gpio.c" -- To view, visit https://review.coreboot.org/29447 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2f7c8c12cb1bdcf47f3b4d4cef0b11e44a5b8863 Gerrit-Change-Number: 29447 Gerrit-PatchSet: 2 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 04 Nov 2018 13:31:01 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: src/mb/asus/p5qc: Fix some mistakes
by Nico Huber (Code Review) 04 Nov '18

04 Nov '18

Nico Huber has submitted this change and it was merged. ( https://review.coreboot.org/29446 ) Change subject: src/mb/asus/p5qc: Fix some mistakes ...................................................................... src/mb/asus/p5qc: Fix some mistakes There are some small mistakes in these recently-added mainboards: - board_info.txt: Lists board socket incorrectly. - cmos.default: Loglevel was decreased some time ago. - devicetree.cb: Spelling mistake. - Kconfig: Mainboard name does not have a hyphen. Change-Id: I08d9b06e79683acd3994b84647bce401ed6741e2 Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> Reviewed-on: https://review.coreboot.org/29446 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Arthur Heymans <arthur(a)aheymans.xyz> Reviewed-by: Nico Huber <nico.h(a)gmx.de> --- M src/mainboard/asus/p5qc/Kconfig M src/mainboard/asus/p5qc/board_info.txt M src/mainboard/asus/p5qc/cmos.default M src/mainboard/asus/p5qc/variants/p5q_pro/devicetree.cb M src/mainboard/asus/p5qc/variants/p5qc/devicetree.cb 5 files changed, 13 insertions(+), 13 deletions(-) Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved Arthur Heymans: Looks good to me, approved diff --git a/src/mainboard/asus/p5qc/Kconfig b/src/mainboard/asus/p5qc/Kconfig index 2bcee16..e8d596f 100644 --- a/src/mainboard/asus/p5qc/Kconfig +++ b/src/mainboard/asus/p5qc/Kconfig @@ -42,7 +42,7 @@ config MAINBOARD_PART_NUMBER string default "P5QC" if BOARD_ASUS_P5QC - default "P5Q-PRO" if BOARD_ASUS_P5Q_PRO + default "P5Q PRO" if BOARD_ASUS_P5Q_PRO config DEVICETREE string diff --git a/src/mainboard/asus/p5qc/board_info.txt b/src/mainboard/asus/p5qc/board_info.txt index 111f2e4..42d4812 100644 --- a/src/mainboard/asus/p5qc/board_info.txt +++ b/src/mainboard/asus/p5qc/board_info.txt @@ -1,6 +1,6 @@ Category: desktop Board URL: https://www.asus.com/Motherboards/P5QC/ -ROM package: SOP-8 +ROM package: DIP-8 ROM protocol: SPI ROM socketed: y Flashrom support: y diff --git a/src/mainboard/asus/p5qc/cmos.default b/src/mainboard/asus/p5qc/cmos.default index ccdb7c8..ad822d5 100644 --- a/src/mainboard/asus/p5qc/cmos.default +++ b/src/mainboard/asus/p5qc/cmos.default @@ -1,5 +1,5 @@ boot_option=Fallback -debug_level=Spew +debug_level=Debug power_on_after_fail=Disable nmi=Enable sata_mode=AHCI diff --git a/src/mainboard/asus/p5qc/variants/p5q_pro/devicetree.cb b/src/mainboard/asus/p5qc/variants/p5q_pro/devicetree.cb index f7088fc..8753d4c 100644 --- a/src/mainboard/asus/p5qc/variants/p5q_pro/devicetree.cb +++ b/src/mainboard/asus/p5qc/variants/p5q_pro/devicetree.cb @@ -85,15 +85,15 @@ irq 0x72 = 12 end device pnp 2e.106 off end # SPI1 - device pnp 2e.107 off end # GIPO6 - device pnp 2e.207 off end # GIPO7 - device pnp 2e.307 on # GIPO8 + device pnp 2e.107 off end # GPIO6 + device pnp 2e.207 off end # GPIO7 + device pnp 2e.307 on # GPIO8 irq 0xe4 = 0xfb irq 0xe5 = 0x82 end - device pnp 2e.407 off end # GIPO9 + device pnp 2e.407 off end # GPIO9 device pnp 2e.8 off end # WDT - device pnp 2e.108 off end # GPIO 1 + device pnp 2e.108 off end # GPIO1 device pnp 2e.9 off end # GPIO2 device pnp 2e.109 on end # GPIO3 device pnp 2e.209 on # GPIO4 diff --git a/src/mainboard/asus/p5qc/variants/p5qc/devicetree.cb b/src/mainboard/asus/p5qc/variants/p5qc/devicetree.cb index 52bbb40..6fac063 100644 --- a/src/mainboard/asus/p5qc/variants/p5qc/devicetree.cb +++ b/src/mainboard/asus/p5qc/variants/p5qc/devicetree.cb @@ -82,15 +82,15 @@ irq 0x72 = 12 end device pnp 2e.106 off end # SPI1 - device pnp 2e.107 off end # GIPO6 - device pnp 2e.207 off end # GIPO7 - device pnp 2e.307 on # GIPO8 + device pnp 2e.107 off end # GPIO6 + device pnp 2e.207 off end # GPIO7 + device pnp 2e.307 on # GPIO8 irq 0xe4 = 0xfb irq 0xe5 = 0x02 end - device pnp 2e.407 off end # GIPO9 + device pnp 2e.407 off end # GPIO9 device pnp 2e.8 off end # WDT - device pnp 2e.108 off end # GPIO 1 + device pnp 2e.108 off end # GPIO1 device pnp 2e.9 off end # GPIO2 device pnp 2e.109 on end # GPIO3 device pnp 2e.209 on # GPIO4 -- To view, visit https://review.coreboot.org/29446 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I08d9b06e79683acd3994b84647bce401ed6741e2 Gerrit-Change-Number: 29446 Gerrit-PatchSet: 2 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: src/mb/asus/p5qc: Fix some mistakes
by Nico Huber (Code Review) 04 Nov '18

04 Nov '18

Nico Huber has posted comments on this change. ( https://review.coreboot.org/29446 ) Change subject: src/mb/asus/p5qc: Fix some mistakes ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/29446 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I08d9b06e79683acd3994b84647bce401ed6741e2 Gerrit-Change-Number: 29446 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 04 Nov 2018 13:26:08 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: src/arch/x86/acpi.c: Be more verbose when finding the wakeup vector
by Nico Huber (Code Review) 04 Nov '18

04 Nov '18

Nico Huber has posted comments on this change. ( https://review.coreboot.org/29449 ) Change subject: src/arch/x86/acpi.c: Be more verbose when finding the wakeup vector ...................................................................... Patch Set 1: (3 comments) https://review.coreboot.org/#/c/29449/1//COMMIT_MSG Commit Message: https://review.coreboot.org/#/c/29449/1//COMMIT_MSG@7 PS1, Line 7: src/arch/x86/acpi.c: Be more verbose when finding the wakeup vector The original Git rule is 55 chars for the summary. We allow more but it's unnecessary here (e.g. `x86/acpi: ...` would still carry the same information). https://review.coreboot.org/#/c/29449/1/src/arch/x86/acpi.c File src/arch/x86/acpi.c: https://review.coreboot.org/#/c/29449/1/src/arch/x86/acpi.c@1282 PS1, Line 1282: printk(BIOS_ERR, "No RSDP found, wake up from S3 not " Please don't break the string literal. If you want to honor the line limit, break after the comma. (But you don't have to, there's an unwritten exception for string literals.) https://review.coreboot.org/#/c/29449/1/src/arch/x86/acpi.c@1282 PS1, Line 1282: BIOS_ERR rather BIOS_ALERT -- To view, visit https://review.coreboot.org/29449 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib006c4a213c0da180018e5fbf7a47d6af66f8bc4 Gerrit-Change-Number: 29449 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 04 Nov 2018 13:21:02 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: [WIP] Linuxboot: use pre-compiled kernel image
by Marcello Sylvester Bauer (Code Review) 04 Nov '18

04 Nov '18

Marcello Sylvester Bauer has uploaded this change for review. ( https://review.coreboot.org/29450 Change subject: [WIP] Linuxboot: use pre-compiled kernel image ...................................................................... [WIP] Linuxboot: use pre-compiled kernel image Change-Id: Idf5c778ef81decd4b0d66f90b9e8e825c3566bc5 Signed-off-by: Marcello Sylvester Bauer <info(a)marcellobauer.com> --- M payloads/external/LinuxBoot/Kconfig M payloads/external/Makefile.inc 2 files changed, 18 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/29450/1 diff --git a/payloads/external/LinuxBoot/Kconfig b/payloads/external/LinuxBoot/Kconfig index 4225330..23536c1 100644 --- a/payloads/external/LinuxBoot/Kconfig +++ b/payloads/external/LinuxBoot/Kconfig @@ -45,9 +45,16 @@ default "386" if LINUXBOOT_X86 default "arm64" if LINUXBOOT_ARM64 +config LINUXBOOT_COMPILE_KERNEL + bool "Compile kernel" + default y + help + Download and compile the Linux kernel + choice prompt "Kernel release" default LINUXBOOT_KERNEL_STABLE + depends on LINUXBOOT_COMPILE_KERNEL help choose the kernel release. @@ -90,14 +97,21 @@ default "stable" if LINUXBOOT_KERNEL_STABLE default "longterm" if LINUXBOOT_KERNEL_LONGTERM default "custom" if LINUXBOOT_KERNEL_CUSTOM + depends on LINUXBOOT_COMPILE_KERNEL config LINUXBOOT_KERNEL_CONFIGFILE string "Kernel config file" default "" + depends on LINUXBOOT_COMPILE_KERNEL help Add your own kernel configuration file. Otherwise a default minimal defconfig is used. +config LINUXBOOT_KERNEL + string "path to linux kernel" + default "" + depends on !LINUXBOOT_COMPILE_KERNEL + config LINUXBOOT_KERNEL_COMMANDLINE string "Kernel command-line" default "" @@ -110,7 +124,8 @@ default "" config PAYLOAD_FILE - default "payloads/external/LinuxBoot/linuxboot/kernel-image" + default "payloads/external/LinuxBoot/linuxboot/kernel-image" if LINUXBOOT_COMPILE_KERNEL + default LINUXBOOT_KERNEL if !LINUXBOOT_COMPILE_KERNEL choice prompt "Payload Mode" diff --git a/payloads/external/Makefile.inc b/payloads/external/Makefile.inc index cb806b7..b136cc8 100644 --- a/payloads/external/Makefile.inc +++ b/payloads/external/Makefile.inc @@ -286,6 +286,8 @@ payloads/external/LinuxBoot/linuxboot/kernel/.config: linuxboot payloads/external/LinuxBoot/linuxboot/go/src/github.com/u-root/u-root/.git: linuxboot +# Yabits + payloads/external/Yabits/uefi/build/uefi.elf yabits: $(MAKE) -C payloads/external/Yabits all \ CC="$(CC_x86_32)" \ -- To view, visit https://review.coreboot.org/29450 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Idf5c778ef81decd4b0d66f90b9e8e825c3566bc5 Gerrit-Change-Number: 29450 Gerrit-PatchSet: 1 Gerrit-Owner: Marcello Sylvester Bauer <info(a)marcellobauer.com>

1 0

Change in coreboot[master]: mb/lenovo/x220: Add x1 as a variant
by Nico Huber (Code Review) 04 Nov '18

04 Nov '18

Nico Huber has posted comments on this change. ( https://review.coreboot.org/29434 ) Change subject: mb/lenovo/x220: Add x1 as a variant ...................................................................... Patch Set 5: Code-Review-1 (1 comment) Please use an override devicetree instead. See google/fizz for example, `config OVERRIDE_DEVICETREE` and 27efc501d1 (util/sconfig: Add support for overriding base tree properties/node). https://review.coreboot.org/#/c/29434/5/src/mainboard/lenovo/x220/variants/… File src/mainboard/lenovo/x220/variants/x1/devicetree.cb: https://review.coreboot.org/#/c/29434/5/src/mainboard/lenovo/x220/variants/… PS5, Line 79: 0x2005 > As far as I understand UVSCC only applies to the "upper" aka second flash chip. The SPI Guide suggests to fill both for maximum compatibility. And no, it's kind of the other way around. If there is no distinction, everything is "upper". The actual distinction is not based on the chips but a configurable boundary (FPBA in the descriptor). Everything below that boundary is "lower"; if FPBA is 0, nothing is below it. They probably made it that weird to be able to treat two flash chips with the same characteristics as one (wrt. all the lower/upper set- tings). -- To view, visit https://review.coreboot.org/29434 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibbc45f22c63b77ac95c188db825d0d7e2b03d2d1 Gerrit-Change-Number: 29434 Gerrit-PatchSet: 5 Gerrit-Owner: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 04 Nov 2018 13:05:58 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: Linuxboot: remove initramfs path entry
by Marcello Sylvester Bauer (Code Review) 04 Nov '18

04 Nov '18

Hello Patrick Rudolph, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/29448 to look at the new patch set (#6). Change subject: Linuxboot: remove initramfs path entry ...................................................................... Linuxboot: remove initramfs path entry Remove Linuxboot initramfs path entry in Kconfig. Custom initramfs can and should be used with 'Linux payload'. Change-Id: I648fb2e0383d20b0e4d50e416af637ea07d1efb4 Signed-off-by: Marcello Sylvester Bauer <info(a)marcellobauer.com> --- M payloads/external/LinuxBoot/Kconfig M payloads/external/LinuxBoot/Makefile 2 files changed, 3 insertions(+), 6 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/48/29448/6 -- To view, visit https://review.coreboot.org/29448 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I648fb2e0383d20b0e4d50e416af637ea07d1efb4 Gerrit-Change-Number: 29448 Gerrit-PatchSet: 6 Gerrit-Owner: Marcello Sylvester Bauer <info(a)marcellobauer.com> Gerrit-Reviewer: Marcello Sylvester Bauer <info(a)marcellobauer.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: src/arch/x86/acpi.c: Be more verbose when finding the wakeup vector
by Angel Pons (Code Review) 04 Nov '18

04 Nov '18

Angel Pons has uploaded this change for review. ( https://review.coreboot.org/29449 Change subject: src/arch/x86/acpi.c: Be more verbose when finding the wakeup vector ...................................................................... src/arch/x86/acpi.c: Be more verbose when finding the wakeup vector Since S3 resume sometimes breaks when trying to find the wakeup vector, it is useful to log whether it errors or not. Since it is an error, print it as such. Change-Id: Ib006c4a213c0da180018e5fbf7a47d6af66f8bc4 Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> --- M src/arch/x86/acpi.c 1 file changed, 9 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/49/29449/1 diff --git a/src/arch/x86/acpi.c b/src/arch/x86/acpi.c index 24db7c0..26789d6 100644 --- a/src/arch/x86/acpi.c +++ b/src/arch/x86/acpi.c @@ -1278,8 +1278,11 @@ break; } - if (rsdp == NULL) + if (rsdp == NULL) { + printk(BIOS_ERR, "No RSDP found, wake up from S3 not " + "possible.\n"); return NULL; + } printk(BIOS_DEBUG, "RSDP found at %p\n", rsdp); rsdt = (acpi_rsdt_t *)(uintptr_t)rsdp->rsdt_address; @@ -1294,14 +1297,17 @@ fadt = NULL; } - if (fadt == NULL) + if (fadt == NULL) { + printk(BIOS_ERR, "No FADT found, wake up from S3 not " + "possible.\n"); return NULL; + } printk(BIOS_DEBUG, "FADT found at %p\n", fadt); facs = (acpi_facs_t *)(uintptr_t)fadt->firmware_ctrl; if (facs == NULL) { - printk(BIOS_DEBUG, "No FACS found, wake up from S3 not " + printk(BIOS_ERR, "No FACS found, wake up from S3 not " "possible.\n"); return NULL; } -- To view, visit https://review.coreboot.org/29449 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ib006c4a213c0da180018e5fbf7a47d6af66f8bc4 Gerrit-Change-Number: 29449 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com>

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2018