coreboot-gerrit November 2018

coreboot-gerrit@coreboot.org

1 participants
1699 discussions

Change in coreboot[master]: mb/lenovo/x220: Add x1 as a variant
by Patrick Rudolph (Code Review) 03 Nov '18

03 Nov '18

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/29434 ) Change subject: mb/lenovo/x220: Add x1 as a variant ...................................................................... Patch Set 4: (4 comments) https://review.coreboot.org/#/c/29434/4/Documentation/mainboard/lenovo/t4xx… File Documentation/mainboard/lenovo/t4xx_series.md: https://review.coreboot.org/#/c/29434/4/Documentation/mainboard/lenovo/t4xx… PS4, Line 7: :doc:`thinkpad_hmm` Why is this … [View More]

1 0

Change in coreboot[master]: src/mb/asus/p5qc/gpio.c: Use a per-variant gpio.c
by Angel Pons (Code Review) 03 Nov '18

03 Nov '18

Angel Pons has uploaded this change for review. ( https://review.coreboot.org/29447 Change subject: src/mb/asus/p5qc/gpio.c: Use a per-variant gpio.c ...................................................................... src/mb/asus/p5qc/gpio.c: Use a per-variant gpio.c Even though these two mainboards use the same gpio.c file, other boards such as the p5ql_pro do not.* Change-Id: I2f7c8c12cb1bdcf47f3b4d4cef0b11e44a5b8863 Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> --- M src/… [View More]

1 0

Change in coreboot[master]: src/mb/asus/p5qc: Fix some mistakes
by Angel Pons (Code Review) 03 Nov '18

03 Nov '18

Angel Pons has uploaded this change for review. ( https://review.coreboot.org/29446 Change subject: src/mb/asus/p5qc: Fix some mistakes ...................................................................... src/mb/asus/p5qc: Fix some mistakes There are some small mistakes in these recently-added mainboards: - board_info.txt: Lists board socket incorrectly. - cmos.default: Loglevel was decreased some time ago. - devicetree.cb: Spelling mistake. - Kconfig: Mainboard name does … [View More]not have a hyphen. Change-Id: I08d9b06e79683acd3994b84647bce401ed6741e2 Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> --- M src/mainboard/asus/p5qc/Kconfig M src/mainboard/asus/p5qc/board_info.txt M src/mainboard/asus/p5qc/cmos.default M src/mainboard/asus/p5qc/variants/p5q_pro/devicetree.cb M src/mainboard/asus/p5qc/variants/p5qc/devicetree.cb 5 files changed, 13 insertions(+), 13 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/46/29446/1 diff --git a/src/mainboard/asus/p5qc/Kconfig b/src/mainboard/asus/p5qc/Kconfig index 2bcee16..e8d596f 100644 --- a/src/mainboard/asus/p5qc/Kconfig +++ b/src/mainboard/asus/p5qc/Kconfig @@ -42,7 +42,7 @@ config MAINBOARD_PART_NUMBER string default "P5QC" if BOARD_ASUS_P5QC - default "P5Q-PRO" if BOARD_ASUS_P5Q_PRO + default "P5Q PRO" if BOARD_ASUS_P5Q_PRO config DEVICETREE string diff --git a/src/mainboard/asus/p5qc/board_info.txt b/src/mainboard/asus/p5qc/board_info.txt index 111f2e4..42d4812 100644 --- a/src/mainboard/asus/p5qc/board_info.txt +++ b/src/mainboard/asus/p5qc/board_info.txt @@ -1,6 +1,6 @@ Category: desktop Board URL: https://www.asus.com/Motherboards/P5QC/ -ROM package: SOP-8 +ROM package: DIP-8 ROM protocol: SPI ROM socketed: y Flashrom support: y diff --git a/src/mainboard/asus/p5qc/cmos.default b/src/mainboard/asus/p5qc/cmos.default index ccdb7c8..ad822d5 100644 --- a/src/mainboard/asus/p5qc/cmos.default +++ b/src/mainboard/asus/p5qc/cmos.default @@ -1,5 +1,5 @@ boot_option=Fallback -debug_level=Spew +debug_level=Debug power_on_after_fail=Disable nmi=Enable sata_mode=AHCI diff --git a/src/mainboard/asus/p5qc/variants/p5q_pro/devicetree.cb b/src/mainboard/asus/p5qc/variants/p5q_pro/devicetree.cb index f7088fc..8753d4c 100644 --- a/src/mainboard/asus/p5qc/variants/p5q_pro/devicetree.cb +++ b/src/mainboard/asus/p5qc/variants/p5q_pro/devicetree.cb @@ -85,15 +85,15 @@ irq 0x72 = 12 end device pnp 2e.106 off end # SPI1 - device pnp 2e.107 off end # GIPO6 - device pnp 2e.207 off end # GIPO7 - device pnp 2e.307 on # GIPO8 + device pnp 2e.107 off end # GPIO6 + device pnp 2e.207 off end # GPIO7 + device pnp 2e.307 on # GPIO8 irq 0xe4 = 0xfb irq 0xe5 = 0x82 end - device pnp 2e.407 off end # GIPO9 + device pnp 2e.407 off end # GPIO9 device pnp 2e.8 off end # WDT - device pnp 2e.108 off end # GPIO 1 + device pnp 2e.108 off end # GPIO1 device pnp 2e.9 off end # GPIO2 device pnp 2e.109 on end # GPIO3 device pnp 2e.209 on # GPIO4 diff --git a/src/mainboard/asus/p5qc/variants/p5qc/devicetree.cb b/src/mainboard/asus/p5qc/variants/p5qc/devicetree.cb index 52bbb40..6fac063 100644 --- a/src/mainboard/asus/p5qc/variants/p5qc/devicetree.cb +++ b/src/mainboard/asus/p5qc/variants/p5qc/devicetree.cb @@ -82,15 +82,15 @@ irq 0x72 = 12 end device pnp 2e.106 off end # SPI1 - device pnp 2e.107 off end # GIPO6 - device pnp 2e.207 off end # GIPO7 - device pnp 2e.307 on # GIPO8 + device pnp 2e.107 off end # GPIO6 + device pnp 2e.207 off end # GPIO7 + device pnp 2e.307 on # GPIO8 irq 0xe4 = 0xfb irq 0xe5 = 0x02 end - device pnp 2e.407 off end # GIPO9 + device pnp 2e.407 off end # GPIO9 device pnp 2e.8 off end # WDT - device pnp 2e.108 off end # GPIO 1 + device pnp 2e.108 off end # GPIO1 device pnp 2e.9 off end # GPIO2 device pnp 2e.109 on end # GPIO3 device pnp 2e.209 on # GPIO4 -- To view, visit https://review.coreboot.org/29446 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I08d9b06e79683acd3994b84647bce401ed6741e2 Gerrit-Change-Number: 29446 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> [View Less]

1 0

Change in coreboot[master]: mb/lenovo/x220: Add x1 as a variant
by Bill XIE (Code Review) 03 Nov '18

03 Nov '18

Hello Patrick Rudolph, Angel Pons, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/29434 to look at the new patch set (#4). Change subject: mb/lenovo/x220: Add x1 as a variant ...................................................................... mb/lenovo/x220: Add x1 as a variant ThinkPad X1 ( https://www.thinkwiki.org/wiki/Category:X1 ) is nearly a clone of X220, with additional USB3 controller on pci-e (as i7 variant of x220), and … [View More]

1 0

Change in coreboot[master]: mb/asus/p5qc: Fix spelling of Marvell
by Angel Pons (Code Review) 03 Nov '18

03 Nov '18

Angel Pons has posted comments on this change. ( https://review.coreboot.org/29347 ) Change subject: mb/asus/p5qc: Fix spelling of Marvell ...................................................................... Patch Set 1: Code-Review+2 > Patch Set 1: > > Does it need to be in uppercase? I'd rather use "Marvell", since it is not an acronym. Whatever -- To view, visit https://review.coreboot.org/29347 To unsubscribe, or for help writing mail filters, visit https://review.… [View More]

1 0

Change in coreboot[master]: Linuxboot: check go version
by Marcello Sylvester Bauer (Code Review) 03 Nov '18

03 Nov '18

Marcello Sylvester Bauer has uploaded a new patch set (#2). ( https://review.coreboot.org/29445 ) Change subject: Linuxboot: check go version ...................................................................... Linuxboot: check go version Check if the installed Golang version is >= 1.9. Change-Id: I9fd74fa8dc5e906e8b54ff5afaf69609fe957960 Signed-off-by: Marcello Sylvester Bauer <info(a)marcellobauer.com> --- M payloads/external/LinuxBoot/targets/u-root.mk 1 file changed, 12 … [View More]

1 0

Change in coreboot[master]: Linuxboot: check golang version
by Marcello Sylvester Bauer (Code Review) 03 Nov '18

03 Nov '18

Marcello Sylvester Bauer has uploaded this change for review. ( https://review.coreboot.org/29445 Change subject: Linuxboot: check golang version ...................................................................... Linuxboot: check golang version Check if the installed Golang version is >= 1.9. Change-Id: I9fd74fa8dc5e906e8b54ff5afaf69609fe957960 Signed-off-by: Marcello Sylvester Bauer <info(a)marcellobauer.com> --- M payloads/external/LinuxBoot/targets/u-root.mk 1 file changed, … [View More]

1 0

Change in coreboot[master]: sb/intel/bd82x6x/early_usb.c: Fix formating
by Angel Pons (Code Review) 03 Nov '18

03 Nov '18

Angel Pons has posted comments on this change. ( https://review.coreboot.org/29428 ) Change subject: sb/intel/bd82x6x/early_usb.c: Fix formating ...................................................................... Patch Set 2: Code-Review+1 (1 comment) https://review.coreboot.org/#/c/29428/2/src/southbridge/intel/bd82x6x/early… File src/southbridge/intel/bd82x6x/early_usb.c: https://review.coreboot.org/#/c/29428/2/src/southbridge/intel/bd82x6x/early… PS2, Line 20: #include <… [View More]

1 0

Change in coreboot[master]: mb/lenovo/x220: Add x1 as a variant
by Patrick Rudolph (Code Review) 03 Nov '18

03 Nov '18

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/29434 ) Change subject: mb/lenovo/x220: Add x1 as a variant ...................................................................... Patch Set 3: Code-Review+1 (1 comment) Please also add Documentation. https://review.coreboot.org/#/c/29434/3/src/mainboard/lenovo/x220/variants/… File src/mainboard/lenovo/x220/variants/x1/gpio.c: https://review.coreboot.org/#/c/29434/3/src/mainboard/lenovo/x220/variants/… … [View More]

1 0

Change in coreboot[master]: Linuxboot: add current kernel releases
by Marcello Sylvester Bauer (Code Review) 03 Nov '18

03 Nov '18

Hello Patrick Rudolph, Philipp Deppenwiese, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/29443 to look at the new patch set (#3). Change subject: Linuxboot: add current kernel releases ...................................................................... Linuxboot: add current kernel releases Add current kernel releases instead of hardcode the version number. Also add the option to select a custom version of the kernel. Change-Id:… [View More]

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2018