coreboot-gerrit November 2018

coreboot-gerrit@coreboot.org

1 participants
1699 discussions

Change in coreboot[master]: mb/lenovo/x220: Add x1 as a variant
by Patrick Rudolph (Code Review) 03 Nov '18

03 Nov '18

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/29434 ) Change subject: mb/lenovo/x220: Add x1 as a variant ...................................................................... Patch Set 4: (4 comments) https://review.coreboot.org/#/c/29434/4/Documentation/mainboard/lenovo/t4xx… File Documentation/mainboard/lenovo/t4xx_series.md: https://review.coreboot.org/#/c/29434/4/Documentation/mainboard/lenovo/t4xx… PS4, Line 7: :doc:`thinkpad_hmm` Why is this here ? Should be mainboard/index.md https://review.coreboot.org/#/c/29434/4/Documentation/mainboard/lenovo/x1.md File Documentation/mainboard/lenovo/x1.md: https://review.coreboot.org/#/c/29434/4/Documentation/mainboard/lenovo/x1.m… PS4, Line 1: # Lenovo X1 this file needs to be referenced from mainboard/index.md https://review.coreboot.org/#/c/29434/4/Documentation/mainboard/lenovo/x1.m… PS4, Line 9: No picture ? https://review.coreboot.org/#/c/29434/4/Documentation/mainboard/lenovo/x2xx… File Documentation/mainboard/lenovo/x2xx_series.md: https://review.coreboot.org/#/c/29434/4/Documentation/mainboard/lenovo/x2xx… PS4, Line 3: A skilled engineer takes around 5 minutes to remove the keyboard and not very detailed... -- To view, visit https://review.coreboot.org/29434 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibbc45f22c63b77ac95c188db825d0d7e2b03d2d1 Gerrit-Change-Number: 29434 Gerrit-PatchSet: 4 Gerrit-Owner: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 03 Nov 2018 15:44:09 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: src/mb/asus/p5qc/gpio.c: Use a per-variant gpio.c
by Angel Pons (Code Review) 03 Nov '18

03 Nov '18

Angel Pons has uploaded this change for review. ( https://review.coreboot.org/29447 Change subject: src/mb/asus/p5qc/gpio.c: Use a per-variant gpio.c ...................................................................... src/mb/asus/p5qc/gpio.c: Use a per-variant gpio.c Even though these two mainboards use the same gpio.c file, other boards such as the p5ql_pro do not.* Change-Id: I2f7c8c12cb1bdcf47f3b4d4cef0b11e44a5b8863 Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> --- M src/mainboard/asus/p5qc/Makefile.inc C src/mainboard/asus/p5qc/variants/p5q_pro/gpio.c R src/mainboard/asus/p5qc/variants/p5qc/gpio.c 3 files changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/47/29447/1 diff --git a/src/mainboard/asus/p5qc/Makefile.inc b/src/mainboard/asus/p5qc/Makefile.inc index 630abda..9fcbdf1 100644 --- a/src/mainboard/asus/p5qc/Makefile.inc +++ b/src/mainboard/asus/p5qc/Makefile.inc @@ -12,4 +12,4 @@ # ramstage-y += cstates.c -romstage-y += gpio.c +romstage-y += variants/$(VARIANT_DIR)/gpio.c diff --git a/src/mainboard/asus/p5qc/gpio.c b/src/mainboard/asus/p5qc/variants/p5q_pro/gpio.c similarity index 100% copy from src/mainboard/asus/p5qc/gpio.c copy to src/mainboard/asus/p5qc/variants/p5q_pro/gpio.c diff --git a/src/mainboard/asus/p5qc/gpio.c b/src/mainboard/asus/p5qc/variants/p5qc/gpio.c similarity index 100% rename from src/mainboard/asus/p5qc/gpio.c rename to src/mainboard/asus/p5qc/variants/p5qc/gpio.c -- To view, visit https://review.coreboot.org/29447 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I2f7c8c12cb1bdcf47f3b4d4cef0b11e44a5b8863 Gerrit-Change-Number: 29447 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com>

1 0

Change in coreboot[master]: src/mb/asus/p5qc: Fix some mistakes
by Angel Pons (Code Review) 03 Nov '18

03 Nov '18

Angel Pons has uploaded this change for review. ( https://review.coreboot.org/29446 Change subject: src/mb/asus/p5qc: Fix some mistakes ...................................................................... src/mb/asus/p5qc: Fix some mistakes There are some small mistakes in these recently-added mainboards: - board_info.txt: Lists board socket incorrectly. - cmos.default: Loglevel was decreased some time ago. - devicetree.cb: Spelling mistake. - Kconfig: Mainboard name does not have a hyphen. Change-Id: I08d9b06e79683acd3994b84647bce401ed6741e2 Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> --- M src/mainboard/asus/p5qc/Kconfig M src/mainboard/asus/p5qc/board_info.txt M src/mainboard/asus/p5qc/cmos.default M src/mainboard/asus/p5qc/variants/p5q_pro/devicetree.cb M src/mainboard/asus/p5qc/variants/p5qc/devicetree.cb 5 files changed, 13 insertions(+), 13 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/46/29446/1 diff --git a/src/mainboard/asus/p5qc/Kconfig b/src/mainboard/asus/p5qc/Kconfig index 2bcee16..e8d596f 100644 --- a/src/mainboard/asus/p5qc/Kconfig +++ b/src/mainboard/asus/p5qc/Kconfig @@ -42,7 +42,7 @@ config MAINBOARD_PART_NUMBER string default "P5QC" if BOARD_ASUS_P5QC - default "P5Q-PRO" if BOARD_ASUS_P5Q_PRO + default "P5Q PRO" if BOARD_ASUS_P5Q_PRO config DEVICETREE string diff --git a/src/mainboard/asus/p5qc/board_info.txt b/src/mainboard/asus/p5qc/board_info.txt index 111f2e4..42d4812 100644 --- a/src/mainboard/asus/p5qc/board_info.txt +++ b/src/mainboard/asus/p5qc/board_info.txt @@ -1,6 +1,6 @@ Category: desktop Board URL: https://www.asus.com/Motherboards/P5QC/ -ROM package: SOP-8 +ROM package: DIP-8 ROM protocol: SPI ROM socketed: y Flashrom support: y diff --git a/src/mainboard/asus/p5qc/cmos.default b/src/mainboard/asus/p5qc/cmos.default index ccdb7c8..ad822d5 100644 --- a/src/mainboard/asus/p5qc/cmos.default +++ b/src/mainboard/asus/p5qc/cmos.default @@ -1,5 +1,5 @@ boot_option=Fallback -debug_level=Spew +debug_level=Debug power_on_after_fail=Disable nmi=Enable sata_mode=AHCI diff --git a/src/mainboard/asus/p5qc/variants/p5q_pro/devicetree.cb b/src/mainboard/asus/p5qc/variants/p5q_pro/devicetree.cb index f7088fc..8753d4c 100644 --- a/src/mainboard/asus/p5qc/variants/p5q_pro/devicetree.cb +++ b/src/mainboard/asus/p5qc/variants/p5q_pro/devicetree.cb @@ -85,15 +85,15 @@ irq 0x72 = 12 end device pnp 2e.106 off end # SPI1 - device pnp 2e.107 off end # GIPO6 - device pnp 2e.207 off end # GIPO7 - device pnp 2e.307 on # GIPO8 + device pnp 2e.107 off end # GPIO6 + device pnp 2e.207 off end # GPIO7 + device pnp 2e.307 on # GPIO8 irq 0xe4 = 0xfb irq 0xe5 = 0x82 end - device pnp 2e.407 off end # GIPO9 + device pnp 2e.407 off end # GPIO9 device pnp 2e.8 off end # WDT - device pnp 2e.108 off end # GPIO 1 + device pnp 2e.108 off end # GPIO1 device pnp 2e.9 off end # GPIO2 device pnp 2e.109 on end # GPIO3 device pnp 2e.209 on # GPIO4 diff --git a/src/mainboard/asus/p5qc/variants/p5qc/devicetree.cb b/src/mainboard/asus/p5qc/variants/p5qc/devicetree.cb index 52bbb40..6fac063 100644 --- a/src/mainboard/asus/p5qc/variants/p5qc/devicetree.cb +++ b/src/mainboard/asus/p5qc/variants/p5qc/devicetree.cb @@ -82,15 +82,15 @@ irq 0x72 = 12 end device pnp 2e.106 off end # SPI1 - device pnp 2e.107 off end # GIPO6 - device pnp 2e.207 off end # GIPO7 - device pnp 2e.307 on # GIPO8 + device pnp 2e.107 off end # GPIO6 + device pnp 2e.207 off end # GPIO7 + device pnp 2e.307 on # GPIO8 irq 0xe4 = 0xfb irq 0xe5 = 0x02 end - device pnp 2e.407 off end # GIPO9 + device pnp 2e.407 off end # GPIO9 device pnp 2e.8 off end # WDT - device pnp 2e.108 off end # GPIO 1 + device pnp 2e.108 off end # GPIO1 device pnp 2e.9 off end # GPIO2 device pnp 2e.109 on end # GPIO3 device pnp 2e.209 on # GPIO4 -- To view, visit https://review.coreboot.org/29446 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I08d9b06e79683acd3994b84647bce401ed6741e2 Gerrit-Change-Number: 29446 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com>

1 0

Change in coreboot[master]: mb/lenovo/x220: Add x1 as a variant
by Bill XIE (Code Review) 03 Nov '18

03 Nov '18

Hello Patrick Rudolph, Angel Pons, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/29434 to look at the new patch set (#4). Change subject: mb/lenovo/x220: Add x1 as a variant ...................................................................... mb/lenovo/x220: Add x1 as a variant ThinkPad X1 ( https://www.thinkwiki.org/wiki/Category:X1 ) is nearly a clone of X220, with additional USB3 controller on pci-e (as i7 variant of x220), and a powered ESATA port wired to ata4 (Linux' annotation). Documentation added. Tested: - CPU i5-2520M - Slotted DIMM 8GiB - Camera - Mini pci-e on wlan slot - Msata on wwan slot - On board SDHCI connected to pci-e - USB3 controller connected to pci-e - NVRAM options for North and South bridges - S3 - TPM1 on LPC - Linux 4.9.110-3 within Debian GNU/Linux stable, loaded from SeaBIOS, or Linux payload (Heads) Not tested: - Fingerprint reader on USB2 - Onboard USB2 interfaces (wlan slot, wwan slot) Change-Id: Ibbc45f22c63b77ac95c188db825d0d7e2b03d2d1 Signed-off-by: Bill XIE <persmule(a)gmail.com> --- M Documentation/mainboard/lenovo/t4xx_series.md A Documentation/mainboard/lenovo/thinkpad_hmm.md A Documentation/mainboard/lenovo/x1.md A Documentation/mainboard/lenovo/x2xx_series.md M src/mainboard/lenovo/x220/Kconfig M src/mainboard/lenovo/x220/Kconfig.name M src/mainboard/lenovo/x220/Makefile.inc A src/mainboard/lenovo/x220/variants/x1/devicetree.cb A src/mainboard/lenovo/x220/variants/x1/gpio.c R src/mainboard/lenovo/x220/variants/x220/devicetree.cb R src/mainboard/lenovo/x220/variants/x220/gpio.c 11 files changed, 495 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/34/29434/4 -- To view, visit https://review.coreboot.org/29434 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ibbc45f22c63b77ac95c188db825d0d7e2b03d2d1 Gerrit-Change-Number: 29434 Gerrit-PatchSet: 4 Gerrit-Owner: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: mb/asus/p5qc: Fix spelling of Marvell
by Angel Pons (Code Review) 03 Nov '18

03 Nov '18

Angel Pons has posted comments on this change. ( https://review.coreboot.org/29347 ) Change subject: mb/asus/p5qc: Fix spelling of Marvell ...................................................................... Patch Set 1: Code-Review+2 > Patch Set 1: > > Does it need to be in uppercase? I'd rather use "Marvell", since it is not an acronym. Whatever -- To view, visit https://review.coreboot.org/29347 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I437ac0d4fc706fbb62a0a74ca74a197dba4499fb Gerrit-Change-Number: 29347 Gerrit-PatchSet: 1 Gerrit-Owner: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 03 Nov 2018 14:14:33 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: Linuxboot: check go version
by Marcello Sylvester Bauer (Code Review) 03 Nov '18

03 Nov '18

Marcello Sylvester Bauer has uploaded a new patch set (#2). ( https://review.coreboot.org/29445 ) Change subject: Linuxboot: check go version ...................................................................... Linuxboot: check go version Check if the installed Golang version is >= 1.9. Change-Id: I9fd74fa8dc5e906e8b54ff5afaf69609fe957960 Signed-off-by: Marcello Sylvester Bauer <info(a)marcellobauer.com> --- M payloads/external/LinuxBoot/targets/u-root.mk 1 file changed, 12 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/45/29445/2 -- To view, visit https://review.coreboot.org/29445 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I9fd74fa8dc5e906e8b54ff5afaf69609fe957960 Gerrit-Change-Number: 29445 Gerrit-PatchSet: 2 Gerrit-Owner: Marcello Sylvester Bauer <info(a)marcellobauer.com>

1 0

Change in coreboot[master]: Linuxboot: check golang version
by Marcello Sylvester Bauer (Code Review) 03 Nov '18

03 Nov '18

Marcello Sylvester Bauer has uploaded this change for review. ( https://review.coreboot.org/29445 Change subject: Linuxboot: check golang version ...................................................................... Linuxboot: check golang version Check if the installed Golang version is >= 1.9. Change-Id: I9fd74fa8dc5e906e8b54ff5afaf69609fe957960 Signed-off-by: Marcello Sylvester Bauer <info(a)marcellobauer.com> --- M payloads/external/LinuxBoot/targets/u-root.mk 1 file changed, 12 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/45/29445/1 diff --git a/payloads/external/LinuxBoot/targets/u-root.mk b/payloads/external/LinuxBoot/targets/u-root.mk index 001f7c4..27f184e 100644 --- a/payloads/external/LinuxBoot/targets/u-root.mk +++ b/payloads/external/LinuxBoot/targets/u-root.mk @@ -14,7 +14,10 @@ uroot_git_repo=https://github.com/u-root/u-root.git uroot_dir=$(project_dir)/go/src/github.com/u-root/u-root -go_check=$(shell command -v go 1>/dev/null 2>&1 && echo go) +go_version=$(shell go version | sed -nr 's/.*go([0-9]+\.[0-9]+.?[0-9]?).*/\1/p' ) +go_version_major=$(shell echo $(go_version) | sed -nr 's/^([0-9]+)\.([0-9]+)\.?([0-9]*)$$/\1/p') +go_version_minor=$(shell echo $(go_version) | sed -nr 's/^([0-9]+)\.([0-9]+)\.?([0-9]*)$$/\2/p') + project_dir=$(shell pwd)/linuxboot project_name=u-root go_path_dir=$(shell pwd)/linuxboot/go @@ -22,10 +25,17 @@ all: build check: -ifneq ($(go_check),go) +ifeq ("$(go_version)","") printf "\n<<Please install Golang >= 1.9 for u-root mode>>\n\n" exit 1 endif +ifeq ($(shell if [ $(go_version_major) -eq 1 ]; then echo y; fi),y) +ifeq ($(shell if [ $(go_version_minor) -lt 9 ]; then echo y; fi),y) + printf "\n Golang version $(go_version) currently installed.\n\ + <<Please install Golang >= 1.9 for u-root mode>>\n\n" + exit 1 +endif +endif mkdir -p $(project_dir)/go/src/github.com/u-root $(uroot_dir)/.git: -- To view, visit https://review.coreboot.org/29445 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I9fd74fa8dc5e906e8b54ff5afaf69609fe957960 Gerrit-Change-Number: 29445 Gerrit-PatchSet: 1 Gerrit-Owner: Marcello Sylvester Bauer <info(a)marcellobauer.com>

1 0

Change in coreboot[master]: sb/intel/bd82x6x/early_usb.c: Fix formating
by Angel Pons (Code Review) 03 Nov '18

03 Nov '18

Angel Pons has posted comments on this change. ( https://review.coreboot.org/29428 ) Change subject: sb/intel/bd82x6x/early_usb.c: Fix formating ...................................................................... Patch Set 2: Code-Review+1 (1 comment) https://review.coreboot.org/#/c/29428/2/src/southbridge/intel/bd82x6x/early… File src/southbridge/intel/bd82x6x/early_usb.c: https://review.coreboot.org/#/c/29428/2/src/southbridge/intel/bd82x6x/early… PS2, Line 20: #include <northbridge/intel/sandybridge/sandybridge.h> /* For DEFAULT_RCBABASE */ > line over 80 characters Comment should be moved in another line. -- To view, visit https://review.coreboot.org/29428 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0db1263ec11240003fe1f7080c758994fc0224d3 Gerrit-Change-Number: 29428 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 03 Nov 2018 11:41:58 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mb/lenovo/x220: Add x1 as a variant
by Patrick Rudolph (Code Review) 03 Nov '18

03 Nov '18

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/29434 ) Change subject: mb/lenovo/x220: Add x1 as a variant ...................................................................... Patch Set 3: Code-Review+1 (1 comment) Please also add Documentation. https://review.coreboot.org/#/c/29434/3/src/mainboard/lenovo/x220/variants/… File src/mainboard/lenovo/x220/variants/x1/gpio.c: https://review.coreboot.org/#/c/29434/3/src/mainboard/lenovo/x220/variants/… PS3, Line 5: * Copyright (C) 2014 Vladimir Serbinenko your copyright is missing -- To view, visit https://review.coreboot.org/29434 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibbc45f22c63b77ac95c188db825d0d7e2b03d2d1 Gerrit-Change-Number: 29434 Gerrit-PatchSet: 3 Gerrit-Owner: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 03 Nov 2018 10:59:35 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: Linuxboot: add current kernel releases
by Marcello Sylvester Bauer (Code Review) 03 Nov '18

03 Nov '18

Hello Patrick Rudolph, Philipp Deppenwiese, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/29443 to look at the new patch set (#3). Change subject: Linuxboot: add current kernel releases ...................................................................... Linuxboot: add current kernel releases Add current kernel releases instead of hardcode the version number. Also add the option to select a custom version of the kernel. Change-Id: Ieb071696cfbb466521faaef045fc488a06f6db0c Signed-off-by: Marcello Sylvester Bauer <info(a)marcellobauer.com> --- M payloads/external/LinuxBoot/Kconfig M payloads/external/LinuxBoot/Makefile M payloads/external/Makefile.inc 3 files changed, 46 insertions(+), 10 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/43/29443/3 -- To view, visit https://review.coreboot.org/29443 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ieb071696cfbb466521faaef045fc488a06f6db0c Gerrit-Change-Number: 29443 Gerrit-PatchSet: 3 Gerrit-Owner: Marcello Sylvester Bauer <info(a)marcellobauer.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2018