coreboot-gerrit November 2018

coreboot-gerrit@coreboot.org

1 participants
1699 discussions

Change in coreboot[master]: Linuxboot: add option to parse initramfs
by Marcello Sylvester Bauer (Code Review) 04 Nov '18

04 Nov '18

Marcello Sylvester Bauer has uploaded this change for review. ( https://review.coreboot.org/29448 Change subject: Linuxboot: add option to parse initramfs ...................................................................... Linuxboot: add option to parse initramfs Add the option to build the Linuxboot initramfs, otherwise choose the path to a custom initramfs. Build a u-root initramfs remains default. Change-Id: I648fb2e0383d20b0e4d50e416af637ea07d1efb4 Signed-off-by: Marcello Sylvester Bauer <info(a)marcellobauer.com> --- M payloads/external/LinuxBoot/Kconfig M payloads/external/LinuxBoot/Makefile 2 files changed, 21 insertions(+), 6 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/48/29448/1 diff --git a/payloads/external/LinuxBoot/Kconfig b/payloads/external/LinuxBoot/Kconfig index 58a67d6..30bd610 100644 --- a/payloads/external/LinuxBoot/Kconfig +++ b/payloads/external/LinuxBoot/Kconfig @@ -112,9 +112,16 @@ config PAYLOAD_FILE default "payloads/external/LinuxBoot/linuxboot/kernel-image" +config LINUXBOOT_BUILD_INITRAMFS + bool "build initramfs" + default y + help + build Linuxboot initramfs + choice prompt "Payload Mode" default LINUXBOOT_UROOT + depends on LINUXBOOT_BUILD_INITRAMFS config LINUXBOOT_UROOT bool "u-root" @@ -153,12 +160,20 @@ Path to directory containing root structure for embedding into the initramfs. -config PAYLOAD_USERSPACE - string "LinuxBoot initramfs" - default "payloads/external/LinuxBoot/linuxboot/initramfs.cpio.xz" +endif + +config LINUXBOOT_CUSTOM_INITRAMFS + string "path to LinuxBoot initramfs" + default "" + depends on !LINUXBOOT_BUILD_INITRAMFS help The initramfs to use with the compiled kernel. Useful for debugging or custom initramfs. -endif +config PAYLOAD_USERSPACE + string + default "payloads/external/LinuxBoot/linuxboot/initramfs.cpio.xz" \ + if LINUXBOOT_BUILD_INITRAMFS && LINUXBOOT_UROOT + default LINUXBOOT_CUSTOM_INITRAMFS if !LINUXBOOT_BUILD_INITRAMFS + endif diff --git a/payloads/external/LinuxBoot/Makefile b/payloads/external/LinuxBoot/Makefile index 2390ba8..352c271 100644 --- a/payloads/external/LinuxBoot/Makefile +++ b/payloads/external/LinuxBoot/Makefile @@ -42,7 +42,7 @@ OBJCOPY:=$(LINUXBOOT_COMPILE)objcopy -all: payload +all: linuxboot toolchain: if [[ ! -x "$(LINUXBOOT_COMPILE)gcc" ]]; then \ @@ -104,7 +104,7 @@ echo "Building without u-root support" endif -payload: $(project_dir)/kernel-image $(PWD)/$(CONFIG_PAYLOAD_USERSPACE) +linuxboot: $(project_dir)/kernel-image $(PWD)/$(CONFIG_PAYLOAD_USERSPACE) clean: if [ -d "$(kernel_dir)" ]; then rm -rf $(kernel_dir); fi -- To view, visit https://review.coreboot.org/29448 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I648fb2e0383d20b0e4d50e416af637ea07d1efb4 Gerrit-Change-Number: 29448 Gerrit-PatchSet: 1 Gerrit-Owner: Marcello Sylvester Bauer <info(a)marcellobauer.com>

1 0

Change in coreboot[master]: Linuxboot: add current kernel releases
by Marcello Sylvester Bauer (Code Review) 04 Nov '18

04 Nov '18

Hello Patrick Rudolph, Philipp Deppenwiese, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/29443 to look at the new patch set (#5). Change subject: Linuxboot: add current kernel releases ...................................................................... Linuxboot: add current kernel releases Add current kernel releases instead of hardcode the version number. Also add the option to select a custom version of the kernel. Change-Id: Ieb071696cfbb466521faaef045fc488a06f6db0c Signed-off-by: Marcello Sylvester Bauer <info(a)marcellobauer.com> --- M payloads/external/LinuxBoot/Kconfig M payloads/external/LinuxBoot/Makefile M payloads/external/Makefile.inc 3 files changed, 46 insertions(+), 10 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/43/29443/5 -- To view, visit https://review.coreboot.org/29443 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ieb071696cfbb466521faaef045fc488a06f6db0c Gerrit-Change-Number: 29443 Gerrit-PatchSet: 5 Gerrit-Owner: Marcello Sylvester Bauer <info(a)marcellobauer.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: Linuxboot: check go version
by Marcello Sylvester Bauer (Code Review) 04 Nov '18

04 Nov '18

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/29445 to look at the new patch set (#3). Change subject: Linuxboot: check go version ...................................................................... Linuxboot: check go version Check if the installed Golang version is >= 1.9. Change-Id: I9fd74fa8dc5e906e8b54ff5afaf69609fe957960 Signed-off-by: Marcello Sylvester Bauer <info(a)marcellobauer.com> --- M payloads/external/LinuxBoot/targets/u-root.mk 1 file changed, 12 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/45/29445/3 -- To view, visit https://review.coreboot.org/29445 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I9fd74fa8dc5e906e8b54ff5afaf69609fe957960 Gerrit-Change-Number: 29445 Gerrit-PatchSet: 3 Gerrit-Owner: Marcello Sylvester Bauer <info(a)marcellobauer.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: mb/lenovo/x220: Add x1 as a variant
by Patrick Rudolph (Code Review) 04 Nov '18

04 Nov '18

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/29434 ) Change subject: mb/lenovo/x220: Add x1 as a variant ...................................................................... Patch Set 5: (1 comment) https://review.coreboot.org/#/c/29434/5/src/mainboard/lenovo/x220/variants/… File src/mainboard/lenovo/x220/variants/x1/devicetree.cb: https://review.coreboot.org/#/c/29434/5/src/mainboard/lenovo/x220/variants/… PS5, Line 173: has_bdc_detection > Does "BDC" stand for "Bluetooth Daughter Card"? yes -- To view, visit https://review.coreboot.org/29434 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibbc45f22c63b77ac95c188db825d0d7e2b03d2d1 Gerrit-Change-Number: 29434 Gerrit-PatchSet: 5 Gerrit-Owner: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 04 Nov 2018 09:16:30 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: mb/lenovo/x220: Add x1 as a variant
by Bill XIE (Code Review) 04 Nov '18

04 Nov '18

Bill XIE has posted comments on this change. ( https://review.coreboot.org/29434 ) Change subject: mb/lenovo/x220: Add x1 as a variant ...................................................................... Patch Set 5: (1 comment) https://review.coreboot.org/#/c/29434/5/src/mainboard/lenovo/x220/variants/… File src/mainboard/lenovo/x220/variants/x1/devicetree.cb: https://review.coreboot.org/#/c/29434/5/src/mainboard/lenovo/x220/variants/… PS5, Line 173: has_bdc_detection > enable has_bdc_detection and set bdc_gpio_num=54 and test if BDC is still detected by Lenovo's H8 co […] Does "BDC" stand for "Bluetooth Daughter Card"? -- To view, visit https://review.coreboot.org/29434 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibbc45f22c63b77ac95c188db825d0d7e2b03d2d1 Gerrit-Change-Number: 29434 Gerrit-PatchSet: 5 Gerrit-Owner: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 04 Nov 2018 08:39:50 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: mb/lenovo/x220: Add x1 as a variant
by Patrick Rudolph (Code Review) 04 Nov '18

04 Nov '18

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/29434 ) Change subject: mb/lenovo/x220: Add x1 as a variant ...................................................................... Patch Set 5: (4 comments) @Nico: As far as I understand UVSCC applies to the second flash chip and should be set to 0 on boards that only have one flash chip, correct ? https://review.coreboot.org/#/c/29434/5/src/mainboard/lenovo/x220/variants/… File src/mainboard/lenovo/x220/variants/x1/devicetree.cb: https://review.coreboot.org/#/c/29434/5/src/mainboard/lenovo/x220/variants/… PS5, Line 71: 0, 0, 0, 0, 0, 0, 0, 0 > X1 does not have Expresscard slot. Ack https://review.coreboot.org/#/c/29434/5/src/mainboard/lenovo/x220/variants/… PS5, Line 79: 0x2005 > No, it has one flash chip, same as x220. As far as I understand UVSCC only applies to the "upper" aka second flash chip. https://review.coreboot.org/#/c/29434/5/src/mainboard/lenovo/x220/variants/… PS5, Line 104: on > a wlan card slot, and a USB3 controller. in that case you have three unused enabled pcie slots, which should be set to "off". https://review.coreboot.org/#/c/29434/5/src/mainboard/lenovo/x220/variants/… PS5, Line 173: has_bdc_detection > How to check whether BDC detection works? enable has_bdc_detection and set bdc_gpio_num=54 and test if BDC is still detected by Lenovo's H8 code. it prints "H8: BDC ..." -- To view, visit https://review.coreboot.org/29434 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibbc45f22c63b77ac95c188db825d0d7e2b03d2d1 Gerrit-Change-Number: 29434 Gerrit-PatchSet: 5 Gerrit-Owner: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 04 Nov 2018 08:36:12 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: Linuxboot: add current kernel releases
by Patrick Rudolph (Code Review) 04 Nov '18

04 Nov '18

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/29443 ) Change subject: Linuxboot: add current kernel releases ...................................................................... Patch Set 4: (1 comment) https://review.coreboot.org/#/c/29443/4/payloads/external/LinuxBoot/Makefile File payloads/external/LinuxBoot/Makefile: https://review.coreboot.org/#/c/29443/4/payloads/external/LinuxBoot/Makefil… PS4, Line 24: kernel_tarball=https://cdn.kernel.org/pub/linux/kernel/v4.x/linux-$(kernel_… that will only work for 4.x kernels. Can you get the major version number from kernel_version and replace the v4.x by it ? That way it'll work for 3.x and 5.x kernels. -- To view, visit https://review.coreboot.org/29443 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ieb071696cfbb466521faaef045fc488a06f6db0c Gerrit-Change-Number: 29443 Gerrit-PatchSet: 4 Gerrit-Owner: Marcello Sylvester Bauer <info(a)marcellobauer.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 04 Nov 2018 07:44:58 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: mb/lenovo/x220: Add x1 as a variant
by Bill XIE (Code Review) 04 Nov '18

04 Nov '18

Bill XIE has posted comments on this change. ( https://review.coreboot.org/29434 ) Change subject: mb/lenovo/x220: Add x1 as a variant ...................................................................... Patch Set 5: (4 comments) https://review.coreboot.org/#/c/29434/5/src/mainboard/lenovo/x220/variants/… File src/mainboard/lenovo/x220/variants/x1/devicetree.cb: https://review.coreboot.org/#/c/29434/5/src/mainboard/lenovo/x220/variants/… PS5, Line 71: 0, 0, 0, 0, 0, 0, 0, 0 > The Expresscard port should have a one here. X1 does not have Expresscard slot. https://review.coreboot.org/#/c/29434/5/src/mainboard/lenovo/x220/variants/… PS5, Line 79: 0x2005 > Does it have two flash chips ? It's not clear from the documentation. No, it has one flash chip, same as x220. https://review.coreboot.org/#/c/29434/5/src/mainboard/lenovo/x220/variants/… PS5, Line 104: on > What's behind those ports ? One might be for Expresscard. a wlan card slot, and a USB3 controller. https://review.coreboot.org/#/c/29434/5/src/mainboard/lenovo/x220/variants/… PS5, Line 173: has_bdc_detection > Does BDC detection properly work ? […] How to check whether BDC detection works? -- To view, visit https://review.coreboot.org/29434 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibbc45f22c63b77ac95c188db825d0d7e2b03d2d1 Gerrit-Change-Number: 29434 Gerrit-PatchSet: 5 Gerrit-Owner: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 04 Nov 2018 07:27:59 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: mb/lenovo/x220: Add x1 as a variant
by Patrick Rudolph (Code Review) 04 Nov '18

04 Nov '18

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/29434 ) Change subject: mb/lenovo/x220: Add x1 as a variant ...................................................................... Patch Set 5: Code-Review+1 (4 comments) https://review.coreboot.org/#/c/29434/5/src/mainboard/lenovo/x220/variants/… File src/mainboard/lenovo/x220/variants/x1/devicetree.cb: https://review.coreboot.org/#/c/29434/5/src/mainboard/lenovo/x220/variants/… PS5, Line 71: 0, 0, 0, 0, 0, 0, 0, 0 The Expresscard port should have a one here. https://review.coreboot.org/#/c/29434/5/src/mainboard/lenovo/x220/variants/… PS5, Line 79: 0x2005 Does it have two flash chips ? It's not clear from the documentation. https://review.coreboot.org/#/c/29434/5/src/mainboard/lenovo/x220/variants/… PS5, Line 104: on What's behind those ports ? One might be for Expresscard. https://review.coreboot.org/#/c/29434/5/src/mainboard/lenovo/x220/variants/… PS5, Line 173: has_bdc_detection Does BDC detection properly work ? Maybe it was fixed while updating the design. -- To view, visit https://review.coreboot.org/29434 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibbc45f22c63b77ac95c188db825d0d7e2b03d2d1 Gerrit-Change-Number: 29434 Gerrit-PatchSet: 5 Gerrit-Owner: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 04 Nov 2018 07:22:06 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mb/lenovo/x220: Add x1 as a variant
by Bill XIE (Code Review) 03 Nov '18

03 Nov '18

Hello Patrick Rudolph, Angel Pons, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/29434 to look at the new patch set (#5). Change subject: mb/lenovo/x220: Add x1 as a variant ...................................................................... mb/lenovo/x220: Add x1 as a variant ThinkPad X1 ( https://www.thinkwiki.org/wiki/Category:X1 ) is nearly a clone of X220, with additional USB3 controller on pci-e (as i7 variant of x220), and a powered ESATA port wired to ata4 (Linux' annotation). Documentation added. Tested: - CPU i5-2520M - Slotted DIMM 8GiB - Camera - Mini pci-e on wlan slot - Msata on wwan slot - On board SDHCI connected to pci-e - USB3 controller connected to pci-e - NVRAM options for North and South bridges - S3 - TPM1 on LPC - Linux 4.9.110-3 within Debian GNU/Linux stable, loaded from SeaBIOS, or Linux payload (Heads) Not tested: - Fingerprint reader on USB2 - Onboard USB2 interfaces (wlan slot, wwan slot) Change-Id: Ibbc45f22c63b77ac95c188db825d0d7e2b03d2d1 Signed-off-by: Bill XIE <persmule(a)gmail.com> --- M Documentation/mainboard/index.md M Documentation/mainboard/lenovo/t4xx_series.md A Documentation/mainboard/lenovo/thinkpad_hmm.md A Documentation/mainboard/lenovo/x1.md A Documentation/mainboard/lenovo/x2xx_series.md M src/mainboard/lenovo/x220/Kconfig M src/mainboard/lenovo/x220/Kconfig.name M src/mainboard/lenovo/x220/Makefile.inc A src/mainboard/lenovo/x220/variants/x1/devicetree.cb A src/mainboard/lenovo/x220/variants/x1/gpio.c R src/mainboard/lenovo/x220/variants/x220/devicetree.cb R src/mainboard/lenovo/x220/variants/x220/gpio.c 12 files changed, 494 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/34/29434/5 -- To view, visit https://review.coreboot.org/29434 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ibbc45f22c63b77ac95c188db825d0d7e2b03d2d1 Gerrit-Change-Number: 29434 Gerrit-PatchSet: 5 Gerrit-Owner: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2018