coreboot-gerrit November 2018

coreboot-gerrit@coreboot.org

1 participants
1699 discussions

Change in coreboot[master]: x86/acpi.c: Be more verbose when finding the wakeup vector
by Angel Pons (Code Review) 04 Nov '18

04 Nov '18

Hello build bot (Jenkins), Nico Huber, I'd like you to reexamine a change. Please visit https://review.coreboot.org/29449 to look at the new patch set (#2). Change subject: x86/acpi.c: Be more verbose when finding the wakeup vector ...................................................................... x86/acpi.c: Be more verbose when finding the wakeup vector Since S3 resume sometimes breaks when trying to find the wakeup vector, it is useful to log whether it errors or not. Since it is an error, print it as such. Change-Id: Ib006c4a213c0da180018e5fbf7a47d6af66f8bc4 Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> --- M src/arch/x86/acpi.c 1 file changed, 10 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/49/29449/2 -- To view, visit https://review.coreboot.org/29449 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ib006c4a213c0da180018e5fbf7a47d6af66f8bc4 Gerrit-Change-Number: 29449 Gerrit-PatchSet: 2 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: src/mb/asus/p5qc/gpio.c: Allow specifying a gpio.c in Kconfig
by Patrick Rudolph (Code Review) 04 Nov '18

04 Nov '18

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/29447 ) Change subject: src/mb/asus/p5qc/gpio.c: Allow specifying a gpio.c in Kconfig ...................................................................... Patch Set 3: *into the devicetree -- To view, visit https://review.coreboot.org/29447 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2f7c8c12cb1bdcf47f3b4d4cef0b11e44a5b8863 Gerrit-Change-Number: 29447 Gerrit-PatchSet: 3 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 04 Nov 2018 16:08:47 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: src/mb/asus/p5qc/gpio.c: Allow specifying a gpio.c in Kconfig
by Patrick Rudolph (Code Review) 04 Nov '18

04 Nov '18

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/29447 ) Change subject: src/mb/asus/p5qc/gpio.c: Allow specifying a gpio.c in Kconfig ...................................................................... Patch Set 3: Code-Review+1 time to move gpio stuff into the device ;-) -- To view, visit https://review.coreboot.org/29447 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2f7c8c12cb1bdcf47f3b4d4cef0b11e44a5b8863 Gerrit-Change-Number: 29447 Gerrit-PatchSet: 3 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 04 Nov 2018 16:08:15 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: intel/nb/*/gma: Use new common PMBASE API
by Patrick Rudolph (Code Review) 04 Nov '18

04 Nov '18

Hello Arthur Heymans, build bot (Jenkins), Nico Huber, I'd like you to reexamine a change. Please visit https://review.coreboot.org/29439 to look at the new patch set (#6). Change subject: intel/nb/*/gma: Use new common PMBASE API ...................................................................... intel/nb/*/gma: Use new common PMBASE API * Introduce common function to enable TCO SCI. * Use new PMBASE functions to get rid of get_pmbase * Port helper functions from lynxpoint to common folder Change-Id: I6b5977b10d1e38b45e09530e9dcabbd5f42facb2 Signed-off-by: Patrick Rudolph <siro(a)das-labor.org> --- M src/northbridge/intel/fsp_sandybridge/gma.c M src/northbridge/intel/haswell/gma.c M src/northbridge/intel/nehalem/gma.c M src/northbridge/intel/sandybridge/gma.c M src/southbridge/intel/common/Makefile.inc A src/southbridge/intel/common/gma.c A src/southbridge/intel/common/gma.h M src/southbridge/intel/common/pmutil.c M src/southbridge/intel/common/pmutil.h M src/southbridge/intel/lynxpoint/pmutil.c 10 files changed, 105 insertions(+), 89 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/39/29439/6 -- To view, visit https://review.coreboot.org/29439 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I6b5977b10d1e38b45e09530e9dcabbd5f42facb2 Gerrit-Change-Number: 29439 Gerrit-PatchSet: 6 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: src/mb/asus/p5qc/gpio.c: Allow specifying a gpio.c in Kconfig
by Angel Pons (Code Review) 04 Nov '18

04 Nov '18

Angel Pons has posted comments on this change. ( https://review.coreboot.org/29447 ) Change subject: src/mb/asus/p5qc/gpio.c: Allow specifying a gpio.c in Kconfig ...................................................................... Patch Set 3: > Patch Set 2: Code-Review-1 > > Please do not duplicate the file, you can point to the correct one in > Kconfig. e.g. > > config ... > string > default "variants/p5qc/gpio.c" if PRO > default "variants/$(VARIANT_DIR)/gpio.c" I made something that works and does not need to duplicate gpio.c. Not sure how sane it is, though. -- To view, visit https://review.coreboot.org/29447 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2f7c8c12cb1bdcf47f3b4d4cef0b11e44a5b8863 Gerrit-Change-Number: 29447 Gerrit-PatchSet: 3 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 04 Nov 2018 15:57:24 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: intel/nb/*/gma: Use new common PMBASE API
by Patrick Rudolph (Code Review) 04 Nov '18

04 Nov '18

Hello Arthur Heymans, build bot (Jenkins), Nico Huber, I'd like you to reexamine a change. Please visit https://review.coreboot.org/29439 to look at the new patch set (#5). Change subject: intel/nb/*/gma: Use new common PMBASE API ...................................................................... intel/nb/*/gma: Use new common PMBASE API * Introduce common function to enable TCO SCI. * Use new PMBASE functions to get rid of get_pmbase * Port helper functions from lynxpoint to common folder Change-Id: I6b5977b10d1e38b45e09530e9dcabbd5f42facb2 Signed-off-by: Patrick Rudolph <siro(a)das-labor.org> --- M src/northbridge/intel/fsp_sandybridge/gma.c M src/northbridge/intel/haswell/gma.c M src/northbridge/intel/nehalem/gma.c M src/northbridge/intel/sandybridge/gma.c M src/southbridge/intel/common/Makefile.inc A src/southbridge/intel/common/gma.c A src/southbridge/intel/common/gma.h M src/southbridge/intel/common/pmutil.c M src/southbridge/intel/common/pmutil.h M src/southbridge/intel/lynxpoint/pmutil.c 10 files changed, 104 insertions(+), 89 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/39/29439/5 -- To view, visit https://review.coreboot.org/29439 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I6b5977b10d1e38b45e09530e9dcabbd5f42facb2 Gerrit-Change-Number: 29439 Gerrit-PatchSet: 5 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: src/mb/asus/p5qc/gpio.c: Allow specifying a gpio.c in Kconfig
by Angel Pons (Code Review) 04 Nov '18

04 Nov '18

Hello Patrick Rudolph, Arthur Heymans, build bot (Jenkins), Nico Huber, I'd like you to reexamine a change. Please visit https://review.coreboot.org/29447 to look at the new patch set (#3). Change subject: src/mb/asus/p5qc/gpio.c: Allow specifying a gpio.c in Kconfig ...................................................................... src/mb/asus/p5qc/gpio.c: Allow specifying a gpio.c in Kconfig Even though these two mainboards use the same gpio.c file, other boards such as the p5ql_pro do not. Change-Id: I2f7c8c12cb1bdcf47f3b4d4cef0b11e44a5b8863 Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> --- M src/mainboard/asus/p5qc/Kconfig M src/mainboard/asus/p5qc/Makefile.inc 2 files changed, 7 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/47/29447/3 -- To view, visit https://review.coreboot.org/29447 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I2f7c8c12cb1bdcf47f3b4d4cef0b11e44a5b8863 Gerrit-Change-Number: 29447 Gerrit-PatchSet: 3 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: Linuxboot: add current kernel releases
by Marcello Sylvester Bauer (Code Review) 04 Nov '18

04 Nov '18

Hello Patrick Rudolph, Philipp Deppenwiese, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/29443 to look at the new patch set (#6). Change subject: Linuxboot: add current kernel releases ...................................................................... Linuxboot: add current kernel releases Add current kernel releases instead of hardcode the version number. Also add the option to select a custom version of the kernel. Change-Id: Ieb071696cfbb466521faaef045fc488a06f6db0c Signed-off-by: Marcello Sylvester Bauer <info(a)marcellobauer.com> --- M payloads/external/LinuxBoot/Kconfig M payloads/external/LinuxBoot/Makefile M payloads/external/Makefile.inc 3 files changed, 46 insertions(+), 10 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/43/29443/6 -- To view, visit https://review.coreboot.org/29443 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ieb071696cfbb466521faaef045fc488a06f6db0c Gerrit-Change-Number: 29443 Gerrit-PatchSet: 6 Gerrit-Owner: Marcello Sylvester Bauer <info(a)marcellobauer.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: mb/lenovo/x220: Add x1 as a variant
by Patrick Rudolph (Code Review) 04 Nov '18

04 Nov '18

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/29434 ) Change subject: mb/lenovo/x220: Add x1 as a variant ...................................................................... Patch Set 6: (1 comment) https://review.coreboot.org/#/c/29434/5/src/mainboard/lenovo/x220/variants/… File src/mainboard/lenovo/x220/variants/x1/devicetree.cb: https://review.coreboot.org/#/c/29434/5/src/mainboard/lenovo/x220/variants/… PS5, Line 79: > The SPI Guide suggests to fill both for maximum compatibility. And […] Thanks for clarifying, the PCH datasheet doesn't explain 'upper' and 'lower'. -- To view, visit https://review.coreboot.org/29434 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibbc45f22c63b77ac95c188db825d0d7e2b03d2d1 Gerrit-Change-Number: 29434 Gerrit-PatchSet: 6 Gerrit-Owner: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 04 Nov 2018 14:53:54 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: mb/lenovo/x220: Add x1 as a variant
by Bill XIE (Code Review) 04 Nov '18

04 Nov '18

Bill XIE has posted comments on this change. ( https://review.coreboot.org/29434 ) Change subject: mb/lenovo/x220: Add x1 as a variant ...................................................................... Patch Set 6: > Patch Set 5: Code-Review-1 > > (1 comment) > > Please use an override devicetree instead. See google/fizz for example, > `config OVERRIDE_DEVICETREE` and 27efc501d1 (util/sconfig: Add support > for overriding base tree properties/node). Done. Please help review them. (they may need further changes) -- To view, visit https://review.coreboot.org/29434 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibbc45f22c63b77ac95c188db825d0d7e2b03d2d1 Gerrit-Change-Number: 29434 Gerrit-PatchSet: 6 Gerrit-Owner: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 04 Nov 2018 14:34:45 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2018