coreboot-gerrit November 2018

coreboot-gerrit@coreboot.org

1 participants
1699 discussions

Change in coreboot[master]: coreboot-sdk: Don't install libisl-dev
by Nico Huber (Code Review) 04 Nov '18

04 Nov '18

Nico Huber has uploaded this change for review. ( https://review.coreboot.org/29453 Change subject: coreboot-sdk: Don't install libisl-dev ...................................................................... coreboot-sdk: Don't install libisl-dev The current version in debian:sid is incompatible with our crossgcc version. But it turned out that we don't use the optimization features enabled by libisl at all: crossgcc builds with and without (a proper version of) libisl-dev installed generate the same coreboot binaries. Change-Id: I9f9115d8ab33cbe11aa77f16c98465e1c1dedeac Signed-off-by: Nico Huber <nico.h(a)gmx.de> --- M util/docker/coreboot-sdk/Dockerfile 1 file changed, 0 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/53/29453/1 diff --git a/util/docker/coreboot-sdk/Dockerfile b/util/docker/coreboot-sdk/Dockerfile index 4410e5b..44682f8 100644 --- a/util/docker/coreboot-sdk/Dockerfile +++ b/util/docker/coreboot-sdk/Dockerfile @@ -41,7 +41,6 @@ libftdi1-dev \ libglib2.0-dev \ libgmp-dev \ - libisl-dev \ libjaylink-dev \ liblzma-dev \ libncurses5-dev \ -- To view, visit https://review.coreboot.org/29453 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I9f9115d8ab33cbe11aa77f16c98465e1c1dedeac Gerrit-Change-Number: 29453 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>

1 0

Change in coreboot[master]: util/abuild: Use absolute paths for (failed|passed)_boards
by Nico Huber (Code Review) 04 Nov '18

04 Nov '18

Nico Huber has uploaded this change for review. ( https://review.coreboot.org/29451 Change subject: util/abuild: Use absolute paths for (failed|passed)_boards ...................................................................... util/abuild: Use absolute paths for (failed|passed)_boards The variables are used from different relative locations so they have to hold an absolute path. Fixes runs with the default, relative TARGET path `coreboot-builds/`. Change-Id: Ief00e28e09a4714b0106c35ad4f4e9c696f6aad4 Signed-off-by: Nico Huber <nico.h(a)gmx.de> --- M util/abuild/abuild 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/51/29451/1 diff --git a/util/abuild/abuild b/util/abuild/abuild index 9afd364..8ec9b11 100755 --- a/util/abuild/abuild +++ b/util/abuild/abuild @@ -747,8 +747,8 @@ customizing="default configuration" fi -FAILED_BOARDS="${TARGET}/failed_boards" -PASSED_BOARDS="${TARGET}/passing_boards" +FAILED_BOARDS=$(realpath ${TARGET}/failed_boards) +PASSED_BOARDS=$(realpath ${TARGET}/passing_boards) if [ "$recursive" = "false" ]; then rm -f "$FAILED_BOARDS" "$PASSED_BOARDS" -- To view, visit https://review.coreboot.org/29451 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ief00e28e09a4714b0106c35ad4f4e9c696f6aad4 Gerrit-Change-Number: 29451 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>

1 0

Change in coreboot[master]: intel/nb/*/gma: Use new common PMBASE API
by Patrick Rudolph (Code Review) 04 Nov '18

04 Nov '18

Hello Arthur Heymans, build bot (Jenkins), Nico Huber, I'd like you to reexamine a change. Please visit https://review.coreboot.org/29439 to look at the new patch set (#11). Change subject: intel/nb/*/gma: Use new common PMBASE API ...................................................................... intel/nb/*/gma: Use new common PMBASE API * Introduce common function to enable TCO SCI * Use new PMBASE functions to get rid of get_pmbase * Port helper functions from lynxpoint to common folder Change-Id: I6b5977b10d1e38b45e09530e9dcabbd5f42facb2 Signed-off-by: Patrick Rudolph <siro(a)das-labor.org> --- M src/northbridge/intel/haswell/gma.c M src/northbridge/intel/sandybridge/gma.c M src/southbridge/intel/common/Makefile.inc A src/southbridge/intel/common/gma.c A src/southbridge/intel/common/gma.h M src/southbridge/intel/common/pmutil.c M src/southbridge/intel/common/pmutil.h M src/southbridge/intel/lynxpoint/pch.h M src/southbridge/intel/lynxpoint/pmutil.c 9 files changed, 104 insertions(+), 49 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/39/29439/11 -- To view, visit https://review.coreboot.org/29439 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I6b5977b10d1e38b45e09530e9dcabbd5f42facb2 Gerrit-Change-Number: 29439 Gerrit-PatchSet: 11 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: intel/nb/*/gma: Use new common PMBASE API
by Patrick Rudolph (Code Review) 04 Nov '18

04 Nov '18

Hello Arthur Heymans, build bot (Jenkins), Nico Huber, I'd like you to reexamine a change. Please visit https://review.coreboot.org/29439 to look at the new patch set (#10). Change subject: intel/nb/*/gma: Use new common PMBASE API ...................................................................... intel/nb/*/gma: Use new common PMBASE API * Introduce common function to enable TCO SCI * Use new PMBASE functions to get rid of get_pmbase * Port helper functions from lynxpoint to common folder Change-Id: I6b5977b10d1e38b45e09530e9dcabbd5f42facb2 Signed-off-by: Patrick Rudolph <siro(a)das-labor.org> --- M src/northbridge/intel/fsp_sandybridge/gma.c M src/northbridge/intel/haswell/gma.c M src/northbridge/intel/sandybridge/gma.c M src/southbridge/intel/common/Makefile.inc A src/southbridge/intel/common/gma.c A src/southbridge/intel/common/gma.h M src/southbridge/intel/common/pmutil.c M src/southbridge/intel/common/pmutil.h M src/southbridge/intel/lynxpoint/pch.h M src/southbridge/intel/lynxpoint/pmutil.c 10 files changed, 107 insertions(+), 70 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/39/29439/10 -- To view, visit https://review.coreboot.org/29439 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I6b5977b10d1e38b45e09530e9dcabbd5f42facb2 Gerrit-Change-Number: 29439 Gerrit-PatchSet: 10 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: sb/intel/bd82x6x/early_usb.c: Fix formating
by Elyes HAOUAS (Code Review) 04 Nov '18

04 Nov '18

Hello Angel Pons, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/29428 to look at the new patch set (#3). Change subject: sb/intel/bd82x6x/early_usb.c: Fix formating ...................................................................... sb/intel/bd82x6x/early_usb.c: Fix formating Remove whitespace between the function name and open parenthesis, and fix 81+ characters lines. Change-Id: I0db1263ec11240003fe1f7080c758994fc0224d3 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/southbridge/intel/bd82x6x/early_usb.c 1 file changed, 13 insertions(+), 13 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/29428/3 -- To view, visit https://review.coreboot.org/29428 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I0db1263ec11240003fe1f7080c758994fc0224d3 Gerrit-Change-Number: 29428 Gerrit-PatchSet: 3 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: intel/nb/*/gma: Use new common PMBASE API
by Patrick Rudolph (Code Review) 04 Nov '18

04 Nov '18

Hello Arthur Heymans, build bot (Jenkins), Nico Huber, I'd like you to reexamine a change. Please visit https://review.coreboot.org/29439 to look at the new patch set (#9). Change subject: intel/nb/*/gma: Use new common PMBASE API ...................................................................... intel/nb/*/gma: Use new common PMBASE API * Introduce common function to enable TCO SCI. * Use new PMBASE functions to get rid of get_pmbase * Port helper functions from lynxpoint to common folder Change-Id: I6b5977b10d1e38b45e09530e9dcabbd5f42facb2 Signed-off-by: Patrick Rudolph <siro(a)das-labor.org> --- M src/northbridge/intel/fsp_sandybridge/gma.c M src/northbridge/intel/haswell/gma.c M src/northbridge/intel/nehalem/gma.c M src/northbridge/intel/sandybridge/gma.c M src/southbridge/intel/common/Makefile.inc A src/southbridge/intel/common/gma.c A src/southbridge/intel/common/gma.h M src/southbridge/intel/common/pmutil.c M src/southbridge/intel/common/pmutil.h M src/southbridge/intel/lynxpoint/pch.h M src/southbridge/intel/lynxpoint/pmutil.c 11 files changed, 110 insertions(+), 90 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/39/29439/9 -- To view, visit https://review.coreboot.org/29439 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I6b5977b10d1e38b45e09530e9dcabbd5f42facb2 Gerrit-Change-Number: 29439 Gerrit-PatchSet: 9 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: intel/nb/*/gma: Use new common PMBASE API
by Patrick Rudolph (Code Review) 04 Nov '18

04 Nov '18

Hello Arthur Heymans, build bot (Jenkins), Nico Huber, I'd like you to reexamine a change. Please visit https://review.coreboot.org/29439 to look at the new patch set (#8). Change subject: intel/nb/*/gma: Use new common PMBASE API ...................................................................... intel/nb/*/gma: Use new common PMBASE API * Introduce common function to enable TCO SCI. * Use new PMBASE functions to get rid of get_pmbase * Port helper functions from lynxpoint to common folder Change-Id: I6b5977b10d1e38b45e09530e9dcabbd5f42facb2 Signed-off-by: Patrick Rudolph <siro(a)das-labor.org> --- M src/northbridge/intel/fsp_sandybridge/gma.c M src/northbridge/intel/haswell/gma.c M src/northbridge/intel/nehalem/gma.c M src/northbridge/intel/sandybridge/gma.c M src/southbridge/intel/common/Makefile.inc A src/southbridge/intel/common/gma.c A src/southbridge/intel/common/gma.h M src/southbridge/intel/common/pmutil.c M src/southbridge/intel/common/pmutil.h M src/southbridge/intel/lynxpoint/pch.h M src/southbridge/intel/lynxpoint/pmutil.c 11 files changed, 110 insertions(+), 90 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/39/29439/8 -- To view, visit https://review.coreboot.org/29439 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I6b5977b10d1e38b45e09530e9dcabbd5f42facb2 Gerrit-Change-Number: 29439 Gerrit-PatchSet: 8 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: x86/acpi.c: Be more verbose when finding the wakeup vector
by Nico Huber (Code Review) 04 Nov '18

04 Nov '18

Nico Huber has posted comments on this change. ( https://review.coreboot.org/29449 ) Change subject: x86/acpi.c: Be more verbose when finding the wakeup vector ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/29449 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib006c4a213c0da180018e5fbf7a47d6af66f8bc4 Gerrit-Change-Number: 29449 Gerrit-PatchSet: 2 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 04 Nov 2018 16:24:19 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: intel/nb/*/gma: Use new common PMBASE API
by Patrick Rudolph (Code Review) 04 Nov '18

04 Nov '18

Hello Arthur Heymans, build bot (Jenkins), Nico Huber, I'd like you to reexamine a change. Please visit https://review.coreboot.org/29439 to look at the new patch set (#7). Change subject: intel/nb/*/gma: Use new common PMBASE API ...................................................................... intel/nb/*/gma: Use new common PMBASE API * Introduce common function to enable TCO SCI. * Use new PMBASE functions to get rid of get_pmbase * Port helper functions from lynxpoint to common folder Change-Id: I6b5977b10d1e38b45e09530e9dcabbd5f42facb2 Signed-off-by: Patrick Rudolph <siro(a)das-labor.org> --- M src/northbridge/intel/fsp_sandybridge/gma.c M src/northbridge/intel/haswell/gma.c M src/northbridge/intel/nehalem/gma.c M src/northbridge/intel/sandybridge/gma.c M src/southbridge/intel/common/Makefile.inc A src/southbridge/intel/common/gma.c A src/southbridge/intel/common/gma.h M src/southbridge/intel/common/pmutil.c M src/southbridge/intel/common/pmutil.h M src/southbridge/intel/lynxpoint/pch.h M src/southbridge/intel/lynxpoint/pmutil.c 11 files changed, 109 insertions(+), 90 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/39/29439/7 -- To view, visit https://review.coreboot.org/29439 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I6b5977b10d1e38b45e09530e9dcabbd5f42facb2 Gerrit-Change-Number: 29439 Gerrit-PatchSet: 7 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: x86/acpi.c: Be more verbose when finding the wakeup vector
by Angel Pons (Code Review) 04 Nov '18

04 Nov '18

Angel Pons has posted comments on this change. ( https://review.coreboot.org/29449 ) Change subject: x86/acpi.c: Be more verbose when finding the wakeup vector ...................................................................... Patch Set 2: (3 comments) https://review.coreboot.org/#/c/29449/1//COMMIT_MSG Commit Message: https://review.coreboot.org/#/c/29449/1//COMMIT_MSG@7 PS1, Line 7: x86/acpi.c: Be more verbose when finding the wakeup vector > The original Git rule is 55 chars for the summary. We allow […] Now I understand why my editor (neovim) would only highlight a part of the summary... Done https://review.coreboot.org/#/c/29449/1/src/arch/x86/acpi.c File src/arch/x86/acpi.c: https://review.coreboot.org/#/c/29449/1/src/arch/x86/acpi.c@1282 PS1, Line 1282: BIOS_ALE > rather BIOS_ALERT Done https://review.coreboot.org/#/c/29449/1/src/arch/x86/acpi.c@1282 PS1, Line 1282: printk(BIOS_ALERT, > Please don't break the string literal. If you want to honor the […] Done -- To view, visit https://review.coreboot.org/29449 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib006c4a213c0da180018e5fbf7a47d6af66f8bc4 Gerrit-Change-Number: 29449 Gerrit-PatchSet: 2 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 04 Nov 2018 16:18:08 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2018