coreboot-gerrit November 2018

coreboot-gerrit@coreboot.org

1 participants
1699 discussions

Change in coreboot[master]: mb/clevo/n130wu: Add mainboard
by Philipp Deppenwiese (Code Review) 04 Nov '18

04 Nov '18

Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/28640 ) Change subject: mb/clevo/n130wu: Add mainboard ...................................................................... Patch Set 30: Can you rename the company from clevo to tuxedo? -- To view, visit https://review.coreboot.org/28640 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I364f5849ef88f43b85efbd7a635a27e54d08c513 Gerrit-Change-Number: 28640 Gerrit-PatchSet: 30 Gerrit-Owner: Felix Singer <migy(a)darmstadt.ccc.de> Gerrit-Reviewer: Felix Singer <migy(a)darmstadt.ccc.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Comment-Date: Sun, 04 Nov 2018 22:30:23 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: Linuxboot: gitignore build directory
by Marcello Sylvester Bauer (Code Review) 04 Nov '18

04 Nov '18

Marcello Sylvester Bauer has posted comments on this change. ( https://review.coreboot.org/29444 ) Change subject: Linuxboot: gitignore build directory ...................................................................... Patch Set 3: > (1 comment) > > Other payloads' source/build directories are so far ignored in the > top-level .gitgnore true, I revised it. Thanks for the advice. -- To view, visit https://review.coreboot.org/29444 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic11311e2de544a334043a55eda42643d9df3374d Gerrit-Change-Number: 29444 Gerrit-PatchSet: 3 Gerrit-Owner: Marcello Sylvester Bauer <info(a)marcellobauer.com> Gerrit-Reviewer: Marcello Sylvester Bauer <info(a)marcellobauer.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Comment-Date: Sun, 04 Nov 2018 22:24:09 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: Linuxboot: gitignore build directory
by Marcello Sylvester Bauer (Code Review) 04 Nov '18

04 Nov '18

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/29444 to look at the new patch set (#3). Change subject: Linuxboot: gitignore build directory ...................................................................... Linuxboot: gitignore build directory Add the Linuxboot build directory to .gitignore. Change-Id: Ic11311e2de544a334043a55eda42643d9df3374d Signed-off-by: Marcello Sylvester Bauer <info(a)marcellobauer.com> --- M .gitignore 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/44/29444/3 -- To view, visit https://review.coreboot.org/29444 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ic11311e2de544a334043a55eda42643d9df3374d Gerrit-Change-Number: 29444 Gerrit-PatchSet: 3 Gerrit-Owner: Marcello Sylvester Bauer <info(a)marcellobauer.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net>

1 0

Change in coreboot[master]: Linuxboot: gitignore build directory
by Marcello Sylvester Bauer (Code Review) 04 Nov '18

04 Nov '18

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/29444 to look at the new patch set (#2). Change subject: Linuxboot: gitignore build directory ...................................................................... Linuxboot: gitignore build directory Add the Linuxboot build directory to a .gitignore file. Change-Id: Ic11311e2de544a334043a55eda42643d9df3374d Signed-off-by: Marcello Sylvester Bauer <info(a)marcellobauer.com> --- A payloads/external/LinuxBoot/.gitignore 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/44/29444/2 -- To view, visit https://review.coreboot.org/29444 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ic11311e2de544a334043a55eda42643d9df3374d Gerrit-Change-Number: 29444 Gerrit-PatchSet: 2 Gerrit-Owner: Marcello Sylvester Bauer <info(a)marcellobauer.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net>

1 0

Change in coreboot[master]: coreboot-sdk: Don't install libisl-dev
by Jonathan Neuschäfer (Code Review) 04 Nov '18

04 Nov '18

Jonathan Neuschäfer has posted comments on this change. ( https://review.coreboot.org/29453 ) Change subject: coreboot-sdk: Don't install libisl-dev ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/29453 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9f9115d8ab33cbe11aa77f16c98465e1c1dedeac Gerrit-Change-Number: 29453 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 04 Nov 2018 20:55:37 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: coreboot-sdk: Don't install libelf-dev
by Jonathan Neuschäfer (Code Review) 04 Nov '18

04 Nov '18

Jonathan Neuschäfer has posted comments on this change. ( https://review.coreboot.org/29452 ) Change subject: coreboot-sdk: Don't install libelf-dev ...................................................................... Patch Set 1: Code-Review+2 Thanks -- To view, visit https://review.coreboot.org/29452 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3124cb6db5975c21e635636babe700adb0f8cd8b Gerrit-Change-Number: 29452 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 04 Nov 2018 20:54:36 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: sb/intel/bd82x6x/early_usb.c: Fix formatting
by Elyes HAOUAS (Code Review) 04 Nov '18

04 Nov '18

Elyes HAOUAS has posted comments on this change. ( https://review.coreboot.org/29428 ) Change subject: sb/intel/bd82x6x/early_usb.c: Fix formatting ...................................................................... Patch Set 3: (1 comment) https://review.coreboot.org/#/c/29428/3/src/southbridge/intel/bd82x6x/early… File src/southbridge/intel/bd82x6x/early_usb.c: https://review.coreboot.org/#/c/29428/3/src/southbridge/intel/bd82x6x/early… PS3, Line 20: #include <northbridge/intel/sandybridge/sandybridge.h> > Was there a need to remove the commit message? I think, the comment about "include sandybridge.h" is useless. -- To view, visit https://review.coreboot.org/29428 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0db1263ec11240003fe1f7080c758994fc0224d3 Gerrit-Change-Number: 29428 Gerrit-PatchSet: 3 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 04 Nov 2018 20:31:33 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: sb/intel/bd82x6x/early_usb.c: Fix formatting
by Elyes HAOUAS (Code Review) 04 Nov '18

04 Nov '18

Hello Angel Pons, Jonathan Neuschäfer, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/29428 to look at the new patch set (#4). Change subject: sb/intel/bd82x6x/early_usb.c: Fix formatting ...................................................................... sb/intel/bd82x6x/early_usb.c: Fix formatting Remove whitespace between the function name and open parenthesis, and fix 81+ characters lines. Unnecessary comment about 'include sandybridge.h'removed. Change-Id: I0db1263ec11240003fe1f7080c758994fc0224d3 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/southbridge/intel/bd82x6x/early_usb.c 1 file changed, 13 insertions(+), 13 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/29428/4 -- To view, visit https://review.coreboot.org/29428 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I0db1263ec11240003fe1f7080c758994fc0224d3 Gerrit-Change-Number: 29428 Gerrit-PatchSet: 4 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: sb/intel/bd82x6x/early_usb.c: Fix formating
by Angel Pons (Code Review) 04 Nov '18

04 Nov '18

Angel Pons has posted comments on this change. ( https://review.coreboot.org/29428 ) Change subject: sb/intel/bd82x6x/early_usb.c: Fix formating ...................................................................... Patch Set 3: (1 comment) https://review.coreboot.org/#/c/29428/3/src/southbridge/intel/bd82x6x/early… File src/southbridge/intel/bd82x6x/early_usb.c: https://review.coreboot.org/#/c/29428/3/src/southbridge/intel/bd82x6x/early… PS3, Line 20: #include <northbridge/intel/sandybridge/sandybridge.h> > Please mention this part in the commit message. Was there a need to remove the commit message? -- To view, visit https://review.coreboot.org/29428 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0db1263ec11240003fe1f7080c758994fc0224d3 Gerrit-Change-Number: 29428 Gerrit-PatchSet: 3 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 04 Nov 2018 20:25:38 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: sb/intel/bd82x6x/early_usb.c: Fix formating
by Jonathan Neuschäfer (Code Review) 04 Nov '18

04 Nov '18

Jonathan Neuschäfer has posted comments on this change. ( https://review.coreboot.org/29428 ) Change subject: sb/intel/bd82x6x/early_usb.c: Fix formating ...................................................................... Patch Set 3: Code-Review+1 (2 comments) Thanks https://review.coreboot.org/#/c/29428/3//COMMIT_MSG Commit Message: https://review.coreboot.org/#/c/29428/3//COMMIT_MSG@7 PS3, Line 7: sb/intel/bd82x6x/early_usb.c: Fix formating s/formating/formatting/ https://review.coreboot.org/#/c/29428/3/src/southbridge/intel/bd82x6x/early… File src/southbridge/intel/bd82x6x/early_usb.c: https://review.coreboot.org/#/c/29428/3/src/southbridge/intel/bd82x6x/early… PS3, Line 20: #include <northbridge/intel/sandybridge/sandybridge.h> Please mention this part in the commit message. -- To view, visit https://review.coreboot.org/29428 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0db1263ec11240003fe1f7080c758994fc0224d3 Gerrit-Change-Number: 29428 Gerrit-PatchSet: 3 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 04 Nov 2018 20:11:03 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2018