coreboot-gerrit November 2018

coreboot-gerrit@coreboot.org

1 participants
1699 discussions

Change in coreboot[master]: siemens/mc_apl2: Adjust GPIO settings for mc_apl2
by Mario Scheithauer (Code Review) 05 Nov '18

05 Nov '18

Hello Werner Zeh, uwe poeche, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/29318 to look at the new patch set (#2). Change subject: siemens/mc_apl2: Adjust GPIO settings for mc_apl2 ...................................................................... siemens/mc_apl2: Adjust GPIO settings for mc_apl2 This mainboard variant requires GPIO adaptations to match the hardware. Change-Id: I16387358d6c6fa15efd16f7ba7f6b89740477e9d Signed-off-by: Mario Scheithauer <mario.scheithauer(a)siemens.com> --- M src/mainboard/siemens/mc_apl1/variants/mc_apl2/Makefile.inc A src/mainboard/siemens/mc_apl1/variants/mc_apl2/gpio.c 2 files changed, 687 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/18/29318/2 -- To view, visit https://review.coreboot.org/29318 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I16387358d6c6fa15efd16f7ba7f6b89740477e9d Gerrit-Change-Number: 29318 Gerrit-PatchSet: 2 Gerrit-Owner: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: uwe poeche <uwetaz(a)gmail.com>

1 0

Change in coreboot[master]: security/vboot: Add VB2_LIB to postcar stage if available
by Werner Zeh (Code Review) 05 Nov '18

05 Nov '18

Werner Zeh has uploaded this change for review. ( https://review.coreboot.org/29465 Change subject: security/vboot: Add VB2_LIB to postcar stage if available ...................................................................... security/vboot: Add VB2_LIB to postcar stage if available VB2_LIB will be used across all stages to hash data. Add it to postcar stage if this stage is available for the given configuration. In this way the new function tpm_measure_region() introduced in commit 61322d7 (security/tpm: Add function to measure a region device) can be used in every stage. Change-Id: I933d33b0188d1b123bb4735722b6086e7786624f Signed-off-by: Werner Zeh <werner.zeh(a)siemens.com> --- M src/security/vboot/Makefile.inc 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/65/29465/1 diff --git a/src/security/vboot/Makefile.inc b/src/security/vboot/Makefile.inc index 704b6c9..92498d8 100644 --- a/src/security/vboot/Makefile.inc +++ b/src/security/vboot/Makefile.inc @@ -112,6 +112,9 @@ $(eval $(call vboot-for-stage,verstage)) $(eval $(call vboot-for-stage,bootblock)) $(eval $(call vboot-for-stage,ramstage)) +ifeq ($(CONFIG_POSTCAR_STAGE), y) +$(eval $(call vboot-for-stage,postcar)) +endif # CONFIG_POSTCAR_STAGE ifeq ($(CONFIG_VBOOT_SEPARATE_VERSTAGE),y) -- To view, visit https://review.coreboot.org/29465 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I933d33b0188d1b123bb4735722b6086e7786624f Gerrit-Change-Number: 29465 Gerrit-PatchSet: 1 Gerrit-Owner: Werner Zeh <werner.zeh(a)siemens.com>

1 0

Change in coreboot[master]: mb/lenovo/x220: Add x1 as a variant
by Bill XIE (Code Review) 05 Nov '18

05 Nov '18

Bill XIE has posted comments on this change. ( https://review.coreboot.org/29434 ) Change subject: mb/lenovo/x220: Add x1 as a variant ...................................................................... Patch Set 8: (2 comments) https://review.coreboot.org/#/c/29434/4/Documentation/mainboard/lenovo/x1.md File Documentation/mainboard/lenovo/x1.md: https://review.coreboot.org/#/c/29434/4/Documentation/mainboard/lenovo/x1.m… PS4, Line 9: cable (already detached from MB in the picture) connecting the keyboard > No picture ? A picture is added in the newest revision. https://review.coreboot.org/#/c/29434/5/src/mainboard/lenovo/x220/variants/… File src/mainboard/lenovo/x220/variants/x1/devicetree.cb: https://review.coreboot.org/#/c/29434/5/src/mainboard/lenovo/x220/variants/… PS5, Line 104: > in that case you have three unused enabled pcie slots, which should be set to "off". Unused pci-e ports are set to off in the newest revision. -- To view, visit https://review.coreboot.org/29434 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibbc45f22c63b77ac95c188db825d0d7e2b03d2d1 Gerrit-Change-Number: 29434 Gerrit-PatchSet: 8 Gerrit-Owner: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 05 Nov 2018 06:06:09 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: mb/lenovo/x220: Add x1 as a variant
by Bill XIE (Code Review) 05 Nov '18

05 Nov '18

Hello Patrick Rudolph, Angel Pons, build bot (Jenkins), Nico Huber, I'd like you to reexamine a change. Please visit https://review.coreboot.org/29434 to look at the new patch set (#8). Change subject: mb/lenovo/x220: Add x1 as a variant ...................................................................... mb/lenovo/x220: Add x1 as a variant ThinkPad X1 ( https://www.thinkwiki.org/wiki/Category:X1 ) is nearly a clone of X220, with additional USB3 controller on pci-e (as i7 variant of x220), and a powered ESATA port wired to ata4 (Linux' annotation). Documentation added. Tested: - CPU i5-2520M - Slotted DIMM 8GiB - Camera - Mini pci-e on wlan slot - Msata on wwan slot - On board SDHCI connected to pci-e - USB3 controller connected to pci-e - NVRAM options for North and South bridges - S3 - TPM1 on LPC - Linux 4.9.110-3 within Debian GNU/Linux stable, loaded from SeaBIOS, or Linux payload (Heads) Not tested: - Fingerprint reader on USB2 - Onboard USB2 interfaces (wlan slot, wwan slot) Change-Id: Ibbc45f22c63b77ac95c188db825d0d7e2b03d2d1 Signed-off-by: Bill XIE <persmule(a)gmail.com> --- M Documentation/mainboard/index.md M Documentation/mainboard/lenovo/t4xx_series.md A Documentation/mainboard/lenovo/thinkpad_hmm.md A Documentation/mainboard/lenovo/x1.md A Documentation/mainboard/lenovo/x1_flash_ic.png A Documentation/mainboard/lenovo/x2xx_series.md M src/mainboard/lenovo/x220/Kconfig M src/mainboard/lenovo/x220/Kconfig.name M src/mainboard/lenovo/x220/Makefile.inc M src/mainboard/lenovo/x220/devicetree.cb A src/mainboard/lenovo/x220/variants/x1/gpio.c A src/mainboard/lenovo/x220/variants/x1/overridetree.cb R src/mainboard/lenovo/x220/variants/x220/gpio.c A src/mainboard/lenovo/x220/variants/x220/overridetree.cb 14 files changed, 392 insertions(+), 7 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/34/29434/8 -- To view, visit https://review.coreboot.org/29434 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ibbc45f22c63b77ac95c188db825d0d7e2b03d2d1 Gerrit-Change-Number: 29434 Gerrit-PatchSet: 8 Gerrit-Owner: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: mb/lenovo/x220: Add x1 as a variant
by Bill XIE (Code Review) 05 Nov '18

05 Nov '18

Hello Patrick Rudolph, Angel Pons, build bot (Jenkins), Nico Huber, I'd like you to reexamine a change. Please visit https://review.coreboot.org/29434 to look at the new patch set (#7). Change subject: mb/lenovo/x220: Add x1 as a variant ...................................................................... mb/lenovo/x220: Add x1 as a variant ThinkPad X1 ( https://www.thinkwiki.org/wiki/Category:X1 ) is nearly a clone of X220, with additional USB3 controller on pci-e (as i7 variant of x220), and a powered ESATA port wired to ata4 (Linux' annotation). Documentation added. Tested: - CPU i5-2520M - Slotted DIMM 8GiB - Camera - Mini pci-e on wlan slot - Msata on wwan slot - On board SDHCI connected to pci-e - USB3 controller connected to pci-e - NVRAM options for North and South bridges - S3 - TPM1 on LPC - Linux 4.9.110-3 within Debian GNU/Linux stable, loaded from SeaBIOS, or Linux payload (Heads) Not tested: - Fingerprint reader on USB2 - Onboard USB2 interfaces (wlan slot, wwan slot) Change-Id: Ibbc45f22c63b77ac95c188db825d0d7e2b03d2d1 Signed-off-by: Bill XIE <persmule(a)gmail.com> --- M Documentation/mainboard/index.md M Documentation/mainboard/lenovo/t4xx_series.md A Documentation/mainboard/lenovo/thinkpad_hmm.md A Documentation/mainboard/lenovo/x1.md A Documentation/mainboard/lenovo/x1_flash_ic.png A Documentation/mainboard/lenovo/x2xx_series.md M src/mainboard/lenovo/x220/Kconfig M src/mainboard/lenovo/x220/Kconfig.name M src/mainboard/lenovo/x220/Makefile.inc M src/mainboard/lenovo/x220/devicetree.cb A src/mainboard/lenovo/x220/variants/x1/gpio.c A src/mainboard/lenovo/x220/variants/x1/overridetree.cb R src/mainboard/lenovo/x220/variants/x220/gpio.c A src/mainboard/lenovo/x220/variants/x220/overridetree.cb 14 files changed, 394 insertions(+), 7 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/34/29434/7 -- To view, visit https://review.coreboot.org/29434 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ibbc45f22c63b77ac95c188db825d0d7e2b03d2d1 Gerrit-Change-Number: 29434 Gerrit-PatchSet: 7 Gerrit-Owner: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: mb/google/fizz: Comment variant names in Kconfig
by David Wu (Code Review) 05 Nov '18

05 Nov '18

David Wu has uploaded this change for review. ( https://review.coreboot.org/29464 Change subject: mb/google/fizz: Comment variant names in Kconfig ...................................................................... mb/google/fizz: Comment variant names in Kconfig Refer to CL:1043916 BUG=none BRANCH=none TEST=none Change-Id: I3fbbbcac334646f68b8b9fd38fbb529d9e833581 Signed-off-by: David Wu <David_Wu(a)quanta.corp-partner.google.com> --- M src/mainboard/google/fizz/Kconfig.name 1 file changed, 4 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/29464/1 diff --git a/src/mainboard/google/fizz/Kconfig.name b/src/mainboard/google/fizz/Kconfig.name index d7343f9..608a58d 100644 --- a/src/mainboard/google/fizz/Kconfig.name +++ b/src/mainboard/google/fizz/Kconfig.name @@ -1,7 +1,9 @@ +comment "Fizz" + config BOARD_GOOGLE_FIZZ - bool "Fizz" + bool "-> Fizz" select BOARD_GOOGLE_BASEBOARD_FIZZ config BOARD_GOOGLE_KARMA - bool "Karma" + bool "-> Karma" select BOARD_GOOGLE_BASEBOARD_FIZZ -- To view, visit https://review.coreboot.org/29464 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I3fbbbcac334646f68b8b9fd38fbb529d9e833581 Gerrit-Change-Number: 29464 Gerrit-PatchSet: 1 Gerrit-Owner: David Wu <david_wu(a)quanta.corp-partner.google.com>

1 0

Change in coreboot[master]: mb/lenovo/x220: Add x1 as a variant
by Bill XIE (Code Review) 05 Nov '18

05 Nov '18

Bill XIE has posted comments on this change. ( https://review.coreboot.org/29434 ) Change subject: mb/lenovo/x220: Add x1 as a variant ...................................................................... Patch Set 6: (1 comment) https://review.coreboot.org/#/c/29434/5/src/mainboard/lenovo/x220/variants/… File src/mainboard/lenovo/x220/variants/x1/devicetree.cb: https://review.coreboot.org/#/c/29434/5/src/mainboard/lenovo/x220/variants/… PS5, Line 173: > Did you set has_bdc_detection=1 ? Yes, I have tried setting has_bdc_detection=1 and bdc_gpio_num=54. -- To view, visit https://review.coreboot.org/29434 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibbc45f22c63b77ac95c188db825d0d7e2b03d2d1 Gerrit-Change-Number: 29434 Gerrit-PatchSet: 6 Gerrit-Owner: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 05 Nov 2018 05:33:00 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: mb/lenovo/x220: Add x1 as a variant
by Patrick Rudolph (Code Review) 05 Nov '18

05 Nov '18

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/29434 ) Change subject: mb/lenovo/x220: Add x1 as a variant ...................................................................... Patch Set 6: (1 comment) https://review.coreboot.org/#/c/29434/5/src/mainboard/lenovo/x220/variants/… File src/mainboard/lenovo/x220/variants/x1/devicetree.cb: https://review.coreboot.org/#/c/29434/5/src/mainboard/lenovo/x220/variants/… PS5, Line 173: > I have tried BDC detection on X1, and it says "H8: BDC detection not implemented. […] Did you set has_bdc_detection=1 ? -- To view, visit https://review.coreboot.org/29434 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibbc45f22c63b77ac95c188db825d0d7e2b03d2d1 Gerrit-Change-Number: 29434 Gerrit-PatchSet: 6 Gerrit-Owner: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 05 Nov 2018 05:23:52 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: mb/lenovo/x220: Add x1 as a variant
by Bill XIE (Code Review) 05 Nov '18

05 Nov '18

Bill XIE has posted comments on this change. ( https://review.coreboot.org/29434 ) Change subject: mb/lenovo/x220: Add x1 as a variant ...................................................................... Patch Set 6: (1 comment) https://review.coreboot.org/#/c/29434/5/src/mainboard/lenovo/x220/variants/… File src/mainboard/lenovo/x220/variants/x1/devicetree.cb: https://review.coreboot.org/#/c/29434/5/src/mainboard/lenovo/x220/variants/… PS5, Line 173: > yes I have tried BDC detection on X1, and it says "H8: BDC detection not implemented. Assuming BDC installed" -- To view, visit https://review.coreboot.org/29434 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibbc45f22c63b77ac95c188db825d0d7e2b03d2d1 Gerrit-Change-Number: 29434 Gerrit-PatchSet: 6 Gerrit-Owner: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 05 Nov 2018 05:16:41 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: util/docker: Unify local build targets
by Martin Roth (Code Review) 05 Nov '18

05 Nov '18

Martin Roth has posted comments on this change. ( https://review.coreboot.org/29456 ) Change subject: util/docker: Unify local build targets ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/#/c/29456/1/util/docker/Makefile File util/docker/Makefile: https://review.coreboot.org/#/c/29456/1/util/docker/Makefile@105 PS1, Line 105: override I don't think the override operator is needed. It just makes it so you can't update it from the command line. Since it's not defined anywhere else, the makefiles should work fine without it. -- To view, visit https://review.coreboot.org/29456 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9088fb9211726cddc37b17ddf70170c2c382679e Gerrit-Change-Number: 29456 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 05 Nov 2018 04:33:26 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2018