Hello Chris Wang, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/29469
to look at the new patch set (#4).
Change subject: mb/google/kahlee: edp panel initialization time tuning
......................................................................
mb/google/kahlee: edp panel initialization time tuning
1.adding two parameters for panel initialization timing.
> lvds_poseq_varybl_to_blon
> lvds_poseq_blon_to_varybl
2.changing GPIO EP133 to high as default.
BUG=b:118011567
TEST=emerge-grunt coreboot
Change-Id: Ib20c48813b208d697b950b2f02a70a690e483fdb
Signed-off-by: Chris Wang <chris.wang(a)amd.corp-partner.google.com>
---
M src/mainboard/google/kahlee/OemCustomize.c
M src/mainboard/google/kahlee/variants/baseboard/gpio.c
M src/soc/amd/stoneyridge/chip.h
3 files changed, 19 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/29469/4
--
To view, visit https://review.coreboot.org/29469
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib20c48813b208d697b950b2f02a70a690e483fdb
Gerrit-Change-Number: 29469
Gerrit-PatchSet: 4
Gerrit-Owner: chris wang <Chris.Wang(a)amd.com>
Gerrit-Reviewer: Chris Wang <chris.wang(a)amd.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/29470
to look at the new patch set (#2).
Change subject: src/mainboard/portwell/m107: Do initial mainboard commit
......................................................................
src/mainboard/portwell/m107: Do initial mainboard commit
No support for Portwell PQ7-M107.
Create (braswell) board based on Intel Strago.
BUG=N/A
TEST=Portwell PQ7-M107
Change-Id: I7d3173fdcf881f894a75cd9798ba173b425d4e62
Signed-off-by: Frans Hendriks <fhendriks(a)eltan.com>
---
A src/mainboard/portwell/Kconfig
A src/mainboard/portwell/Kconfig.name
A src/mainboard/portwell/m107/Kconfig
A src/mainboard/portwell/m107/Kconfig.name
A src/mainboard/portwell/m107/Makefile.inc
A src/mainboard/portwell/m107/acpi/dptf.asl
A src/mainboard/portwell/m107/acpi/ec.asl
A src/mainboard/portwell/m107/acpi/mainboard.asl
A src/mainboard/portwell/m107/acpi/sleepstates.asl
A src/mainboard/portwell/m107/acpi/superio.asl
A src/mainboard/portwell/m107/acpi_tables.c
A src/mainboard/portwell/m107/board_info.txt
A src/mainboard/portwell/m107/cmos.layout
A src/mainboard/portwell/m107/com_init.c
A src/mainboard/portwell/m107/devicetree.cb
A src/mainboard/portwell/m107/dsdt.asl
A src/mainboard/portwell/m107/fadt.c
A src/mainboard/portwell/m107/gpio.c
A src/mainboard/portwell/m107/hda_verb.c
A src/mainboard/portwell/m107/irqroute.c
A src/mainboard/portwell/m107/irqroute.h
A src/mainboard/portwell/m107/mainboard.c
A src/mainboard/portwell/m107/onboard.h
A src/mainboard/portwell/m107/romstage.c
A src/mainboard/portwell/m107/smihandler.c
A src/mainboard/portwell/m107/spd/SAMSUNG_K4B8G1646D-MYKO.spd.hex
A src/mainboard/portwell/m107/w25q64.c
27 files changed, 1,611 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/70/29470/2
--
To view, visit https://review.coreboot.org/29470
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7d3173fdcf881f894a75cd9798ba173b425d4e62
Gerrit-Change-Number: 29470
Gerrit-PatchSet: 2
Gerrit-Owner: Frans Hendriks <fhendriks(a)eltan.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/29471 )
Change subject: MAINTAINERS: Clarify this is about active upstream development
......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/#/c/29471/1/MAINTAINERS
File MAINTAINERS:
https://review.coreboot.org/#/c/29471/1/MAINTAINERS@76
PS1, Line 76: Should
Must, if we want to automate adding them as reviewers (which has been on the agenda for a while)
https://review.coreboot.org/#/c/29471/1/MAINTAINERS@86
PS1, Line 86: react
in a timely manner
--
To view, visit https://review.coreboot.org/29471
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9ee038dc5ee1f4993ba1d230ef6e737f20e2ff8a
Gerrit-Change-Number: 29471
Gerrit-PatchSet: 1
Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Comment-Date: Mon, 05 Nov 2018 13:13:10 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
Nico Huber has uploaded this change for review. ( https://review.coreboot.org/29471
Change subject: MAINTAINERS: Clarify this is about active upstream development
......................................................................
MAINTAINERS: Clarify this is about active upstream development
<vendor> seems to be confused about the meaning of our maintainers list.
I get the feeling some use it to organize corporate internal teams and
branches, adding names to the list that don't show up in Gerrit and even
if, often don't react to reviewing requests (within months). Maybe they
even don't know that this is about coreboot.org?
To clarify this:
o Add an introductory paragraph mentioning development on coreboot.org.
o Explicitly state that maintainers should be registered to Gerrit.
o If a topic is tagged as `Supported`, expect that somebody reacts to
review requests.
Change-Id: I9ee038dc5ee1f4993ba1d230ef6e737f20e2ff8a
Signed-off-by: Nico Huber <nico.huber(a)secunet.com>
---
M MAINTAINERS
1 file changed, 12 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/29471/1
diff --git a/MAINTAINERS b/MAINTAINERS
index b7031c5..46b588a 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1,6 +1,14 @@
- List of maintainers and how to submit coreboot changes
+ List of upstream coreboot maintainers
+ and how to submit coreboot changes
+
+This represents the list of maintainers that work on the upstream coreboot
+code base (on coreboot.org). Maintainers are assigned to topics and when
+applicable to subtrees of the source tree. You'll find some subtrees that
+don't have a maintainer. If you are looking for reviewers for such a sub-
+tree, it's often a good choice to look at the git history who worked on it
+lastly.
Please try to follow the guidelines below. This will make things
easier on the maintainers. Not all of these guidelines matter for every
@@ -65,6 +73,7 @@
Descriptions of section entries:
M: Maintainer: FullName <address@domain>
+ Should be registered to Gerrit (https://review.coreboot.org/).
R: Designated reviewer: FullName <address@domain>
These reviewers should be CCed on patches.
L: Mailing list that is relevant to this area
@@ -73,7 +82,8 @@
T: SCM tree type and location.
Type is one of: git, hg, quilt, stgit, topgit
S: Status, one of the following:
- Supported: Someone is actually paid to look after this.
+ Supported: Someone is actually paid to look after this and can
+ be expected to react to review requests.
Maintained: Someone actually looks after it.
Odd Fixes: It has a maintainer but they don't have time to do
much other than throw the odd patch in. See below..
--
To view, visit https://review.coreboot.org/29471
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9ee038dc5ee1f4993ba1d230ef6e737f20e2ff8a
Gerrit-Change-Number: 29471
Gerrit-PatchSet: 1
Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>
Hello Chris Wang, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/29469
to look at the new patch set (#3).
Change subject: mb/google/kahlee: edp panel initialization time tuning
......................................................................
mb/google/kahlee: edp panel initialization time tuning
1.adding two parameters for panel initialization timing.
> lvds_poseq_varybl_to_blon
> lvds_poseq_blon_to_varybl
2.changing GPIO EP133 to high as default.
BUG=b:118011567
TEST=emerge-grunt coreboot
Change-Id: Ib20c48813b208d697b950b2f02a70a690e483fdb
Signed-off-by: Chris Wang <chris.wang(a)amd.corp-partner.google.com>
---
M src/mainboard/google/kahlee/OemCustomize.c
M src/mainboard/google/kahlee/variants/baseboard/gpio.c
M src/soc/amd/stoneyridge/chip.h
3 files changed, 18 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/29469/3
--
To view, visit https://review.coreboot.org/29469
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib20c48813b208d697b950b2f02a70a690e483fdb
Gerrit-Change-Number: 29469
Gerrit-PatchSet: 3
Gerrit-Owner: chris wang <Chris.Wang(a)amd.com>
Gerrit-Reviewer: Chris Wang <chris.wang(a)amd.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>