coreboot-gerrit November 2018

coreboot-gerrit@coreboot.org

1 participants
1699 discussions

Change in coreboot[master]: security/vboot: Add VB2_LIB to postcar stage if available
by Julius Werner (Code Review) 05 Nov '18

05 Nov '18

Julius Werner has posted comments on this change. ( https://review.coreboot.org/29465 ) Change subject: security/vboot: Add VB2_LIB to postcar stage if available ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/#/c/29465/1/src/security/vboot/Makefile.inc File src/security/vboot/Makefile.inc: https://review.coreboot.org/#/c/29465/1/src/security/vboot/Makefile.inc@115 PS1, Line 115: ifeq ($(CONFIG_POSTCAR_STAGE), y) I don't think you need to guard this, actually. vboot-for-stage will just set up rules culminating up to VB2_LIB_postcar which is added to postcar-srcs. If we're not building a postcar stage, those rules just won't be executed because postcar-srcs isn't added as a dependency to anything. -- To view, visit https://review.coreboot.org/29465 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I933d33b0188d1b123bb4735722b6086e7786624f Gerrit-Change-Number: 29465 Gerrit-PatchSet: 1 Gerrit-Owner: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-Comment-Date: Mon, 05 Nov 2018 21:19:29 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: Linuxboot: remove initramfs path entry
by Philipp Deppenwiese (Code Review) 05 Nov '18

05 Nov '18

Philipp Deppenwiese has submitted this change and it was merged. ( https://review.coreboot.org/29448 ) Change subject: Linuxboot: remove initramfs path entry ...................................................................... Linuxboot: remove initramfs path entry Remove Linuxboot initramfs path entry in Kconfig. Custom initramfs can and should be used with 'Linux payload'. Change-Id: I648fb2e0383d20b0e4d50e416af637ea07d1efb4 Signed-off-by: Marcello Sylvester Bauer <info(a)marcellobauer.com> Reviewed-on: https://review.coreboot.org/29448 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> --- M payloads/external/LinuxBoot/Kconfig M payloads/external/LinuxBoot/Makefile 2 files changed, 3 insertions(+), 6 deletions(-) Approvals: build bot (Jenkins): Verified Philipp Deppenwiese: Looks good to me, approved diff --git a/payloads/external/LinuxBoot/Kconfig b/payloads/external/LinuxBoot/Kconfig index 8acb542..a872d49 100644 --- a/payloads/external/LinuxBoot/Kconfig +++ b/payloads/external/LinuxBoot/Kconfig @@ -129,11 +129,8 @@ initramfs. config PAYLOAD_USERSPACE - string "LinuxBoot initramfs" + string default "payloads/external/LinuxBoot/linuxboot/initramfs.cpio.xz" - help - The initramfs to use with the compiled kernel. - Useful for debugging or custom initramfs. endif endif diff --git a/payloads/external/LinuxBoot/Makefile b/payloads/external/LinuxBoot/Makefile index 8376805..006fb6e 100644 --- a/payloads/external/LinuxBoot/Makefile +++ b/payloads/external/LinuxBoot/Makefile @@ -33,7 +33,7 @@ OBJCOPY:=$(LINUXBOOT_COMPILE)objcopy -all: payload +all: linuxboot toolchain: if [[ ! -x "$(LINUXBOOT_COMPILE)gcc" ]]; then \ @@ -95,7 +95,7 @@ echo "Building without u-root support" endif -payload: $(project_dir)/kernel-image $(PWD)/$(CONFIG_PAYLOAD_USERSPACE) +linuxboot: $(project_dir)/kernel-image $(PWD)/$(CONFIG_PAYLOAD_USERSPACE) clean: if [ -d "$(kernel_dir)" ]; then rm -rf $(kernel_dir); fi -- To view, visit https://review.coreboot.org/29448 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I648fb2e0383d20b0e4d50e416af637ea07d1efb4 Gerrit-Change-Number: 29448 Gerrit-PatchSet: 7 Gerrit-Owner: Marcello Sylvester Bauer <info(a)marcellobauer.com> Gerrit-Reviewer: Marcello Sylvester Bauer <info(a)marcellobauer.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: Linuxboot: check go version
by Philipp Deppenwiese (Code Review) 05 Nov '18

05 Nov '18

Philipp Deppenwiese has submitted this change and it was merged. ( https://review.coreboot.org/29445 ) Change subject: Linuxboot: check go version ...................................................................... Linuxboot: check go version Check if the installed Golang version is >= 1.9. Change-Id: I9fd74fa8dc5e906e8b54ff5afaf69609fe957960 Signed-off-by: Marcello Sylvester Bauer <info(a)marcellobauer.com> Reviewed-on: https://review.coreboot.org/29445 Reviewed-by: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M payloads/external/LinuxBoot/targets/u-root.mk 1 file changed, 12 insertions(+), 2 deletions(-) Approvals: build bot (Jenkins): Verified Philipp Deppenwiese: Looks good to me, approved diff --git a/payloads/external/LinuxBoot/targets/u-root.mk b/payloads/external/LinuxBoot/targets/u-root.mk index 001f7c4..27f184e 100644 --- a/payloads/external/LinuxBoot/targets/u-root.mk +++ b/payloads/external/LinuxBoot/targets/u-root.mk @@ -14,7 +14,10 @@ uroot_git_repo=https://github.com/u-root/u-root.git uroot_dir=$(project_dir)/go/src/github.com/u-root/u-root -go_check=$(shell command -v go 1>/dev/null 2>&1 && echo go) +go_version=$(shell go version | sed -nr 's/.*go([0-9]+\.[0-9]+.?[0-9]?).*/\1/p' ) +go_version_major=$(shell echo $(go_version) | sed -nr 's/^([0-9]+)\.([0-9]+)\.?([0-9]*)$$/\1/p') +go_version_minor=$(shell echo $(go_version) | sed -nr 's/^([0-9]+)\.([0-9]+)\.?([0-9]*)$$/\2/p') + project_dir=$(shell pwd)/linuxboot project_name=u-root go_path_dir=$(shell pwd)/linuxboot/go @@ -22,10 +25,17 @@ all: build check: -ifneq ($(go_check),go) +ifeq ("$(go_version)","") printf "\n<<Please install Golang >= 1.9 for u-root mode>>\n\n" exit 1 endif +ifeq ($(shell if [ $(go_version_major) -eq 1 ]; then echo y; fi),y) +ifeq ($(shell if [ $(go_version_minor) -lt 9 ]; then echo y; fi),y) + printf "\n Golang version $(go_version) currently installed.\n\ + <<Please install Golang >= 1.9 for u-root mode>>\n\n" + exit 1 +endif +endif mkdir -p $(project_dir)/go/src/github.com/u-root $(uroot_dir)/.git: -- To view, visit https://review.coreboot.org/29445 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I9fd74fa8dc5e906e8b54ff5afaf69609fe957960 Gerrit-Change-Number: 29445 Gerrit-PatchSet: 4 Gerrit-Owner: Marcello Sylvester Bauer <info(a)marcellobauer.com> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: mb/google/poppy/variant/nocturne: use PLTRST for FPMCU_INT_L
by Furquan Shaikh (Code Review) 05 Nov '18

05 Nov '18

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/29429 ) Change subject: mb/google/poppy/variant/nocturne: use PLTRST for FPMCU_INT_L ...................................................................... Patch Set 3: (2 comments) https://review.coreboot.org/#/c/29429/2/src/mainboard/google/poppy/variants… File src/mainboard/google/poppy/variants/nocturne/gpio.c: https://review.coreboot.org/#/c/29429/2/src/mainboard/google/poppy/variants… PS2, Line 134: PLTRST If you change this to PLTRST, doesn't it reset the GPIO state on entry into S3? which would prevent the device from waking the system? https://review.coreboot.org/#/c/29429/2/src/mainboard/google/poppy/variants… PS2, Line 138: PLTRST So does it mean that there was some pending interrupt that wasn't getting handled by the kernel driver? And hence resetting the GPIO state prevents that interrupt from happening and hence the storm? -- To view, visit https://review.coreboot.org/29429 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I008532fce963c51a435378001440ac72b5ebfffc Gerrit-Change-Number: 29429 Gerrit-PatchSet: 3 Gerrit-Owner: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Caveh Jalali <caveh(a)google.com> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 05 Nov 2018 20:53:42 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: mb/google/poppy/variant/nocturne: use PLTRST for FPMCU_INT_L
by Nick Vaccaro (Code Review) 05 Nov '18

05 Nov '18

Hello Caveh Jalali, Duncan Laurie, build bot (Jenkins), Furquan Shaikh, I'd like you to reexamine a change. Please visit https://review.coreboot.org/29429 to look at the new patch set (#3). Change subject: mb/google/poppy/variant/nocturne: use PLTRST for FPMCU_INT_L ...................................................................... mb/google/poppy/variant/nocturne: use PLTRST for FPMCU_INT_L GPP_C9 and GPP_C11 were set to DEEP, causing problems with S3. Changed GPP_C9 and GPP_C11 configuration to use PLTRST instead. BUG=b:114196791 TEST=Build, flash, boot nocturne, log in to kernel and execute the following two commands and verify it passes : echo 0 > /var/lib/power_manager/suspend_to_idle && restart powerd sudo suspend_stress_test -c 2 Change-Id: I008532fce963c51a435378001440ac72b5ebfffc Signed-off-by: Nick Vaccaro <nvaccaro(a)google.com> --- M src/mainboard/google/poppy/variants/nocturne/gpio.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/29/29429/3 -- To view, visit https://review.coreboot.org/29429 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I008532fce963c51a435378001440ac72b5ebfffc Gerrit-Change-Number: 29429 Gerrit-PatchSet: 3 Gerrit-Owner: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Caveh Jalali <caveh(a)google.com> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: mb/google/poppy/variant/nocturne: use PLTRST for GPP_C11
by Nick Vaccaro (Code Review) 05 Nov '18

05 Nov '18

Hello Caveh Jalali, Duncan Laurie, build bot (Jenkins), Furquan Shaikh, I'd like you to reexamine a change. Please visit https://review.coreboot.org/29429 to look at the new patch set (#2). Change subject: mb/google/poppy/variant/nocturne: use PLTRST for GPP_C11 ...................................................................... mb/google/poppy/variant/nocturne: use PLTRST for GPP_C11 GPP_C11 was set to DEEP, causing problems with S3. Changed GPP_C11 configuration to use PLTRST instead. BUG=b:114196791 TEST=Build, flash, boot nocturne, log in to kernel and execute the following two commands and verify it passes : echo 0 > /var/lib/power_manager/suspend_to_idle && restart powerd sudo suspend_stress_test -c 2 Change-Id: I008532fce963c51a435378001440ac72b5ebfffc Signed-off-by: Nick Vaccaro <nvaccaro(a)google.com> --- M src/mainboard/google/poppy/variants/nocturne/gpio.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/29/29429/2 -- To view, visit https://review.coreboot.org/29429 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I008532fce963c51a435378001440ac72b5ebfffc Gerrit-Change-Number: 29429 Gerrit-PatchSet: 2 Gerrit-Owner: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Caveh Jalali <caveh(a)google.com> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: vendorcode/intel/fsp/fsp2.0/glk: Add PmicPmcIpcCtrl
by Lijian Zhao (Code Review) 05 Nov '18

05 Nov '18

Lijian Zhao has posted comments on this change. ( https://review.coreboot.org/29482 ) Change subject: vendorcode/intel/fsp/fsp2.0/glk: Add PmicPmcIpcCtrl ...................................................................... Patch Set 1: > I thought GLK will have fsp header upgrade from github directly > .... Not yet, just checked -- To view, visit https://review.coreboot.org/29482 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8dc38d2a2a33829efb0083de91a367e048188ee9 Gerrit-Change-Number: 29482 Gerrit-PatchSet: 1 Gerrit-Owner: John Zhao <john.zhao(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Comment-Date: Mon, 05 Nov 2018 20:29:57 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: vendorcode/intel/fsp/fsp2.0/glk: Add PmicPmcIpcCtrl
by Lijian Zhao (Code Review) 05 Nov '18

05 Nov '18

Lijian Zhao has posted comments on this change. ( https://review.coreboot.org/29482 ) Change subject: vendorcode/intel/fsp/fsp2.0/glk: Add PmicPmcIpcCtrl ...................................................................... Patch Set 1: I thought GLK will have fsp header upgrade from github directly .... -- To view, visit https://review.coreboot.org/29482 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8dc38d2a2a33829efb0083de91a367e048188ee9 Gerrit-Change-Number: 29482 Gerrit-PatchSet: 1 Gerrit-Owner: John Zhao <john.zhao(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Comment-Date: Mon, 05 Nov 2018 20:12:41 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: vendorcode/intel/fsp/fsp2.0/glk: Add PmicPmcIpcCtrl
by John Zhao (Code Review) 05 Nov '18

05 Nov '18

John Zhao has uploaded this change for review. ( https://review.coreboot.org/29482 Change subject: vendorcode/intel/fsp/fsp2.0/glk: Add PmicPmcIpcCtrl ...................................................................... vendorcode/intel/fsp/fsp2.0/glk: Add PmicPmcIpcCtrl FSP 2.0.7.1 provides UPD interface to execute IPC command. Configure PmicPmcIpcCtrl for PMC to program PMIC PCH_PWROK to improve cold boot and S3 resume performance. BUG=b:118676361 TEST=None Change-Id: I8dc38d2a2a33829efb0083de91a367e048188ee9 Signed-off-by: John Zhao <john.zhao(a)intel.com> --- M src/vendorcode/intel/fsp/fsp2_0/glk/FspsUpd.h 1 file changed, 8 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/82/29482/1 diff --git a/src/vendorcode/intel/fsp/fsp2_0/glk/FspsUpd.h b/src/vendorcode/intel/fsp/fsp2_0/glk/FspsUpd.h index cc194b2..18a43e2 100644 --- a/src/vendorcode/intel/fsp/fsp2_0/glk/FspsUpd.h +++ b/src/vendorcode/intel/fsp/fsp2_0/glk/FspsUpd.h @@ -1715,9 +1715,15 @@ **/ UINT8 SkipSpiPCP; -/** Offset 0x03AB +/** Offset 0x03AB - PMIC PCH_PWROK delay configuration - IPC Configuration + Upd for changing PCH_PWROK delay configuration : I2C_Slave_Address (31:24) + Register_Offset + (23:16) + OR Value (15:8) + AND Value (7:0) **/ - UINT8 ReservedFspsUpd[5]; + UINT32 PmicPmcIpcCtrl; + +/** Offset 0x03AF +**/ + UINT8 ReservedFspsUpd[1]; } FSP_S_CONFIG; /** Fsp S SGX Configuration -- To view, visit https://review.coreboot.org/29482 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I8dc38d2a2a33829efb0083de91a367e048188ee9 Gerrit-Change-Number: 29482 Gerrit-PatchSet: 1 Gerrit-Owner: John Zhao <john.zhao(a)intel.com>

1 0

Change in coreboot[master]: [RFC] lib/spd_bin: Redesign API
by build bot (Jenkins) (Code Review) 05 Nov '18

05 Nov '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/29481 ) Change subject: [RFC] lib/spd_bin: Redesign API ...................................................................... Patch Set 2: (3 comments) https://review.coreboot.org/#/c/29481/2/src/include/spd_bin.h File src/include/spd_bin.h: https://review.coreboot.org/#/c/29481/2/src/include/spd_bin.h@92 PS2, Line 92: ssize_t gather_spds(struct spd_binfo *); function definition argument 'struct spd_binfo *' should also have an identifier name https://review.coreboot.org/#/c/29481/2/src/include/spd_bin.h@94 PS2, Line 94: void dump_spd_info(const struct spd_binfo *); function definition argument 'const struct spd_binfo *' should also have an identifier name https://review.coreboot.org/#/c/29481/2/src/lib/spd_bin.c File src/lib/spd_bin.c: https://review.coreboot.org/#/c/29481/2/src/lib/spd_bin.c@227 PS2, Line 227: if (common_len == -1) { braces {} are not necessary for any arm of this statement -- To view, visit https://review.coreboot.org/29481 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iac300a374e5cd56a9d202cf24ad8fe8367b780d8 Gerrit-Change-Number: 29481 Gerrit-PatchSet: 2 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 05 Nov 2018 17:39:20 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2018