coreboot-gerrit November 2018

coreboot-gerrit@coreboot.org

1 participants
1699 discussions

Change in coreboot[master]: coreboot-sdk: Build Clang first in a separate step
by Martin Roth (Code Review) 05 Nov '18

05 Nov '18

Martin Roth has posted comments on this change. ( https://review.coreboot.org/29455 ) Change subject: coreboot-sdk: Build Clang first in a separate step ...................................................................... Patch Set 1: Code-Review+2 Good call, that makes a lot of sense. -- To view, visit https://review.coreboot.org/29455 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If67b458cde656f1dc6774215f6a575a48d12b797 Gerrit-Change-Number: 29455 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 05 Nov 2018 04:14:38 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: coreboot-sdk: Prefer gnat package over gnat-6
by Martin Roth (Code Review) 05 Nov '18

05 Nov '18

Martin Roth has posted comments on this change. ( https://review.coreboot.org/29454 ) Change subject: coreboot-sdk: Prefer gnat package over gnat-6 ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/29454 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ica8a1f9d6d71a74ffc4ec76aa0cfbe4b604cde1b Gerrit-Change-Number: 29454 Gerrit-PatchSet: 2 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 05 Nov 2018 04:13:41 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: coreboot-sdk: Don't install libisl-dev
by Martin Roth (Code Review) 05 Nov '18

05 Nov '18

Martin Roth has posted comments on this change. ( https://review.coreboot.org/29453 ) Change subject: coreboot-sdk: Don't install libisl-dev ...................................................................... Patch Set 1: Code-Review+2 I'm good with it. Definitely makes things easier. Sorry, I haven't had much time to work on things outside of work lately. -- To view, visit https://review.coreboot.org/29453 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9f9115d8ab33cbe11aa77f16c98465e1c1dedeac Gerrit-Change-Number: 29453 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 05 Nov 2018 04:13:16 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: coreboot-sdk: Don't install libelf-dev
by Martin Roth (Code Review) 05 Nov '18

05 Nov '18

Martin Roth has posted comments on this change. ( https://review.coreboot.org/29452 ) Change subject: coreboot-sdk: Don't install libelf-dev ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/29452 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3124cb6db5975c21e635636babe700adb0f8cd8b Gerrit-Change-Number: 29452 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 05 Nov 2018 04:11:49 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: util/abuild: Use absolute paths for (failed|passed)_boards
by Martin Roth (Code Review) 05 Nov '18

05 Nov '18

Martin Roth has posted comments on this change. ( https://review.coreboot.org/29451 ) Change subject: util/abuild: Use absolute paths for (failed|passed)_boards ...................................................................... Patch Set 1: Yeah, I've futzed with this several times and haven't found a good solution that has worked everywhere. It's been frustrating to me. -- To view, visit https://review.coreboot.org/29451 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ief00e28e09a4714b0106c35ad4f4e9c696f6aad4 Gerrit-Change-Number: 29451 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 05 Nov 2018 04:11:43 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: WIP, DONOTMERGE: Add inteltool support to dump GPIOs
by Angel Pons (Code Review) 04 Nov '18

04 Nov '18

Angel Pons has uploaded this change for review. ( https://review.coreboot.org/29459 Change subject: WIP, DONOTMERGE: Add inteltool support to dump GPIOs ...................................................................... WIP, DONOTMERGE: Add inteltool support to dump GPIOs Change-Id: I2b0d49a175e656ef88d66c559239cac17e51b880 Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> --- M util/inteltool/gpio.c M util/inteltool/inteltool.c M util/inteltool/inteltool.h 3 files changed, 34 insertions(+), 12 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/59/29459/1 diff --git a/util/inteltool/gpio.c b/util/inteltool/gpio.c index b4225a7..d50d8ca 100644 --- a/util/inteltool/gpio.c +++ b/util/inteltool/gpio.c @@ -836,7 +836,7 @@ } } -int print_gpios(struct pci_dev *sb, int show_all, int show_diffs) +int print_gpios(struct pci_dev *sb, int show_all, int show_diffs, int gen_gpio) { int i, j, size, defaults_size = 0; const io_register_t *gpio_registers; @@ -1039,15 +1039,35 @@ return 1; } - if (show_diffs && !show_all) + printf("\nALL: %d, DIFF: %d, GEN: %d\n", show_all, show_diffs, gen_gpio); + + if (gen_gpio) { + printf("/*\n" + " * This file is part of the coreboot project.\n" + " *\n" + " * This program is free software; you can redistribute it and/or modify\n" + " * it under the terms of the GNU General Public License as published by\n" + " * the Free Software Foundation; version 2 of the License.\n" + " *\n" + " * This program is distributed in the hope that it will be useful,\n" + " * but WITHOUT ANY WARRANTY; without even the implied warranty of\n" + " * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the\n" + " * GNU General Public License for more details.\n" + " */\n" + "\n" + "#include <southbridge/intel/common/gpio.h>\n" + "\n" + ); + } else if (show_diffs && !show_all) printf("\n========== GPIO DIFFS ===========\n\n"); - else - printf("\n============= GPIOS =============\n\n"); + else printf("\n============= GPIOS =============\n\n"); printf("GPIOBASE = 0x%04x (IO)\n\n", gpiobase); j = 0; for (i = 0; i < size; i++) { + if (gen_gpio) + printf ("%08x\n", inw(gpiobase+(&gpio_registers[i])->addr)); if (show_all) print_reg(&gpio_registers[i]); diff --git a/util/inteltool/inteltool.c b/util/inteltool/inteltool.c index d0b4279..814b88c 100644 --- a/util/inteltool/inteltool.c +++ b/util/inteltool/inteltool.c @@ -380,6 +380,7 @@ " -R | --ahci: dump AHCI registers\n" " -g | --gpio: dump southbridge GPIO registers\n" " -G | --gpio-diffs: show GPIO differences from defaults\n" + " -C | --gen-gpio: generate a gpio.c file for coreboot\n" " -r | --rcba: dump southbridge RCBA registers\n" " -p | --pmbase: dump southbridge Power Management registers\n\n" " -m | --mchbar: dump northbridge Memory Controller registers\n" @@ -411,7 +412,7 @@ int dump_pmbase = 0, dump_epbar = 0, dump_dmibar = 0; int dump_pciexbar = 0, dump_coremsrs = 0, dump_ambs = 0; int dump_spi = 0, dump_gfx = 0, dump_ahci = 0, dump_sgx = 0; - int show_gpio_diffs = 0; + int show_gpio_diffs = 0, gen_gpio = 0; size_t pcr_count = 0; uint8_t dump_pcr[MAX_PCR_PORTS]; @@ -420,6 +421,7 @@ {"help", 0, 0, 'h'}, {"gpios", 0, 0, 'g'}, {"gpio-diffs", 0, 0, 'G'}, + {"gen-gpio", 0, 0, 'C'}, {"mchbar", 0, 0, 'm'}, {"rcba", 0, 0, 'r'}, {"pmbase", 0, 0, 'p'}, @@ -438,7 +440,7 @@ {0, 0, 0, 0} }; - while ((opt = getopt_long(argc, argv, "vh?gGrpmedPMaAsfRS:x", + while ((opt = getopt_long(argc, argv, "vh?gGCrpmedPMaAsfRS:x", long_options, &option_index)) != EOF) { switch (opt) { case 'v': @@ -461,6 +463,9 @@ case 'G': show_gpio_diffs = 1; break; + case 'C': + gen_gpio = 1; + break; case 'm': dump_mchbar = 1; break; @@ -669,11 +674,8 @@ /* Now do the deed */ - if (dump_gpios) { - print_gpios(sb, 1, show_gpio_diffs); - printf("\n\n"); - } else if (show_gpio_diffs) { - print_gpios(sb, 0, show_gpio_diffs); + if (dump_gpios || show_gpio_diffs || gen_gpio) { + print_gpios(sb, dump_gpios, show_gpio_diffs, gen_gpio); printf("\n\n"); } diff --git a/util/inteltool/inteltool.h b/util/inteltool/inteltool.h index 5de73aa..fa13fec 100644 --- a/util/inteltool/inteltool.h +++ b/util/inteltool/inteltool.h @@ -318,7 +318,7 @@ int print_mchbar(struct pci_dev *nb, struct pci_access *pacc, const char *dump_spd_file); int print_pmbase(struct pci_dev *sb, struct pci_access *pacc); int print_rcba(struct pci_dev *sb); -int print_gpios(struct pci_dev *sb, int show_all, int show_diffs); +int print_gpios(struct pci_dev *sb, int show_all, int show_diffs, int gen_gpio); void print_gpio_groups(struct pci_dev *sb); int print_epbar(struct pci_dev *nb); int print_dmibar(struct pci_dev *nb); -- To view, visit https://review.coreboot.org/29459 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I2b0d49a175e656ef88d66c559239cac17e51b880 Gerrit-Change-Number: 29459 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com>

1 0

Change in coreboot[master]: Linuxboot: gitignore build directory
by Philipp Deppenwiese (Code Review) 04 Nov '18

04 Nov '18

Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/29444 ) Change subject: Linuxboot: gitignore build directory ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/29444 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic11311e2de544a334043a55eda42643d9df3374d Gerrit-Change-Number: 29444 Gerrit-PatchSet: 3 Gerrit-Owner: Marcello Sylvester Bauer <info(a)marcellobauer.com> Gerrit-Reviewer: Marcello Sylvester Bauer <info(a)marcellobauer.com> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Comment-Date: Sun, 04 Nov 2018 22:39:04 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: Linuxboot: add current kernel releases
by Philipp Deppenwiese (Code Review) 04 Nov '18

04 Nov '18

Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/29443 ) Change subject: Linuxboot: add current kernel releases ...................................................................... Patch Set 6: Code-Review+2 -- To view, visit https://review.coreboot.org/29443 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ieb071696cfbb466521faaef045fc488a06f6db0c Gerrit-Change-Number: 29443 Gerrit-PatchSet: 6 Gerrit-Owner: Marcello Sylvester Bauer <info(a)marcellobauer.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 04 Nov 2018 22:37:42 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: Linuxboot: remove initramfs path entry
by Philipp Deppenwiese (Code Review) 04 Nov '18

04 Nov '18

Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/29448 ) Change subject: Linuxboot: remove initramfs path entry ...................................................................... Patch Set 6: Code-Review+2 -- To view, visit https://review.coreboot.org/29448 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I648fb2e0383d20b0e4d50e416af637ea07d1efb4 Gerrit-Change-Number: 29448 Gerrit-PatchSet: 6 Gerrit-Owner: Marcello Sylvester Bauer <info(a)marcellobauer.com> Gerrit-Reviewer: Marcello Sylvester Bauer <info(a)marcellobauer.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 04 Nov 2018 22:34:29 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: Linuxboot: check go version
by Philipp Deppenwiese (Code Review) 04 Nov '18

04 Nov '18

Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/29445 ) Change subject: Linuxboot: check go version ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/29445 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9fd74fa8dc5e906e8b54ff5afaf69609fe957960 Gerrit-Change-Number: 29445 Gerrit-PatchSet: 3 Gerrit-Owner: Marcello Sylvester Bauer <info(a)marcellobauer.com> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 04 Nov 2018 22:33:48 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2018