coreboot-gerrit November 2018

coreboot-gerrit@coreboot.org

1 participants
1699 discussions

Change in coreboot[master]: a useless commit to test the MAINTAINERS->reviewers integration
by Patrick Georgi (Code Review) 09 Nov '18

09 Nov '18

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/29562 to look at the new patch set (#7). Change subject: a useless commit to test the MAINTAINERS->reviewers integration ...................................................................... a useless commit to test the MAINTAINERS->reviewers integration Change-Id: I9c51084dab7811e9c9aa34ac2e1692eec2bf1aa8 Signed-off-by: Patrick Georgi <patrick(a)georgi.software> --- M util/ifdtool/Makefile 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/62/29562/7 -- To view, visit https://review.coreboot.org/29562 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I9c51084dab7811e9c9aa34ac2e1692eec2bf1aa8 Gerrit-Change-Number: 29562 Gerrit-PatchSet: 7 Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: a useless commit to test the MAINTAINERS->reviewers integration
by Patrick Georgi (Code Review) 09 Nov '18

09 Nov '18

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/29562 to look at the new patch set (#6). Change subject: a useless commit to test the MAINTAINERS->reviewers integration ...................................................................... a useless commit to test the MAINTAINERS->reviewers integration Change-Id: I9c51084dab7811e9c9aa34ac2e1692eec2bf1aa8 Signed-off-by: Patrick Georgi <patrick(a)georgi.software> --- M util/ifdtool/Makefile 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/62/29562/6 -- To view, visit https://review.coreboot.org/29562 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I9c51084dab7811e9c9aa34ac2e1692eec2bf1aa8 Gerrit-Change-Number: 29562 Gerrit-PatchSet: 6 Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: a useless commit to test the MAINTAINERS->reviewers integration
by Patrick Georgi (Code Review) 09 Nov '18

09 Nov '18

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/29562 to look at the new patch set (#5). Change subject: a useless commit to test the MAINTAINERS->reviewers integration ...................................................................... a useless commit to test the MAINTAINERS->reviewers integration Change-Id: I9c51084dab7811e9c9aa34ac2e1692eec2bf1aa8 Signed-off-by: Patrick Georgi <patrick(a)georgi.software> --- M util/ifdtool/Makefile 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/62/29562/5 -- To view, visit https://review.coreboot.org/29562 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I9c51084dab7811e9c9aa34ac2e1692eec2bf1aa8 Gerrit-Change-Number: 29562 Gerrit-PatchSet: 5 Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: a useless commit to test the MAINTAINERS->reviewers integration
by Patrick Georgi (Code Review) 09 Nov '18

09 Nov '18

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/29562 to look at the new patch set (#4). Change subject: a useless commit to test the MAINTAINERS->reviewers integration ...................................................................... a useless commit to test the MAINTAINERS->reviewers integration Change-Id: I9c51084dab7811e9c9aa34ac2e1692eec2bf1aa8 Signed-off-by: Patrick Georgi <patrick(a)georgi.software> --- M util/ifdtool/Makefile 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/62/29562/4 -- To view, visit https://review.coreboot.org/29562 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I9c51084dab7811e9c9aa34ac2e1692eec2bf1aa8 Gerrit-Change-Number: 29562 Gerrit-PatchSet: 4 Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: a useless commit to test the MAINTAINERS->reviewers integration
by Patrick Georgi (Code Review) 09 Nov '18

09 Nov '18

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/29562 to look at the new patch set (#3). Change subject: a useless commit to test the MAINTAINERS->reviewers integration ...................................................................... a useless commit to test the MAINTAINERS->reviewers integration Change-Id: I9c51084dab7811e9c9aa34ac2e1692eec2bf1aa8 Signed-off-by: Patrick Georgi <patrick(a)georgi.software> --- M util/ifdtool/Makefile 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/62/29562/3 -- To view, visit https://review.coreboot.org/29562 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I9c51084dab7811e9c9aa34ac2e1692eec2bf1aa8 Gerrit-Change-Number: 29562 Gerrit-PatchSet: 3 Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: a useless commit to test the MAINTAINERS->reviewers integration
by Patrick Georgi (Code Review) 09 Nov '18

09 Nov '18

Patrick Georgi has uploaded a new patch set (#2). ( https://review.coreboot.org/29562 ) Change subject: a useless commit to test the MAINTAINERS->reviewers integration ...................................................................... a useless commit to test the MAINTAINERS->reviewers integration Change-Id: I9c51084dab7811e9c9aa34ac2e1692eec2bf1aa8 Signed-off-by: Patrick Georgi <patrick(a)georgi.software> --- M util/ifdtool/Makefile 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/62/29562/2 -- To view, visit https://review.coreboot.org/29562 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I9c51084dab7811e9c9aa34ac2e1692eec2bf1aa8 Gerrit-Change-Number: 29562 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com>

1 0

Change in coreboot[master]: a useless commit to test the MAINTAINERS->reviewers integration
by Patrick Georgi (Code Review) 09 Nov '18

09 Nov '18

Patrick Georgi has uploaded this change for review. ( https://review.coreboot.org/29562 Change subject: a useless commit to test the MAINTAINERS->reviewers integration ...................................................................... a useless commit to test the MAINTAINERS->reviewers integration Change-Id: I9c51084dab7811e9c9aa34ac2e1692eec2bf1aa8 Signed-off-by: Patrick Georgi <patrick(a)georgi.software> --- M util/ifdtool/Makefile 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/62/29562/1 diff --git a/util/ifdtool/Makefile b/util/ifdtool/Makefile index cf6d378..a21bd76 100644 --- a/util/ifdtool/Makefile +++ b/util/ifdtool/Makefile @@ -1,5 +1,6 @@ # # ifdtool - dump Intel Firmware Descriptor information + # # Copyright (C) 2011 The ChromiumOS Authors. All rights reserved. # -- To view, visit https://review.coreboot.org/29562 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I9c51084dab7811e9c9aa34ac2e1692eec2bf1aa8 Gerrit-Change-Number: 29562 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com>

1 0

Change in coreboot[master]: siemens/mc_apl4: Enable SDCARD
by Werner Zeh (Code Review) 09 Nov '18

09 Nov '18

Werner Zeh has posted comments on this change. ( https://review.coreboot.org/29561 ) Change subject: siemens/mc_apl4: Enable SDCARD ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/29561 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id56bc1be60ec8c2be0e5543d1d8851610b7248e0 Gerrit-Change-Number: 29561 Gerrit-PatchSet: 1 Gerrit-Owner: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 09 Nov 2018 12:16:18 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: siemens/mc_apl4: Remove external RTC from I2C0
by Werner Zeh (Code Review) 09 Nov '18

09 Nov '18

Werner Zeh has posted comments on this change. ( https://review.coreboot.org/29560 ) Change subject: siemens/mc_apl4: Remove external RTC from I2C0 ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/29560 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9ec9631ed15ab30cc6a4594531521f4a1419ad00 Gerrit-Change-Number: 29560 Gerrit-PatchSet: 2 Gerrit-Owner: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 09 Nov 2018 12:16:00 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: drivers/*/tpm: Add postcar target
by Philipp Deppenwiese (Code Review) 09 Nov '18

09 Nov '18

Philipp Deppenwiese has submitted this change and it was merged. ( https://review.coreboot.org/29546 ) Change subject: drivers/*/tpm: Add postcar target ...................................................................... drivers/*/tpm: Add postcar target Now postcar is a standalone stage, add it as target to all TPM bus drivers. This is a required for a measured boot. Change-Id: I758185daf3941a29883c2256b900360e112275e1 Signed-off-by: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Reviewed-on: https://review.coreboot.org/29546 Reviewed-by: Werner Zeh <werner.zeh(a)siemens.com> Reviewed-by: Patrick Georgi <pgeorgi(a)google.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M src/drivers/i2c/tpm/Makefile.inc M src/drivers/pc80/tpm/Makefile.inc M src/drivers/spi/tpm/Makefile.inc 3 files changed, 6 insertions(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved Werner Zeh: Looks good to me, approved diff --git a/src/drivers/i2c/tpm/Makefile.inc b/src/drivers/i2c/tpm/Makefile.inc index e24a66d..51856fa 100644 --- a/src/drivers/i2c/tpm/Makefile.inc +++ b/src/drivers/i2c/tpm/Makefile.inc @@ -2,20 +2,24 @@ romstage-$(CONFIG_DRIVER_TIS_DEFAULT) += tis.c verstage-$(CONFIG_DRIVER_TIS_DEFAULT) += tis.c bootblock-$(CONFIG_DRIVER_TIS_DEFAULT) += tis.c +postcar-$(CONFIG_DRIVER_TIS_DEFAULT) += tis.c ramstage-$(CONFIG_MAINBOARD_HAS_I2C_TPM_ATMEL) += tis_atmel.c romstage-$(CONFIG_MAINBOARD_HAS_I2C_TPM_ATMEL) += tis_atmel.c verstage-$(CONFIG_MAINBOARD_HAS_I2C_TPM_ATMEL) += tis_atmel.c bootblock-$(CONFIG_MAINBOARD_HAS_I2C_TPM_ATMEL) += tis_atmel.c +postcar-$(CONFIG_MAINBOARD_HAS_I2C_TPM_ATMEL) += tis_atmel.c ramstage-$(CONFIG_MAINBOARD_HAS_I2C_TPM_GENERIC) += tpm.c romstage-$(CONFIG_MAINBOARD_HAS_I2C_TPM_GENERIC) += tpm.c verstage-$(CONFIG_MAINBOARD_HAS_I2C_TPM_GENERIC) += tpm.c bootblock-$(CONFIG_MAINBOARD_HAS_I2C_TPM_GENERIC) += tpm.c +postcar-$(CONFIG_MAINBOARD_HAS_I2C_TPM_GENERIC) += tpm.c ramstage-$(CONFIG_MAINBOARD_HAS_I2C_TPM_CR50) += cr50.c romstage-$(CONFIG_MAINBOARD_HAS_I2C_TPM_CR50) += cr50.c verstage-$(CONFIG_MAINBOARD_HAS_I2C_TPM_CR50) += cr50.c bootblock-$(CONFIG_MAINBOARD_HAS_I2C_TPM_CR50) += cr50.c +postcar-$(CONFIG_MAINBOARD_HAS_I2C_TPM_CR50) += cr50.c ramstage-$(CONFIG_DRIVER_I2C_TPM_ACPI) += chip.c diff --git a/src/drivers/pc80/tpm/Makefile.inc b/src/drivers/pc80/tpm/Makefile.inc index 8747374..0de1b76 100644 --- a/src/drivers/pc80/tpm/Makefile.inc +++ b/src/drivers/pc80/tpm/Makefile.inc @@ -1,3 +1,4 @@ verstage-$(CONFIG_LPC_TPM) += tis.c romstage-$(CONFIG_LPC_TPM) += tis.c ramstage-$(CONFIG_LPC_TPM) += tis.c +postcar-$(CONFIG_LPC_TPM) += tis.c diff --git a/src/drivers/spi/tpm/Makefile.inc b/src/drivers/spi/tpm/Makefile.inc index fd214c6..01d3b66 100644 --- a/src/drivers/spi/tpm/Makefile.inc +++ b/src/drivers/spi/tpm/Makefile.inc @@ -2,3 +2,4 @@ verstage-$(CONFIG_SPI_TPM) += tis.c tpm.c romstage-$(CONFIG_SPI_TPM) += tis.c tpm.c ramstage-$(CONFIG_SPI_TPM) += tis.c tpm.c +postcar-$(CONFIG_SPI_TPM) += tis.c tpm.c -- To view, visit https://review.coreboot.org/29546 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I758185daf3941a29883c2256b900360e112275e1 Gerrit-Change-Number: 29546 Gerrit-PatchSet: 3 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2018