coreboot-gerrit November 2018

coreboot-gerrit@coreboot.org

1 participants
1699 discussions

Change in coreboot[master]: mb/google/poppy/variant/atlas: I2C: run trackpad at 1MHz
by Caveh Jalali (Code Review) 09 Nov '18

09 Nov '18

Hello Gaggery Tsai, caveh jalali, Duncan Laurie, Gaggery Tsai, build bot (Jenkins), Furquan Shaikh, I'd like you to reexamine a change. Please visit https://review.coreboot.org/29553 to look at the new patch set (#2). Change subject: mb/google/poppy/variant/atlas: I2C: run trackpad at 1MHz ...................................................................... mb/google/poppy/variant/atlas: I2C: run trackpad at 1MHz With this change, coreboot thinks we're running at 1MHz: DW I2C bus 2 at 0xd1133000 (1000 KHz) Elan eKT3644 IC Specification (trackpad) requires: Low Time larger than 500ns (61 * 8.3ns = 506ns). High Time larger than 260ns (32 * 8.3ns = 265ns), Data Hold_time larger than 0ns (32 * 8.3ns = 265ns). Start Condition Hold time larger than 250ns. Rise/Fall time of less than 120ns. HCNT controls both High Time and Start Condition Hold time. LCNT controls Low Time. SDA_HOLD controls Data Hold Time. P2 Atlas "Rise time" is 90ns and "Fall time" is 32ns and tuned using resistors on the board and must be considered when adjusting any of the parameters since these times are all measured at 30 or 70% of base and peak voltages (0v/1.8v). The eKT3644 requirements are met with LCNT=69, HCNT=33, SDA_HOLD=20 which yields the SCL at around 950KHz - suboptimal but compliant. Lower LCNT or HCNT results in "lost arbitration" errors or not complying with eKT3644 requirements. Verified by gaggery.tsai(a)intel.corp-partner.google.com. Scope shots posted here: https://b.corp.google.com/issues/78601949#comment177 BUG=b:78601949 BRANCH=none TEST=Farzam provided test points on track pad for SCL/SDA/GND. Waveforms measured with oscilloscope and screen shots attached to bug (comment #177, #155, #100). Operate trackpad/touchscreen Review dmesg (kernel) output for correct speed, parameters, and no errors (e.g. "lost arbitration" or "host controller timeout") Change-Id: Iaf42ba7b8818b7cd9c8dcc657823dac705659d38 Signed-off-by: Caveh Jalali <caveh(a)chromium.org> Signed-off-by: Grant Grundler <grundler(a)chromium.org> Tested-by: gaggery.tsai(a)intel.corp-partner.google.com Tested-by: grundler(a)chromium.org --- M src/mainboard/google/poppy/variants/atlas/devicetree.cb 1 file changed, 8 insertions(+), 6 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/53/29553/2 -- To view, visit https://review.coreboot.org/29553 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Iaf42ba7b8818b7cd9c8dcc657823dac705659d38 Gerrit-Change-Number: 29553 Gerrit-PatchSet: 2 Gerrit-Owner: Caveh Jalali <caveh(a)google.com> Gerrit-Reviewer: Caveh Jalali <caveh(a)google.com> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Gaggery Tsai <gaggery.tsai(a)intel.com> Gerrit-Reviewer: Gaggery Tsai <gaggery.tsai(a)intel.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: caveh jalali <caveh(a)chromium.org>

1 0

Change in coreboot[master]: azalia: Add Azalia Reset macro
by build bot (Jenkins) (Code Review) 09 Nov '18

09 Nov '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/29554 ) Change subject: azalia: Add Azalia Reset macro ...................................................................... Patch Set 6: (1 comment) https://review.coreboot.org/#/c/29554/6/src/include/device/azalia_device.h File src/include/device/azalia_device.h: https://review.coreboot.org/#/c/29554/6/src/include/device/azalia_device.h@… PS6, Line 50: #define AZALIA_RESET(pin) \ Macros with complex values should be enclosed in parentheses -- To view, visit https://review.coreboot.org/29554 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie788b7153e25b764cd1d33753af17d5ed4903c36 Gerrit-Change-Number: 29554 Gerrit-PatchSet: 6 Gerrit-Owner: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Krzysztof M Sywula <krzysztof.m.sywula(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 09 Nov 2018 20:51:31 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: azalia: Add Azalia Reset macro
by Lijian Zhao (Code Review) 09 Nov '18

09 Nov '18

Hello Bora Guvendik, build bot (Jenkins), Krzysztof M Sywula, I'd like you to reexamine a change. Please visit https://review.coreboot.org/29554 to look at the new patch set (#6). Change subject: azalia: Add Azalia Reset macro ...................................................................... azalia: Add Azalia Reset macro Provide an reset macro that will use Verb ID 0x7ff and Payload 0 to execute function reset. Change-Id: Ie788b7153e25b764cd1d33753af17d5ed4903c36 Signed-off-by: Lijian Zhao <lijian.zhao(a)intel.com> --- M src/include/device/azalia_device.h 1 file changed, 5 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/29554/6 -- To view, visit https://review.coreboot.org/29554 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ie788b7153e25b764cd1d33753af17d5ed4903c36 Gerrit-Change-Number: 29554 Gerrit-PatchSet: 6 Gerrit-Owner: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Krzysztof M Sywula <krzysztof.m.sywula(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: soc/intel/skylake: Drop FSP_CAR options
by Nico Huber (Code Review) 09 Nov '18

09 Nov '18

Nico Huber has posted comments on this change. ( https://review.coreboot.org/29533 ) Change subject: soc/intel/skylake: Drop FSP_CAR options ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/#/c/29533/1/src/soc/intel/skylake/Kconfig File src/soc/intel/skylake/Kconfig: https://review.coreboot.org/#/c/29533/1/src/soc/intel/skylake/Kconfig@105 PS1, Line 105: select SKIP_FSP_CAR > If we want to use FSP_CAR, what is the right config how to set? […] It's not as easy as toggling a Kconfig. And it's different for FSP1.1 (where we have SKIP_FSP_CAR with the inverse logic) and FSP2.0 (where we have FSP_CAR). IIRC, for FSP1.1 the linker gives an error about a conflict with code from soc/intel/common/. That would have to be fixed, and then we'd have to remove the `select SKIP_FSP_CAR` here (because you can't over- ride a select at the mainboard level) and find a better solution. For FSP2.0 there are symbols missing when FSP_CAR is selected. When you provide the missing symbols you could `select FSP_CAR` at the mainboard level. I'm not a friend of the idea to "select" it at the mainboard level, though. It would take away the option to use the open-source version from the person that configures/compiles coreboot. And that seems to be questionable for an open-source project (what coreboot is about). -- To view, visit https://review.coreboot.org/29533 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iae0a2d2c7fd7a71ed24118564e6080c4789cda28 Gerrit-Change-Number: 29533 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: PraveenX Hodagatta Pranesh <praveenx.hodagatta.pranesh(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Boon Tiong Teo <boon.tiong.teo(a)intel.com> Gerrit-Comment-Date: Fri, 09 Nov 2018 19:54:14 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: cpu/intel/speedstep: Add Netburst CPUs
by build bot (Jenkins) (Code Review) 09 Nov '18

09 Nov '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22604 ) Change subject: cpu/intel/speedstep: Add Netburst CPUs ...................................................................... Patch Set 36: (2 comments) https://review.coreboot.org/#/c/22604/36/src/cpu/intel/common/fsb.c File src/cpu/intel/common/fsb.c: https://review.coreboot.org/#/c/22604/36/src/cpu/intel/common/fsb.c@48 PS36, Line 48: case 0xf: /* Netburst */ Possible switch case/default not preceded by break or fallthrough comment https://review.coreboot.org/#/c/22604/36/src/cpu/intel/common/fsb.c@62 PS36, Line 62: default: Possible switch case/default not preceded by break or fallthrough comment -- To view, visit https://review.coreboot.org/22604 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I06e162d3260dedeb3b16583460633507fbcbd52a Gerrit-Change-Number: 22604 Gerrit-PatchSet: 36 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Comment-Date: Fri, 09 Nov 2018 18:55:24 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: cpu/intel/speedstep: Add Netburst CPUs
by build bot (Jenkins) (Code Review) 09 Nov '18

09 Nov '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22604 ) Change subject: cpu/intel/speedstep: Add Netburst CPUs ...................................................................... Patch Set 35: (2 comments) https://review.coreboot.org/#/c/22604/35/src/cpu/intel/common/fsb.c File src/cpu/intel/common/fsb.c: https://review.coreboot.org/#/c/22604/35/src/cpu/intel/common/fsb.c@48 PS35, Line 48: case 0xf: /* Netburst */ Possible switch case/default not preceded by break or fallthrough comment https://review.coreboot.org/#/c/22604/35/src/cpu/intel/common/fsb.c@62 PS35, Line 62: default: Possible switch case/default not preceded by break or fallthrough comment -- To view, visit https://review.coreboot.org/22604 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I06e162d3260dedeb3b16583460633507fbcbd52a Gerrit-Change-Number: 22604 Gerrit-PatchSet: 35 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Comment-Date: Fri, 09 Nov 2018 18:54:40 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: cpu/intel/speedstep: Add Netburst CPUs
by build bot (Jenkins) (Code Review) 09 Nov '18

09 Nov '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22604 ) Change subject: cpu/intel/speedstep: Add Netburst CPUs ...................................................................... Patch Set 34: (2 comments) https://review.coreboot.org/#/c/22604/34/src/cpu/intel/common/fsb.c File src/cpu/intel/common/fsb.c: https://review.coreboot.org/#/c/22604/34/src/cpu/intel/common/fsb.c@48 PS34, Line 48: case 0xf: /* Netburst */ Possible switch case/default not preceded by break or fallthrough comment https://review.coreboot.org/#/c/22604/34/src/cpu/intel/common/fsb.c@62 PS34, Line 62: default: Possible switch case/default not preceded by break or fallthrough comment -- To view, visit https://review.coreboot.org/22604 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I06e162d3260dedeb3b16583460633507fbcbd52a Gerrit-Change-Number: 22604 Gerrit-PatchSet: 34 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Comment-Date: Fri, 09 Nov 2018 18:22:42 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: cpu/intel/speedstep: Add Netburst CPUs
by build bot (Jenkins) (Code Review) 09 Nov '18

09 Nov '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22604 ) Change subject: cpu/intel/speedstep: Add Netburst CPUs ...................................................................... Patch Set 33: (2 comments) https://review.coreboot.org/#/c/22604/33/src/cpu/intel/common/fsb.c File src/cpu/intel/common/fsb.c: https://review.coreboot.org/#/c/22604/33/src/cpu/intel/common/fsb.c@48 PS33, Line 48: case 0xf: /* Netburst */ Possible switch case/default not preceded by break or fallthrough comment https://review.coreboot.org/#/c/22604/33/src/cpu/intel/common/fsb.c@62 PS33, Line 62: default: Possible switch case/default not preceded by break or fallthrough comment -- To view, visit https://review.coreboot.org/22604 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I06e162d3260dedeb3b16583460633507fbcbd52a Gerrit-Change-Number: 22604 Gerrit-PatchSet: 33 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Comment-Date: Fri, 09 Nov 2018 17:09:16 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: soc/intel/braswell: Configure IO APIC
by Frans Hendriks (Code Review) 09 Nov '18

09 Nov '18

Hello build bot (Jenkins), Hannah Williams, I'd like you to reexamine a change. Please visit https://review.coreboot.org/29423 to look at the new patch set (#5). Change subject: soc/intel/braswell: Configure IO APIC ...................................................................... soc/intel/braswell: Configure IO APIC IO APIC is not configured. Add sc_enable_ioapic() copied from fsp_baytrail Soc. BUG=N/A TEST=Intel CherryHill CRB Change-Id: I917c30892b46ac1d964e7bab339082d17a1e706d Signed-off-by: Frans Hendriks <fhendriks(a)eltan.com> --- M src/soc/intel/braswell/Kconfig M src/soc/intel/braswell/include/soc/lpc.h M src/soc/intel/braswell/southcluster.c 3 files changed, 56 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/23/29423/5 -- To view, visit https://review.coreboot.org/29423 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I917c30892b46ac1d964e7bab339082d17a1e706d Gerrit-Change-Number: 29423 Gerrit-PatchSet: 5 Gerrit-Owner: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Reviewer: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Patrick Rudolph <siro(a)das-labor.org>

1 0

Change in coreboot[master]: util/docker: Unify local build targets
by Patrick Georgi (Code Review) 09 Nov '18

09 Nov '18

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/29456 ) Change subject: util/docker: Unify local build targets ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/29456 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9088fb9211726cddc37b17ddf70170c2c382679e Gerrit-Change-Number: 29456 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 09 Nov 2018 15:00:34 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2018