coreboot-gerrit November 2018

coreboot-gerrit@coreboot.org

1 participants
1699 discussions

Change in coreboot[master]: util/docker: Use common .ccache for local builds
by Patrick Georgi (Code Review) 09 Nov '18

09 Nov '18

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/29457 ) Change subject: util/docker: Use common .ccache for local builds ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/29457 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7d0bdb3861ac56361cacfa74aaf8b45c4f135e5c Gerrit-Change-Number: 29457 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 09 Nov 2018 14:59:49 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: util/docker: Rename _CONTAINER_VERSION => _IMAGE_TAG
by Patrick Georgi (Code Review) 09 Nov '18

09 Nov '18

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/29458 ) Change subject: util/docker: Rename _CONTAINER_VERSION => _IMAGE_TAG ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/29458 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6f87e2f6912d886e241e03998fb4136fb28bc7b1 Gerrit-Change-Number: 29458 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 09 Nov 2018 14:59:07 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: arch/x86/smbios: [WIP] Add CPU SOCKET TYPE
by Richard Spiegel (Code Review) 09 Nov '18

09 Nov '18

Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/29529 ) Change subject: arch/x86/smbios: [WIP] Add CPU_SOCKET_TYPE ...................................................................... Patch Set 7: > Patch Set 7: > > > Over all looks ok, but I would like analysis on the impact on > > SMBIOS tools. > > I've used bits-2079 (BIOS Implementation Test Suite) on LGA775, > it displays the right socket. > > (still missing, the voltage, frequency, ... , but this is not related to current topic) I'll wait to early next week, to give a chance to Raul or Martin to review it in face of a Google app (Mosis). I want their input before approving. -- To view, visit https://review.coreboot.org/29529 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1bf5ac6c411720d349df8fd706015c6835758cd0 Gerrit-Change-Number: 29529 Gerrit-PatchSet: 7 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 09 Nov 2018 14:50:25 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: soc/intel/braswell: Configure IO APIC
by build bot (Jenkins) (Code Review) 09 Nov '18

09 Nov '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/29423 ) Change subject: soc/intel/braswell: Configure IO APIC ...................................................................... Patch Set 4: (1 comment) https://review.coreboot.org/#/c/29423/4/src/soc/intel/braswell/southcluster… File src/soc/intel/braswell/southcluster.c: https://review.coreboot.org/#/c/29423/4/src/soc/intel/braswell/southcluster… PS4, Line 75: add_mmio_resource(dev, 0xfff, 0xffffffff - (CONFIG_COREBOOT_ROMSIZE_KB*KiB) + 1, line over 80 characters -- To view, visit https://review.coreboot.org/29423 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I917c30892b46ac1d964e7bab339082d17a1e706d Gerrit-Change-Number: 29423 Gerrit-PatchSet: 4 Gerrit-Owner: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Reviewer: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Fri, 09 Nov 2018 14:25:07 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: soc/intel/braswell: Configure IO APIC
by Frans Hendriks (Code Review) 09 Nov '18

09 Nov '18

Hello Hannah Williams, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/29423 to look at the new patch set (#4). Change subject: soc/intel/braswell: Configure IO APIC ...................................................................... soc/intel/braswell: Configure IO APIC IO APIC is not configured. Add sc_enable_ioapic() copied from fsp_baytrail Soc. BUG=N/A TEST=Intel CherryHill CRB Change-Id: I917c30892b46ac1d964e7bab339082d17a1e706d Signed-off-by: Frans Hendriks <fhendriks(a)eltan.com> --- M src/soc/intel/braswell/Kconfig M src/soc/intel/braswell/include/soc/lpc.h M src/soc/intel/braswell/southcluster.c 3 files changed, 55 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/23/29423/4 -- To view, visit https://review.coreboot.org/29423 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I917c30892b46ac1d964e7bab339082d17a1e706d Gerrit-Change-Number: 29423 Gerrit-PatchSet: 4 Gerrit-Owner: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Reviewer: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Patrick Rudolph <siro(a)das-labor.org>

1 0

Change in coreboot[master]: a useless commit to test the MAINTAINERS->reviewers integration
by Patrick Georgi (Code Review) 09 Nov '18

09 Nov '18

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/29562 to look at the new patch set (#12). Change subject: a useless commit to test the MAINTAINERS->reviewers integration ...................................................................... a useless commit to test the MAINTAINERS->reviewers integration Change-Id: I9c51084dab7811e9c9aa34ac2e1692eec2bf1aa8 Signed-off-by: Patrick Georgi <patrick(a)georgi.software> --- M util/ifdtool/Makefile 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/62/29562/12 -- To view, visit https://review.coreboot.org/29562 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I9c51084dab7811e9c9aa34ac2e1692eec2bf1aa8 Gerrit-Change-Number: 29562 Gerrit-PatchSet: 12 Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: a useless commit to test the MAINTAINERS->reviewers integration
by Patrick Georgi (Code Review) 09 Nov '18

09 Nov '18

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/29562 to look at the new patch set (#11). Change subject: a useless commit to test the MAINTAINERS->reviewers integration ...................................................................... a useless commit to test the MAINTAINERS->reviewers integration Change-Id: I9c51084dab7811e9c9aa34ac2e1692eec2bf1aa8 Signed-off-by: Patrick Georgi <patrick(a)georgi.software> --- M util/ifdtool/Makefile 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/62/29562/11 -- To view, visit https://review.coreboot.org/29562 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I9c51084dab7811e9c9aa34ac2e1692eec2bf1aa8 Gerrit-Change-Number: 29562 Gerrit-PatchSet: 11 Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: a useless commit to test the MAINTAINERS->reviewers integration
by Patrick Georgi (Code Review) 09 Nov '18

09 Nov '18

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/29562 to look at the new patch set (#10). Change subject: a useless commit to test the MAINTAINERS->reviewers integration ...................................................................... a useless commit to test the MAINTAINERS->reviewers integration Change-Id: I9c51084dab7811e9c9aa34ac2e1692eec2bf1aa8 Signed-off-by: Patrick Georgi <patrick(a)georgi.software> --- M util/ifdtool/Makefile 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/62/29562/10 -- To view, visit https://review.coreboot.org/29562 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I9c51084dab7811e9c9aa34ac2e1692eec2bf1aa8 Gerrit-Change-Number: 29562 Gerrit-PatchSet: 10 Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: a useless commit to test the MAINTAINERS->reviewers integration
by Patrick Georgi (Code Review) 09 Nov '18

09 Nov '18

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/29562 to look at the new patch set (#9). Change subject: a useless commit to test the MAINTAINERS->reviewers integration ...................................................................... a useless commit to test the MAINTAINERS->reviewers integration Change-Id: I9c51084dab7811e9c9aa34ac2e1692eec2bf1aa8 Signed-off-by: Patrick Georgi <patrick(a)georgi.software> --- M util/ifdtool/Makefile 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/62/29562/9 -- To view, visit https://review.coreboot.org/29562 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I9c51084dab7811e9c9aa34ac2e1692eec2bf1aa8 Gerrit-Change-Number: 29562 Gerrit-PatchSet: 9 Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: a useless commit to test the MAINTAINERS->reviewers integration
by Patrick Georgi (Code Review) 09 Nov '18

09 Nov '18

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/29562 to look at the new patch set (#8). Change subject: a useless commit to test the MAINTAINERS->reviewers integration ...................................................................... a useless commit to test the MAINTAINERS->reviewers integration Change-Id: I9c51084dab7811e9c9aa34ac2e1692eec2bf1aa8 Signed-off-by: Patrick Georgi <patrick(a)georgi.software> --- M util/ifdtool/Makefile 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/62/29562/8 -- To view, visit https://review.coreboot.org/29562 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I9c51084dab7811e9c9aa34ac2e1692eec2bf1aa8 Gerrit-Change-Number: 29562 Gerrit-PatchSet: 8 Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2018