coreboot-gerrit November 2018

coreboot-gerrit@coreboot.org

1 participants
1699 discussions

Start a nNew thread

Change in coreboot[master]: cpu/intel/speedstep: Add Netburst CPUs
by build bot (Jenkins) (Code Review) 10 Nov '18

10 Nov '18

1 0

Change in coreboot[master]: cpu/intel/speedstep: Add Netburst CPUs
by build bot (Jenkins) (Code Review) 10 Nov '18

10 Nov '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22604 ) Change subject: cpu/intel/speedstep: Add Netburst CPUs ...................................................................... Patch Set 38: (4 comments) https://review.coreboot.org/#/c/22604/38/src/cpu/intel/common/fsb.c File src/cpu/intel/common/fsb.c: https://review.coreboot.org/#/c/22604/38/src/cpu/intel/common/fsb.c@48 PS38, Line 48: case 0xf: /* Netburst */ Possible switch case/default not preceded by break or fallthrough comment https://review.coreboot.org/#/c/22604/38/src/cpu/intel/speedstep/speedstep.c File src/cpu/intel/speedstep/speedstep.c: https://review.coreboot.org/#/c/22604/38/src/cpu/intel/speedstep/speedstep.… PS38, Line 38: ((c.x86 == 6 && c.x86_model == 0x17) ? SPEEDSTEP_RATIO_NONINT : 0) line over 80 characters https://review.coreboot.org/#/c/22604/38/src/cpu/intel/speedstep/speedstep.… PS38, Line 110: } code indent should use tabs where possible https://review.coreboot.org/#/c/22604/38/src/cpu/intel/speedstep/speedstep.… PS38, Line 110: } please, no spaces at the start of a line -- To view, visit https://review.coreboot.org/22604 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I06e162d3260dedeb3b16583460633507fbcbd52a Gerrit-Change-Number: 22604 Gerrit-PatchSet: 38 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Comment-Date: Sat, 10 Nov 2018 10:48:15 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: mb/google/kahlee/variants/delan: Decrease eDP adjust time to 20 ms
by Ivy Jian (Code Review) 10 Nov '18

10 Nov '18

Ivy Jian has uploaded this change for review. ( https://review.coreboot.org/29566 Change subject: mb/google/kahlee/variants/delan: Decrease eDP adjust time to 20 ms ...................................................................... mb/google/kahlee/variants/delan: Decrease eDP adjust time to 20 ms Add 20ms adjust timing for edp panel in devicetree. BUG=b:119226740 TEST=Verify panel-on sequences on Delan. Change-Id: Icfde81f75cd8413806949a16d8a4b606dcf5b83a Signed-off-by: Ivy Jian <ivy_jian(a)compal.corp-partner.google.com> --- M src/mainboard/google/kahlee/variants/delan/devicetree.cb 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/66/29566/1 diff --git a/src/mainboard/google/kahlee/variants/delan/devicetree.cb b/src/mainboard/google/kahlee/variants/delan/devicetree.cb index fd30d5d..141165d 100644 --- a/src/mainboard/google/kahlee/variants/delan/devicetree.cb +++ b/src/mainboard/google/kahlee/variants/delan/devicetree.cb @@ -20,6 +20,8 @@ register "dram_clear_on_reset" = "DRAM_CONTENTS_KEEP" register "uma_mode" = "UMAMODE_SPECIFIED_SIZE" register "uma_size" = "32 * MiB" + register "lvds_poseq_varybl_to_blon" = "0x5" # in 4ms + register "lvds_poseq_blon_to_varybl" = "0x5" # in 4ms # Enable I2C0 for audio, USB3 hub at 400kHz register "i2c[0]" = "{ -- To view, visit https://review.coreboot.org/29566 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Icfde81f75cd8413806949a16d8a4b606dcf5b83a Gerrit-Change-Number: 29566 Gerrit-PatchSet: 1 Gerrit-Owner: Ivy Jian <ivy_jian(a)compal.corp-partner.google.com>

1 0

Change in coreboot[master]: security/tpm: Fix TCPA log feature
by build bot (Jenkins) (Code Review) 10 Nov '18

10 Nov '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/29563 ) Change subject: security/tpm: Fix TCPA log feature ...................................................................... Patch Set 9: (2 comments) https://review.coreboot.org/#/c/29563/9/src/include/memlayout.h File src/include/memlayout.h: https://review.coreboot.org/#/c/29563/9/src/include/memlayout.h@168 PS9, Line 168: #define VBOOT2_TPM_LOG(addr, size) \ Macros with multiple statements should be enclosed in a do - while loop https://review.coreboot.org/#/c/29563/9/src/include/memlayout.h@168 PS9, Line 168: #define VBOOT2_TPM_LOG(addr, size) \ macros should not use a trailing semicolon -- To view, visit https://review.coreboot.org/29563 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic93133531b84318f48940d34bded48cbae739c44 Gerrit-Change-Number: 29563 Gerrit-PatchSet: 9 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 10 Nov 2018 02:12:23 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: security/tpm: Fix TCPA log feature
by Philipp Deppenwiese (Code Review) 10 Nov '18

10 Nov '18

Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/29563 ) Change subject: security/tpm: Fix TCPA log feature ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/29563 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic93133531b84318f48940d34bded48cbae739c44 Gerrit-Change-Number: 29563 Gerrit-PatchSet: 8 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 10 Nov 2018 01:55:39 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: security/vboot: Add measured boot mode
by Philipp Deppenwiese (Code Review) 10 Nov '18

10 Nov '18

Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/29547 ) Change subject: security/vboot: Add measured boot mode ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/29547 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I339a2f1051e44f36aba9f99828f130592a09355e Gerrit-Change-Number: 29547 Gerrit-PatchSet: 4 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Sat, 10 Nov 2018 01:55:34 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: lenovo/h8, thinkpads: Re-do USB Always On
by build bot (Jenkins) (Code Review) 10 Nov '18

10 Nov '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/29565 ) Change subject: lenovo/h8,thinkpads: Re-do USB Always On ...................................................................... Patch Set 4: (2 comments) https://review.coreboot.org/#/c/29565/4/src/ec/lenovo/h8/h8.c File src/ec/lenovo/h8/h8.c: https://review.coreboot.org/#/c/29565/4/src/ec/lenovo/h8/h8.c@138 PS4, Line 138: switch(on){ space required before the open brace '{' https://review.coreboot.org/#/c/29565/4/src/ec/lenovo/h8/h8.c@138 PS4, Line 138: switch(on){ space required before the open parenthesis '(' -- To view, visit https://review.coreboot.org/29565 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If812cd1ef8fb1a24d7fadbe834f574b40cbcd56a Gerrit-Change-Number: 29565 Gerrit-PatchSet: 4 Gerrit-Owner: Nathaniel Roach <nroach44(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 10 Nov 2018 01:04:32 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: lenovo/h8, thinkpads: Re-do USB Always On
by Nathaniel Roach (Code Review) 10 Nov '18

10 Nov '18

Hello Angel Pons, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/29565 to look at the new patch set (#4). Change subject: lenovo/h8,thinkpads: Re-do USB Always On ...................................................................... lenovo/h8,thinkpads: Re-do USB Always On Re-write the UAO handling code as it had stopped working (#171) (the flag was not getting read from the RTC properly in SMM) Remove the SMM code as it's not needed (but EC flag won't be set upon entering S3 now) Set the EC flags on boot the same way other flags are set Document bitwise operators for clarity Propagate changes to other Thinkpads (updated X201 to have 2 bits for the flag as it only had 1) Per Nicola Corna's previous commits, 0x0d is set for "AC only" "AC only" does exhibit different behaviour - the USB port is turned on a few seconds after entering S3, rather than < 1 sec, regardless of AC status Tested on X220 Change-Id: If812cd1ef8fb1a24d7fadbe834f574b40cbcd56a Signed-off-by: Nathaniel Roach <nroach44(a)gmail.com> --- M src/ec/lenovo/h8/Makefile.inc M src/ec/lenovo/h8/h8.c M src/ec/lenovo/h8/h8.h D src/ec/lenovo/h8/smm.c M src/mainboard/lenovo/l520/smihandler.c M src/mainboard/lenovo/t420/smihandler.c M src/mainboard/lenovo/t420s/smihandler.c M src/mainboard/lenovo/t430/smihandler.c M src/mainboard/lenovo/t430s/smihandler.c M src/mainboard/lenovo/t520/smihandler.c M src/mainboard/lenovo/t530/smihandler.c M src/mainboard/lenovo/x201/cmos.layout M src/mainboard/lenovo/x201/smihandler.c M src/mainboard/lenovo/x220/cmos.layout M src/mainboard/lenovo/x220/smihandler.c M src/mainboard/lenovo/x230/smihandler.c 16 files changed, 43 insertions(+), 73 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/65/29565/4 -- To view, visit https://review.coreboot.org/29565 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: If812cd1ef8fb1a24d7fadbe834f574b40cbcd56a Gerrit-Change-Number: 29565 Gerrit-PatchSet: 4 Gerrit-Owner: Nathaniel Roach <nroach44(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: lenovo/h8, thinkpads: Re-do USB Always On
by build bot (Jenkins) (Code Review) 10 Nov '18

10 Nov '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/29565 ) Change subject: lenovo/h8,thinkpads: Re-do USB Always On ...................................................................... Patch Set 3: (2 comments) https://review.coreboot.org/#/c/29565/3/src/ec/lenovo/h8/h8.c File src/ec/lenovo/h8/h8.c: https://review.coreboot.org/#/c/29565/3/src/ec/lenovo/h8/h8.c@138 PS3, Line 138: switch(on) { switch and case should be at the same indent https://review.coreboot.org/#/c/29565/3/src/ec/lenovo/h8/h8.c@138 PS3, Line 138: switch(on) { space required before the open parenthesis '(' -- To view, visit https://review.coreboot.org/29565 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If812cd1ef8fb1a24d7fadbe834f574b40cbcd56a Gerrit-Change-Number: 29565 Gerrit-PatchSet: 3 Gerrit-Owner: Nathaniel Roach <nroach44(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 10 Nov 2018 00:59:20 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: lenovo/h8, thinkpads: Re-do USB Always On
by Nathaniel Roach (Code Review) 10 Nov '18

10 Nov '18

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/29565 to look at the new patch set (#3). Change subject: lenovo/h8,thinkpads: Re-do USB Always On ...................................................................... lenovo/h8,thinkpads: Re-do USB Always On Re-write the UAO handling code as it had stopped working (#171) (the flag was not getting read from the RTC properly in SMM) Remove the SMM code as it's not needed (but EC flag won't be set upon entering S3 now) Set the EC flags on boot the same way other flags are set Document bitwise operators for clarity Propagate changes to other Thinkpads (updated X201 to have 2 bits for the flag as it only had 1) Per Nicola Corna's previous commits, 0x0d is set for "AC only" "AC only" does exhibit different behaviour - the USB port is turned on a few seconds after entering S3, rather than < 1 sec, regardless of AC status Tested on X220 Change-Id: If812cd1ef8fb1a24d7fadbe834f574b40cbcd56a Signed-off-by: Nathaniel Roach <nroach44(a)gmail.com> --- M src/ec/lenovo/h8/Makefile.inc M src/ec/lenovo/h8/h8.c M src/ec/lenovo/h8/h8.h D src/ec/lenovo/h8/smm.c M src/mainboard/lenovo/l520/smihandler.c M src/mainboard/lenovo/t420/smihandler.c M src/mainboard/lenovo/t420s/smihandler.c M src/mainboard/lenovo/t430/smihandler.c M src/mainboard/lenovo/t430s/smihandler.c M src/mainboard/lenovo/t520/smihandler.c M src/mainboard/lenovo/t530/smihandler.c M src/mainboard/lenovo/x201/cmos.layout M src/mainboard/lenovo/x201/smihandler.c M src/mainboard/lenovo/x220/cmos.layout M src/mainboard/lenovo/x220/smihandler.c M src/mainboard/lenovo/x230/smihandler.c 16 files changed, 43 insertions(+), 73 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/65/29565/3 -- To view, visit https://review.coreboot.org/29565 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: If812cd1ef8fb1a24d7fadbe834f574b40cbcd56a Gerrit-Change-Number: 29565 Gerrit-PatchSet: 3 Gerrit-Owner: Nathaniel Roach <nroach44(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2018