coreboot-gerrit November 2018

coreboot-gerrit@coreboot.org

1 participants
1699 discussions

Change in coreboot[master]: mb/emulation/qemu-i440fx|q35: Get rid of unused headers
by Patrick Rudolph (Code Review) 11 Nov '18

11 Nov '18

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/29577 ) Change subject: mb/emulation/qemu-i440fx|q35: Get rid of unused headers ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/#/c/29577/1/src/mainboard/emulation/qemu-i440fx… File src/mainboard/emulation/qemu-i440fx/mainboard.c: https://review.coreboot.org/#/c/29577/1/src/mainboard/emulation/qemu-i440fx… PS1, Line 21: > pci_write_config8 is implemented in arch/io. […] the arch independent ramstage headers are at <device/pci_ops.h> arch/io.h is only used for PRE_RAM on x86 -- To view, visit https://review.coreboot.org/29577 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3cf0e4ef5b090d15ad823747fcf9219644e130fc Gerrit-Change-Number: 29577 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Sun, 11 Nov 2018 15:56:05 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: src/arch/x86/acpi.c: Update ACPI table revisions
by Elyes HAOUAS (Code Review) 11 Nov '18

11 Nov '18

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/29579 to look at the new patch set (#2). Change subject: src/arch/x86/acpi.c: Update ACPI table revisions ...................................................................... src/arch/x86/acpi.c: Update ACPI table revisions Change-Id: I22020bd156536ee8f23a267d7c7b2d7af6c7cfeb Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/arch/x86/acpi.c 1 file changed, 8 insertions(+), 8 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/79/29579/2 -- To view, visit https://review.coreboot.org/29579 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I22020bd156536ee8f23a267d7c7b2d7af6c7cfeb Gerrit-Change-Number: 29579 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: src/arch/x86/acpi.c: Update ACPI table revisions
by Elyes HAOUAS (Code Review) 11 Nov '18

11 Nov '18

Elyes HAOUAS has posted comments on this change. ( https://review.coreboot.org/29579 ) Change subject: src/arch/x86/acpi.c: Update ACPI table revisions ...................................................................... Patch Set 1: Code-Review-1 -- To view, visit https://review.coreboot.org/29579 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I22020bd156536ee8f23a267d7c7b2d7af6c7cfeb Gerrit-Change-Number: 29579 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Comment-Date: Sun, 11 Nov 2018 14:24:14 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: src/arch/x86/acpi.c: Update ACPI table revisions
by Elyes HAOUAS (Code Review) 11 Nov '18

11 Nov '18

Elyes HAOUAS has uploaded this change for review. ( https://review.coreboot.org/29579 Change subject: src/arch/x86/acpi.c: Update ACPI table revisions ...................................................................... src/arch/x86/acpi.c: Update ACPI table revisions Change-Id: I22020bd156536ee8f23a267d7c7b2d7af6c7cfeb Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/arch/x86/acpi.c 1 file changed, 7 insertions(+), 7 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/79/29579/1 diff --git a/src/arch/x86/acpi.c b/src/arch/x86/acpi.c index f54aa19..6d3c068 100644 --- a/src/arch/x86/acpi.c +++ b/src/arch/x86/acpi.c @@ -1328,9 +1328,9 @@ { switch (table) { case FADT: - return ACPI_FADT_REV_ACPI_3_0; - case MADT: /* ACPI 1.0/2.0: 1, ACPI 3.0: 2, ACPI 4.0: 3 */ - return 2; + return ACPI_FADT_REV_ACPI_6_0; + case MADT: /* ACPI 1.0/2.0: 1, ACPI 3.0: 2, ACPI 4.0/5.0: 3 */ + return 3; // ACPI 6.2a: 45 ? case MCFG: return 1; case TCPA: @@ -1339,8 +1339,8 @@ return 4; case SSDT: /* ACPI 1.0/2.0: ?, ACPI 3.0/4.0: 2 */ return 2; - case SRAT: /* ACPI 1.0: N/A, 2.0: 1, 3.0: 2, 4.0: 3 */ - return 1; /* TODO Should probably be upgraded to 2 */ + case SRAT: /* ACPI 1.0: N/A, 2.0: 1, 3.0: 2, 4.0/5.0/6.2a: 3 */ + return 3; case DMAR: return 1; case SLIT: /* ACPI 1.0: N/A, ACPI 2.0/3.0/4.0: 1 */ @@ -1354,12 +1354,12 @@ case DBG2: return 0; case FACS: /* ACPI 1.0: 0, ACPI 2.0/3.0: 1, ACPI 4.0: 2 */ - return 1; + return 0; case RSDT: /* ACPI 1.0/2.0/3.0/4.0: 1 */ return 1; case XSDT: /* ACPI 1.0: N/A, 2.0/3.0/4.0: 1 */ return 1; - case RSDP: /* ACPI 1.0: 0, ACPI 2.0/3.0/4.0: 2. */ + case RSDP: /* ACPI 1.0: 0, ACPI 2.0/3.0/4.0/5.0/6.2a: 2 */ return 2; case HEST: return 1; -- To view, visit https://review.coreboot.org/29579 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I22020bd156536ee8f23a267d7c7b2d7af6c7cfeb Gerrit-Change-Number: 29579 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr>

1 0

Change in coreboot[master]: arch/acpi.h: Add some update to version 6.2a
by build bot (Jenkins) (Code Review) 11 Nov '18

11 Nov '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/29569 ) Change subject: arch/acpi.h: Add some update to version 6.2a ...................................................................... Patch Set 7: (1 comment) https://review.coreboot.org/#/c/29569/7/src/arch/x86/include/arch/acpi.h File src/arch/x86/include/arch/acpi.h: https://review.coreboot.org/#/c/29569/7/src/arch/x86/include/arch/acpi.h@97 PS7, Line 97: u8 revision; /* 0 for ACPI 1.0, 2 for ACPI 2.0/3.0/4.0/6.2a */ line over 80 characters -- To view, visit https://review.coreboot.org/29569 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I91291c8202d1562b720b9922791c6282e572601f Gerrit-Change-Number: 29569 Gerrit-PatchSet: 7 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Sun, 11 Nov 2018 13:32:21 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: arch/acpi.h: Add some update to version 6.2a
by Elyes HAOUAS (Code Review) 11 Nov '18

11 Nov '18

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/29569 to look at the new patch set (#7). Change subject: arch/acpi.h: Add some update to version 6.2a ...................................................................... arch/acpi.h: Add some update to version 6.2a Some tables updated to comply with ACPI version 6.2a. Change-Id: I91291c8202d1562b720b9922791c6282e572601f Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/arch/x86/include/arch/acpi.h M src/soc/amd/stoneyridge/acpi.c M src/soc/intel/fsp_baytrail/acpi.c M src/soc/intel/fsp_broadwell_de/acpi.c M src/southbridge/amd/agesa/hudson/fadt.c M src/southbridge/amd/cimx/sb800/fadt.c M src/southbridge/amd/pi/hudson/fadt.c M src/southbridge/intel/fsp_rangeley/acpi.c 8 files changed, 51 insertions(+), 41 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/29569/7 -- To view, visit https://review.coreboot.org/29569 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I91291c8202d1562b720b9922791c6282e572601f Gerrit-Change-Number: 29569 Gerrit-PatchSet: 7 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Patrick Rudolph <siro(a)das-labor.org>

1 0

Change in coreboot[master]: arch/acpi.h: Add some update to version 6.2a
by build bot (Jenkins) (Code Review) 11 Nov '18

11 Nov '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/29569 ) Change subject: arch/acpi.h: Add some update to version 6.2a ...................................................................... Patch Set 6: (1 comment) https://review.coreboot.org/#/c/29569/6/src/arch/x86/include/arch/acpi.h File src/arch/x86/include/arch/acpi.h: https://review.coreboot.org/#/c/29569/6/src/arch/x86/include/arch/acpi.h@97 PS6, Line 97: u8 revision; /* 0 for ACPI 1.0, 2 for ACPI 2.0/3.0/4.0/6.2a */ line over 80 characters -- To view, visit https://review.coreboot.org/29569 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I91291c8202d1562b720b9922791c6282e572601f Gerrit-Change-Number: 29569 Gerrit-PatchSet: 6 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Sun, 11 Nov 2018 12:42:38 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: arch/acpi.h: Add some update to version 6.2a
by Elyes HAOUAS (Code Review) 11 Nov '18

11 Nov '18

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/29569 to look at the new patch set (#6). Change subject: arch/acpi.h: Add some update to version 6.2a ...................................................................... arch/acpi.h: Add some update to version 6.2a Some tables updated to comply with ACPI version 6.2a. Change-Id: I91291c8202d1562b720b9922791c6282e572601f Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/arch/x86/include/arch/acpi.h 1 file changed, 37 insertions(+), 16 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/29569/6 -- To view, visit https://review.coreboot.org/29569 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I91291c8202d1562b720b9922791c6282e572601f Gerrit-Change-Number: 29569 Gerrit-PatchSet: 6 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Patrick Rudolph <siro(a)das-labor.org>

1 0

Change in coreboot[master]: arch/acpi.h: Add some update to version 6.2a
by Elyes HAOUAS (Code Review) 11 Nov '18

11 Nov '18

Elyes HAOUAS has posted comments on this change. ( https://review.coreboot.org/29569 ) Change subject: arch/acpi.h: Add some update to version 6.2a ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/29569 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I91291c8202d1562b720b9922791c6282e572601f Gerrit-Change-Number: 29569 Gerrit-PatchSet: 5 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Sun, 11 Nov 2018 12:34:02 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: mb/emulation/qemu-i440fx|q35: Link memory.c
by Arthur Heymans (Code Review) 11 Nov '18

11 Nov '18

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/29574 ) Change subject: mb/emulation/qemu-i440fx|q35: Link memory.c ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/29574 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2bc461b13332ec5885c33c87828a5fd023f8e730 Gerrit-Change-Number: 29574 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 11 Nov 2018 12:29:59 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2018