coreboot-gerrit October 2018

coreboot-gerrit@coreboot.org

1 participants
1285 discussions

Change in coreboot[master]: soc/intel/cannonlake: Add back PM TIMER EMULATION
by Wonkyu Kim (Code Review) 08 Oct '18

08 Oct '18

Wonkyu Kim has posted comments on this change. ( https://review.coreboot.org/28937 ) Change subject: soc/intel/cannonlake: Add back PM TIMER EMULATION ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://review.coreboot.org/28937 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie069e815e6244c3f85fabf51e186311621d316fd Gerrit-Change-Number: 28937 Gerrit-PatchSet: 2 Gerrit-Owner: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-CC: Subrata Banik <subi.banik(a)gmail.com> Gerrit-Comment-Date: Mon, 08 Oct 2018 18:22:54 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: revert soc/intel/cannonlake: Move SkipMpInit config to FSPM
by Wonkyu Kim (Code Review) 08 Oct '18

08 Oct '18

Wonkyu Kim has abandoned this change. ( https://review.coreboot.org/28929 ) Change subject: revert soc/intel/cannonlake: Move SkipMpInit config to FSPM ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/28929 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: abandon Gerrit-Change-Id: Id86d0a8ffed1b26898cd5f14df67c534e075992a Gerrit-Change-Number: 28929 Gerrit-PatchSet: 1 Gerrit-Owner: Wonkyu Kim <wonkyu.kim(a)intel.com>

1 0

Change in coreboot[master]: Enable Debug interface
by Wonkyu Kim (Code Review) 08 Oct '18

08 Oct '18

Wonkyu Kim has abandoned this change. ( https://review.coreboot.org/28970 ) Change subject: Enable Debug interface ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/28970 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: abandon Gerrit-Change-Id: I64d207ad6d63b9ac792b4d39f21572d2ebb2a976 Gerrit-Change-Number: 28970 Gerrit-PatchSet: 1 Gerrit-Owner: Wonkyu Kim <wonkyu.kim(a)intel.com>

1 0

Change in coreboot[master]: mb/google/kahlee: Set 100MHz fast spi read for supported boards
by Martin Roth (Code Review) 08 Oct '18

08 Oct '18

Martin Roth has abandoned this change. ( https://review.coreboot.org/28906 ) Change subject: mb/google/kahlee: Set 100MHz fast spi read for supported boards ...................................................................... Abandoned Violates hold time for the spi chip. Abandoning. -- To view, visit https://review.coreboot.org/28906 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: abandon Gerrit-Change-Id: I9ad95c858376ad0e6c9e787055d3fa72b5682191 Gerrit-Change-Number: 28906 Gerrit-PatchSet: 1 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Daniel Kurtz <djkurtz(a)google.com> Gerrit-Reviewer: Kevin Chiu <Kevin.Chiu(a)quantatw.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: mainboard/google/kahlee: Set PSPP setting to BalancedHigh
by Martin Roth (Code Review) 08 Oct '18

08 Oct '18

Martin Roth has submitted this change and it was merged. ( https://review.coreboot.org/28967 ) Change subject: mainboard/google/kahlee: Set PSPP setting to BalancedHigh ...................................................................... mainboard/google/kahlee: Set PSPP setting to BalancedHigh Setting default PSPP setting to BalancedLow was causing audio playback issue in most of the units. With BalancedLow either there was no sound or noise on playback. Switching to BalancedHigh as default option. BUG=b:116553085, b:112020107 TEST=Test playback and hear proper audio. Change-Id: Ibf64d7b8e58e60ce931ddc85f11b135708cdb1ee Signed-off-by: Akshu Agrawal <akshu.agrawal(a)amd.com> Reviewed-on: https://review.coreboot.org/28967 Reviewed-by: Martin Roth <martinroth(a)google.com> Reviewed-by: Marc Jones <marc(a)marcjonesconsulting.com> Reviewed-by: Daniel Kurtz <djkurtz(a)google.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M src/mainboard/google/kahlee/variants/baseboard/OemCustomize.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified Marc Jones: Looks good to me, approved Martin Roth: Looks good to me, approved Daniel Kurtz: Looks good to me, approved diff --git a/src/mainboard/google/kahlee/variants/baseboard/OemCustomize.c b/src/mainboard/google/kahlee/variants/baseboard/OemCustomize.c index e9cf5c8..f5cab08 100644 --- a/src/mainboard/google/kahlee/variants/baseboard/OemCustomize.c +++ b/src/mainboard/google/kahlee/variants/baseboard/OemCustomize.c @@ -149,7 +149,7 @@ VOID __weak OemCustomizeInitEarly(IN OUT AMD_EARLY_PARAMS *InitEarly) { InitEarly->GnbConfig.PcieComplexList = (void *)&PcieComplex; - InitEarly->GnbConfig.PsppPolicy = PsppBalanceLow; + InitEarly->GnbConfig.PsppPolicy = PsppBalanceHigh; InitEarly->PlatformConfig.GnbAzI2sBusSelect = GnbAcpI2sBus; InitEarly->PlatformConfig.GnbAzI2sBusPinConfig = GnbAcp2Tx4RxBluetooth; if ((IS_ENABLED(CONFIG_BOARD_GOOGLE_LIARA)) && (board_id() <= 4)) -- To view, visit https://review.coreboot.org/28967 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ibf64d7b8e58e60ce931ddc85f11b135708cdb1ee Gerrit-Change-Number: 28967 Gerrit-PatchSet: 3 Gerrit-Owner: Akshu Agrawal <akshu.agrawal(a)amd.com> Gerrit-Reviewer: Akshu Agrawal <akshu.agrawal(a)amd.com> Gerrit-Reviewer: Daniel Kurtz <djkurtz(a)google.com> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Kevin Chiu <Kevin.Chiu(a)quantatw.com>

1 0

Change in coreboot[master]: mainboard/google/kahlee: Set PSPP setting to BalancedHigh
by Marc Jones (Code Review) 08 Oct '18

08 Oct '18

Marc Jones has posted comments on this change. ( https://review.coreboot.org/28967 ) Change subject: mainboard/google/kahlee: Set PSPP setting to BalancedHigh ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/28967 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibf64d7b8e58e60ce931ddc85f11b135708cdb1ee Gerrit-Change-Number: 28967 Gerrit-PatchSet: 2 Gerrit-Owner: Akshu Agrawal <akshu.agrawal(a)amd.com> Gerrit-Reviewer: Akshu Agrawal <akshu.agrawal(a)amd.com> Gerrit-Reviewer: Daniel Kurtz <djkurtz(a)google.com> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Kevin Chiu <Kevin.Chiu(a)quantatw.com> Gerrit-Comment-Date: Mon, 08 Oct 2018 17:19:49 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mainboard/google/kahlee: Set PSPP setting to BalancedHigh
by Martin Roth (Code Review) 08 Oct '18

08 Oct '18

Martin Roth has posted comments on this change. ( https://review.coreboot.org/28967 ) Change subject: mainboard/google/kahlee: Set PSPP setting to BalancedHigh ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/28967 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibf64d7b8e58e60ce931ddc85f11b135708cdb1ee Gerrit-Change-Number: 28967 Gerrit-PatchSet: 2 Gerrit-Owner: Akshu Agrawal <akshu.agrawal(a)amd.com> Gerrit-Reviewer: Akshu Agrawal <akshu.agrawal(a)amd.com> Gerrit-Reviewer: Daniel Kurtz <djkurtz(a)google.com> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Kevin Chiu <Kevin.Chiu(a)quantatw.com> Gerrit-Comment-Date: Mon, 08 Oct 2018 16:28:22 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mainboard/google/kahlee: Set PSPP setting to BalancedHigh
by Daniel Kurtz (Code Review) 08 Oct '18

08 Oct '18

Daniel Kurtz has uploaded a new patch set (#2) to the change originally created by Akshu Agrawal. ( https://review.coreboot.org/28967 ) Change subject: mainboard/google/kahlee: Set PSPP setting to BalancedHigh ...................................................................... mainboard/google/kahlee: Set PSPP setting to BalancedHigh Setting default PSPP setting to BalancedLow was causing audio playback issue in most of the units. With BalancedLow either there was no sound or noise on playback. Switching to BalancedHigh as default option. BUG=b:116553085, b:112020107 TEST=Test playback and hear proper audio. Change-Id: Ibf64d7b8e58e60ce931ddc85f11b135708cdb1ee Signed-off-by: Akshu Agrawal <akshu.agrawal(a)amd.com> --- M src/mainboard/google/kahlee/variants/baseboard/OemCustomize.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/67/28967/2 -- To view, visit https://review.coreboot.org/28967 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ibf64d7b8e58e60ce931ddc85f11b135708cdb1ee Gerrit-Change-Number: 28967 Gerrit-PatchSet: 2 Gerrit-Owner: Akshu Agrawal <akshu.agrawal(a)amd.com> Gerrit-Reviewer: Akshu Agrawal <akshu.agrawal(a)amd.com> Gerrit-Reviewer: Daniel Kurtz <djkurtz(a)google.com> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Kevin Chiu <Kevin.Chiu(a)quantatw.com>

1 0

Change in coreboot[master]: mainboard/google/kahlee: Set PSPP setting to BalancedHigh
by Martin Roth (Code Review) 08 Oct '18

08 Oct '18

Martin Roth has posted comments on this change. ( https://review.coreboot.org/28967 ) Change subject: mainboard/google/kahlee: Set PSPP setting to BalancedHigh ...................................................................... Patch Set 1: (2 comments) https://review.coreboot.org/#/c/28967/1//COMMIT_MSG Commit Message: https://review.coreboot.org/#/c/28967/1//COMMIT_MSG@9 PS1, Line 9: setiing value? https://review.coreboot.org/#/c/28967/1//COMMIT_MSG@12 PS1, Line 12: defuault default -- To view, visit https://review.coreboot.org/28967 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibf64d7b8e58e60ce931ddc85f11b135708cdb1ee Gerrit-Change-Number: 28967 Gerrit-PatchSet: 1 Gerrit-Owner: Akshu Agrawal <akshu.agrawal(a)amd.com> Gerrit-Reviewer: Akshu Agrawal <akshu.agrawal(a)amd.com> Gerrit-Reviewer: Daniel Kurtz <djkurtz(a)google.com> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Kevin Chiu <Kevin.Chiu(a)quantatw.com> Gerrit-Comment-Date: Mon, 08 Oct 2018 15:43:51 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: mainboard/google/kahlee: Set PSPP setting to BalancedHigh
by Daniel Kurtz (Code Review) 08 Oct '18

08 Oct '18

Daniel Kurtz has posted comments on this change. ( https://review.coreboot.org/28967 ) Change subject: mainboard/google/kahlee: Set PSPP setting to BalancedHigh ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/28967 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibf64d7b8e58e60ce931ddc85f11b135708cdb1ee Gerrit-Change-Number: 28967 Gerrit-PatchSet: 1 Gerrit-Owner: Akshu Agrawal <akshu.agrawal(a)amd.com> Gerrit-Reviewer: Akshu Agrawal <akshu.agrawal(a)amd.com> Gerrit-Reviewer: Daniel Kurtz <djkurtz(a)google.com> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Kevin Chiu <Kevin.Chiu(a)quantatw.com> Gerrit-Comment-Date: Mon, 08 Oct 2018 15:42:47 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit October 2018