coreboot-gerrit October 2018

coreboot-gerrit@coreboot.org

1 participants
1285 discussions

Change in coreboot[master]: nb/i945: Check if IGD is enabled before R/W to dev(0, 2)
by Elyes HAOUAS (Code Review) 08 Oct '18

08 Oct '18

Elyes HAOUAS has posted comments on this change. ( https://review.coreboot.org/28935 ) Change subject: nb/i945: Check if IGD is enabled before R/W to dev(0, 2) ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/#/c/28935/1/src/northbridge/intel/i945/raminit.c File src/northbridge/intel/i945/raminit.c: https://review.coreboot.org/#/c/28935/1/src/northbridge/intel/i945/raminit.… PS1, Line 2764: pci_read_config8(PCI_DEV(0, 0x0, 0), DEVEN) & : (DEVEN_D2F0 | DEVEN_D2F1) > Sorry i945_setup_pci_express_x16() is the wrong function for the […] I'm using i945_setup_pci_express_x16() for desktop version. ATI pcie card needs this function, but seems that nvidia don't (see https://review.coreboot.org/#/c/coreboot/+/27985/ comment in "Patch Set 3" ): "Arthur Heymans - Aug 10 6:27 PM Patch Set 3: So from tests it looks like the datasheet is right when it says PEG and the IGD are mutually exclusive. The best thing to do is to make sure i945_setup_pci_express_x16() works fine for 945GC (iirc it messed up nvidia cards)" -- To view, visit https://review.coreboot.org/28935 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I51ab94393710ce0222b353ab0cef28621fafaacf Gerrit-Change-Number: 28935 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Mon, 08 Oct 2018 15:36:45 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: nb/i945: Check if IGD is enabled before R/W to dev(0, 2)
by Nico Huber (Code Review) 08 Oct '18

08 Oct '18

Nico Huber has posted comments on this change. ( https://review.coreboot.org/28935 ) Change subject: nb/i945: Check if IGD is enabled before R/W to dev(0, 2) ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/#/c/28935/1/src/northbridge/intel/i945/raminit.c File src/northbridge/intel/i945/raminit.c: https://review.coreboot.org/#/c/28935/1/src/northbridge/intel/i945/raminit.… PS1, Line 2764: pci_read_config8(PCI_DEV(0, 0x0, 0), DEVEN) & : (DEVEN_D2F0 | DEVEN_D2F1) > And what I was trying to explain is: This code here runs *before* the […] Sorry i945_setup_pci_express_x16() is the wrong function for the desktop version. But still, I think for that it's disabled even later (in ramstage?). -- To view, visit https://review.coreboot.org/28935 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I51ab94393710ce0222b353ab0cef28621fafaacf Gerrit-Change-Number: 28935 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Mon, 08 Oct 2018 14:20:03 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: nb/i945: Check if IGD is enabled before R/W to dev(0, 2)
by Nico Huber (Code Review) 08 Oct '18

08 Oct '18

Nico Huber has posted comments on this change. ( https://review.coreboot.org/28935 ) Change subject: nb/i945: Check if IGD is enabled before R/W to dev(0, 2) ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/#/c/28935/1/src/northbridge/intel/i945/raminit.c File src/northbridge/intel/i945/raminit.c: https://review.coreboot.org/#/c/28935/1/src/northbridge/intel/i945/raminit.… PS1, Line 2764: pci_read_config8(PCI_DEV(0, 0x0, 0), DEVEN) & : (DEVEN_D2F0 | DEVEN_D2F1) > what I'm trying to explain is : […] And what I was trying to explain is: This code here runs *before* the code in i945_setup_pci_express_x16(). So the IGD can't be disabled yet. -- To view, visit https://review.coreboot.org/28935 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I51ab94393710ce0222b353ab0cef28621fafaacf Gerrit-Change-Number: 28935 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Mon, 08 Oct 2018 14:17:33 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: lenovo/x230: introduce FHD variant
by Angel Pons (Code Review) 08 Oct '18

08 Oct '18

Angel Pons has posted comments on this change. ( https://review.coreboot.org/28950 ) Change subject: lenovo/x230: introduce FHD variant ...................................................................... Patch Set 3: > Patch Set 3: > > > Patch Set 3: Code-Review+1 > > > > I might be bikeshedding, but I think the folder name "x230fhd" is a bit hard to read. I'd use "x230-fhd" or "x230_fhd" instead, just like the macro names and topic on gerrit. > > I would then rename it to oem and fhd as variant "x230-stock" and "x230-fhd" seem good to me. -- To view, visit https://review.coreboot.org/28950 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0355d39a61956792e69bccd5274cfc2749d72bf0 Gerrit-Change-Number: 28950 Gerrit-PatchSet: 3 Gerrit-Owner: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Tom Hiller <thrilleratplay(a)gmail.com> Gerrit-Comment-Date: Mon, 08 Oct 2018 14:01:48 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: No need to include acpi_tables.c to Makefiles
by Angel Pons (Code Review) 08 Oct '18

08 Oct '18

Angel Pons has posted comments on this change. ( https://review.coreboot.org/28954 ) Change subject: No need to include acpi_tables.c to Makefiles ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/28954 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If17a6f43e368ccf850031b349714fa1ec4d02c1d Gerrit-Change-Number: 28954 Gerrit-PatchSet: 1 Gerrit-Owner: Peter Lemenkov <lemenkov(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 08 Oct 2018 13:45:49 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: Unify all Lenovo t520 variants
by Peter Lemenkov (Code Review) 08 Oct '18

08 Oct '18

Peter Lemenkov has abandoned this change. ( https://review.coreboot.org/28936 ) Change subject: Unify all Lenovo t520 variants ...................................................................... Abandoned Will propose it differently (as a set of smaller independent patches). -- To view, visit https://review.coreboot.org/28936 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: abandon Gerrit-Change-Id: I936ec6e51dc74637439d8562070443904071708c Gerrit-Change-Number: 28936 Gerrit-PatchSet: 2 Gerrit-Owner: Peter Lemenkov <lemenkov(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Peter Lemenkov <lemenkov(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Patrick Rudolph <siro(a)das-labor.org>

1 0

Change in coreboot[master]: Unify all Lenovo t520 variants
by Peter Lemenkov (Code Review) 08 Oct '18

08 Oct '18

Peter Lemenkov has posted comments on this change. ( https://review.coreboot.org/28936 ) Change subject: Unify all Lenovo t520 variants ...................................................................... Patch Set 2: Code-Review-1 Patrick, thanks for pointing out on this. Please hold on - I'll split this patch into smaller ones and resubmit later (few days or something). -- To view, visit https://review.coreboot.org/28936 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I936ec6e51dc74637439d8562070443904071708c Gerrit-Change-Number: 28936 Gerrit-PatchSet: 2 Gerrit-Owner: Peter Lemenkov <lemenkov(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Peter Lemenkov <lemenkov(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Mon, 08 Oct 2018 10:23:53 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: src: Standardize PCI_DEV(0, 0x1f, 0) name
by Elyes HAOUAS (Code Review) 08 Oct '18

08 Oct '18

Elyes HAOUAS has abandoned this change. ( https://review.coreboot.org/28956 ) Change subject: src: Standardize PCI_DEV(0, 0x1f, 0) name ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/28956 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: abandon Gerrit-Change-Id: I0be00e5e9c733bbeb863250bd51eea8d33f54300 Gerrit-Change-Number: 28956 Gerrit-PatchSet: 5 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin Roth <martinroth(a)google.com> Gerrit-CC: Patrick Rudolph <siro(a)das-labor.org>

1 0

Change in coreboot[master]: src/mainboard: Use macro instead of "PCI_DEV(0, 0x1f, 0)"
by Elyes HAOUAS (Code Review) 08 Oct '18

08 Oct '18

Elyes HAOUAS has abandoned this change. ( https://review.coreboot.org/28957 ) Change subject: src/mainboard: Use macro instead of "PCI_DEV(0, 0x1f, 0)" ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/28957 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: abandon Gerrit-Change-Id: I7e340d42cc9498740fa7158f76472e26b5509695 Gerrit-Change-Number: 28957 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Patrick Rudolph <siro(a)das-labor.org>

1 0

Change in coreboot[master]: nb/i945: Check if IGD is enabled before R/W to dev(0, 2)
by Elyes HAOUAS (Code Review) 08 Oct '18

08 Oct '18

Elyes HAOUAS has abandoned this change. ( https://review.coreboot.org/28935 ) Change subject: nb/i945: Check if IGD is enabled before R/W to dev(0, 2) ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/28935 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: abandon Gerrit-Change-Id: I51ab94393710ce0222b353ab0cef28621fafaacf Gerrit-Change-Number: 28935 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com>

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit October 2018