Martin Roth has posted comments on this change. ( https://review.coreboot.org/29065 )
Change subject: cpu/amd: Use common AMD's MSR
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/#/c/29065/4/src/include/cpu/amd/msr.h
File src/include/cpu/amd/msr.h:
https://review.coreboot.org/#/c/29065/4/src/include/cpu/amd/msr.h@29
PS4, Line 29: 5
> Extra 5 at the end.
You caught it at the same time.
--
To view, visit https://review.coreboot.org/29065
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0236e0960cd1e79558ea50c814e1de2830aa0550
Gerrit-Change-Number: 29065
Gerrit-PatchSet: 4
Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Richard Spiegel <richard.spiegel(a)silverbackltd.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Marc Jones <marc(a)marcjonesconsulting.com>
Gerrit-Comment-Date: Fri, 12 Oct 2018 16:04:57 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
Martin Roth has posted comments on this change. ( https://review.coreboot.org/29069 )
Change subject: mb: Replace MSR addresses with macros
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://review.coreboot.org/29069
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I020431ba8eb61f5ce256088b919c049985331d64
Gerrit-Change-Number: 29069
Gerrit-PatchSet: 2
Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Fri, 12 Oct 2018 16:04:12 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: Yes
Martin Roth has posted comments on this change. ( https://review.coreboot.org/29065 )
Change subject: cpu/amd: Use common AMD's MSR
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/#/c/29065/4/src/include/cpu/amd/msr.h
File src/include/cpu/amd/msr.h:
https://review.coreboot.org/#/c/29065/4/src/include/cpu/amd/msr.h@29
PS4, Line 29: 5
Extra 5 at the end.
--
To view, visit https://review.coreboot.org/29065
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0236e0960cd1e79558ea50c814e1de2830aa0550
Gerrit-Change-Number: 29065
Gerrit-PatchSet: 4
Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Marc Jones <marc(a)marcjonesconsulting.com>
Gerrit-Comment-Date: Fri, 12 Oct 2018 15:55:15 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
Hello Marshall Dawson, build bot (Jenkins), Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/29065
to look at the new patch set (#5).
Change subject: cpu/amd: Use common AMD's MSR
......................................................................
cpu/amd: Use common AMD's MSR
Change-Id: I0236e0960cd1e79558ea50c814e1de2830aa0550
Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr>
---
M src/cpu/amd/agesa/family12/model_12_init.c
M src/cpu/amd/agesa/family14/model_14_init.c
M src/cpu/amd/agesa/family15tn/model_15_init.c
M src/cpu/amd/agesa/family16kb/model_16_init.c
M src/cpu/amd/car/disable_cache_as_ram.c
M src/cpu/amd/family_10h-family_15h/model_10xxx_init.c
M src/cpu/amd/pi/00630F01/model_15_init.c
M src/cpu/amd/pi/00660F01/model_15_init.c
M src/cpu/amd/pi/00730F01/model_16_init.c
M src/include/cpu/amd/amdfam12.h
M src/include/cpu/amd/amdfam14.h
M src/include/cpu/amd/amdfam15.h
M src/include/cpu/amd/amdfam16.h
M src/include/cpu/amd/msr.h
M src/soc/amd/stoneyridge/cpu.c
M src/soc/amd/stoneyridge/finalize.c
M src/soc/amd/stoneyridge/ramtop.c
17 files changed, 47 insertions(+), 84 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/65/29065/5
--
To view, visit https://review.coreboot.org/29065
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I0236e0960cd1e79558ea50c814e1de2830aa0550
Gerrit-Change-Number: 29065
Gerrit-PatchSet: 5
Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Marc Jones <marc(a)marcjonesconsulting.com>
Marc Jones has posted comments on this change. ( https://review.coreboot.org/29071 )
Change subject: soc/amd/stoneyridge: Cleanup procedure pci_ehci_dbg_dev()
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/29071
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I95eb2b7be53efe6a7cedf9a2a515d608f2643cf7
Gerrit-Change-Number: 29071
Gerrit-PatchSet: 1
Gerrit-Owner: Richard Spiegel <richard.spiegel(a)silverbackltd.com>
Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Richard Spiegel <richard.spiegel(a)silverbackltd.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Fri, 12 Oct 2018 15:44:38 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: Yes
Hello build bot (Jenkins), Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/29065
to look at the new patch set (#4).
Change subject: cpu/amd: Use common AMD's MSR
......................................................................
cpu/amd: Use common AMD's MSR
Change-Id: I0236e0960cd1e79558ea50c814e1de2830aa0550
Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr>
---
M src/cpu/amd/agesa/family12/model_12_init.c
M src/cpu/amd/agesa/family14/model_14_init.c
M src/cpu/amd/agesa/family15tn/model_15_init.c
M src/cpu/amd/agesa/family16kb/model_16_init.c
M src/cpu/amd/car/disable_cache_as_ram.c
M src/cpu/amd/family_10h-family_15h/model_10xxx_init.c
M src/cpu/amd/pi/00630F01/model_15_init.c
M src/cpu/amd/pi/00660F01/model_15_init.c
M src/cpu/amd/pi/00730F01/model_16_init.c
M src/include/cpu/amd/amdfam12.h
M src/include/cpu/amd/amdfam14.h
M src/include/cpu/amd/amdfam15.h
M src/include/cpu/amd/amdfam16.h
M src/include/cpu/amd/msr.h
M src/soc/amd/stoneyridge/cpu.c
M src/soc/amd/stoneyridge/finalize.c
M src/soc/amd/stoneyridge/ramtop.c
17 files changed, 48 insertions(+), 85 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/65/29065/4
--
To view, visit https://review.coreboot.org/29065
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I0236e0960cd1e79558ea50c814e1de2830aa0550
Gerrit-Change-Number: 29065
Gerrit-PatchSet: 4
Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Hello build bot (Jenkins), Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/29069
to look at the new patch set (#2).
Change subject: mb: Replace MSR addresses with macros
......................................................................
mb: Replace MSR addresses with macros
Change-Id: I020431ba8eb61f5ce256088b919c049985331d64
Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr>
---
M src/mainboard/amd/thatcher/mainboard.c
M src/mainboard/asus/f2a85-m/mainboard.c
M src/mainboard/msi/ms7721/mainboard.c
3 files changed, 21 insertions(+), 18 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/29069/2
--
To view, visit https://review.coreboot.org/29069
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I020431ba8eb61f5ce256088b919c049985331d64
Gerrit-Change-Number: 29069
Gerrit-PatchSet: 2
Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/29009 )
Change subject: amd/stoneyridge: Convert hex definitions to lower case
......................................................................
Patch Set 2:
(1 comment)
I'll work this.
https://review.coreboot.org/#/c/29009/1/src/soc/amd/stoneyridge/enable_usbd…
File src/soc/amd/stoneyridge/enable_usbdebug.c:
https://review.coreboot.org/#/c/29009/1/src/soc/amd/stoneyridge/enable_usbd…
PS1, Line 32: return PCI_DEV(0, 0x16, 0);
: else if (hcd_idx == 2)
: return PCI_DEV(0, 0x13, 0);
> I don't think these two exist on stoney.
You are correct, just checked with pci_list on my grunt.
--
To view, visit https://review.coreboot.org/29009
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4531e6dad0362be73499647d9fc93c168b6f163e
Gerrit-Change-Number: 29009
Gerrit-PatchSet: 2
Gerrit-Owner: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Richard Spiegel <richard.spiegel(a)silverbackltd.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Fri, 12 Oct 2018 15:23:06 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No