Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/29033 )
Change subject: mb/lenovo/*/smihandler: Remove some unused includes
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit https://review.coreboot.org/29033
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I385cac1a75cee13453b831bd75b3ecc7a6d229fa
Gerrit-Change-Number: 29033
Gerrit-PatchSet: 4
Gerrit-Owner: Peter Lemenkov <lemenkov(a)gmail.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Fri, 12 Oct 2018 11:39:36 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: Yes
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/28954 )
Change subject: mb/*/*/Makefile.inc: No need to include acpi_tables.c to Makefiles
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://review.coreboot.org/28954
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If17a6f43e368ccf850031b349714fa1ec4d02c1d
Gerrit-Change-Number: 28954
Gerrit-PatchSet: 2
Gerrit-Owner: Peter Lemenkov <lemenkov(a)gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Fri, 12 Oct 2018 11:36:00 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: Yes
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/29070 )
Change subject: mb/lenovo/*/dsdt: Remove HAVE_LCD_SCREEN
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/29070
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifbb62441e16e97c0cae0713968844e296619a880
Gerrit-Change-Number: 29070
Gerrit-PatchSet: 1
Gerrit-Owner: Peter Lemenkov <lemenkov(a)gmail.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Fri, 12 Oct 2018 11:34:30 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: Yes
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/29064 )
Change subject: mb/lenovo/*/acpi: Store the requested state wake state for bluetooth and WWAN.
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/29064
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib177f024871e82979dd430da86f1551aef14d446
Gerrit-Change-Number: 29064
Gerrit-PatchSet: 1
Gerrit-Owner: Peter Lemenkov <lemenkov(a)gmail.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Fri, 12 Oct 2018 11:33:43 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: Yes
Peter Lemenkov has uploaded this change for review. ( https://review.coreboot.org/29068
Change subject: mb/lenovo/x60/dsdt: Remove unused include
......................................................................
mb/lenovo/x60/dsdt: Remove unused include
Tested - still builds fine with this patch.
Change-Id: I4666a8c9dd0e03ee32770844019dfc032e07e460
Signed-off-by: Peter Lemenkov <lemenkov(a)gmail.com>
---
M src/mainboard/lenovo/x60/dsdt.asl
1 file changed, 0 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/68/29068/1
diff --git a/src/mainboard/lenovo/x60/dsdt.asl b/src/mainboard/lenovo/x60/dsdt.asl
index 3222303..d4f4668 100644
--- a/src/mainboard/lenovo/x60/dsdt.asl
+++ b/src/mainboard/lenovo/x60/dsdt.asl
@@ -14,8 +14,6 @@
* GNU General Public License for more details.
*/
-#include "smi.h"
-
#define THINKPAD_EC_GPE 28
#define BRIGHTNESS_UP \_SB.PCI0.GFX0.INCB
#define BRIGHTNESS_DOWN \_SB.PCI0.GFX0.DECB
--
To view, visit https://review.coreboot.org/29068
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4666a8c9dd0e03ee32770844019dfc032e07e460
Gerrit-Change-Number: 29068
Gerrit-PatchSet: 1
Gerrit-Owner: Peter Lemenkov <lemenkov(a)gmail.com>
Hello build bot (Jenkins), Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/29065
to look at the new patch set (#3).
Change subject: cpu/amd: Use common AMD's MSR
......................................................................
cpu/amd: Use common AMD's MSR
Change-Id: I0236e0960cd1e79558ea50c814e1de2830aa0550
Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr>
---
M src/cpu/amd/agesa/family12/model_12_init.c
M src/cpu/amd/agesa/family14/model_14_init.c
M src/cpu/amd/agesa/family15tn/model_15_init.c
M src/cpu/amd/agesa/family16kb/model_16_init.c
M src/cpu/amd/car/disable_cache_as_ram.c
M src/cpu/amd/family_10h-family_15h/model_10xxx_init.c
M src/cpu/amd/pi/00630F01/model_15_init.c
M src/cpu/amd/pi/00660F01/model_15_init.c
M src/cpu/amd/pi/00730F01/model_16_init.c
M src/include/cpu/amd/amdfam12.h
M src/include/cpu/amd/amdfam14.h
M src/include/cpu/amd/amdfam15.h
M src/include/cpu/amd/amdfam16.h
M src/include/cpu/amd/msr.h
M src/soc/amd/stoneyridge/cpu.c
M src/soc/amd/stoneyridge/finalize.c
M src/soc/amd/stoneyridge/ramtop.c
17 files changed, 46 insertions(+), 72 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/65/29065/3
--
To view, visit https://review.coreboot.org/29065
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I0236e0960cd1e79558ea50c814e1de2830aa0550
Gerrit-Change-Number: 29065
Gerrit-PatchSet: 3
Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Elyes HAOUAS has posted comments on this change. ( https://review.coreboot.org/29065 )
Change subject: cpu/amd: Use common AMD's MSR
......................................................................
Set Ready For Review
--
To view, visit https://review.coreboot.org/29065
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0236e0960cd1e79558ea50c814e1de2830aa0550
Gerrit-Change-Number: 29065
Gerrit-PatchSet: 2
Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Fri, 12 Oct 2018 09:46:57 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No