Martin Roth has posted comments on this change. ( https://review.coreboot.org/29009 )
Change subject: amd/stoneyridge: Convert hex definitions to lower case
......................................................................
Patch Set 1:
(2 comments)
A couple of comments unrelated to this change.
https://review.coreboot.org/#/c/29009/1/src/soc/amd/stoneyridge/enable_usbd…
File src/soc/amd/stoneyridge/enable_usbdebug.c:
https://review.coreboot.org/#/c/29009/1/src/soc/amd/stoneyridge/enable_usbd…
PS1, Line 32: return PCI_DEV(0, 0x16, 0);
: else if (hcd_idx == 2)
: return PCI_DEV(0, 0x13, 0);
I don't think these two exist on stoney.
https://review.coreboot.org/#/c/29009/1/src/soc/amd/stoneyridge/enable_usbd…
PS1, Line 36: PCI_DEV(0, 0x12, 0)
SOC_EHCI1_DEV
--
To view, visit https://review.coreboot.org/29009
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4531e6dad0362be73499647d9fc93c168b6f163e
Gerrit-Change-Number: 29009
Gerrit-PatchSet: 1
Gerrit-Owner: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: Richard Spiegel <richard.spiegel(a)silverbackltd.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Martin Roth <martinroth(a)google.com>
Gerrit-Comment-Date: Fri, 12 Oct 2018 15:13:28 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
Martin Roth has submitted this change and it was merged. ( https://review.coreboot.org/29008 )
Change subject: amd/stoneyridge: Remove hudson register definitions
......................................................................
amd/stoneyridge: Remove hudson register definitions
Delete artifacts remaining from the original "hudson" and "yangtze"
controller hub designs.
Husdon devices had a configurable AcpiMmio base address, and a selection
for I/O vs. MMIO decode. Modern products are fixed at 0xfed80000 in MMIO.
Remove the flash control register definitions for the old generations.
The manual reset register appears to not function as hudson.
PMIO_DEBUG is named differently now, and not used, so remove its
definition too.
Change-Id: I6484bb2ca80b65318565dfee1a3368b121aea9de
Signed-off-by: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Reviewed-on: https://review.coreboot.org/29008
Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org>
Reviewed-by: Richard Spiegel <richard.spiegel(a)silverbackltd.com>
---
M src/soc/amd/stoneyridge/include/soc/southbridge.h
1 file changed, 0 insertions(+), 5 deletions(-)
Approvals:
build bot (Jenkins): Verified
Richard Spiegel: Looks good to me, approved
diff --git a/src/soc/amd/stoneyridge/include/soc/southbridge.h b/src/soc/amd/stoneyridge/include/soc/southbridge.h
index a3c4c7c..e7a8cc3 100644
--- a/src/soc/amd/stoneyridge/include/soc/southbridge.h
+++ b/src/soc/amd/stoneyridge/include/soc/southbridge.h
@@ -40,7 +40,6 @@
#define PM_PCI_CTRL 0x08
#define FORCE_SLPSTATE_RETRY BIT(25)
#define FORCE_STPCLK_RETRY BIT(24)
-#define PM_ACPI_MMIO_EN 0x24
#define PM_SERIRQ_CONF 0x54
#define PM_SERIRQ_NUM_BITS_17 0x0000
#define PM_SERIRQ_NUM_BITS_18 0x0004
@@ -92,10 +91,6 @@
#define PM_RST_CTRL1 0xbe
#define SLPTYPE_CONTROL_EN BIT(5)
#define PM_RST_STATUS 0xc0
-#define PM_PMIO_DEBUG 0xd2
-#define PM_MANUAL_RESET 0xd3
-#define PM_HUD_SD_FLASH_CTRL 0xe7
-#define PM_YANG_SD_FLASH_CTRL 0xe8
#define PM_PCIB_CFG 0xea
#define PM_GENINT_DISABLE BIT(0)
#define PM_LPC_GATING 0xec
--
To view, visit https://review.coreboot.org/29008
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I6484bb2ca80b65318565dfee1a3368b121aea9de
Gerrit-Change-Number: 29008
Gerrit-PatchSet: 2
Gerrit-Owner: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Richard Spiegel <richard.spiegel(a)silverbackltd.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>