Philipp Deppenwiese has submitted this change and it was merged. ( https://review.coreboot.org/28593 )
Change subject: drivers/intel/fsp2_0: Hook up IntelFSP repo
......................................................................
drivers/intel/fsp2_0: Hook up IntelFSP repo
With https://github.com/IntelFsp/FSP/pull/4 merged, this allows using
Intel's FSP repo (that we mirror) to build a complete BIOS ifd region
with a simple coreboot build, automatically drawing in headers and
binaries.
This commit covers Apollolake, Coffeelake, Skylake, and Kabylake.
Skylake is using Kabylake's FSP since its own is FSP 1.1 and Kabylake's
also supports Skylake.
Another candidate (given 3rdparty/fsp's content) is Denverton NS, but
it requires changes to coreboot's FSP bindings to become compatible.
Cannonlake, Whiskeylake require an FSP release.
Change-Id: I8d838ca6555348ce877f54e95907e9fdf6b9f2e7
Signed-off-by: Patrick Georgi <pgeorgi(a)google.com>
Reviewed-on: https://review.coreboot.org/28593
Reviewed-by: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com>
Reviewed-by: Naresh Solanki <naresh.solanki(a)intel.com>
Reviewed-by: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com>
Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org>
---
M src/drivers/intel/fsp2_0/Kconfig
M src/drivers/intel/fsp2_0/Makefile.inc
M src/soc/intel/apollolake/Kconfig
M src/soc/intel/apollolake/Makefile.inc
M src/soc/intel/cannonlake/Kconfig
M src/soc/intel/cannonlake/Makefile.inc
M src/soc/intel/skylake/Kconfig
M src/soc/intel/skylake/Makefile.inc
D src/vendorcode/intel/fsp/fsp2_0/apollolake/FspUpd.h
D src/vendorcode/intel/fsp/fsp2_0/apollolake/FspmUpd.h
D src/vendorcode/intel/fsp/fsp2_0/apollolake/FspsUpd.h
D src/vendorcode/intel/fsp/fsp2_0/coffeelake/FirmwareVersionInfoHob.h
D src/vendorcode/intel/fsp/fsp2_0/coffeelake/FspUpd.h
D src/vendorcode/intel/fsp/fsp2_0/coffeelake/FspmUpd.h
D src/vendorcode/intel/fsp/fsp2_0/coffeelake/FspsUpd.h
D src/vendorcode/intel/fsp/fsp2_0/coffeelake/FsptUpd.h
D src/vendorcode/intel/fsp/fsp2_0/coffeelake/MemInfoHob.h
D src/vendorcode/intel/fsp/fsp2_0/skykabylake/ConfigBlock/CpuConfigFspData.h
D src/vendorcode/intel/fsp/fsp2_0/skykabylake/FspUpd.h
D src/vendorcode/intel/fsp/fsp2_0/skykabylake/FspmUpd.h
D src/vendorcode/intel/fsp/fsp2_0/skykabylake/FspsUpd.h
D src/vendorcode/intel/fsp/fsp2_0/skykabylake/MemInfoHob.h
22 files changed, 65 insertions(+), 14,250 deletions(-)
Approvals:
build bot (Jenkins): Verified
Philipp Deppenwiese: Looks good to me, approved
Naresh Solanki: Looks good to me, approved
Pratikkumar V Prajapati: Looks good to me, approved
--
To view, visit https://review.coreboot.org/28593
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I8d838ca6555348ce877f54e95907e9fdf6b9f2e7
Gerrit-Change-Number: 28593
Gerrit-PatchSet: 12
Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org>
Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com>
Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com>
Gerrit-Reviewer: Krystian Hebel (1002088)
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Naresh Solanki <naresh.solanki(a)intel.com>
Gerrit-Reviewer: Nathaniel L Desimone <nathaniel.l.desimone(a)intel.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com>
Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com>
Gerrit-Reviewer: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com>
Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/29053 )
Change subject: soc/amd: Implement common reset API
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit https://review.coreboot.org/29053
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id33eda676d79529db759b85fa8e28386846e6fa4
Gerrit-Change-Number: 29053
Gerrit-PatchSet: 3
Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: Richard Spiegel <richard.spiegel(a)silverbackltd.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Marc Jones <marc(a)marcjonesconsulting.com>
Gerrit-Comment-Date: Fri, 12 Oct 2018 21:03:22 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: Yes
Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/29065 )
Change subject: cpu/amd: Use common AMD's MSR
......................................................................
Patch Set 9: Code-Review+2
--
To view, visit https://review.coreboot.org/29065
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0236e0960cd1e79558ea50c814e1de2830aa0550
Gerrit-Change-Number: 29065
Gerrit-PatchSet: 9
Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr>
Gerrit-Reviewer: Elyes HAOUAS <ehaouas(a)noos.fr>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Richard Spiegel <richard.spiegel(a)silverbackltd.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Marc Jones <marc(a)marcjonesconsulting.com>
Gerrit-Comment-Date: Fri, 12 Oct 2018 20:53:07 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: Yes
Nico Huber has uploaded a new patch set (#2). ( https://review.coreboot.org/29077 )
Change subject: security/vboot: Drop `depends on HAVE_HARD_RESET`
......................................................................
security/vboot: Drop `depends on HAVE_HARD_RESET`
While this is true in theory, Kconfig gets completely messed up by it:
The `config VBOOT` is redefined all over the place in different Kconfig
files. Thus, having a `depends on` here, only hides this single defini-
tion and the other (incomplete) definitions take over and break the
build.
v2: Use `depends on y` instead to override the implicit dependencies of
earlier, spurious definitions. Also tell people to clean their mess
up.
Change-Id: Ib0e0bcf7d5a662a526ce20f0a6d9cfeb8fafe7fe
Signed-off-by: Nico Huber <nico.h(a)gmx.de>
---
M src/mainboard/google/auron/Kconfig
M src/mainboard/google/beltino/Kconfig
M src/mainboard/google/butterfly/Kconfig
M src/mainboard/google/cheza/Kconfig
M src/mainboard/google/cyan/Kconfig
M src/mainboard/google/daisy/Kconfig
M src/mainboard/google/eve/Kconfig
M src/mainboard/google/fizz/Kconfig
M src/mainboard/google/foster/Kconfig
M src/mainboard/google/gale/Kconfig
M src/mainboard/google/glados/Kconfig
M src/mainboard/google/gru/Kconfig
M src/mainboard/google/jecht/Kconfig
M src/mainboard/google/kahlee/Kconfig
M src/mainboard/google/kukui/Kconfig
M src/mainboard/google/link/Kconfig
M src/mainboard/google/nyan/Kconfig
M src/mainboard/google/nyan_big/Kconfig
M src/mainboard/google/nyan_blaze/Kconfig
M src/mainboard/google/oak/Kconfig
M src/mainboard/google/parrot/Kconfig
M src/mainboard/google/peach_pit/Kconfig
M src/mainboard/google/poppy/Kconfig
M src/mainboard/google/purin/Kconfig
M src/mainboard/google/rambi/Kconfig
M src/mainboard/google/reef/Kconfig
M src/mainboard/google/slippy/Kconfig
M src/mainboard/google/smaug/Kconfig
M src/mainboard/google/storm/Kconfig
M src/mainboard/google/stout/Kconfig
M src/mainboard/google/veyron/Kconfig
M src/mainboard/google/veyron_mickey/Kconfig
M src/mainboard/google/veyron_rialto/Kconfig
M src/mainboard/google/zoombini/Kconfig
M src/mainboard/intel/baskingridge/Kconfig
M src/mainboard/intel/cannonlake_rvp/Kconfig
M src/mainboard/intel/coffeelake_rvp/Kconfig
M src/mainboard/intel/emeraldlake2/Kconfig
M src/mainboard/intel/glkrvp/Kconfig
M src/mainboard/intel/kblrvp/Kconfig
M src/mainboard/intel/kunimitsu/Kconfig
M src/mainboard/intel/strago/Kconfig
M src/mainboard/intel/wtm2/Kconfig
M src/mainboard/opencellular/elgon/Kconfig
M src/mainboard/opencellular/rotundu/Kconfig
M src/mainboard/samsung/lumpy/Kconfig
M src/mainboard/samsung/stumpy/Kconfig
M src/northbridge/intel/haswell/Kconfig
M src/northbridge/intel/sandybridge/Kconfig
M src/security/vboot/Kconfig
M src/soc/amd/stoneyridge/Kconfig
M src/soc/broadcom/cygnus/Kconfig
M src/soc/cavium/cn81xx/Kconfig
M src/soc/intel/apollolake/Kconfig
M src/soc/intel/baytrail/Kconfig
M src/soc/intel/braswell/Kconfig
M src/soc/intel/broadwell/Kconfig
M src/soc/intel/cannonlake/Kconfig
M src/soc/intel/fsp_baytrail/Kconfig
M src/soc/intel/skylake/Kconfig
M src/soc/mediatek/mt8173/Kconfig
M src/soc/mediatek/mt8183/Kconfig
M src/soc/nvidia/tegra124/Kconfig
M src/soc/nvidia/tegra210/Kconfig
M src/soc/qualcomm/ipq40xx/Kconfig
M src/soc/qualcomm/ipq806x/Kconfig
M src/soc/qualcomm/sdm845/Kconfig
M src/soc/rockchip/rk3288/Kconfig
M src/soc/rockchip/rk3399/Kconfig
M src/soc/samsung/exynos5250/Kconfig
M src/soc/samsung/exynos5420/Kconfig
71 files changed, 141 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/77/29077/2
--
To view, visit https://review.coreboot.org/29077
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib0e0bcf7d5a662a526ce20f0a6d9cfeb8fafe7fe
Gerrit-Change-Number: 29077
Gerrit-PatchSet: 2
Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>
Nico Huber has uploaded this change for review. ( https://review.coreboot.org/29077
Change subject: security/vboot: Drop `depends on HAVE_HARD_RESET`
......................................................................
security/vboot: Drop `depends on HAVE_HARD_RESET`
While this is true in theory, Kconfig gets completely messed up by it:
The `config VBOOT` is redefined all over the place in different Kconfig
files. Thus, having a `depends on` here, only hides this single defini-
tion and the other (incomplete) definitions take over and break the
build.
Change-Id: Ib0e0bcf7d5a662a526ce20f0a6d9cfeb8fafe7fe
Signed-off-by: Nico Huber <nico.h(a)gmx.de>
---
M src/security/vboot/Kconfig
1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/77/29077/1
diff --git a/src/security/vboot/Kconfig b/src/security/vboot/Kconfig
index e13101b..0509520 100644
--- a/src/security/vboot/Kconfig
+++ b/src/security/vboot/Kconfig
@@ -18,7 +18,6 @@
bool "Verify firmware with vboot."
default n
select VBOOT_MOCK_SECDATA if !TPM1 && !TPM2
- depends on HAVE_HARD_RESET
help
Enabling VBOOT will use vboot to verify the components of the firmware
(stages, payload, etc).
--
To view, visit https://review.coreboot.org/29077
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib0e0bcf7d5a662a526ce20f0a6d9cfeb8fafe7fe
Gerrit-Change-Number: 29077
Gerrit-PatchSet: 1
Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/29059
to look at the new patch set (#2).
Change subject: reset: Final moves to new API
......................................................................
reset: Final moves to new API
Move soft_reset() to `southbridge/amd/common/` it's only used for
amdfam10 now.
Let common code call board_reset() instead of hard_reset() and drop
the latter for good.
Change-Id: Ifdc5791160653c5578007f6c1b96015efe2b3e1e
Signed-off-by: Nico Huber <nico.h(a)gmx.de>
---
M src/Kconfig
M src/cpu/amd/family_10h-family_15h/init_cpus.c
M src/device/root_device.c
M src/include/reset.h
M src/lib/prog_loaders.c
M src/lib/reset.c
M src/mainboard/advansus/a785e-i/romstage.c
M src/mainboard/amd/bimini_fam10/romstage.c
M src/mainboard/amd/mahogany_fam10/romstage.c
M src/mainboard/amd/tilapia_fam10/romstage.c
M src/mainboard/asus/kcma-d8/romstage.c
M src/mainboard/asus/kfsn4-dre/romstage.c
M src/mainboard/asus/kgpe-d16/romstage.c
M src/mainboard/asus/m4a78-em/romstage.c
M src/mainboard/asus/m4a785-m/romstage.c
M src/mainboard/asus/m5a88-v/romstage.c
M src/mainboard/avalue/eax-785e/romstage.c
M src/mainboard/gigabyte/ma785gm/romstage.c
M src/mainboard/gigabyte/ma785gmt/romstage.c
M src/mainboard/gigabyte/ma78gm/romstage.c
M src/mainboard/hp/dl165_g6_fam10/romstage.c
M src/mainboard/iei/kino-780am2-fam10/romstage.c
M src/mainboard/jetway/pa78vm5/romstage.c
M src/mainboard/msi/ms9652_fam10/romstage.c
M src/mainboard/supermicro/h8dmr_fam10/romstage.c
M src/mainboard/supermicro/h8qme_fam10/romstage.c
M src/mainboard/supermicro/h8scm_fam10/romstage.c
M src/mainboard/tyan/s2912_fam10/romstage.c
M src/northbridge/amd/amdmct/mct_ddr3/mct_d.c
M src/security/vboot/vboot_common.c
M src/southbridge/amd/amd8111/early_ctrl.c
A src/southbridge/amd/common/reset.h
M src/southbridge/amd/sb700/reset.c
M src/southbridge/amd/sb800/early_setup.c
M src/southbridge/amd/sr5650/early_setup.c
M src/southbridge/broadcom/bcm5785/early_setup.c
M src/southbridge/nvidia/ck804/early_setup.c
M src/southbridge/nvidia/ck804/early_setup_car.c
M src/southbridge/nvidia/mcp55/early_ctrl.c
M src/vendorcode/google/chromeos/watchdog.c
40 files changed, 72 insertions(+), 55 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/59/29059/2
--
To view, visit https://review.coreboot.org/29059
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ifdc5791160653c5578007f6c1b96015efe2b3e1e
Gerrit-Change-Number: 29059
Gerrit-PatchSet: 2
Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Richard Spiegel has abandoned this change. ( https://review.coreboot.org/29071 )
Change subject: soc/amd/stoneyridge: Cleanup procedure pci_ehci_dbg_dev()
......................................................................
Abandoned
Marshall implemented the same code.
--
To view, visit https://review.coreboot.org/29071
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: I95eb2b7be53efe6a7cedf9a2a515d608f2643cf7
Gerrit-Change-Number: 29071
Gerrit-PatchSet: 1
Gerrit-Owner: Richard Spiegel <richard.spiegel(a)silverbackltd.com>
Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Richard Spiegel <richard.spiegel(a)silverbackltd.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/29071 )
Change subject: soc/amd/stoneyridge: Cleanup procedure pci_ehci_dbg_dev()
......................................................................
Patch Set 1:
> Patch Set 1: Code-Review-1
>
> I don't believe your patch will work, and it looks to me like you couldn't possibly have built your change. I was already working on a stack when you pushed this. See my version at https://review.coreboot.org/#/c/coreboot/+/29074/
I build it, and so has Jenkins... but I believe I know what's wrong... I did not enabled USB debug, so this code was not compiled. Good catch, I needed to include pci_devs.h
--
To view, visit https://review.coreboot.org/29071
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I95eb2b7be53efe6a7cedf9a2a515d608f2643cf7
Gerrit-Change-Number: 29071
Gerrit-PatchSet: 1
Gerrit-Owner: Richard Spiegel <richard.spiegel(a)silverbackltd.com>
Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Richard Spiegel <richard.spiegel(a)silverbackltd.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Fri, 12 Oct 2018 18:24:33 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No