coreboot-gerrit October 2018

coreboot-gerrit@coreboot.org

1 participants
1285 discussions

Change in coreboot[master]: This patch fixes Klockwork issues due to the possibility of a NULL po...
by Jonathan Neuschäfer (Code Review) 19 Oct '18

19 Oct '18

Jonathan Neuschäfer has posted comments on this change. ( https://review.coreboot.org/29045 ) Change subject: This patch fixes Klockwork issues due to the possibility of a NULL pointer being dereferenced ...................................................................... Patch Set 2: Code-Review+1 (2 comments) https://review.coreboot.org/#/c/29045/2//COMMIT_MSG Commit Message: https://review.coreboot.org/#/c/29045/2//COMMIT_MSG@7 PS2, Line 7: This patch fixes Klockwork issues due to the possibility of a NULL pointer being dereferenced Please use a slightly shorter commit title, like "Fix potential NULL pointer dereferences reported by Klockwork" https://review.coreboot.org/#/c/29045/2/src/arch/x86/acpigen.c File src/arch/x86/acpigen.c: https://review.coreboot.org/#/c/29045/2/src/arch/x86/acpigen.c@289 PS2, Line 289: /* If we have an incoming NULL namepath Then we need to put a null Please use a comma (,) before "then", rather than spelling "then" in uppercase. -- To view, visit https://review.coreboot.org/29045 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ife366fcb9f8932b39f4a227082c1724e25aa83d1 Gerrit-Change-Number: 29045 Gerrit-PatchSet: 2 Gerrit-Owner: Francois Toguo Fotso <francois.toguo.fotso(a)intel.com> Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 18 Oct 2018 17:33:11 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: src/mainboard: Remove unneeded whitespace
by Patrick Georgi (Code Review) 19 Oct '18

19 Oct '18

Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/28979 ) Change subject: src/mainboard: Remove unneeded whitespace ...................................................................... src/mainboard: Remove unneeded whitespace Change-Id: Ibf23f49e7864c611a3cb32a91891b6023a692e1d Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> Reviewed-on: https://review.coreboot.org/28979 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Angel Pons <th3fanbus(a)gmail.com> Reviewed-by: Patrick Georgi <pgeorgi(a)google.com> --- M src/mainboard/asrock/g41c-gs/variants/g41m-gs/devicetree.cb M src/mainboard/asrock/g41c-gs/variants/g41m-s3/devicetree.cb M src/mainboard/asrock/g41c-gs/variants/g41m-vs3-r2/devicetree.cb M src/mainboard/google/cyan/acpi/touchscreen_elan.asl M src/mainboard/google/cyan/acpi/touchscreen_melfas.asl M src/mainboard/google/cyan/acpi/touchscreen_synaptics.asl 6 files changed, 6 insertions(+), 6 deletions(-) Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved Angel Pons: Looks good to me, but someone else must approve diff --git a/src/mainboard/asrock/g41c-gs/variants/g41m-gs/devicetree.cb b/src/mainboard/asrock/g41c-gs/variants/g41m-gs/devicetree.cb index f12a50b..d4708c6 100644 --- a/src/mainboard/asrock/g41c-gs/variants/g41m-gs/devicetree.cb +++ b/src/mainboard/asrock/g41c-gs/variants/g41m-gs/devicetree.cb @@ -104,7 +104,7 @@ device pnp 2e.6 off end # SPI device pnp 2e.7 off end # GPIO6 device pnp 2e.8 off end # WDT0#, PLED - device pnp 2e.9 on end # GPIO2 + device pnp 2e.9 on end # GPIO2 device pnp 2e.109 on # GPIO3 irq 0xfe = 0x07 end diff --git a/src/mainboard/asrock/g41c-gs/variants/g41m-s3/devicetree.cb b/src/mainboard/asrock/g41c-gs/variants/g41m-s3/devicetree.cb index 7b16cf0..cdcadba 100644 --- a/src/mainboard/asrock/g41c-gs/variants/g41m-s3/devicetree.cb +++ b/src/mainboard/asrock/g41c-gs/variants/g41m-s3/devicetree.cb @@ -113,7 +113,7 @@ device pnp 2e.6 off end # SPI device pnp 2e.7 off end # GPIO6 device pnp 2e.8 off end # WDT0#, PLED - device pnp 2e.9 on end # GPIO2 + device pnp 2e.9 on end # GPIO2 device pnp 2e.109 on # GPIO3 irq 0xfe = 0x07 end diff --git a/src/mainboard/asrock/g41c-gs/variants/g41m-vs3-r2/devicetree.cb b/src/mainboard/asrock/g41c-gs/variants/g41m-vs3-r2/devicetree.cb index 6e47ea9..4c910c5 100644 --- a/src/mainboard/asrock/g41c-gs/variants/g41m-vs3-r2/devicetree.cb +++ b/src/mainboard/asrock/g41c-gs/variants/g41m-vs3-r2/devicetree.cb @@ -103,7 +103,7 @@ device pnp 2e.6 off end # SPI device pnp 2e.7 off end # GPIO6 device pnp 2e.8 off end # WDT0#, PLED - device pnp 2e.9 on end # GPIO2 + device pnp 2e.9 on end # GPIO2 device pnp 2e.109 off end # GPIO3 device pnp 2e.209 on # GPIO4 irq 0xf4 = 0xb3 diff --git a/src/mainboard/google/cyan/acpi/touchscreen_elan.asl b/src/mainboard/google/cyan/acpi/touchscreen_elan.asl index cd67a0e..1fc362e 100644 --- a/src/mainboard/google/cyan/acpi/touchscreen_elan.asl +++ b/src/mainboard/google/cyan/acpi/touchscreen_elan.asl @@ -36,7 +36,7 @@ "\\_SB.PCI0.I2C1", /* ResourceSource */ ) GpioInt (Level, ActiveLow, ExclusiveAndWake, PullDefault,, - "\\_SB.GPNC") { BOARD_TOUCH_GPIO_INDEX } + "\\_SB.GPNC") { BOARD_TOUCH_GPIO_INDEX } } ) Return (BUF0) diff --git a/src/mainboard/google/cyan/acpi/touchscreen_melfas.asl b/src/mainboard/google/cyan/acpi/touchscreen_melfas.asl index 15b2237..e8bc0f2 100644 --- a/src/mainboard/google/cyan/acpi/touchscreen_melfas.asl +++ b/src/mainboard/google/cyan/acpi/touchscreen_melfas.asl @@ -36,7 +36,7 @@ "\\_SB.PCI0.I2C1", /* ResourceSource */ ) GpioInt (Level, ActiveLow, ExclusiveAndWake, PullDefault,, - "\\_SB.GPNC") { BOARD_TOUCH_GPIO_INDEX } + "\\_SB.GPNC") { BOARD_TOUCH_GPIO_INDEX } }) Return (BUF0) } diff --git a/src/mainboard/google/cyan/acpi/touchscreen_synaptics.asl b/src/mainboard/google/cyan/acpi/touchscreen_synaptics.asl index 1b10848..421119a 100644 --- a/src/mainboard/google/cyan/acpi/touchscreen_synaptics.asl +++ b/src/mainboard/google/cyan/acpi/touchscreen_synaptics.asl @@ -79,7 +79,7 @@ "\\_SB.PCI0.I2C1", /* ResourceSource */ ) GpioInt (Level, ActiveLow, ExclusiveAndWake, PullDefault,, - "\\_SB.GPNC") { BOARD_TOUCH_GPIO_INDEX } + "\\_SB.GPNC") { BOARD_TOUCH_GPIO_INDEX } }) Return (BUF0) } -- To view, visit https://review.coreboot.org/28979 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ibf23f49e7864c611a3cb32a91891b6023a692e1d Gerrit-Change-Number: 28979 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: src/mainboard: Remove unneeded whitespace
by Patrick Georgi (Code Review) 19 Oct '18

19 Oct '18

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/28979 ) Change subject: src/mainboard: Remove unneeded whitespace ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/28979 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibf23f49e7864c611a3cb32a91891b6023a692e1d Gerrit-Change-Number: 28979 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 18 Oct 2018 17:17:57 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: libpayload/curses/PDCurses/doc/intro.txt: Remove unneeded whitespace
by Patrick Georgi (Code Review) 19 Oct '18

19 Oct '18

Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/28432 ) Change subject: libpayload/curses/PDCurses/doc/intro.txt: Remove unneeded whitespace ...................................................................... libpayload/curses/PDCurses/doc/intro.txt: Remove unneeded whitespace Change-Id: Ib5a0f193d54d1b6f2431f7b801678f2a983c7941 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> Reviewed-on: https://review.coreboot.org/28432 Reviewed-by: Patrick Georgi <pgeorgi(a)google.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M payloads/libpayload/curses/PDCurses/doc/intro.txt 1 file changed, 57 insertions(+), 57 deletions(-) Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved diff --git a/payloads/libpayload/curses/PDCurses/doc/intro.txt b/payloads/libpayload/curses/PDCurses/doc/intro.txt index c0f80fe..d965328 100644 --- a/payloads/libpayload/curses/PDCurses/doc/intro.txt +++ b/payloads/libpayload/curses/PDCurses/doc/intro.txt @@ -129,7 +129,7 @@ A_INVIS invisible A_ITALIC italic A_LEFTLINE line along the left edge - A_PROTECT protected (?) -- PDCurses renders this as a + A_PROTECT protected (?) -- PDCurses renders this as a combination of the *LINE attributes A_REVERSE reverse video A_RIGHTLINE line along the right edge @@ -291,62 +291,62 @@ KEY_C1 lower left of virtual keypad KEY_C3 lower right of virtual keypad - KEY_BTAB Back tab key - KEY_BEG Beginning key - KEY_CANCEL Cancel key - KEY_CLOSE Close key - KEY_COMMAND Cmd (command) key - KEY_COPY Copy key - KEY_CREATE Create key - KEY_END End key - KEY_EXIT Exit key - KEY_FIND Find key - KEY_HELP Help key - KEY_MARK Mark key - KEY_MESSAGE Message key - KEY_MOVE Move key - KEY_NEXT Next object key - KEY_OPEN Open key - KEY_OPTIONS Options key - KEY_PREVIOUS Previous object key - KEY_REDO Redo key - KEY_REFERENCE Reference key - KEY_REFRESH Refresh key - KEY_REPLACE Replace key - KEY_RESTART Restart key - KEY_RESUME Resume key - KEY_SAVE Save key - KEY_SBEG Shifted beginning key - KEY_SCANCEL Shifted cancel key - KEY_SCOMMAND Shifted command key - KEY_SCOPY Shifted copy key - KEY_SCREATE Shifted create key - KEY_SDC Shifted delete char key - KEY_SDL Shifted delete line key - KEY_SELECT Select key - KEY_SEND Shifted end key - KEY_SEOL Shifted clear line key - KEY_SEXIT Shifted exit key - KEY_SFIND Shifted find key - KEY_SHELP Shifted help key - KEY_SHOME Shifted home key - KEY_SIC Shifted input key - KEY_SLEFT Shifted left arrow key - KEY_SMESSAGE Shifted message key - KEY_SMOVE Shifted move key - KEY_SNEXT Shifted next key - KEY_SOPTIONS Shifted options key - KEY_SPREVIOUS Shifted prev key - KEY_SPRINT Shifted print key - KEY_SREDO Shifted redo key - KEY_SREPLACE Shifted replace key - KEY_SRIGHT Shifted right arrow - KEY_SRSUME Shifted resume key - KEY_SSAVE Shifted save key - KEY_SSUSPEND Shifted suspend key - KEY_SUNDO Shifted undo key - KEY_SUSPEND Suspend key - KEY_UNDO Undo key + KEY_BTAB Back tab key + KEY_BEG Beginning key + KEY_CANCEL Cancel key + KEY_CLOSE Close key + KEY_COMMAND Cmd (command) key + KEY_COPY Copy key + KEY_CREATE Create key + KEY_END End key + KEY_EXIT Exit key + KEY_FIND Find key + KEY_HELP Help key + KEY_MARK Mark key + KEY_MESSAGE Message key + KEY_MOVE Move key + KEY_NEXT Next object key + KEY_OPEN Open key + KEY_OPTIONS Options key + KEY_PREVIOUS Previous object key + KEY_REDO Redo key + KEY_REFERENCE Reference key + KEY_REFRESH Refresh key + KEY_REPLACE Replace key + KEY_RESTART Restart key + KEY_RESUME Resume key + KEY_SAVE Save key + KEY_SBEG Shifted beginning key + KEY_SCANCEL Shifted cancel key + KEY_SCOMMAND Shifted command key + KEY_SCOPY Shifted copy key + KEY_SCREATE Shifted create key + KEY_SDC Shifted delete char key + KEY_SDL Shifted delete line key + KEY_SELECT Select key + KEY_SEND Shifted end key + KEY_SEOL Shifted clear line key + KEY_SEXIT Shifted exit key + KEY_SFIND Shifted find key + KEY_SHELP Shifted help key + KEY_SHOME Shifted home key + KEY_SIC Shifted input key + KEY_SLEFT Shifted left arrow key + KEY_SMESSAGE Shifted message key + KEY_SMOVE Shifted move key + KEY_SNEXT Shifted next key + KEY_SOPTIONS Shifted options key + KEY_SPREVIOUS Shifted prev key + KEY_SPRINT Shifted print key + KEY_SREDO Shifted redo key + KEY_SREPLACE Shifted replace key + KEY_SRIGHT Shifted right arrow + KEY_SRSUME Shifted resume key + KEY_SSAVE Shifted save key + KEY_SSUSPEND Shifted suspend key + KEY_SUNDO Shifted undo key + KEY_SUSPEND Suspend key + KEY_UNDO Undo key The virtual keypad is arranged like this: -- To view, visit https://review.coreboot.org/28432 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ib5a0f193d54d1b6f2431f7b801678f2a983c7941 Gerrit-Change-Number: 28432 Gerrit-PatchSet: 3 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: mb/google/glados/variants/sentry: Remove unnneded whitespace
by Patrick Georgi (Code Review) 19 Oct '18

19 Oct '18

Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/28703 ) Change subject: mb/google/glados/variants/sentry: Remove unnneded whitespace ...................................................................... mb/google/glados/variants/sentry: Remove unnneded whitespace Change-Id: Ibc928dc66e00dbb40d25420fd92f6c5f8049dec1 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> Reviewed-on: https://review.coreboot.org/28703 Reviewed-by: Patrick Georgi <pgeorgi(a)google.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M src/mainboard/google/glados/variants/sentry/Makefile.inc 1 file changed, 14 insertions(+), 14 deletions(-) Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved diff --git a/src/mainboard/google/glados/variants/sentry/Makefile.inc b/src/mainboard/google/glados/variants/sentry/Makefile.inc index 0ebf605..a60bcae 100644 --- a/src/mainboard/google/glados/variants/sentry/Makefile.inc +++ b/src/mainboard/google/glados/variants/sentry/Makefile.inc @@ -19,22 +19,22 @@ SPD_BIN = $(obj)/spd.bin -SPD_SOURCES = hynix_dimm_H9CCNNN8GTMLAR-NUD # 0b0000 Dual Channel 4GB +SPD_SOURCES = hynix_dimm_H9CCNNN8GTMLAR-NUD # 0b0000 Dual Channel 4GB SPD_SOURCES += micron_dimm_MT52L256M32D1PF-107-1G-1866 # 0b0001 Dual Channel 4GB -SPD_SOURCES += samsung_dimm_K4E8E304EE-EGCF # 0b0010 Dual Channel 4GB -SPD_SOURCES += samsung_dimm_K4E6E304EB-EGCF # 0b0011 Dual Channel 8GB +SPD_SOURCES += samsung_dimm_K4E8E304EE-EGCF # 0b0010 Dual Channel 4GB +SPD_SOURCES += samsung_dimm_K4E6E304EB-EGCF # 0b0011 Dual Channel 8GB SPD_SOURCES += micron_dimm_MT52L512M32D2PF-107-2G-1866 # 0b0100 Dual Channel 8GB -SPD_SOURCES += samsung_dimm_K4E8E324EB-EGCF # 0b0101 Dual Channel 8GB -SPD_SOURCES += hynix_dimm_H9CCNNNBJTMLAR-NUD # 0b0110 Dual Channel 4GB -SPD_SOURCES += hynix_dimm_H9CCNNNBLTBLAR-NUD-2G-1866 # 0b0111 Dual Channel 8GB -SPD_SOURCES += empty # 0b1000 -SPD_SOURCES += empty # 0b1001 -SPD_SOURCES += empty # 0b1010 -SPD_SOURCES += empty # 0b1011 -SPD_SOURCES += empty # 0b1100 -SPD_SOURCES += empty # 0b1101 -SPD_SOURCES += empty # 0b1110 -SPD_SOURCES += empty # 0b1111 +SPD_SOURCES += samsung_dimm_K4E8E324EB-EGCF # 0b0101 Dual Channel 8GB +SPD_SOURCES += hynix_dimm_H9CCNNNBJTMLAR-NUD # 0b0110 Dual Channel 4GB +SPD_SOURCES += hynix_dimm_H9CCNNNBLTBLAR-NUD-2G-1866 # 0b0111 Dual Channel 8GB +SPD_SOURCES += empty # 0b1000 +SPD_SOURCES += empty # 0b1001 +SPD_SOURCES += empty # 0b1010 +SPD_SOURCES += empty # 0b1011 +SPD_SOURCES += empty # 0b1100 +SPD_SOURCES += empty # 0b1101 +SPD_SOURCES += empty # 0b1110 +SPD_SOURCES += empty # 0b1111 SPD_DEPS := $(foreach f, $(SPD_SOURCES), src/mainboard/$(MAINBOARDDIR)/spd/$(f).spd.hex) -- To view, visit https://review.coreboot.org/28703 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ibc928dc66e00dbb40d25420fd92f6c5f8049dec1 Gerrit-Change-Number: 28703 Gerrit-PatchSet: 4 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: mb/google/glados/variants/sentry: Remove unnneded whitespace
by Patrick Georgi (Code Review) 19 Oct '18

19 Oct '18

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/28703 ) Change subject: mb/google/glados/variants/sentry: Remove unnneded whitespace ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/28703 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibc928dc66e00dbb40d25420fd92f6c5f8049dec1 Gerrit-Change-Number: 28703 Gerrit-PatchSet: 3 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 18 Oct 2018 17:17:24 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: libpayload/curses/PDCurses/doc/intro.txt: Remove unneeded whitespace
by Patrick Georgi (Code Review) 19 Oct '18

19 Oct '18

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/28432 ) Change subject: libpayload/curses/PDCurses/doc/intro.txt: Remove unneeded whitespace ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/28432 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib5a0f193d54d1b6f2431f7b801678f2a983c7941 Gerrit-Change-Number: 28432 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 18 Oct 2018 17:17:14 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: soc/amd/stoneyridge: Remove smbus.asl
by Richard Spiegel (Code Review) 19 Oct '18

19 Oct '18

Richard Spiegel has uploaded this change for review. ( https://review.coreboot.org/29182 Change subject: soc/amd/stoneyridge: Remove smbus.asl ...................................................................... soc/amd/stoneyridge: Remove smbus.asl The file smbus.asl has 0 bytes (no content). Now that it's no longer included, remove it. BUG=b:117814641 TEST=Build grunt and gardenia. Change-Id: I66389c721e272053d86357f71a6d1242ca767edd Signed-off-by: Richard Spiegel <richard.spiegel(a)silverbackltd.com> --- D src/soc/amd/stoneyridge/acpi/smbus.asl 1 file changed, 0 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/82/29182/1 diff --git a/src/soc/amd/stoneyridge/acpi/smbus.asl b/src/soc/amd/stoneyridge/acpi/smbus.asl deleted file mode 100644 index e69de29..0000000 --- a/src/soc/amd/stoneyridge/acpi/smbus.asl +++ /dev/null -- To view, visit https://review.coreboot.org/29182 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I66389c721e272053d86357f71a6d1242ca767edd Gerrit-Change-Number: 29182 Gerrit-PatchSet: 1 Gerrit-Owner: Richard Spiegel <richard.spiegel(a)silverbackltd.com>

1 0

Change in coreboot[master]: treewide: use /usr/bin/env where appropriate
by Patrick Georgi (Code Review) 19 Oct '18

19 Oct '18

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/28953 ) Change subject: treewide: use /usr/bin/env where appropriate ...................................................................... Patch Set 1: Code-Review+1 (1 comment) https://review.coreboot.org/#/c/28953/1/util/cbfstool/Makefile File util/cbfstool/Makefile: https://review.coreboot.org/#/c/28953/1/util/cbfstool/Makefile@9 PS1, Line 9: INSTALL ?= /usr/bin/env install that's troublesome as well as "install" does very different things on different unixoids. I had data loss from that (on Solaris, I think), so if we expect this to run on non-GNU, I'd propose getting rid of uses of "install" -- To view, visit https://review.coreboot.org/28953 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7546bcb881c532adc984577ecb0ee2ec4f2efe00 Gerrit-Change-Number: 28953 Gerrit-PatchSet: 1 Gerrit-Owner: Yegor Timoshenko <yegortimoshenko(a)riseup.net> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Yegor Timoshenko <yegortimoshenko(a)riseup.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Thu, 18 Oct 2018 16:31:57 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: tpm/tspi: clean up tpm_setup function flow
by Philipp Deppenwiese (Code Review) 19 Oct '18

19 Oct '18

Philipp Deppenwiese has submitted this change and it was merged. ( https://review.coreboot.org/29026 ) Change subject: tpm/tspi: clean up tpm_setup function flow ...................................................................... tpm/tspi: clean up tpm_setup function flow Introduce two helper functions for more readable code. Use epilogue function instead of goto for error handling. BUG=None TEST=None Change-Id: Ibea44880683a301e82ee2ba049003c36fcb44eba Signed-off-by: Joel Kitching <kitching(a)google.com> Reviewed-on: https://review.coreboot.org/29026 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Aaron Durbin <adurbin(a)chromium.org> Reviewed-by: Furquan Shaikh <furquan(a)google.com> Reviewed-by: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> --- M src/security/tpm/tspi/tspi.c 1 file changed, 46 insertions(+), 38 deletions(-) Approvals: build bot (Jenkins): Verified Aaron Durbin: Looks good to me, approved Philipp Deppenwiese: Looks good to me, approved Furquan Shaikh: Looks good to me, approved diff --git a/src/security/tpm/tspi/tspi.c b/src/security/tpm/tspi/tspi.c index c1779e6..d9cade9 100644 --- a/src/security/tpm/tspi/tspi.c +++ b/src/security/tpm/tspi/tspi.c @@ -64,6 +64,43 @@ } #endif +static uint32_t tpm_setup_s3_helper(void) +{ + uint32_t result; + + result = tlcl_resume(); + switch (result) { + case TPM_SUCCESS: + break; + + case TPM_E_INVALID_POSTINIT: + /* + * We're on a platform where the TPM maintains power + * in S3, so it's already initialized. + */ + printk(BIOS_INFO, "TPM: Already initialized.\n"); + result = TPM_SUCCESS; + break; + + default: + printk(BIOS_ERR, "TPM: Resume failed (%#x).\n", result); + break; + + } + + return result; +} + +static uint32_t tpm_setup_epilogue(uint32_t result) +{ + if (result != TPM_SUCCESS) + post_code(POST_TPM_FAILURE); + else + printk(BIOS_INFO, "TPM: setup succeeded\n"); + + return result; +} + /* * tpm_setup starts the TPM and establishes the root of trust for the * anti-rollback mechanism. SetupTPM can fail for three reasons. 1 A bug. 2 a @@ -91,37 +128,19 @@ result = tlcl_lib_init(); if (result != TPM_SUCCESS) { printk(BIOS_ERR, "TPM: Can't initialize.\n"); - goto out; + return tpm_setup_epilogue(result); } /* Handle special init for S3 resume path */ if (s3flag) { - result = tlcl_resume(); - switch (result) { - case TPM_SUCCESS: - break; - - case TPM_E_INVALID_POSTINIT: - /* - * We're on a platform where the TPM maintains power - * in S3, so it's already initialized. - */ - printk(BIOS_INFO, "TPM: Already initialized.\n"); - result = TPM_SUCCESS; - break; - - default: - printk(BIOS_ERR, "TPM: Resume failed (%#x).\n", result); - break; - - } - goto out; + printk(BIOS_INFO, "TPM: Handle S3 resume.\n"); + return tpm_setup_epilogue(tpm_setup_s3_helper()); } result = tlcl_startup(); if (result != TPM_SUCCESS) { printk(BIOS_ERR, "TPM: Can't run startup command.\n"); - goto out; + return tpm_setup_epilogue(result); } result = tlcl_assert_physical_presence(); @@ -133,33 +152,22 @@ */ result = tlcl_physical_presence_cmd_enable(); if (result != TPM_SUCCESS) { - printk( - BIOS_ERR, - "TPM: Can't enable physical presence command.\n"); - goto out; + printk(BIOS_ERR, "TPM: Can't enable physical presence command.\n"); + return tpm_setup_epilogue(result); } result = tlcl_assert_physical_presence(); if (result != TPM_SUCCESS) { - printk(BIOS_ERR, - "TPM: Can't assert physical presence.\n"); - goto out; + printk(BIOS_ERR, "TPM: Can't assert physical presence.\n"); + return tpm_setup_epilogue(result); } } #if IS_ENABLED(CONFIG_TPM1) result = tpm1_invoke_state_machine(); - if (result != TPM_SUCCESS) - return result; #endif -out: - if (result != TPM_SUCCESS) - post_code(POST_TPM_FAILURE); - else - printk(BIOS_INFO, "TPM: setup succeeded\n"); - - return result; + return tpm_setup_epilogue(result); } uint32_t tpm_clear_and_reenable(void) -- To view, visit https://review.coreboot.org/29026 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ibea44880683a301e82ee2ba049003c36fcb44eba Gerrit-Change-Number: 29026 Gerrit-PatchSet: 6 Gerrit-Owner: Joel Kitching <kitching(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Joel Kitching <kitching(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Patrick Rudolph <siro(a)das-labor.org>

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit October 2018