Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/29194
to look at the new patch set (#2).
Change subject: security/tpm: Add generalized ACPI table generation
......................................................................
security/tpm: Add generalized ACPI table generation
* Move ACPI table generation from TPM bus drivers
to security/tpm/acpi
* Update TPPI interface implementation
Change-Id: I2afdf4872566353284ab7734205a3bea738a6e0e
Signed-off-by: Philipp Deppenwiese <zaolin(a)das-labor.org>
---
M src/drivers/i2c/tpm/Makefile.inc
A src/drivers/i2c/tpm/acpi.c
D src/drivers/i2c/tpm/chip.c
M src/drivers/pc80/tpm/tis.c
M src/drivers/spi/acpi/acpi.c
M src/security/tpm/Makefile.inc
A src/security/tpm/acpi.h
A src/security/tpm/acpi/acpi.c
8 files changed, 539 insertions(+), 480 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/94/29194/2
--
To view, visit https://review.coreboot.org/29194
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2afdf4872566353284ab7734205a3bea738a6e0e
Gerrit-Change-Number: 29194
Gerrit-PatchSet: 2
Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Zhuohao Lee has uploaded this change for review. ( https://review.coreboot.org/29191
Change subject: mb/google/poppy: add the smi_events back
......................................................................
mb/google/poppy: add the smi_events back
Before entering the OS, the AP relies on the smi handler to shutdown
the system when the lid closes. Without the smi_events setting, the
AP will not receive the smi handler. As a result, the AP won't
shutdown and will always keep in S0.
BRANCH=master
BUG=b:115572596
TEST=test_that -b ${BOARD} ${IP} firmware_ECLidShutdown
Change-Id: Id82311a8ccd109f9c26516f59a45bdf34da98529
Signed-off-by: Zhuohao Lee <zhuohao(a)chromium.org>
---
M src/mainboard/google/poppy/ec.c
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/91/29191/1
diff --git a/src/mainboard/google/poppy/ec.c b/src/mainboard/google/poppy/ec.c
index 71327be..a93bf19 100644
--- a/src/mainboard/google/poppy/ec.c
+++ b/src/mainboard/google/poppy/ec.c
@@ -24,6 +24,7 @@
static const struct google_chromeec_event_info info = {
.log_events = MAINBOARD_EC_LOG_EVENTS,
.sci_events = MAINBOARD_EC_SCI_EVENTS,
+ .smi_events = MAINBOARD_EC_SMI_EVENTS,
.s3_wake_events = MAINBOARD_EC_S3_WAKE_EVENTS,
.s5_wake_events = MAINBOARD_EC_S5_WAKE_EVENTS,
.s0ix_wake_events = MAINBOARD_EC_S0IX_WAKE_EVENTS,
--
To view, visit https://review.coreboot.org/29191
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id82311a8ccd109f9c26516f59a45bdf34da98529
Gerrit-Change-Number: 29191
Gerrit-PatchSet: 1
Gerrit-Owner: Zhuohao Lee <zhuohao(a)chromium.org>