build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/29189 )
Change subject: mb/google/octopus: Use a single GPIO for trackpad wake and IRQ
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/29189/1/src/mainboard/google/octopus/varian…
File src/mainboard/google/octopus/variants/baseboard/gpio.c:
https://review.coreboot.org/#/c/29189/1/src/mainboard/google/octopus/varian…
PS1, Line 199: PAD_CFG_GPI_IRQ_WAKE(GPIO_135, NONE, DEEP, LEVEL, INVERT),/* GPIO_135 -- TRACKPAD_INT1_1V8_ODL */
line over 80 characters
--
To view, visit https://review.coreboot.org/29189
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2b704f1be493141629c647b79723b0025b0f7dd6
Gerrit-Change-Number: 29189
Gerrit-PatchSet: 1
Gerrit-Owner: Furquan Shaikh <furquan(a)google.com>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Fri, 19 Oct 2018 02:20:16 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/29184
to look at the new patch set (#2).
Change subject: soc/amd/stoneyridge: Replace public magic numbers
......................................................................
soc/amd/stoneyridge: Replace public magic numbers
Some "magic" numbers became public available registers/bits after the code
was originally written. Find all magic numbers, and if available in a public
BKDG than replace them with literals.
BUG=b:117648026
TEST=Build and boot grunt.
Change-Id: I9a241150917b290feeeee9d91e5f0fb01d030225
Signed-off-by: Richard Spiegel <richard.spiegel(a)silverbackltd.com>
---
M src/soc/amd/stoneyridge/include/soc/northbridge.h
M src/soc/amd/stoneyridge/include/soc/southbridge.h
M src/soc/amd/stoneyridge/northbridge.c
M src/soc/amd/stoneyridge/southbridge.c
4 files changed, 12 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/84/29184/2
--
To view, visit https://review.coreboot.org/29184
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9a241150917b290feeeee9d91e5f0fb01d030225
Gerrit-Change-Number: 29184
Gerrit-PatchSet: 2
Gerrit-Owner: Richard Spiegel <richard.spiegel(a)silverbackltd.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/29167 )
Change subject: util/inteltool: Fix LynxPoint (non-LP) GPIO register map
......................................................................
util/inteltool: Fix LynxPoint (non-LP) GPIO register map
The GPIO register dumper code for the LynxPoint family PCH chips
(Intel 8 Series and C220 Series) was incorrectly using a
shortened version of the LynxPoint-LP GPIO register map.
Switched to the correct register map for the affected chipsets.
Change-Id: I394a198bbb6628915cb73cabc5c8ff808579a07f
Signed-off-by: Fehér Roland Ádám <feherneoh(a)gmail.com>
Reviewed-on: https://review.coreboot.org/29167
Reviewed-by: Nico Huber <nico.h(a)gmx.de>
Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org>
---
M util/inteltool/gpio.c
1 file changed, 2 insertions(+), 3 deletions(-)
Approvals:
build bot (Jenkins): Verified
Nico Huber: Looks good to me, approved
diff --git a/util/inteltool/gpio.c b/util/inteltool/gpio.c
index c38051c..b4225a7 100644
--- a/util/inteltool/gpio.c
+++ b/util/inteltool/gpio.c
@@ -869,9 +869,8 @@
case PCI_DEVICE_ID_INTEL_C226:
case PCI_DEVICE_ID_INTEL_H81:
gpiobase = pci_read_word(sb, 0x48) & 0xfffc;
- gpio_registers = lynxpoint_lp_gpio_registers;
- /* Shares register locations but has less of them */
- size = 29;
+ gpio_registers = pch_gpio_registers;
+ size = ARRAY_SIZE(pch_gpio_registers);
break;
case PCI_DEVICE_ID_INTEL_3400:
case PCI_DEVICE_ID_INTEL_3420:
--
To view, visit https://review.coreboot.org/29167
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I394a198bbb6628915cb73cabc5c8ff808579a07f
Gerrit-Change-Number: 29167
Gerrit-PatchSet: 5
Gerrit-Owner: Roland Fehér <feherneoh(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Roland Fehér <feherneoh(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>