Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/29060 )
Change subject: vboot: fix CONFIG_RESUME_PATH_SAME_AS_BOOT S3 resume logic
......................................................................
Patch Set 2: Code-Review-2
Hey please fix that for the FSP vboot platforms as well. Otherwise it will break existing boards
--
To view, visit https://review.coreboot.org/29060
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1ef0bcdfd01746198f8140f49698b58065d820b9
Gerrit-Change-Number: 29060
Gerrit-PatchSet: 2
Gerrit-Owner: Joel Kitching <kitching(a)google.com>
Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Joel Kitching <kitching(a)google.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Thu, 18 Oct 2018 07:34:41 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: Yes
Werner Zeh has uploaded this change for review. ( https://review.coreboot.org/29176
Change subject: security/tpm: Unify return value for tlcl_resume() across TPM 1.2 and 2.0
......................................................................
security/tpm: Unify return value for tlcl_resume() across TPM 1.2 and 2.0
The TPM_Startup is slightly different in terms of the return value among
TPM version 1.2 and TPM 2.0. TPM 1.2 returns TPM_E_INVALID_POSTINIT
while TPM 2.0 returns TPM_RC_INITIALIZE in the case where the
TPM_Startup command is inappropriate. Do not expose this difference to
the TSPI layer but instead handle it in the TSS layer and provide a
common return value for both versions.
Change-Id: Ibaca1aa6100eaac69a3c1ba00e8c50dedc097d02
Signed-off-by: Werner Zeh <werner.zeh(a)siemens.com>
---
M src/security/tpm/tspi/tspi.c
M src/security/tpm/tss/tcg-1.2/tss.c
2 files changed, 11 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/76/29176/1
diff --git a/src/security/tpm/tspi/tspi.c b/src/security/tpm/tspi/tspi.c
index fccf224..c13a9d2 100644
--- a/src/security/tpm/tspi/tspi.c
+++ b/src/security/tpm/tspi/tspi.c
@@ -97,10 +97,10 @@
/* Handle special init for S3 resume path */
if (s3flag) {
result = tlcl_resume();
- if (result == TPM_E_INVALID_POSTINIT)
+ if (result == TPM_SUCCESS) {
printk(BIOS_INFO, "TPM: Already initialized.\n");
-
- return TPM_SUCCESS;
+ return TPM_SUCCESS;
+ }
}
result = tlcl_startup();
diff --git a/src/security/tpm/tss/tcg-1.2/tss.c b/src/security/tpm/tss/tcg-1.2/tss.c
index 0cb7eaa..db98669 100644
--- a/src/security/tpm/tss/tcg-1.2/tss.c
+++ b/src/security/tpm/tss/tcg-1.2/tss.c
@@ -103,7 +103,7 @@
VBDEBUG("TPM: command 0x%x returned 0x%x\n",
tpm_command_code(request), result);
-return result;
+ return result;
}
@@ -174,8 +174,14 @@
uint32_t tlcl_resume(void)
{
+ uint32_t result;
+
VBDEBUG("TPM: Resume\n");
- return send(tpm_resume_cmd.buffer);
+ result = send(tpm_resume_cmd.buffer);
+ if (result == TPM_E_INVALID_POSTINIT)
+ return TPM_SUCCESS;
+ else
+ return result;
}
uint32_t tlcl_self_test_full(void)
--
To view, visit https://review.coreboot.org/29176
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibaca1aa6100eaac69a3c1ba00e8c50dedc097d02
Gerrit-Change-Number: 29176
Gerrit-PatchSet: 1
Gerrit-Owner: Werner Zeh <werner.zeh(a)siemens.com>
Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/29173 )
Change subject: {cpu,drivers}/amd: Replace MTRR addresses with macros
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit https://review.coreboot.org/29173
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I315c0b70c552c5dd7f640b18b913350bb88be81b
Gerrit-Change-Number: 29173
Gerrit-PatchSet: 4
Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr>
Gerrit-Reviewer: Richard Spiegel <richard.spiegel(a)silverbackltd.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Wed, 17 Oct 2018 22:20:33 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: Yes
Hello Richard Spiegel, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/29173
to look at the new patch set (#4).
Change subject: {cpu,drivers}/amd: Replace MTRR addresses with macros
......................................................................
{cpu,drivers}/amd: Replace MTRR addresses with macros
Change-Id: I315c0b70c552c5dd7f640b18b913350bb88be81b
Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr>
---
M src/cpu/amd/agesa/family12/fixme.c
M src/cpu/amd/agesa/family14/fixme.c
M src/cpu/amd/agesa/family14/model_14_init.c
M src/cpu/amd/agesa/family15tn/fixme.c
M src/cpu/amd/agesa/family15tn/model_15_init.c
M src/cpu/amd/agesa/family16kb/fixme.c
M src/cpu/amd/agesa/family16kb/model_16_init.c
M src/cpu/amd/pi/00630F01/fixme.c
M src/cpu/amd/pi/00630F01/model_15_init.c
M src/cpu/amd/pi/00660F01/fixme.c
M src/cpu/amd/pi/00660F01/model_15_init.c
M src/cpu/amd/pi/00730F01/fixme.c
M src/cpu/amd/pi/00730F01/model_16_init.c
M src/drivers/amd/agesa/s3_mtrr.c
14 files changed, 50 insertions(+), 50 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/29173/4
--
To view, visit https://review.coreboot.org/29173
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I315c0b70c552c5dd7f640b18b913350bb88be81b
Gerrit-Change-Number: 29173
Gerrit-PatchSet: 4
Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr>
Gerrit-Reviewer: Richard Spiegel <richard.spiegel(a)silverbackltd.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Hello Richard Spiegel, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/29173
to look at the new patch set (#3).
Change subject: {cpu,drivers}/amd: Replace MSR addresses with macros
......................................................................
{cpu,drivers}/amd: Replace MSR addresses with macros
Change-Id: I315c0b70c552c5dd7f640b18b913350bb88be81b
Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr>
---
M src/cpu/amd/agesa/family12/fixme.c
M src/cpu/amd/agesa/family14/fixme.c
M src/cpu/amd/agesa/family14/model_14_init.c
M src/cpu/amd/agesa/family15tn/fixme.c
M src/cpu/amd/agesa/family15tn/model_15_init.c
M src/cpu/amd/agesa/family16kb/fixme.c
M src/cpu/amd/agesa/family16kb/model_16_init.c
M src/cpu/amd/pi/00630F01/fixme.c
M src/cpu/amd/pi/00630F01/model_15_init.c
M src/cpu/amd/pi/00660F01/fixme.c
M src/cpu/amd/pi/00660F01/model_15_init.c
M src/cpu/amd/pi/00730F01/fixme.c
M src/cpu/amd/pi/00730F01/model_16_init.c
M src/drivers/amd/agesa/s3_mtrr.c
14 files changed, 50 insertions(+), 50 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/29173/3
--
To view, visit https://review.coreboot.org/29173
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I315c0b70c552c5dd7f640b18b913350bb88be81b
Gerrit-Change-Number: 29173
Gerrit-PatchSet: 3
Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr>
Gerrit-Reviewer: Richard Spiegel <richard.spiegel(a)silverbackltd.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>