Elyes HAOUAS has uploaded a new patch set (#2). ( https://review.coreboot.org/29173 )
Change subject: {cpu,drivers}/amd: Replace MSR addresses with macros
......................................................................
{cpu,drivers}/amd: Replace MSR addresses with macros
Change-Id: I315c0b70c552c5dd7f640b18b913350bb88be81b
Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr>
---
M src/cpu/amd/agesa/family12/fixme.c
M src/cpu/amd/agesa/family14/fixme.c
M src/cpu/amd/agesa/family14/model_14_init.c
M src/cpu/amd/agesa/family15tn/fixme.c
M src/cpu/amd/agesa/family15tn/model_15_init.c
M src/cpu/amd/agesa/family16kb/fixme.c
M src/cpu/amd/agesa/family16kb/model_16_init.c
M src/cpu/amd/pi/00630F01/fixme.c
M src/cpu/amd/pi/00630F01/model_15_init.c
M src/cpu/amd/pi/00660F01/fixme.c
M src/cpu/amd/pi/00660F01/model_15_init.c
M src/cpu/amd/pi/00730F01/fixme.c
M src/cpu/amd/pi/00730F01/model_16_init.c
M src/drivers/amd/agesa/s3_mtrr.c
14 files changed, 44 insertions(+), 44 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/29173/2
--
To view, visit https://review.coreboot.org/29173
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I315c0b70c552c5dd7f640b18b913350bb88be81b
Gerrit-Change-Number: 29173
Gerrit-PatchSet: 2
Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr>
Hello Patrick Rudolph, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/29169
to look at the new patch set (#2).
Change subject: intel: Use CF9 reset (part 2)
......................................................................
intel: Use CF9 reset (part 2)
Make use of the common CF9 reset in SOC_INTEL_COMMON_RESET. Also
implement board_reset() as a "full reset" (aka. cold reset) as that
is what was used here for hard_reset().
We leave some comments to remind us that a system_reset() should
be enough, where a full_reset() is called now to retain current
behaviour.
Note, as no global_reset() is implemented for Denverton-NS, we halt
there now instead of issuing a non-global reset. This seems safer;
a non-global reset might result in a reset loop.
Change-Id: I5e7025c3c9ea6ded18e72037412b60a1df31bd53
Signed-off-by: Nico Huber <nico.h(a)gmx.de>
---
M src/drivers/intel/fsp1_1/raminit.c
M src/drivers/intel/fsp1_1/romstage.c
M src/drivers/intel/fsp2_0/memory_init.c
M src/drivers/intel/fsp2_0/util.c
D src/include/cpu/intel/reset.h
M src/include/reset.h
M src/lib/reset.c
M src/soc/intel/apollolake/Kconfig
M src/soc/intel/apollolake/reset.c
M src/soc/intel/apollolake/romstage.c
M src/soc/intel/braswell/Kconfig
M src/soc/intel/cannonlake/Kconfig
M src/soc/intel/cannonlake/reset.c
M src/soc/intel/common/Kconfig
M src/soc/intel/common/block/acpi/acpi.c
M src/soc/intel/common/reset.c
M src/soc/intel/denverton_ns/Kconfig
M src/soc/intel/denverton_ns/reset.c
M src/soc/intel/denverton_ns/romstage.c
M src/soc/intel/quark/Kconfig
M src/soc/intel/quark/reset.c
M src/soc/intel/skylake/Kconfig
M src/soc/intel/skylake/reset.c
23 files changed, 52 insertions(+), 106 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/29169/2
--
To view, visit https://review.coreboot.org/29169
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5e7025c3c9ea6ded18e72037412b60a1df31bd53
Gerrit-Change-Number: 29169
Gerrit-PatchSet: 2
Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Raul Rangel has uploaded this change for review. ( https://review.coreboot.org/29171
Change subject: grunt: Remove RECOVERY_MRC_CACHE from FMAP
......................................................................
grunt: Remove RECOVERY_MRC_CACHE from FMAP
I didn't subtract the offset from everything else because I didn't know
if was ok to change the whole FMAP. I can shuffle everything if that's
what I should do.
BUG=b:117797131, b:117798830
BRANCH=none
TEST=Ran autotest and made sure the tests were skipped
/tmp/test_that_results_2OZ90v/results-1-firmware_CorruptRecoveryCache [ PASSED ]
/tmp/test_that_results_2OZ90v/results-1-firmware_CorruptRecoveryCache TEST_NA: No RECOVERY_MRC_CACHE was found on DUT.
/tmp/test_that_results_2OZ90v/results-1-firmware_CorruptRecoveryCache/firmware_CorruptRecoveryCache.normal [ PASSED ]
/tmp/test_that_results_2OZ90v/results-1-firmware_CorruptRecoveryCache/firmware_CorruptRecoveryCache.normal TEST_NA: No RECOVERY_MRC_CACHE was found on DUT.
Change-Id: I5cdbf4139dde80fe6e9d0045139a97841b03bc42
Signed-off-by: Raul E Rangel <rrangel(a)chromium.org>
---
M src/mainboard/google/kahlee/variants/baseboard/chromeos.fmd
1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/29171/1
diff --git a/src/mainboard/google/kahlee/variants/baseboard/chromeos.fmd b/src/mainboard/google/kahlee/variants/baseboard/chromeos.fmd
index f84ed01..2d140fb 100644
--- a/src/mainboard/google/kahlee/variants/baseboard/chromeos.fmd
+++ b/src/mainboard/google/kahlee/variants/baseboard/chromeos.fmd
@@ -1,7 +1,6 @@
FLASH@0xFF000000 0x1000000 {
SI_BIOS@0x0 0x1000000 {
UNIFIED_MRC_CACHE@0x0 0x21000 {
- RECOVERY_MRC_CACHE@0x0 0x10000
RW_MRC_CACHE@0x10000 0x10000
RW_VAR_MRC_CACHE@0x20000 0x1000
}
--
To view, visit https://review.coreboot.org/29171
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5cdbf4139dde80fe6e9d0045139a97841b03bc42
Gerrit-Change-Number: 29171
Gerrit-PatchSet: 1
Gerrit-Owner: Raul Rangel <rrangel(a)chromium.org>
Hello build bot (Jenkins), Nico Huber,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/29167
to look at the new patch set (#4).
Change subject: util/inteltool: Fix LynxPoint (non-LP) GPIO register map
......................................................................
util/inteltool: Fix LynxPoint (non-LP) GPIO register map
The GPIO register dumper code for the LynxPoint family PCH chips
(Intel 8 Series and C220 Series) was incorrectly using a
shortened version of the LynxPoint-LP GPIO register map.
Switched to the correct register map for the affected chipsets.
Change-Id: I394a198bbb6628915cb73cabc5c8ff808579a07f
Signed-off-by: Fehér Roland Ádám <feherneoh(a)gmail.com>
---
M util/inteltool/gpio.c
1 file changed, 2 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/67/29167/4
--
To view, visit https://review.coreboot.org/29167
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I394a198bbb6628915cb73cabc5c8ff808579a07f
Gerrit-Change-Number: 29167
Gerrit-PatchSet: 4
Gerrit-Owner: Roland Fehér <feherneoh(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Roland Fehér <feherneoh(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Roland Fehér has posted comments on this change. ( https://review.coreboot.org/29167 )
Change subject: util/inteltool: Fix LynxPoint (non-LP) GPIO register map
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/#/c/29167/2//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/29167/2//COMMIT_MSG@11
PS2, Line 11: Intel 9 Series
> IIRC, those were rebranded Lynx Point chips. A real 9 series […]
Thanks, did not know this. I guess I should ask first, push later. Removing it from the commit message.
--
To view, visit https://review.coreboot.org/29167
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I394a198bbb6628915cb73cabc5c8ff808579a07f
Gerrit-Change-Number: 29167
Gerrit-PatchSet: 3
Gerrit-Owner: Roland Fehér <feherneoh(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Roland Fehér <feherneoh(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Wed, 17 Oct 2018 17:34:05 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No