coreboot-gerrit October 2018

coreboot-gerrit@coreboot.org

1 participants
1285 discussions

Change in coreboot[master]: tpm2/tlcl_send_startup: correct TPM2_Startup error logic
by Philipp Deppenwiese (Code Review) 05 Oct '18

05 Oct '18

Philipp Deppenwiese has submitted this change and it was merged. ( https://review.coreboot.org/28749 ) Change subject: tpm2/tlcl_send_startup: correct TPM2_Startup error logic ...................................................................... tpm2/tlcl_send_startup: correct TPM2_Startup error logic BUG=b:114018226 TEST=compile coreboot Change-Id: Iffad582d5c19252dde1c9dc97fc7fd145944a3b3 Signed-off-by: Joel Kitching <kitching(a)google.com> Reviewed-on: https://review.coreboot.org/28749 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Aaron Durbin <adurbin(a)chromium.org> Reviewed-by: Furquan Shaikh <furquan(a)google.com> --- M src/security/tpm/tss/tcg-2.0/tss.c 1 file changed, 6 insertions(+), 7 deletions(-) Approvals: build bot (Jenkins): Verified Aaron Durbin: Looks good to me, approved Furquan Shaikh: Looks good to me, approved diff --git a/src/security/tpm/tss/tcg-2.0/tss.c b/src/security/tpm/tss/tcg-2.0/tss.c index 7db746f..e6ec57c 100644 --- a/src/security/tpm/tss/tcg-2.0/tss.c +++ b/src/security/tpm/tss/tcg-2.0/tss.c @@ -61,14 +61,13 @@ startup.startup_type = type; response = tpm_process_command(TPM2_Startup, &startup); - if (response && response->hdr.tpm_code && - (response->hdr.tpm_code != TPM_RC_INITIALIZE)) { - printk(BIOS_INFO, "%s: Startup return code is %x\n", - __func__, response->hdr.tpm_code); - return TPM_E_IOERROR; + if (response && (response->hdr.tpm_code == 0 || + response->hdr.tpm_code == TPM_RC_INITIALIZE)) { + return TPM_SUCCESS; } - return TPM_SUCCESS; - + printk(BIOS_INFO, "%s: Startup return code is %x\n", + __func__, response->hdr.tpm_code); + return TPM_E_IOERROR; } uint32_t tlcl_resume(void) -- To view, visit https://review.coreboot.org/28749 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Iffad582d5c19252dde1c9dc97fc7fd145944a3b3 Gerrit-Change-Number: 28749 Gerrit-PatchSet: 5 Gerrit-Owner: Joel Kitching <kitching(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Andrey Pronin <apronin(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Joel Kitching <kitching(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: [WIP]KBL: Update FSP headers - upgrade to FSP 3.6.2
by Philipp Deppenwiese (Code Review) 05 Oct '18

05 Oct '18

Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/28578 ) Change subject: [WIP]KBL: Update FSP headers - upgrade to FSP 3.6.2 ...................................................................... Patch Set 1: Code-Review-2 We will directly use the FSP from the github repo See. 28593 -- To view, visit https://review.coreboot.org/28578 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I827fa17bef597178016782e13499efe751d7b675 Gerrit-Change-Number: 28578 Gerrit-PatchSet: 1 Gerrit-Owner: Shaunak Saha <shaunak.saha(a)intel.com> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Reviewer: Shaunak Saha <shaunak.saha(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 05 Oct 2018 03:30:54 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: 3rdparty/fsp: update to current master
by Philipp Deppenwiese (Code Review) 05 Oct '18

05 Oct '18

Philipp Deppenwiese has submitted this change and it was merged. ( https://review.coreboot.org/28775 ) Change subject: 3rdparty/fsp: update to current master ...................................................................... 3rdparty/fsp: update to current master This includes the SplitFspBin.py script. Change-Id: I6323a7a1a2bd9b5e11c0b21e5ea991a3fbd3daac Signed-off-by: Patrick Georgi <pgeorgi(a)google.com> Reviewed-on: https://review.coreboot.org/28775 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Reviewed-by: Paul Menzel <paulepanter(a)users.sourceforge.net> --- M 3rdparty/fsp 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Philipp Deppenwiese: Looks good to me, approved diff --git a/3rdparty/fsp b/3rdparty/fsp index 7431e4f..162719b 160000 --- a/3rdparty/fsp +++ b/3rdparty/fsp @@ -1 +1 @@ -Subproject commit 7431e4f3399a5081c956753b5fa3bcd764196723 +Subproject commit 162719b6cb5efc6c50dcb23dfdb378358573e2b6 -- To view, visit https://review.coreboot.org/28775 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I6323a7a1a2bd9b5e11c0b21e5ea991a3fbd3daac Gerrit-Change-Number: 28775 Gerrit-PatchSet: 4 Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: 3rdparty/fsp: update to current master
by Philipp Deppenwiese (Code Review) 05 Oct '18

05 Oct '18

Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/28775 ) Change subject: 3rdparty/fsp: update to current master ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/28775 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6323a7a1a2bd9b5e11c0b21e5ea991a3fbd3daac Gerrit-Change-Number: 28775 Gerrit-PatchSet: 3 Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 05 Oct 2018 03:29:08 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: LinuxBoot/arm64: Remove firmware from defconfig
by Philipp Deppenwiese (Code Review) 05 Oct '18

05 Oct '18

Philipp Deppenwiese has submitted this change and it was merged. ( https://review.coreboot.org/28908 ) Change subject: LinuxBoot/arm64: Remove firmware from defconfig ...................................................................... LinuxBoot/arm64: Remove firmware from defconfig The extra firmware is not part of upstream kernel. Fixes build error if the firmware is not present. Change-Id: Ifbcb0bb0e2edf3aa260b40dfa339812019f9f0b3 Signed-off-by: Patrick Rudolph <patrick.rudolph(a)9elements.com> Reviewed-on: https://review.coreboot.org/28908 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Angel Pons <th3fanbus(a)gmail.com> Reviewed-by: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> --- M payloads/external/LinuxBoot/arm64/defconfig 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified Philipp Deppenwiese: Looks good to me, approved Angel Pons: Looks good to me, but someone else must approve diff --git a/payloads/external/LinuxBoot/arm64/defconfig b/payloads/external/LinuxBoot/arm64/defconfig index 6f68019..ffb6702 100644 --- a/payloads/external/LinuxBoot/arm64/defconfig +++ b/payloads/external/LinuxBoot/arm64/defconfig @@ -114,7 +114,6 @@ CONFIG_UEVENT_HELPER_PATH="/sbin/hotplug" CONFIG_DEVTMPFS=y CONFIG_DEVTMPFS_MOUNT=y -CONFIG_EXTRA_FIRMWARE="cpt8x-mc-ae.out cpt8x-mc-se.out" CONFIG_DMA_CMA=y CONFIG_MTD=y CONFIG_MTD_NAND=y -- To view, visit https://review.coreboot.org/28908 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ifbcb0bb0e2edf3aa260b40dfa339812019f9f0b3 Gerrit-Change-Number: 28908 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Jens Drenhaus <jens.drenhaus(a)9elements.com> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Ronald G. Minnich <rminnich(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: LinuxBoot/arm64: Remove firmware from defconfig
by Philipp Deppenwiese (Code Review) 05 Oct '18

05 Oct '18

Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/28908 ) Change subject: LinuxBoot/arm64: Remove firmware from defconfig ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/28908 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifbcb0bb0e2edf3aa260b40dfa339812019f9f0b3 Gerrit-Change-Number: 28908 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Jens Drenhaus <jens.drenhaus(a)9elements.com> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Ronald G. Minnich <rminnich(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 05 Oct 2018 03:27:36 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: drivers/spi/winbond: Add new chip
by Philipp Deppenwiese (Code Review) 05 Oct '18

05 Oct '18

Philipp Deppenwiese has submitted this change and it was merged. ( https://review.coreboot.org/28861 ) Change subject: drivers/spi/winbond: Add new chip ...................................................................... drivers/spi/winbond: Add new chip The W25Q128J is a QSPI flash chip, without ~HOLD and ~WP. Add the device id to make coreboot boot from it. Change-Id: I623fdf7d7e30eb28259bec6294785ad873f1f503 Signed-off-by: Patrick Rudolph <patrick.rudolph(a)9elements.com> Reviewed-on: https://review.coreboot.org/28861 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Angel Pons <th3fanbus(a)gmail.com> Reviewed-by: Julius Werner <jwerner(a)chromium.org> Reviewed-by: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> --- M src/drivers/spi/winbond.c 1 file changed, 10 insertions(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Philipp Deppenwiese: Looks good to me, approved Julius Werner: Looks good to me, approved Angel Pons: Looks good to me, but someone else must approve diff --git a/src/drivers/spi/winbond.c b/src/drivers/spi/winbond.c index a6089b5..e2c6538 100644 --- a/src/drivers/spi/winbond.c +++ b/src/drivers/spi/winbond.c @@ -179,6 +179,16 @@ .bp_bits = 3, }, { + .id = 0x7018, + .l2_page_size_shift = 8, + .pages_per_sector_shift = 4, + .sectors_per_block_shift = 4, + .nr_blocks_shift = 8, + .name = "W25Q128J", + .protection_granularity_shift = 18, + .bp_bits = 3, + }, + { .id = 0x4019, .l2_page_size_shift = 8, .pages_per_sector_shift = 4, -- To view, visit https://review.coreboot.org/28861 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I623fdf7d7e30eb28259bec6294785ad873f1f503 Gerrit-Change-Number: 28861 Gerrit-PatchSet: 4 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin Roth <martinroth(a)google.com> Gerrit-CC: Patrick Rudolph <siro(a)das-labor.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>

1 0

Change in coreboot[master]: drivers/spi/winbond: Add new chip
by Philipp Deppenwiese (Code Review) 05 Oct '18

05 Oct '18

Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/28861 ) Change subject: drivers/spi/winbond: Add new chip ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/28861 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I623fdf7d7e30eb28259bec6294785ad873f1f503 Gerrit-Change-Number: 28861 Gerrit-PatchSet: 3 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin Roth <martinroth(a)google.com> Gerrit-CC: Patrick Rudolph <siro(a)das-labor.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Comment-Date: Fri, 05 Oct 2018 03:25:13 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: acpi: Reverse logic for setting PCIEXPWAK_STS bit in PM1_EN_STS
by Nick Vaccaro (Code Review) 05 Oct '18

05 Oct '18

Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/28932 ) Change subject: acpi: Reverse logic for setting PCIEXPWAK_STS bit in PM1_EN_STS ...................................................................... Patch Set 1: Code-Review-1 I am still in process of verifying out this change, but since I will not be available tomorrow, I wanted to get this CL posted where others can get to it. -- To view, visit https://review.coreboot.org/28932 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id8b14ae2ae4d97e184906dec468b405134d590da Gerrit-Change-Number: 28932 Gerrit-PatchSet: 1 Gerrit-Owner: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 05 Oct 2018 03:23:35 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: acpi: Reverse logic for setting PCIEXPWAK_STS bit in PM1_EN_STS
by Nick Vaccaro (Code Review) 05 Oct '18

05 Oct '18

Nick Vaccaro has uploaded this change for review. ( https://review.coreboot.org/28932 Change subject: acpi: Reverse logic for setting PCIEXPWAK_STS bit in PM1_EN_STS ...................................................................... acpi: Reverse logic for setting PCIEXPWAK_STS bit in PM1_EN_STS The logic for setting the PCIEXPWAK_STS is backwards. According to EDS, PCIEXPWAK_STS should be set to disable "the inputs to the PCIEXP_WAKE_STS bit in the PM1 Status register from waking the system", but the logic was setting that bit if DSX_EN_WAKE_PIN is enabled, not disabled. This was causing spurious wake issues on nocturne. Changed logic to set the PCIEXPWAK_STS bit if DSX_EN_WAKE_PIN is not defined in deep_sx_config register in devicetree.cb. BUG=b:111683988 TEST="emerge-nocturne coreboot chromeos-bootimage', flash build onto nocturne, boot nocturne, and verify that pulling WAKE# pin low does not wake the system. Change-Id: Id8b14ae2ae4d97e184906dec468b405134d590da Signed-off-by: Nick Vaccaro <nvaccaro(a)google.com> --- M src/soc/intel/skylake/acpi.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/32/28932/1 diff --git a/src/soc/intel/skylake/acpi.c b/src/soc/intel/skylake/acpi.c index d2ec7e7..bc3ea45 100644 --- a/src/soc/intel/skylake/acpi.c +++ b/src/soc/intel/skylake/acpi.c @@ -715,7 +715,7 @@ pm1_en |= PWRBTN_STS; /* Always enabled as wake source */ if (config->deep_sx_config & DSX_EN_LAN_WAKE_PIN) gpe0_std |= LAN_WAK_EN; - if (config->deep_sx_config & DSX_EN_WAKE_PIN) + if ((config->deep_sx_config & DSX_EN_WAKE_PIN) == 0) pm1_en |= PCIEXPWAK_STS; } -- To view, visit https://review.coreboot.org/28932 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Id8b14ae2ae4d97e184906dec468b405134d590da Gerrit-Change-Number: 28932 Gerrit-PatchSet: 1 Gerrit-Owner: Nick Vaccaro <nvaccaro(a)google.com>

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit October 2018