coreboot-gerrit September 2017

coreboot-gerrit@coreboot.org

1 participants
1960 discussions

Change in coreboot[master]: amd/stoneyridge: Clean up smi_util.c
by build bot (Jenkins) (Code Review) 28 Sep '17

28 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21743 ) Change subject: amd/stoneyridge: Clean up smi_util.c ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/61281/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/16427/ : SUCCESS -- To view, visit https://review.coreboot.org/21743 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If963a817a4bea9b6dbb0d41a2bc0789a44a01391 Gerrit-Change-Number: 21743 Gerrit-PatchSet: 1 Gerrit-Owner: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 28 Sep 2017 16:45:17 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: amd/stoneyridge: Use generic SMM command port values
by build bot (Jenkins) (Code Review) 28 Sep '17

28 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21741 ) Change subject: amd/stoneyridge: Use generic SMM command port values ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/61277/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/16423/ : SUCCESS -- To view, visit https://review.coreboot.org/21741 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3de9a178e5f189ac1dbc921e41b69d47e3796a4f Gerrit-Change-Number: 21741 Gerrit-PatchSet: 1 Gerrit-Owner: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 28 Sep 2017 16:43:20 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: amd/stoneyridge: Add more SMM definitions
by build bot (Jenkins) (Code Review) 28 Sep '17

28 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21742 ) Change subject: amd/stoneyridge: Add more SMM definitions ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/61280/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/16426/ : SUCCESS -- To view, visit https://review.coreboot.org/21742 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4c8069a18ea430ec6e66d41879c8e77f1ef2b340 Gerrit-Change-Number: 21742 Gerrit-PatchSet: 1 Gerrit-Owner: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 28 Sep 2017 16:43:19 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/amd/common: Add included directory
by build bot (Jenkins) (Code Review) 28 Sep '17

28 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21738 ) Change subject: soc/amd/common: Add included directory ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/61276/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/16422/ : SUCCESS -- To view, visit https://review.coreboot.org/21738 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia8191897d2030c475c9268ae86faaf01952c6ace Gerrit-Change-Number: 21738 Gerrit-PatchSet: 1 Gerrit-Owner: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 28 Sep 2017 16:39:15 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: amd/stoneyridge: Remove HAVE_SMI_HANDLER from makefile
by build bot (Jenkins) (Code Review) 28 Sep '17

28 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21739 ) Change subject: amd/stoneyridge: Remove HAVE_SMI_HANDLER from makefile ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/61279/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/16425/ : SUCCESS -- To view, visit https://review.coreboot.org/21739 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4ea89d7bce83a99328c58897a4098debacd86d66 Gerrit-Change-Number: 21739 Gerrit-PatchSet: 1 Gerrit-Owner: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 28 Sep 2017 16:38:39 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: amd/stoneyridge: Add uart.c to smm-y list
by build bot (Jenkins) (Code Review) 28 Sep '17

28 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21740 ) Change subject: amd/stoneyridge: Add uart.c to smm-y list ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/61278/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/16424/ : SUCCESS -- To view, visit https://review.coreboot.org/21740 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie1962e969a8cb93eefc0b86bf4062752580e5acd Gerrit-Change-Number: 21740 Gerrit-PatchSet: 1 Gerrit-Owner: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 28 Sep 2017 16:38:29 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: amd/stoneyridge: Check SMI command address before reading
by Marshall Dawson (Code Review) 28 Sep '17

28 Sep '17

Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/21744 ) Change subject: amd/stoneyridge: Check SMI command address before reading ...................................................................... Patch Set 1: (1 comment) Relocate prototype from https://review.coreboot.org/#/c/21742/1/src/soc/amd/stoneyridge/include/soc… to here. https://review.coreboot.org/#/c/21744/1//COMMIT_MSG Commit Message: https://review.coreboot.org/#/c/21744/1//COMMIT_MSG@11 PS1, Line 11: the port maybe "it" -- To view, visit https://review.coreboot.org/21744 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8a3ca285d3a9afd4a107cd471c202abf03f372ac Gerrit-Change-Number: 21744 Gerrit-PatchSet: 1 Gerrit-Owner: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Comment-Date: Thu, 28 Sep 2017 16:36:32 +0000 Gerrit-HasComments: Yes

1 0

Change in coreboot[master]: [WIP] drv/intel/gma/opregion: Add common init_idg_opregion()
by build bot (Jenkins) (Code Review) 28 Sep '17

28 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20969 ) Change subject: [WIP] drv/intel/gma/opregion: Add common init_idg_opregion() ...................................................................... Patch Set 6: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/61275/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/16421/ : SUCCESS -- To view, visit https://review.coreboot.org/20969 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8ee50ea9900537bd9e3ca5ab0cd3f48d2acec970 Gerrit-Change-Number: 20969 Gerrit-PatchSet: 6 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 28 Sep 2017 16:33:13 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: amd/stoneyridge: Add more SMM definitions
by Marshall Dawson (Code Review) 28 Sep '17

28 Sep '17

Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/21742 ) Change subject: amd/stoneyridge: Add more SMM definitions ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/#/c/21742/1/src/soc/amd/stoneyridge/include/soc… File src/soc/amd/stoneyridge/include/soc/smi.h: https://review.coreboot.org/#/c/21742/1/src/soc/amd/stoneyridge/include/soc… PS1, Line 219: uint16_t pm_acpi_smi_cmd_port(void); wrong commit -- To view, visit https://review.coreboot.org/21742 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4c8069a18ea430ec6e66d41879c8e77f1ef2b340 Gerrit-Change-Number: 21742 Gerrit-PatchSet: 1 Gerrit-Owner: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Comment-Date: Thu, 28 Sep 2017 16:33:08 +0000 Gerrit-HasComments: Yes

1 0

Change in coreboot[master]: WIP amd/stoneridge: Enable SMI trap on SlpTyp
by Marshall Dawson (Code Review) 28 Sep '17

28 Sep '17

Marshall Dawson has uploaded this change for review. ( https://review.coreboot.org/21752 Change subject: WIP amd/stoneridge: Enable SMI trap on SlpTyp ...................................................................... WIP amd/stoneridge: Enable SMI trap on SlpTyp Consider adding a check for HAVE_ACPI_RESUME, maybe SOC_AMD_COMMON_BLOCK_PSP. Change-Id: I8db0df36b285ad26c8c9e62c3857fb6580c35229 Signed-off-by: Marshall Dawson <marshalldawson3rd(a)gmail.com> --- M src/soc/amd/stoneyridge/southbridge.c 1 file changed, 9 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/21752/1 diff --git a/src/soc/amd/stoneyridge/southbridge.c b/src/soc/amd/stoneyridge/southbridge.c index b5357a9..4c91efa 100644 --- a/src/soc/amd/stoneyridge/southbridge.c +++ b/src/soc/amd/stoneyridge/southbridge.c @@ -89,8 +89,17 @@ pm_write16(PM_CPU_CTRL, ACPI_CPU_CONTROL); if (IS_ENABLED(CONFIG_HAVE_SMI_HANDLER)) { + /* APMC - SMI Command Port */ pm_write16(PM_ACPI_SMI_CMD, APM_CNT); configure_smi(SMITYPE_SMI_CMD_PORT, SMI_MODE_SMI); + + /* SlpTypEn */ + pm_write32(PM_PCI_CTRL, + (pm_read32(PM_PCI_CTRL) | FORCE_SLPSTATE_RETRY) + & ~FORCE_STPCLK_RETRY); + pm_write32(PM_RST_CTRL1, + pm_read32(PM_RST_CTRL1) & ~SLPTYPE_CONTROL_EN); + configure_smi(SMITYPE_SLP_TYP, SMI_MODE_SMI); } else { pm_write16(PM_ACPI_SMI_CMD, 0); } -- To view, visit https://review.coreboot.org/21752 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I8db0df36b285ad26c8c9e62c3857fb6580c35229 Gerrit-Change-Number: 21752 Gerrit-PatchSet: 1 Gerrit-Owner: Marshall Dawson <marshalldawson3rd(a)gmail.com>

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit September 2017