coreboot-gerrit September 2017

coreboot-gerrit@coreboot.org

1 participants
1960 discussions

Change in coreboot[master]: drivers/intel/fsp2_0: use common code to fetch vbt.bin
by build bot (Jenkins) (Code Review) 28 Sep '17

28 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21723 ) Change subject: drivers/intel/fsp2_0: use common code to fetch vbt.bin ...................................................................... Patch Set 2: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/61267/ : ABORTED https://qa.coreboot.org/job/coreboot-checkpatch/16414/ : SUCCESS -- To view, visit https://review.coreboot.org/21723 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie1cdd1783dd5dababd1e97436a4ce1a4f068d5b3 Gerrit-Change-Number: 21723 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 28 Sep 2017 15:56:58 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/intel/common: Allow overriding CBFS filename of VBT
by build bot (Jenkins) (Code Review) 28 Sep '17

28 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21724 ) Change subject: soc/intel/common: Allow overriding CBFS filename of VBT ...................................................................... Patch Set 2: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/61268/ : ABORTED https://qa.coreboot.org/job/coreboot-checkpatch/16415/ : SUCCESS -- To view, visit https://review.coreboot.org/21724 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic7865dc0e0c9ea3077b749d9d0482079877e9c4f Gerrit-Change-Number: 21724 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 28 Sep 2017 15:56:58 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mainboard/google/reef: Override VBT selection in coral
by build bot (Jenkins) (Code Review) 28 Sep '17

28 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21725 ) Change subject: mainboard/google/reef: Override VBT selection in coral ...................................................................... Patch Set 2: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/61269/ : ABORTED https://qa.coreboot.org/job/coreboot-checkpatch/16416/ : SUCCESS -- To view, visit https://review.coreboot.org/21725 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7fd667b1cf0b7c2a5e4ab7ac7748d9636a52ae54 Gerrit-Change-Number: 21725 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 28 Sep 2017 15:56:58 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: ifdtool: refactor region-permission-related functions
by build bot (Jenkins) (Code Review) 28 Sep '17

28 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21416 ) Change subject: ifdtool: refactor region-permission-related functions ...................................................................... Patch Set 54: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/61257/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/16404/ : SUCCESS -- To view, visit https://review.coreboot.org/21416 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4d34606545db4d970ce3ec202da4bf4c5cbad18c Gerrit-Change-Number: 21416 Gerrit-PatchSet: 54 Gerrit-Owner: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: Nicola Corna <nicola(a)corna.info> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philippe Mathieu-Daudé <f4bug(a)amsat.org> Gerrit-Reviewer: Shawn Chang <citypw(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 28 Sep 2017 15:02:07 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: ifdtool: Port the feature to jail ME from me_cleaner
by build bot (Jenkins) (Code Review) 28 Sep '17

28 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21607 ) Change subject: ifdtool: Port the feature to jail ME from me_cleaner ...................................................................... Patch Set 19: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/61256/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/16403/ : SUCCESS -- To view, visit https://review.coreboot.org/21607 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I00533f4e2569c4763fbfc302bb460db1e60e5564 Gerrit-Change-Number: 21607 Gerrit-PatchSet: 19 Gerrit-Owner: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 28 Sep 2017 14:43:55 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: MAINTAINERS: add maintainers for all PC Engines mainboards
by build bot (Jenkins) (Code Review) 28 Sep '17

28 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21732 ) Change subject: MAINTAINERS: add maintainers for all PC Engines mainboards ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/61259/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/16406/ : SUCCESS -- To view, visit https://review.coreboot.org/21732 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic5855257900fe6e1e8dd3551f1427a4fe51924b1 Gerrit-Change-Number: 21732 Gerrit-PatchSet: 2 Gerrit-Owner: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Reviewer: Kamil Wcisło <kamil.wcislo(a)3mdeb.com> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 28 Sep 2017 14:42:44 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: ifdtool: port the feature to set AltMeDisable/HAP bit here
by build bot (Jenkins) (Code Review) 28 Sep '17

28 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21437 ) Change subject: ifdtool: port the feature to set AltMeDisable/HAP bit here ...................................................................... Patch Set 49: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/61258/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/16405/ : SUCCESS -- To view, visit https://review.coreboot.org/21437 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9a2ecc60cfbb9ee9d96f15be3d53226cb428729a Gerrit-Change-Number: 21437 Gerrit-PatchSet: 49 Gerrit-Owner: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nicola Corna <nicola(a)corna.info> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 28 Sep 2017 14:41:51 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: ifdtool: improve the "new layout" feature
by build bot (Jenkins) (Code Review) 28 Sep '17

28 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21315 ) Change subject: ifdtool: improve the "new layout" feature ...................................................................... Patch Set 63: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/61255/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/16402/ : SUCCESS -- To view, visit https://review.coreboot.org/21315 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia2b92c3f835f9849a243a48c37588c2dbe7449bf Gerrit-Change-Number: 21315 Gerrit-PatchSet: 63 Gerrit-Owner: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Christopher Douglass <cdouglass.orion(a)gmail.com> Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: Nicola Corna <nicola(a)corna.info> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philippe Mathieu-Daudé <f4bug(a)amsat.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 28 Sep 2017 14:33:53 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: arch/x86: CAR setup CQOS
by build bot (Jenkins) (Code Review) 28 Sep '17

28 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21701 ) Change subject: arch/x86: CAR setup CQOS ...................................................................... Patch Set 4: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/61254/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/16401/ : SUCCESS -- To view, visit https://review.coreboot.org/21701 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic736dba1a46629ff5bf3183082799c0c1468e6d9 Gerrit-Change-Number: 21701 Gerrit-PatchSet: 4 Gerrit-Owner: Naresh Solanki <naresh.solanki(a)intel.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: AndreX Andraos <andrex.andraos(a)intel.com> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 28 Sep 2017 14:05:32 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: arch/x86: CAR setup CQOS
by Naresh Solanki (Code Review) 28 Sep '17

28 Sep '17

Naresh Solanki has uploaded this change for review. ( https://review.coreboot.org/21701 Change subject: arch/x86: CAR setup CQOS ...................................................................... arch/x86: CAR setup CQOS Enable CQOS on Geminilake. In Appololake, CBM_LEN is 0x7. Whereas the same in Geminilake is 0xF. Thus get CBM_LEN using cpuid instruction & generate CBM_LEN_MASK. Later use the CBM_LEN_MASK when writing to IA32_L2_MASK_* to set right bits. BUG=None TEST= Build for Geminilake platform i.e., glkrvp & check for successful CAR setup. Even verified the same on APL platfrom i.e., on Reef Change-Id: Ic736dba1a46629ff5bf3183082799c0c1468e6d9 Signed-off-by: Naresh G Solanki <naresh.solanki(a)intel.com --- M src/soc/intel/common/block/cpu/car/cache_as_ram.S 1 file changed, 29 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/21701/4 diff --git a/src/soc/intel/common/block/cpu/car/cache_as_ram.S b/src/soc/intel/common/block/cpu/car/cache_as_ram.S index 94e2694..9475c8c 100644 --- a/src/soc/intel/common/block/cpu/car/cache_as_ram.S +++ b/src/soc/intel/common/block/cpu/car/cache_as_ram.S @@ -255,6 +255,25 @@ .global car_cqos car_cqos: /* + * Create CBM_LEN_MASK based on CBM_LEN + * Get CPUID.(EAX=10H, ECX=2H):EAX.CBM_LEN[bits 4:0] + */ + mov $0x10, %eax + mov $0x2, %ecx + cpuid + and $0xF, %eax + add $1, %al + + mov $1, %ebx + xor %ecx, %ecx + mov %al, %cl + shl %cl, %ebx + sub $1, %ebx + + /* Store the CBM_LEN_MASK in mm3 for later use. */ + movd %ebx, %mm3 + + /* * Disable both L1 and L2 prefetcher. For yet-to-understood reason, * prefetchers slow down filling cache with rep stos in CQOS mode. */ @@ -284,7 +303,7 @@ /* Set this mask for initial cache fill */ mov $MSR_L2_QOS_MASK(0), %ecx rdmsr - mov %bl, %al + mov %ebx, %eax wrmsr /* Set CLOS selector to 0 */ @@ -297,8 +316,15 @@ mov $MSR_L2_QOS_MASK(1), %ecx rdmsr /* Invert bits that are to be used for cache */ - mov %bl, %al - xor $~0, %al /* invert 8 bits */ + mov %ebx, %eax + xor $~0, %eax /* invert 32 bits */ + + /* + * Use CBM_LEN_MASK stored in mm3 to set bits based on Capacity Bit + * Mask Length. + */ + movd %mm3, %ebx + and %ebx, %eax wrmsr post_code(0x26) -- To view, visit https://review.coreboot.org/21701 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ic736dba1a46629ff5bf3183082799c0c1468e6d9 Gerrit-Change-Number: 21701 Gerrit-PatchSet: 4 Gerrit-Owner: Naresh Solanki <naresh.solanki(a)intel.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: AndreX Andraos <andrex.andraos(a)intel.com> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com>

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit September 2017