coreboot-gerrit August 2017

coreboot-gerrit@coreboot.org

1 participants
1999 discussions

Change in coreboot[master]: google/edgar: add new board as variant of cyan baseboard
by build bot (Jenkins) (Code Review) 22 Aug '17

22 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21127 ) Change subject: google/edgar: add new board as variant of cyan baseboard ...................................................................... Patch Set 3: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/59061/ : FAILURE https://qa.coreboot.org/job/coreboot-checkpatch/14398/ : SUCCESS -- To view, visit https://review.coreboot.org/21127 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I58548cbbc85828f37c0023e8aa9e09bdca612659 Gerrit-Change-Number: 21127 Gerrit-PatchSet: 3 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 22 Aug 2017 06:31:00 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: google/cyan: Increase RO coreboot size on flash
by build bot (Jenkins) (Code Review) 22 Aug '17

22 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21124 ) Change subject: google/cyan: Increase RO coreboot size on flash ...................................................................... Patch Set 2: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/59057/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/14394/ : SUCCESS -- To view, visit https://review.coreboot.org/21124 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id86bea538a7b82367ea6ddbd3fe3efb1b1c0078d Gerrit-Change-Number: 21124 Gerrit-PatchSet: 2 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 22 Aug 2017 06:30:16 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: google/cyan: Remove support for pre-EVT board
by build bot (Jenkins) (Code Review) 22 Aug '17

22 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21123 ) Change subject: google/cyan: Remove support for pre-EVT board ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/59058/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/14395/ : SUCCESS -- To view, visit https://review.coreboot.org/21123 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I29b32da8064e0743cc9c5df02ce7d3441459ee8f Gerrit-Change-Number: 21123 Gerrit-PatchSet: 2 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 22 Aug 2017 06:30:15 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: google/edgar: add new board as variant of cyan baseboard
by Matt DeVillier (Code Review) 22 Aug '17

22 Aug '17

Hello Paul Menzel, build bot (Jenkins), Martin Roth, I'd like you to reexamine a change. Please visit https://review.coreboot.org/21127 to look at the new patch set (#3). Change subject: google/edgar: add new board as variant of cyan baseboard ...................................................................... google/edgar: add new board as variant of cyan baseboard Add support for google/edgar (Acer Chromebook 14 CB3-431) as a variant of the cyan Braswell basebaseboard. Add common code to the baseboard and selectively apply it on a per-variant basis. Sourced from Chromium branch firmware-edgar-7287.167.B, commit 2319742: Edgar: Add Micron MT52L256M32D1PF-107 SPD data Change-Id: I58548cbbc85828f37c0023e8aa9e09bdca612659 Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com> --- M src/mainboard/google/cyan/Kconfig M src/mainboard/google/cyan/Kconfig.name M src/mainboard/google/cyan/Makefile.inc A src/mainboard/google/cyan/acpi/codec_realtek.asl M src/mainboard/google/cyan/acpi_tables.c M src/mainboard/google/cyan/chromeos.c A src/mainboard/google/cyan/spd/empty.spd.hex A src/mainboard/google/cyan/spd/hynix_dimm_H9CCNNN8JTBLAR-NUD.spd.hex A src/mainboard/google/cyan/spd/mainboard_spd.h A src/mainboard/google/cyan/spd/samsung_dimm_K4E8E304EE-EGCE.spd.hex A src/mainboard/google/cyan/spd/samsung_dimm_K4E8E324EB-EGCF.spd.hex A src/mainboard/google/cyan/variants/edgar/Makefile.inc A src/mainboard/google/cyan/variants/edgar/board_info.txt A src/mainboard/google/cyan/variants/edgar/devicetree.cb A src/mainboard/google/cyan/variants/edgar/gpio.c A src/mainboard/google/cyan/variants/edgar/include/variant/acpi/dptf.asl A src/mainboard/google/cyan/variants/edgar/include/variant/acpi/mainboard.asl A src/mainboard/google/cyan/variants/edgar/include/variant/onboard.h A src/mainboard/google/cyan/variants/edgar/spd.c 19 files changed, 1,053 insertions(+), 6 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/21127/3 -- To view, visit https://review.coreboot.org/21127 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I58548cbbc85828f37c0023e8aa9e09bdca612659 Gerrit-Change-Number: 21127 Gerrit-PatchSet: 3 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: soc/intel/common: Add function to DLOCK PR registers
by build bot (Jenkins) (Code Review) 22 Aug '17

22 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21063 ) Change subject: soc/intel/common: Add function to DLOCK PR registers ...................................................................... Patch Set 6: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/59053/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/14390/ : SUCCESS -- To view, visit https://review.coreboot.org/21063 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I46e1948315ea9489932efdf7d60d6d78ab3948a6 Gerrit-Change-Number: 21063 Gerrit-PatchSet: 6 Gerrit-Owner: Barnali Sarkar <barnali.sarkar(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 22 Aug 2017 06:24:41 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/intel/skylake: Move SPI lock down config after resource allocation
by build bot (Jenkins) (Code Review) 22 Aug '17

22 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21064 ) Change subject: soc/intel/skylake: Move SPI lock down config after resource allocation ...................................................................... Patch Set 6: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/59054/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/14391/ : SUCCESS -- To view, visit https://review.coreboot.org/21064 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8f5a952656e51d3bf365917b90d3056b46f899c5 Gerrit-Change-Number: 21064 Gerrit-PatchSet: 6 Gerrit-Owner: Barnali Sarkar <barnali.sarkar(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 22 Aug 2017 06:24:31 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: google/edgar: add new board as variant of cyan baseboard
by Matt DeVillier (Code Review) 22 Aug '17

22 Aug '17

Hello Paul Menzel, build bot (Jenkins), Martin Roth, I'd like you to reexamine a change. Please visit https://review.coreboot.org/21127 to look at the new patch set (#2). Change subject: google/edgar: add new board as variant of cyan baseboard ...................................................................... google/edgar: add new board as variant of cyan baseboard Add support for google/edgar (Acer Chromebook 14 CB3-431) as a variant of the cyan Braswell basebaseboard. Add common code to the baseboard and selectively apply it on a per-variant basis. Sourced from Chromium branch firmware-edgar-7287.167.B, commit 2319742: Edgar: Add Micron MT52L256M32D1PF-107 SPD data Change-Id: I58548cbbc85828f37c0023e8aa9e09bdca612659 Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com> --- M src/mainboard/google/cyan/Kconfig M src/mainboard/google/cyan/Kconfig.name M src/mainboard/google/cyan/Makefile.inc A src/mainboard/google/cyan/acpi/codec_realtek.asl M src/mainboard/google/cyan/acpi_tables.c M src/mainboard/google/cyan/chromeos.c M src/mainboard/google/cyan/romstage.c A src/mainboard/google/cyan/spd/empty.spd.hex A src/mainboard/google/cyan/spd/hynix_dimm_H9CCNNN8JTBLAR-NUD.spd.hex A src/mainboard/google/cyan/spd/mainboard_spd.h A src/mainboard/google/cyan/spd/samsung_dimm_K4E8E304EE-EGCE.spd.hex A src/mainboard/google/cyan/spd/samsung_dimm_K4E8E324EB-EGCF.spd.hex A src/mainboard/google/cyan/variants/edgar/Makefile.inc A src/mainboard/google/cyan/variants/edgar/board_info.txt A src/mainboard/google/cyan/variants/edgar/devicetree.cb A src/mainboard/google/cyan/variants/edgar/gpio.c A src/mainboard/google/cyan/variants/edgar/include/variant/acpi/dptf.asl A src/mainboard/google/cyan/variants/edgar/include/variant/acpi/mainboard.asl A src/mainboard/google/cyan/variants/edgar/include/variant/onboard.h A src/mainboard/google/cyan/variants/edgar/spd.c 20 files changed, 1,054 insertions(+), 6 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/21127/2 -- To view, visit https://review.coreboot.org/21127 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I58548cbbc85828f37c0023e8aa9e09bdca612659 Gerrit-Change-Number: 21127 Gerrit-PatchSet: 2 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: google/cyan: convert to variant configuration
by Matt DeVillier (Code Review) 22 Aug '17

22 Aug '17

Hello Paul Menzel, build bot (Jenkins), Martin Roth, I'd like you to reexamine a change. Please visit https://review.coreboot.org/21126 to look at the new patch set (#3). Change subject: google/cyan: convert to variant configuration ...................................................................... google/cyan: convert to variant configuration Setup cyan to be the baseboard for other Google Braswell boards, to be added in subsequent commits. This commit keeps code common to all Google Braswell boards in the cyan baseboard, separates out the board-specific bits into the new cyan variant, and defines the I2C ACPI devices such that they can be easily reused for other variants. It also switches the trackpad/touchscreen interrupts from edge to level, for better performance/compatibility as was done with all previous Google boards. Additionally, a few hardcoded values were replaced with variables, and a few typos/formatting errors were corrected. Change-Id: Iabbbad16efa9cfa79338f4e94d0771779900d8d9 Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com> --- M src/mainboard/google/cyan/Kconfig M src/mainboard/google/cyan/Kconfig.name M src/mainboard/google/cyan/Makefile.inc A src/mainboard/google/cyan/acpi/codec_maxim.asl M src/mainboard/google/cyan/acpi/dptf.asl M src/mainboard/google/cyan/acpi/mainboard.asl M src/mainboard/google/cyan/acpi/superio.asl A src/mainboard/google/cyan/acpi/touchscreen_elan.asl A src/mainboard/google/cyan/acpi/trackpad_elan.asl M src/mainboard/google/cyan/board_info.txt M src/mainboard/google/cyan/boardid.c M src/mainboard/google/cyan/ramstage.c M src/mainboard/google/cyan/smihandler.c R src/mainboard/google/cyan/variants/cyan/Makefile.inc A src/mainboard/google/cyan/variants/cyan/board_info.txt R src/mainboard/google/cyan/variants/cyan/devicetree.cb R src/mainboard/google/cyan/variants/cyan/gpio.c A src/mainboard/google/cyan/variants/cyan/include/variant/acpi/dptf.asl A src/mainboard/google/cyan/variants/cyan/include/variant/acpi/mainboard.asl R src/mainboard/google/cyan/variants/cyan/include/variant/onboard.h R src/mainboard/google/cyan/variants/cyan/spd.c 21 files changed, 380 insertions(+), 267 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/21126/3 -- To view, visit https://review.coreboot.org/21126 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Iabbbad16efa9cfa79338f4e94d0771779900d8d9 Gerrit-Change-Number: 21126 Gerrit-PatchSet: 3 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: drivers/intel/fsp2_0: Link Post PCI enumeration Notify with BS_DEV_EN...
by build bot (Jenkins) (Code Review) 22 Aug '17

22 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21084 ) Change subject: drivers/intel/fsp2_0: Link Post PCI enumeration Notify with BS_DEV_ENABLE ...................................................................... Patch Set 3: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/59055/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/14392/ : SUCCESS -- To view, visit https://review.coreboot.org/21084 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4cb4eac5256c1ce98f51adad0be6e69f7d05d8e1 Gerrit-Change-Number: 21084 Gerrit-PatchSet: 3 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Barnali Sarkar <barnali.sarkar(a)intel.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Kin Wai Ng <kin.wai.ng(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: dhaval v sharma <dhaval.v.sharma(a)intel.com> Gerrit-Comment-Date: Tue, 22 Aug 2017 06:21:22 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/intel/skylake: Remove TCO lock down programming
by build bot (Jenkins) (Code Review) 22 Aug '17

22 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21031 ) Change subject: soc/intel/skylake: Remove TCO lock down programming ...................................................................... Patch Set 7: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/59052/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/14389/ : SUCCESS -- To view, visit https://review.coreboot.org/21031 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iec9e3075df01862f8558b303a458126c68202bff Gerrit-Change-Number: 21031 Gerrit-PatchSet: 7 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Barnali Sarkar <barnali.sarkar(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: dhaval v sharma <dhaval.v.sharma(a)intel.com> Gerrit-Comment-Date: Tue, 22 Aug 2017 06:17:48 +0000 Gerrit-HasComments: No

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit August 2017