coreboot-gerrit August 2017

coreboot-gerrit@coreboot.org

1 participants
1999 discussions

Change in coreboot[master]: soc/intel/common: Early system agent lirary access in postcar stage
by Subrata Banik (Code Review) 22 Aug '17

22 Aug '17

Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/21149 Change subject: soc/intel/common: Early system agent lirary access in postcar stage ...................................................................... soc/intel/common: Early system agent lirary access in postcar stage BRANCH=none BUG=b:63974384 TEST=Build and boot eve successfully. Change-Id: Ie5558cdb7acacc34451e1cf63a3e4239e7901c67 Signed-off-by: Subrata Banik <subrata.banik(a)intel.com> --- M src/soc/intel/common/block/systemagent/Makefile.inc 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/49/21149/1 diff --git a/src/soc/intel/common/block/systemagent/Makefile.inc b/src/soc/intel/common/block/systemagent/Makefile.inc index 81e680b..0c29636 100644 --- a/src/soc/intel/common/block/systemagent/Makefile.inc +++ b/src/soc/intel/common/block/systemagent/Makefile.inc @@ -1,4 +1,5 @@ bootblock-$(CONFIG_SOC_INTEL_COMMON_BLOCK_SA) += systemagent_early.c romstage-$(CONFIG_SOC_INTEL_COMMON_BLOCK_SA) += systemagent_early.c ramstage-$(CONFIG_SOC_INTEL_COMMON_BLOCK_SA) += systemagent_early.c +postcar-$(CONFIG_SOC_INTEL_COMMON_BLOCK_SA) += systemagent_early.c ramstage-$(CONFIG_SOC_INTEL_COMMON_BLOCK_SA) += systemagent.c -- To view, visit https://review.coreboot.org/21149 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ie5558cdb7acacc34451e1cf63a3e4239e7901c67 Gerrit-Change-Number: 21149 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com>

1 0

Change in coreboot[master]: sb/intel/*: add options to trigger finalize_smm() during normal boot ...
by build bot (Jenkins) (Code Review) 22 Aug '17

22 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21129 ) Change subject: sb/intel/*: add options to trigger finalize_smm() during normal boot path ...................................................................... Patch Set 6: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/59069/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/14405/ : SUCCESS -- To view, visit https://review.coreboot.org/21129 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I43d4142291c8737b29738c41e8c484328b297b55 Gerrit-Change-Number: 21129 Gerrit-PatchSet: 6 Gerrit-Owner: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 22 Aug 2017 12:23:35 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: sb/intel/*: add options to trigger finalize_smm() during normal boot ...
by build bot (Jenkins) (Code Review) 22 Aug '17

22 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21129 ) Change subject: sb/intel/*: add options to trigger finalize_smm() during normal boot path ...................................................................... Patch Set 5: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/59068/ : ABORTED https://qa.coreboot.org/job/coreboot-checkpatch/14404/ : SUCCESS -- To view, visit https://review.coreboot.org/21129 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I43d4142291c8737b29738c41e8c484328b297b55 Gerrit-Change-Number: 21129 Gerrit-PatchSet: 5 Gerrit-Owner: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 22 Aug 2017 12:16:13 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: sb/intel/*: add options to trigger finalize_smm() during normal boot ...
by build bot (Jenkins) (Code Review) 22 Aug '17

22 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21129 ) Change subject: sb/intel/*: add options to trigger finalize_smm() during normal boot path ...................................................................... Patch Set 4: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/59067/ : ABORTED https://qa.coreboot.org/job/coreboot-checkpatch/14403/ : SUCCESS -- To view, visit https://review.coreboot.org/21129 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I43d4142291c8737b29738c41e8c484328b297b55 Gerrit-Change-Number: 21129 Gerrit-PatchSet: 4 Gerrit-Owner: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 22 Aug 2017 12:15:37 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: sb/intel/common/spi.c: Port to i82801gx
by Patrick Rudolph (Code Review) 22 Aug '17

22 Aug '17

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/21113 ) Change subject: sb/intel/common/spi.c: Port to i82801gx ...................................................................... Patch Set 3: (3 comments) https://review.coreboot.org/#/c/21113/3/src/southbridge/intel/common/spi.c File src/southbridge/intel/common/spi.c: https://review.coreboot.org/#/c/21113/3/src/southbridge/intel/common/spi.c@… PS3, Line 342: if ((cntlr.hsfs & HSFS_FDV) && !IS_ENABLED(CONFIG_SOUTHBRIDGE_INTEL_I82801GX)) move into else block ? https://review.coreboot.org/#/c/21113/3/src/southbridge/intel/common/spi.c@… PS3, Line 678: u32 mask = IS_ENABLED(CONFIG_SOUTHBRIDGE_INTEL_I82801GX) ? 0x00ffffff const https://review.coreboot.org/#/c/21113/3/src/southbridge/intel/common/spi.c@… PS3, Line 680: uint32_t addr_old = readl_(cntlr.addr) & ~mask; const -- To view, visit https://review.coreboot.org/21113 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I39199f3279a8b76e290b6693adc50dc2ac0ccf23 Gerrit-Change-Number: 21113 Gerrit-PatchSet: 3 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 22 Aug 2017 11:39:16 +0000 Gerrit-HasComments: Yes

1 0

Change in coreboot[master]: payloads/external/iPXE: Add more Kconfig options
by Paul Menzel (Code Review) 22 Aug '17

22 Aug '17

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/20782 ) Change subject: payloads/external/iPXE: Add more Kconfig options ...................................................................... Patch Set 2: Code-Review+1 (3 comments) https://review.coreboot.org/#/c/20782/2//COMMIT_MSG Commit Message: https://review.coreboot.org/#/c/20782/2//COMMIT_MSG@9 PS2, Line 9: now more https://review.coreboot.org/#/c/20782/2//COMMIT_MSG@11 PS2, Line 11: that disable *that disables* or *disabling* https://review.coreboot.org/#/c/20782/2/payloads/external/iPXE/Kconfig File payloads/external/iPXE/Kconfig: https://review.coreboot.org/#/c/20782/2/payloads/external/iPXE/Kconfig@86 PS2, Line 86: Dont Don’t -- To view, visit https://review.coreboot.org/20782 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie1083d8571d9d1f1c7c71659fb6ff0de2eecad0e Gerrit-Change-Number: 20782 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 22 Aug 2017 10:25:40 +0000 Gerrit-HasComments: Yes

1 0

Change in coreboot[master]: util/inteltool: Remove duplicated error message, switch to snprintf
by Nico Huber (Code Review) 22 Aug '17

22 Aug '17

Nico Huber has submitted this change and it was merged. ( https://review.coreboot.org/21025 ) Change subject: util/inteltool: Remove duplicated error message, switch to snprintf ...................................................................... util/inteltool: Remove duplicated error message, switch to snprintf Passing a string containing output from strerror() to perror() causes double error message display. It is also causing segfaults when the error message is longer than temp_string capacity. To fix the problems, sterror() call has been removed so the error message is printed only once. This could be enough to avoid segfaults, but it is a good practice to limit output size with snprintf(). Change-Id: I5ccc37e404f278cafae0a451c5acaa27d7907cce Signed-off-by: Maciej Suminski <maciej.suminski(a)cern.ch> Reviewed-on: https://review.coreboot.org/21025 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Nico Huber <nico.h(a)gmx.de> --- M util/inteltool/cpu.c 1 file changed, 5 insertions(+), 7 deletions(-) Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved diff --git a/util/inteltool/cpu.c b/util/inteltool/cpu.c index 7b2e503..360b86b 100644 --- a/util/inteltool/cpu.c +++ b/util/inteltool/cpu.c @@ -117,14 +117,13 @@ *fd = open(dev, mode); if (*fd < 0) { - sprintf(temp_string, - "open(\"%s\"): %s\n", dev, strerror(errno)); + snprintf(temp_string, sizeof(temp_string), "open(\"%s\")", dev); perror(temp_string); return -1; } if (lseek(*fd, msr, SEEK_SET) == (off_t)-1) { - sprintf(temp_string, "lseek(%lu): %s\n", msr, strerror(errno)); + snprintf(temp_string, sizeof(temp_string), "lseek(%lu)", msr); perror(temp_string); close(*fd); return -1; @@ -141,7 +140,8 @@ char temp_string[50]; if (open_and_seek(cpu, addr, O_RDONLY, &fd) < 0) { - sprintf(temp_string, "Could not read MSR for CPU#%d", cpu); + snprintf(temp_string, sizeof(temp_string), + "Could not read MSR for CPU#%d", cpu); perror(temp_string); } @@ -194,13 +194,11 @@ #ifndef __DARWIN__ int ncpus = get_number_of_cpus(); int i = 0; - char temp_string[50]; printf("\n============= Dumping INTEL SGX status ============="); if (ncpus < 1) { - sprintf(temp_string, "Failed to get number of CPUs\n"); - perror(temp_string); + perror("Failed to get number of CPUs"); error = -1; } else { printf("\nNumber of CPUs = %d\n", ncpus); -- To view, visit https://review.coreboot.org/21025 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I5ccc37e404f278cafae0a451c5acaa27d7907cce Gerrit-Change-Number: 21025 Gerrit-PatchSet: 6 Gerrit-Owner: Maciej Suminski <maciej.suminski(a)cern.ch> Gerrit-Reviewer: Maciej Suminski <maciej.suminski(a)cern.ch> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: util/inteltool: Remove duplicated error message, switch to snprintf
by Nico Huber (Code Review) 22 Aug '17

22 Aug '17

Nico Huber has posted comments on this change. ( https://review.coreboot.org/21025 ) Change subject: util/inteltool: Remove duplicated error message, switch to snprintf ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://review.coreboot.org/21025 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5ccc37e404f278cafae0a451c5acaa27d7907cce Gerrit-Change-Number: 21025 Gerrit-PatchSet: 5 Gerrit-Owner: Maciej Suminski <maciej.suminski(a)cern.ch> Gerrit-Reviewer: Maciej Suminski <maciej.suminski(a)cern.ch> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 22 Aug 2017 10:10:31 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mb/google/soraka: Camera PMIC runtime power control
by Paul Menzel (Code Review) 22 Aug '17

22 Aug '17

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/20741 ) Change subject: mb/google/soraka: Camera PMIC runtime power control ...................................................................... Patch Set 8: (3 comments) https://review.coreboot.org/#/c/20741/8//COMMIT_MSG Commit Message: https://review.coreboot.org/#/c/20741/8//COMMIT_MSG@9 PS8, Line 9: PMIC(tps68470) Please add a space before the `(`. https://review.coreboot.org/#/c/20741/8/src/mainboard/google/poppy/acpi/mip… File src/mainboard/google/poppy/acpi/mipi_camera.asl: https://review.coreboot.org/#/c/20741/8/src/mainboard/google/poppy/acpi/mip… PS8, Line 32: * Turn on 3V3_VDD. It takes around 1 ms : * for volatge to settle to 3.3 Volt. : * Provide additional 2 ms before we : * enable regulators. The allowed text width is longer. https://review.coreboot.org/#/c/20741/8/src/mainboard/google/poppy/acpi/mip… PS8, Line 59: * This reset is avoided in S3 & S0ix resume. Do not reset PMIC in S3 & S0ix resume. -- To view, visit https://review.coreboot.org/20741 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I23b0c0a887c9eb5d29b89f14aebba273b01228e0 Gerrit-Change-Number: 20741 Gerrit-PatchSet: 8 Gerrit-Owner: Naresh Solanki <naresh.solanki(a)intel.com> Gerrit-Reviewer: Divagar Mohandass <divagar.mohandass(a)intel.corp-partner.google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Lakshmi G Prasad <lakshmi.g.prasad(a)intel.com> Gerrit-Reviewer: Naresh Solanki <naresh.solanki(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Rajmohan Mani <rajmohan.mani(a)intel.com> Gerrit-Reviewer: Ricky Liang <jcliang(a)google.com> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Tomasz Figa <tfiga(a)google.com> Gerrit-Reviewer: V Sowmya <v.sowmya(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: rushikesh s kadam <rushikesh.s.kadam(a)intel.com> Gerrit-Comment-Date: Tue, 22 Aug 2017 10:09:21 +0000 Gerrit-HasComments: Yes

1 0

Change in coreboot[master]: mb/google/soraka: Camera PMIC runtime power control
by Naresh Solanki (Code Review) 22 Aug '17

22 Aug '17

Naresh Solanki has posted comments on this change. ( https://review.coreboot.org/20741 ) Change subject: mb/google/soraka: Camera PMIC runtime power control ...................................................................... Patch Set 8: (1 comment) https://review.coreboot.org/#/c/20741/8/src/mainboard/google/poppy/variants… File src/mainboard/google/poppy/variants/soraka/gpio.c: https://review.coreboot.org/#/c/20741/8/src/mainboard/google/poppy/variants… PS8, Line 146: PAD_CFG_GPO(GPP_C11, 0, DEEP), > Is there any update on this. We are currently waiting on this change to ver 1. Will update in poppy as well. 2. test are done except for power number. @Rushikesh: Please update with power numbers. -- To view, visit https://review.coreboot.org/20741 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I23b0c0a887c9eb5d29b89f14aebba273b01228e0 Gerrit-Change-Number: 20741 Gerrit-PatchSet: 8 Gerrit-Owner: Naresh Solanki <naresh.solanki(a)intel.com> Gerrit-Reviewer: Divagar Mohandass <divagar.mohandass(a)intel.corp-partner.google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Lakshmi G Prasad <lakshmi.g.prasad(a)intel.com> Gerrit-Reviewer: Naresh Solanki <naresh.solanki(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Rajmohan Mani <rajmohan.mani(a)intel.com> Gerrit-Reviewer: Ricky Liang <jcliang(a)google.com> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Tomasz Figa <tfiga(a)google.com> Gerrit-Reviewer: V Sowmya <v.sowmya(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: rushikesh s kadam <rushikesh.s.kadam(a)intel.com> Gerrit-Comment-Date: Tue, 22 Aug 2017 09:26:54 +0000 Gerrit-HasComments: Yes

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit August 2017