coreboot-gerrit August 2017

coreboot-gerrit@coreboot.org

1 participants
1999 discussions

Change in coreboot[master]: mainboard/lenovo: add Lenovo Z61t laptop
by build bot (Jenkins) (Code Review) 22 Aug '17

22 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21019 ) Change subject: mainboard/lenovo: add Lenovo Z61t laptop ...................................................................... Patch Set 6: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/59093/ : FAILURE https://qa.coreboot.org/job/coreboot-checkpatch/14429/ : SUCCESS -- To view, visit https://review.coreboot.org/21019 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I84c89cc47d3db126d827f92d50270954bc42f224 Gerrit-Change-Number: 21019 Gerrit-PatchSet: 6 Gerrit-Owner: Andrey Korolyov <andrey(a)xdel.ru> Gerrit-Reviewer: Andrey Korolyov <andrey(a)xdel.ru> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 22 Aug 2017 16:41:02 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: arch/x86/Kconfig: Add deprecation warnings for LATE_CBMEM_INIT
by build bot (Jenkins) (Code Review) 22 Aug '17

22 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21112 ) Change subject: arch/x86/Kconfig: Add deprecation warnings for LATE_CBMEM_INIT ...................................................................... Patch Set 4: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/59091/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/14427/ : SUCCESS -- To view, visit https://review.coreboot.org/21112 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2d21a6ab2fc2811d44fc4febb05841bb2f8d1857 Gerrit-Change-Number: 21112 Gerrit-PatchSet: 4 Gerrit-Owner: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 22 Aug 2017 16:35:12 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: src/mainboard/intel/cannonlake: Add gpio support for cannonlake
by John Zhao (Code Review) 22 Aug '17

22 Aug '17

John Zhao has posted comments on this change. ( https://review.coreboot.org/21139 ) Change subject: src/mainboard/intel/cannonlake: Add gpio support for cannonlake ...................................................................... Patch Set 2: (1 comment) https://review.coreboot.org/#/c/21139/1/src/mainboard/intel/cannonlake_rvp/… File src/mainboard/intel/cannonlake_rvp/variants/baseboard/gpio.c: https://review.coreboot.org/#/c/21139/1/src/mainboard/intel/cannonlake_rvp/… PS1, Line 30: /* A7 : PRIQAB_GSP10_CS1B */ : PAD_CFG_GPI_ACPI_SCI(GPP_A7, 20K_PU, PLTRST, NONE), > i think you should put the comment after macro for the same pin. The gpio pins configuration and comments format is consistent with other platforms like poppy. -- To view, visit https://review.coreboot.org/21139 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia077a070979401fe7bd23bda110d2b66a038d9fc Gerrit-Change-Number: 21139 Gerrit-PatchSet: 2 Gerrit-Owner: John Zhao <john.zhao(a)intel.corp-partner.google.com> Gerrit-Reviewer: John Zhao <john.zhao(a)intel.com> Gerrit-Reviewer: John Zhao <john.zhao(a)intel.corp-partner.google.com> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 22 Aug 2017 16:32:15 +0000 Gerrit-HasComments: Yes

1 0

Change in coreboot[master]: src/mainboard/intel/cannonlake: Add gpio support for cannonlake
by build bot (Jenkins) (Code Review) 22 Aug '17

22 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21139 ) Change subject: src/mainboard/intel/cannonlake: Add gpio support for cannonlake ...................................................................... Patch Set 2: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/59092/ : FAILURE https://qa.coreboot.org/job/coreboot-checkpatch/14428/ : SUCCESS -- To view, visit https://review.coreboot.org/21139 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia077a070979401fe7bd23bda110d2b66a038d9fc Gerrit-Change-Number: 21139 Gerrit-PatchSet: 2 Gerrit-Owner: John Zhao <john.zhao(a)intel.corp-partner.google.com> Gerrit-Reviewer: John Zhao <john.zhao(a)intel.com> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 22 Aug 2017 16:30:58 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: src/mainboard/intel/cannonlake: Add gpio support for cannonlake
by John Zhao (Code Review) 22 Aug '17

22 Aug '17

Hello Pratikkumar V Prajapati, John Zhao, Paul Menzel, build bot (Jenkins), Lijian Zhao, I'd like you to reexamine a change. Please visit https://review.coreboot.org/21139 to look at the new patch set (#2). Change subject: src/mainboard/intel/cannonlake: Add gpio support for cannonlake ...................................................................... src/mainboard/intel/cannonlake: Add gpio support for cannonlake Add gpio pins configuration for cannonlake rvp u/y boards. Change-Id: Ia077a070979401fe7bd23bda110d2b66a038d9fc Signed-off-by: john zhao <john.zhao(a)intel.com> --- M src/mainboard/intel/cannonlake_rvp/Kconfig M src/mainboard/intel/cannonlake_rvp/Makefile.inc A src/mainboard/intel/cannonlake_rvp/bootblock.c A src/mainboard/intel/cannonlake_rvp/chromeos.c A src/mainboard/intel/cannonlake_rvp/variants/baseboard/Makefile.inc A src/mainboard/intel/cannonlake_rvp/variants/baseboard/gpio.c A src/mainboard/intel/cannonlake_rvp/variants/baseboard/include/baseboard/gpio.h A src/mainboard/intel/cannonlake_rvp/variants/baseboard/include/baseboard/variants.h A src/mainboard/intel/cannonlake_rvp/variants/cnl_u/include/variants/gpio.h A src/mainboard/intel/cannonlake_rvp/variants/cnl_y/include/variant/gpio.h 10 files changed, 545 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/39/21139/2 -- To view, visit https://review.coreboot.org/21139 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ia077a070979401fe7bd23bda110d2b66a038d9fc Gerrit-Change-Number: 21139 Gerrit-PatchSet: 2 Gerrit-Owner: John Zhao <john.zhao(a)intel.corp-partner.google.com> Gerrit-Reviewer: John Zhao <john.zhao(a)intel.com> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: soc/intel/apollolake: Allow overriding dev tree settings by board
by build bot (Jenkins) (Code Review) 22 Aug '17

22 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21142 ) Change subject: soc/intel/apollolake: Allow overriding dev tree settings by board ...................................................................... Patch Set 4: Verified-1 Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/59084/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/14420/ : SUCCESS -- To view, visit https://review.coreboot.org/21142 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I349b1678d9e66022b586b6c7f344b831ed631c74 Gerrit-Change-Number: 21142 Gerrit-PatchSet: 4 Gerrit-Owner: Kane Chen <kane.chen(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Kane Chen <kane.chen(a)intel.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Tim Chen <Tim-Chen(a)quantatw.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 22 Aug 2017 16:17:07 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: amd/padmelon: Fix up PCIe settings
by build bot (Jenkins) (Code Review) 22 Aug '17

22 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21039 ) Change subject: amd/padmelon: Fix up PCIe settings ...................................................................... Patch Set 6: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/59083/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/14419/ : SUCCESS -- To view, visit https://review.coreboot.org/21039 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id638c2bc980d5d2bfb4d49290fa24b9869543814 Gerrit-Change-Number: 21039 Gerrit-PatchSet: 6 Gerrit-Owner: John E. Kabat <sljkrr(a)gmail.com> Gerrit-Reviewer: John E. Kabat Jr. <john.kabat(a)scarletltd.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 22 Aug 2017 15:35:27 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: amd/padmelon: Fix up PCIe settings
by John E. Kabat Jr. (Code Review) 22 Aug '17

22 Aug '17

John E. Kabat Jr. has uploaded a new patch set (#6) to the change originally created by John E. Kabat. ( https://review.coreboot.org/21039 ) Change subject: amd/padmelon: Fix up PCIe settings ...................................................................... amd/padmelon: Fix up PCIe settings Change devicetree.cb and OemCustomize.c to match the board's design. This has been checked with a Merlin Falcon APU. Brown Falcon supports only 4 Gfx lanes. Add the missing PSP device to the devicetree, remove the extraneous "hudson" HDA device, and move the two "kern" HDAs to northbridge (see "root complex" diagram in the BKDG). Change-Id: Id638c2bc980d5d2bfb4d49290fa24b9869543814 Signed-off-by: Marshall Dawson <marshalldawson3rd(a)gmail.com> Signed-off-by: John Kabat <john.kabat(a)scarletltd.com> --- M src/mainboard/amd/padmelon/OemCustomize.c M src/mainboard/amd/padmelon/devicetree.cb 2 files changed, 21 insertions(+), 20 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/39/21039/6 -- To view, visit https://review.coreboot.org/21039 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Id638c2bc980d5d2bfb4d49290fa24b9869543814 Gerrit-Change-Number: 21039 Gerrit-PatchSet: 6 Gerrit-Owner: John E. Kabat <sljkrr(a)gmail.com> Gerrit-Reviewer: John E. Kabat Jr. <john.kabat(a)scarletltd.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: amd/padmelon: Add fintek superio to devicetree
by build bot (Jenkins) (Code Review) 22 Aug '17

22 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21038 ) Change subject: amd/padmelon: Add fintek superio to devicetree ...................................................................... Patch Set 9: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/59082/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/14418/ : SUCCESS -- To view, visit https://review.coreboot.org/21038 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I73d128d5fa4227c05fcebe1ed2a3ac98b4923426 Gerrit-Change-Number: 21038 Gerrit-PatchSet: 9 Gerrit-Owner: John E. Kabat <sljkrr(a)gmail.com> Gerrit-Reviewer: John E. Kabat Jr. <john.kabat(a)scarletltd.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 22 Aug 2017 15:22:00 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: amd/padmelon: Add fintek superio to devicetree
by John E. Kabat Jr. (Code Review) 22 Aug '17

22 Aug '17

John E. Kabat Jr. has uploaded a new patch set (#9) to the change originally created by John E. Kabat. ( https://review.coreboot.org/21038 ) Change subject: amd/padmelon: Add fintek superio to devicetree ...................................................................... amd/padmelon: Add fintek superio to devicetree Add the path to the device and enable the two UARTs. Leave other devices disabled. Change-Id: I73d128d5fa4227c05fcebe1ed2a3ac98b4923426 Signed-off-by: Marshall Dawson <marshalldawson3rd(a)gmail.com> Signed-off-by: John Kabat <john.kabat(a)scarletltd.com> --- M src/mainboard/amd/padmelon/devicetree.cb 1 file changed, 27 insertions(+), 11 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/38/21038/9 -- To view, visit https://review.coreboot.org/21038 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I73d128d5fa4227c05fcebe1ed2a3ac98b4923426 Gerrit-Change-Number: 21038 Gerrit-PatchSet: 9 Gerrit-Owner: John E. Kabat <sljkrr(a)gmail.com> Gerrit-Reviewer: John E. Kabat Jr. <john.kabat(a)scarletltd.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit August 2017