coreboot-gerrit August 2017

coreboot-gerrit@coreboot.org

1 participants
1999 discussions

Change in coreboot[master]: mainboard/intel/cannonlake_rvp: set Max CPUs and Mainboard Family
by build bot (Jenkins) (Code Review) 22 Aug '17

22 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21152 ) Change subject: mainboard/intel/cannonlake_rvp: set Max CPUs and Mainboard Family ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/59098/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/14433/ : SUCCESS -- To view, visit https://review.coreboot.org/21152 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic6ef7e4f247ac2d227bab3b53512c659c5e72da7 Gerrit-Change-Number: 21152 Gerrit-PatchSet: 1 Gerrit-Owner: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 22 Aug 2017 18:08:05 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/intel/cannonlake: Add cpu.c and MP init support
by build bot (Jenkins) (Code Review) 22 Aug '17

22 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21081 ) Change subject: soc/intel/cannonlake: Add cpu.c and MP init support ...................................................................... Patch Set 4: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/59099/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/14434/ : SUCCESS -- To view, visit https://review.coreboot.org/21081 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia33691c17c663d704abf65320d4bf1262239524d Gerrit-Change-Number: 21081 Gerrit-PatchSet: 4 Gerrit-Owner: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 22 Aug 2017 18:07:10 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: util/hugo: Add `serve` target for hugo's builtin webserver
by build bot (Jenkins) (Code Review) 22 Aug '17

22 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21153 ) Change subject: util/hugo: Add `serve` target for hugo's builtin webserver ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/59100/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/14435/ : SUCCESS -- To view, visit https://review.coreboot.org/21153 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idea9e27330de6407171ebb9984422257dd460c6d Gerrit-Change-Number: 21153 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 22 Aug 2017 18:06:19 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: util/hugo: Add `serve` target for hugo's builtin webserver
by Nico Huber (Code Review) 22 Aug '17

22 Aug '17

Nico Huber has uploaded this change for review. ( https://review.coreboot.org/21153 Change subject: util/hugo: Add `serve` target for hugo's builtin webserver ...................................................................... util/hugo: Add `serve` target for hugo's builtin webserver Change-Id: Idea9e27330de6407171ebb9984422257dd460c6d Signed-off-by: Nico Huber <nico.h(a)gmx.de> --- M util/hugo/Makefile 1 file changed, 5 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/53/21153/1 diff --git a/util/hugo/Makefile b/util/hugo/Makefile index d76c00a..4fe09a2 100644 --- a/util/hugo/Makefile +++ b/util/hugo/Makefile @@ -1,5 +1,5 @@ .SILENT: -.PHONY: error public +.PHONY: error serve public error: echo please state a valid target @@ -9,5 +9,9 @@ mkdir -p themes git clone https://github.com/digitalcraftsman/hugo-material-docs.git themes/hugo-material-docs +serve: themes/hugo-material-docs + -docker network create --subnet 172.23.0.0/30 hugonet 2>/dev/null + docker run --rm -it -v $$PWD:/src:ro -v $$PWD/../../Documentation:/src/content:ro --network hugonet --ip=172.23.0.2 jguyomard/hugo-builder hugo server --bind=172.23.0.2 -b http://172.23.0.2/Documentation/ + public: themes/hugo-material-docs docker run --rm -v $$PWD:/src:ro -v $$PWD/../../Documentation:/src/content:ro -v /srv/www/vhosts/www.coreboot.org/Documentation:/src/public jguyomard/hugo-builder hugo --forceSyncStatic --cleanDestinationDir -- To view, visit https://review.coreboot.org/21153 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Idea9e27330de6407171ebb9984422257dd460c6d Gerrit-Change-Number: 21153 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>

1 0

Change in coreboot[master]: mainboard/intel/cannonlake_rvp: set Max CPUs and Mainboard Family
by Pratikkumar V Prajapati (Code Review) 22 Aug '17

22 Aug '17

Pratikkumar V Prajapati has uploaded this change for review. ( https://review.coreboot.org/21152 Change subject: mainboard/intel/cannonlake_rvp: set Max CPUs and Mainboard Family ...................................................................... mainboard/intel/cannonlake_rvp: set Max CPUs and Mainboard Family Set MAX_CPUS and MAINBOARD_FAMILY for cannonlake RVP. Signed-off-by: Pratik Prajapati <pratikkumar.v.prajapati(a)intel.com> Change-Id: Ic6ef7e4f247ac2d227bab3b53512c659c5e72da7 --- M src/mainboard/intel/cannonlake_rvp/Kconfig 1 file changed, 8 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/21152/1 diff --git a/src/mainboard/intel/cannonlake_rvp/Kconfig b/src/mainboard/intel/cannonlake_rvp/Kconfig index c59abcf..35afb07 100644 --- a/src/mainboard/intel/cannonlake_rvp/Kconfig +++ b/src/mainboard/intel/cannonlake_rvp/Kconfig @@ -23,6 +23,14 @@ string default "Intel" +config MAINBOARD_FAMILY + string + default "Intel_cannonlake_rvp" + +config MAX_CPUS + int + default 8 + config DEVICETREE string default "variants/$(CONFIG_VARIANT_DIR)/devicetree.cb" -- To view, visit https://review.coreboot.org/21152 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ic6ef7e4f247ac2d227bab3b53512c659c5e72da7 Gerrit-Change-Number: 21152 Gerrit-PatchSet: 1 Gerrit-Owner: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com>

1 0

Change in coreboot[master]: [WIP, UNTESTED]cpu/amdk8: Depreciate LATE_CBMEM_INIT
by build bot (Jenkins) (Code Review) 22 Aug '17

22 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21151 ) Change subject: [WIP,UNTESTED]cpu/amdk8: Depreciate LATE_CBMEM_INIT ...................................................................... Patch Set 3: Verified-1 Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/59096/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/14432/ : SUCCESS -- To view, visit https://review.coreboot.org/21151 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ief7dd6d6f450fb8ed9dd4d36b099f3c0072b6b2e Gerrit-Change-Number: 21151 Gerrit-PatchSet: 3 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 22 Aug 2017 17:21:47 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: [WIP, UNTESTED]cpu/amdk8: Depreciate LATE_CBMEM_INIT
by build bot (Jenkins) (Code Review) 22 Aug '17

22 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21151 ) Change subject: [WIP,UNTESTED]cpu/amdk8: Depreciate LATE_CBMEM_INIT ...................................................................... Patch Set 2: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/59095/ : ABORTED https://qa.coreboot.org/job/coreboot-checkpatch/14431/ : SUCCESS -- To view, visit https://review.coreboot.org/21151 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ief7dd6d6f450fb8ed9dd4d36b099f3c0072b6b2e Gerrit-Change-Number: 21151 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 22 Aug 2017 16:59:51 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: [WIP, UNTESTED]cpu/amdk8: Depreciate LATE_CBMEM_INIT
by build bot (Jenkins) (Code Review) 22 Aug '17

22 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21151 ) Change subject: [WIP,UNTESTED]cpu/amdk8: Depreciate LATE_CBMEM_INIT ...................................................................... Patch Set 1: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/59094/ : ABORTED https://qa.coreboot.org/job/coreboot-checkpatch/14430/ : SUCCESS -- To view, visit https://review.coreboot.org/21151 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ief7dd6d6f450fb8ed9dd4d36b099f3c0072b6b2e Gerrit-Change-Number: 21151 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 22 Aug 2017 16:57:46 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: [WIP, UNTESTED]cpu/amdk8: Depreciate LATE_CBMEM_INIT
by Arthur Heymans (Code Review) 22 Aug '17

22 Aug '17

Arthur Heymans has uploaded a new patch set (#2). ( https://review.coreboot.org/21151 ) Change subject: [WIP,UNTESTED]cpu/amdk8: Depreciate LATE_CBMEM_INIT ...................................................................... [WIP,UNTESTED]cpu/amdk8: Depreciate LATE_CBMEM_INIT Change-Id: Ief7dd6d6f450fb8ed9dd4d36b099f3c0072b6b2e Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/cpu/amd/model_fxx/Makefile.inc A src/cpu/amd/model_fxx/ram_calc.c A src/cpu/amd/model_fxx/ram_calc.h M src/northbridge/amd/amdk8/Kconfig M src/northbridge/amd/amdk8/northbridge.c 5 files changed, 104 insertions(+), 44 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/51/21151/2 -- To view, visit https://review.coreboot.org/21151 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ief7dd6d6f450fb8ed9dd4d36b099f3c0072b6b2e Gerrit-Change-Number: 21151 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>

1 0

Change in coreboot[master]: [WIP, UNTESTED]cpu/amdk8: Depreciate LATE_CBMEM_INIT
by Arthur Heymans (Code Review) 22 Aug '17

22 Aug '17

Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/21151 Change subject: [WIP,UNTESTED]cpu/amdk8: Depreciate LATE_CBMEM_INIT ...................................................................... [WIP,UNTESTED]cpu/amdk8: Depreciate LATE_CBMEM_INIT Change-Id: Ief7dd6d6f450fb8ed9dd4d36b099f3c0072b6b2e Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/cpu/amd/model_fxx/Makefile.inc A src/cpu/amd/model_fxx/ram_calc.c A src/cpu/amd/model_fxx/ram_calc.h M src/northbridge/amd/amdk8/Kconfig M src/northbridge/amd/amdk8/northbridge.c 5 files changed, 104 insertions(+), 44 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/51/21151/1 diff --git a/src/cpu/amd/model_fxx/Makefile.inc b/src/cpu/amd/model_fxx/Makefile.inc index 4d8153a..31eeeb7 100644 --- a/src/cpu/amd/model_fxx/Makefile.inc +++ b/src/cpu/amd/model_fxx/Makefile.inc @@ -5,5 +5,7 @@ ramstage-y += model_fxx_update_microcode.c ramstage-y += processor_name.c ramstage-$(CONFIG_HAVE_ACPI_TABLES) += powernow_acpi.c +romstage-y += ram_calc.c +ramstage-y += ram_calc.c cpu_microcode_bins += 3rdparty/blobs/cpu/amd/model_fxx/microcode.bin diff --git a/src/cpu/amd/model_fxx/ram_calc.c b/src/cpu/amd/model_fxx/ram_calc.c new file mode 100644 index 0000000..34f1ebb --- /dev/null +++ b/src/cpu/amd/model_fxx/ram_calc.c @@ -0,0 +1,79 @@ +/* + * This file is part of the coreboot project. + * + * Copyright (C) 2015 Timothy Pearson <tpearson(a)raptorengineeringinc.com>, Raptor Engineering + * Copyright (C) 2007 Advanced Micro Devices, Inc. + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; version 2 of the License. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + +#include <cpu/cpu.h> +#include <cpu/x86/msr.h> +#include <cpu/amd/mtrr.h> + +#include <arch/io.h> +#include <device/device.h> +#include <device/pci.h> + +#include <cbmem.h> + +#include "ram_calc.h" + +uint64_t get_uma_memory_size(uint64_t topmem) +{ + uint64_t uma_size = 0; + +#if IS_ENABLED(CONFIG_GFXUMA) +#if !IS_ENABLED(CONFIG_BOARD_ASROCK_939A785GMH) && \ + !IS_ENABLED(CONFIG_BOARD_AMD_MAHOGANY) + + switch (topmem) { + case 0x10000000: /* 256M system memory */ + uma_memory_size = 0x2000000; /* 32M recommended UMA */ + break; + + case 0x18000000: /* 384M system memory */ + uma_memory_size = 0x4000000; /* 64M recommended UMA */ + break; + + case 0x20000000: /* 512M system memory */ + uma_memory_size = 0x4000000; /* 64M recommended UMA */ + break; + + default: /* 1GB and above system memory */ + uma_memory_size = 0x8000000; /* 128M recommended UMA */ + break; + } +#else + /* refer to UMA Size Consideration in 780 BDG. */ + switch (topmem) { + case 0x10000000: /* 256M system memory */ + uma_memory_size = 0x4000000; /* 64M recommended UMA */ + break; + + case 0x20000000: /* 512M system memory */ + uma_memory_size = 0x8000000; /* 128M recommended UMA */ + break; + + default: /* 1GB and above system memory */ + uma_memory_size = 0x10000000; /* 256M recommended UMA */ + break; + } +#endif +#endif + return uma_size; +} + +void *cbmem_top(void) +{ + uint32_t topmem = rdmsr(TOP_MEM).lo; + + return (void *) topmem - get_uma_memory_size(topmem); +} diff --git a/src/cpu/amd/model_fxx/ram_calc.h b/src/cpu/amd/model_fxx/ram_calc.h new file mode 100644 index 0000000..b780fe2 --- /dev/null +++ b/src/cpu/amd/model_fxx/ram_calc.h @@ -0,0 +1,21 @@ +/* + * This file is part of the coreboot project. + * + * Copyright (C) 2015 Timothy Pearson <tpearson(a)raptorengineeringinc.com>, Raptor Engineering + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; version 2 of the License. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + +#ifndef _AMD_MODEL_FXX_RAM_CALC_H_ +#define _AMD_MODEL_FXX_RAM_CALC_H_ + +uint64_t get_uma_memory_size(uint64_t topmem); + +#endif diff --git a/src/northbridge/amd/amdk8/Kconfig b/src/northbridge/amd/amdk8/Kconfig index 83f70c9..0acd5d7 100644 --- a/src/northbridge/amd/amdk8/Kconfig +++ b/src/northbridge/amd/amdk8/Kconfig @@ -19,7 +19,6 @@ select HAVE_DEBUG_SMBUS select HAVE_DEBUG_CAR select HYPERTRANSPORT_PLUGIN_SUPPORT - select LATE_CBMEM_INIT if NORTHBRIDGE_AMD_AMDK8 diff --git a/src/northbridge/amd/amdk8/northbridge.c b/src/northbridge/amd/amdk8/northbridge.c index 2a92ca2..140c53d 100644 --- a/src/northbridge/amd/amdk8/northbridge.c +++ b/src/northbridge/amd/amdk8/northbridge.c @@ -36,6 +36,7 @@ #include <cpu/amd/model_fxx_rev.h> #include <cpu/amd/amdk8_sysconf.h> +#include <cpu/amd/model_fxx/ram_calc.h> struct amdk8_sysconf_t sysconf; @@ -807,51 +808,12 @@ } #endif -#include <cbmem.h> - static void setup_uma_memory(void) { #if IS_ENABLED(CONFIG_GFXUMA) uint32_t topmem = (uint32_t) bsp_topmem(); -#if !IS_ENABLED(CONFIG_BOARD_ASROCK_939A785GMH) && \ - !IS_ENABLED(CONFIG_BOARD_AMD_MAHOGANY) - - switch (topmem) { - case 0x10000000: /* 256M system memory */ - uma_memory_size = 0x2000000; /* 32M recommended UMA */ - break; - - case 0x18000000: /* 384M system memory */ - uma_memory_size = 0x4000000; /* 64M recommended UMA */ - break; - - case 0x20000000: /* 512M system memory */ - uma_memory_size = 0x4000000; /* 64M recommended UMA */ - break; - - default: /* 1GB and above system memory */ - uma_memory_size = 0x8000000; /* 128M recommended UMA */ - break; - } -#else - /* refer to UMA Size Consideration in 780 BDG. */ - switch (topmem) { - case 0x10000000: /* 256M system memory */ - uma_memory_size = 0x4000000; /* 64M recommended UMA */ - break; - - case 0x20000000: /* 512M system memory */ - uma_memory_size = 0x8000000; /* 128M recommended UMA */ - break; - - default: /* 1GB and above system memory */ - uma_memory_size = 0x10000000; /* 256M recommended UMA */ - break; - } -#endif - - uma_memory_base = topmem - uma_memory_size; /* TOP_MEM1 */ + uma_memory_base = topmem - get_uma_memory_size(topmem); /* TOP_MEM1 */ printk(BIOS_INFO, "%s: uma size 0x%08llx, memory start 0x%08llx\n", __func__, uma_memory_size, uma_memory_base); #endif @@ -1000,10 +962,7 @@ } #if IS_ENABLED(CONFIG_GFXUMA) - set_late_cbmem_top(uma_memory_base); uma_resource(dev, 7, uma_memory_base >> 10, uma_memory_size >> 10); -#else - set_late_cbmem_top(ramtop); #endif assign_resources(dev->link_list); -- To view, visit https://review.coreboot.org/21151 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ief7dd6d6f450fb8ed9dd4d36b099f3c0072b6b2e Gerrit-Change-Number: 21151 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit August 2017