coreboot-gerrit August 2017

coreboot-gerrit@coreboot.org

1 participants
1999 discussions

Change in coreboot[master]: soc/intel/cannonlake: Fix Coverity scan error
by Lijian Zhao (Code Review) 23 Aug '17

23 Aug '17

Lijian Zhao has uploaded this change for review. ( https://review.coreboot.org/21155 Change subject: soc/intel/cannonlake: Fix Coverity scan error ...................................................................... soc/intel/cannonlake: Fix Coverity scan error Add dummy PMC pci driver to avoid coverity scan error. Bug:CID 1379849 Change-Id: Ica19735307736c8a55c29af88db8b1372f8779e4 Signed-off-by: Lijian Zhao <lijian.zhao(a)intel.com> --- M src/soc/intel/cannonlake/Makefile.inc A src/soc/intel/cannonlake/pmc.c 2 files changed, 39 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/55/21155/1 diff --git a/src/soc/intel/cannonlake/Makefile.inc b/src/soc/intel/cannonlake/Makefile.inc index 10d444b..e1a37f3 100644 --- a/src/soc/intel/cannonlake/Makefile.inc +++ b/src/soc/intel/cannonlake/Makefile.inc @@ -27,6 +27,7 @@ ramstage-y += chip.c ramstage-y += gspi.c ramstage-y += memmap.c +ramstage-y += pmc.c ramstage-y += pmutil.c ramstage-$(CONFIG_PLATFORM_USES_FSP2_0) += reset.c ramstage-y += spi.c diff --git a/src/soc/intel/cannonlake/pmc.c b/src/soc/intel/cannonlake/pmc.c new file mode 100644 index 0000000..9043805 --- /dev/null +++ b/src/soc/intel/cannonlake/pmc.c @@ -0,0 +1,38 @@ +/* + * This file is part of the coreboot project. + * + * Copyright (C) 2008-2009 coresystems GmbH + * Copyright (C) 2014 Google Inc. + * Copyright (C) 2017 Intel Corporation. + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; version 2 of the License. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + +#include <device/device.h> +#include <device/pci.h> +#include <device/pci_ids.h> +#include <soc/ramstage.h> + +static struct device_operations device_ops = { + .read_resources = &pci_dev_read_resources, + .set_resources = &pci_dev_set_resources, + .enable_resources = &pci_dev_enable_resources, +}; + +static const unsigned short pci_device_ids[] = { + PCI_DEVICE_ID_INTEL_CNL_PMC, + 0 +}; + +static const struct pci_driver pch_lpc __pci_driver = { + .ops = &device_ops, + .vendor = PCI_VENDOR_ID_INTEL, + .devices = pci_device_ids, +}; -- To view, visit https://review.coreboot.org/21155 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ica19735307736c8a55c29af88db8b1372f8779e4 Gerrit-Change-Number: 21155 Gerrit-PatchSet: 1 Gerrit-Owner: Lijian Zhao <lijian.zhao(a)intel.com>

1 0

Change in coreboot[master]: buildgcc: Update GCC to 7.1.0
by guqr (Code Review) 23 Aug '17

23 Aug '17

guqr has posted comments on this change. ( https://review.coreboot.org/20809 ) Change subject: buildgcc: Update GCC to 7.1.0 ...................................................................... Patch Set 2: Could you update to 7.2? https://gcc.gnu.org/gcc-7/ -- To view, visit https://review.coreboot.org/20809 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I85ee0efc6497ba8a38f6295e30524c90c689d909 Gerrit-Change-Number: 20809 Gerrit-PatchSet: 2 Gerrit-Owner: Iru Cai <mytbk920423(a)gmail.com> Gerrit-Reviewer: Idwer Vollering <vidwer(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: guqr Gerrit-Comment-Date: Wed, 23 Aug 2017 00:39:35 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: amd/pi/hudson: Clean up makefile.inc
by Martin Roth (Code Review) 22 Aug '17

22 Aug '17

Martin Roth has posted comments on this change. ( https://review.coreboot.org/19640 ) Change subject: amd/pi/hudson: Clean up makefile.inc ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/19640 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic8c6ca2b57527fcc96c135cc801a098201bf0465 Gerrit-Change-Number: 19640 Gerrit-PatchSet: 2 Gerrit-Owner: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 22 Aug 2017 22:37:26 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: src/mainboard/intel/cannonlake: Add gpio support for cannonlake
by build bot (Jenkins) (Code Review) 22 Aug '17

22 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21139 ) Change subject: src/mainboard/intel/cannonlake: Add gpio support for cannonlake ...................................................................... Patch Set 4: Verified-1 Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/59120/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/14455/ : SUCCESS -- To view, visit https://review.coreboot.org/21139 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia077a070979401fe7bd23bda110d2b66a038d9fc Gerrit-Change-Number: 21139 Gerrit-PatchSet: 4 Gerrit-Owner: John Zhao <john.zhao(a)intel.corp-partner.google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: John Zhao <john.zhao(a)intel.com> Gerrit-Reviewer: John Zhao <john.zhao(a)intel.corp-partner.google.com> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 22 Aug 2017 22:11:02 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/intel/skylake: Enable common SMM code for SKL
by build bot (Jenkins) (Code Review) 22 Aug '17

22 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19440 ) Change subject: soc/intel/skylake: Enable common SMM code for SKL ...................................................................... Patch Set 26: Verified-1 Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/59119/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/14454/ : SUCCESS -- To view, visit https://review.coreboot.org/19440 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icdbde4cf39703ce10283715d2a28e501de489aae Gerrit-Change-Number: 19440 Gerrit-PatchSet: 26 Gerrit-Owner: Brandon Breitenstein <brandon.breitenstein(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Brandon Breitenstein <brandon.breitenstein(a)intel.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Shaunak Saha <shaunak.saha(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 22 Aug 2017 20:06:04 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: [WIP, UNTESTED]cpu/amdk8: Depreciate LATE_CBMEM_INIT
by build bot (Jenkins) (Code Review) 22 Aug '17

22 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21151 ) Change subject: [WIP,UNTESTED]cpu/amdk8: Depreciate LATE_CBMEM_INIT ...................................................................... Patch Set 4: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/59101/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/14436/ : SUCCESS -- To view, visit https://review.coreboot.org/21151 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ief7dd6d6f450fb8ed9dd4d36b099f3c0072b6b2e Gerrit-Change-Number: 21151 Gerrit-PatchSet: 4 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 22 Aug 2017 18:27:05 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: src/mainboard/intel/cannonlake: Add gpio support for cannonlake
by build bot (Jenkins) (Code Review) 22 Aug '17

22 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21139 ) Change subject: src/mainboard/intel/cannonlake: Add gpio support for cannonlake ...................................................................... Patch Set 3: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/59102/ : FAILURE https://qa.coreboot.org/job/coreboot-checkpatch/14437/ : SUCCESS -- To view, visit https://review.coreboot.org/21139 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia077a070979401fe7bd23bda110d2b66a038d9fc Gerrit-Change-Number: 21139 Gerrit-PatchSet: 3 Gerrit-Owner: John Zhao <john.zhao(a)intel.corp-partner.google.com> Gerrit-Reviewer: John Zhao <john.zhao(a)intel.com> Gerrit-Reviewer: John Zhao <john.zhao(a)intel.corp-partner.google.com> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 22 Aug 2017 18:22:25 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: src/mainboard/intel/cannonlake: Add gpio support for cannonlake
by John Zhao (Code Review) 22 Aug '17

22 Aug '17

Hello Pratikkumar V Prajapati, John Zhao, Paul Menzel, build bot (Jenkins), Lijian Zhao, I'd like you to reexamine a change. Please visit https://review.coreboot.org/21139 to look at the new patch set (#3). Change subject: src/mainboard/intel/cannonlake: Add gpio support for cannonlake ...................................................................... src/mainboard/intel/cannonlake: Add gpio support for cannonlake Add gpio pins configuration for cannonlake rvp u/y boards. Change-Id: Ia077a070979401fe7bd23bda110d2b66a038d9fc Signed-off-by: john zhao <john.zhao(a)intel.com> --- M src/mainboard/intel/cannonlake_rvp/Kconfig M src/mainboard/intel/cannonlake_rvp/Makefile.inc A src/mainboard/intel/cannonlake_rvp/bootblock.c A src/mainboard/intel/cannonlake_rvp/chromeos.c A src/mainboard/intel/cannonlake_rvp/variants/baseboard/Makefile.inc A src/mainboard/intel/cannonlake_rvp/variants/baseboard/gpio.c A src/mainboard/intel/cannonlake_rvp/variants/baseboard/include/baseboard/gpio.h A src/mainboard/intel/cannonlake_rvp/variants/baseboard/include/baseboard/variants.h A src/mainboard/intel/cannonlake_rvp/variants/cnl_u/include/variants/gpio.h A src/mainboard/intel/cannonlake_rvp/variants/cnl_y/include/variant/gpio.h 10 files changed, 545 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/39/21139/3 -- To view, visit https://review.coreboot.org/21139 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ia077a070979401fe7bd23bda110d2b66a038d9fc Gerrit-Change-Number: 21139 Gerrit-PatchSet: 3 Gerrit-Owner: John Zhao <john.zhao(a)intel.corp-partner.google.com> Gerrit-Reviewer: John Zhao <john.zhao(a)intel.com> Gerrit-Reviewer: John Zhao <john.zhao(a)intel.corp-partner.google.com> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: [WIP, UNTESTED]cpu/amdk8: Depreciate LATE_CBMEM_INIT
by Arthur Heymans (Code Review) 22 Aug '17

22 Aug '17

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/21151 to look at the new patch set (#4). Change subject: [WIP,UNTESTED]cpu/amdk8: Depreciate LATE_CBMEM_INIT ...................................................................... [WIP,UNTESTED]cpu/amdk8: Depreciate LATE_CBMEM_INIT Change-Id: Ief7dd6d6f450fb8ed9dd4d36b099f3c0072b6b2e Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/cpu/amd/model_fxx/Makefile.inc A src/cpu/amd/model_fxx/ram_calc.c A src/cpu/amd/model_fxx/ram_calc.h M src/northbridge/amd/amdk8/Kconfig M src/northbridge/amd/amdk8/northbridge.c M src/southbridge/via/vt8237r/lpc.c 6 files changed, 104 insertions(+), 50 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/51/21151/4 -- To view, visit https://review.coreboot.org/21151 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ief7dd6d6f450fb8ed9dd4d36b099f3c0072b6b2e Gerrit-Change-Number: 21151 Gerrit-PatchSet: 4 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: [WIP, UNTESTED]cpu/amdk8: Depreciate LATE_CBMEM_INIT
by Arthur Heymans (Code Review) 22 Aug '17

22 Aug '17

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/21151 ) Change subject: [WIP,UNTESTED]cpu/amdk8: Depreciate LATE_CBMEM_INIT ...................................................................... Patch Set 3: Code-Review-2 No idea if cbmem is even initialised all targets... -- To view, visit https://review.coreboot.org/21151 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ief7dd6d6f450fb8ed9dd4d36b099f3c0072b6b2e Gerrit-Change-Number: 21151 Gerrit-PatchSet: 3 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 22 Aug 2017 18:18:27 +0000 Gerrit-HasComments: No

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit August 2017