coreboot-gerrit August 2017

coreboot-gerrit@coreboot.org

1 participants
1999 discussions

Change in coreboot[master]: google/kahlee: Enable ALS connected to EC
by build bot (Jenkins) (Code Review) 22 Aug '17

22 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21146 ) Change subject: google/kahlee: Enable ALS connected to EC ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/59046/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/14383/ : SUCCESS -- To view, visit https://review.coreboot.org/21146 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id1138a0fc5270489a734bdf8b1f4ac02d358c0df Gerrit-Change-Number: 21146 Gerrit-PatchSet: 1 Gerrit-Owner: Akshu Agrawal <akshu.agrawal(a)amd.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 22 Aug 2017 06:16:56 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/intel/skylake: Move DMI lock down config after resource allocation
by build bot (Jenkins) (Code Review) 22 Aug '17

22 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21030 ) Change subject: soc/intel/skylake: Move DMI lock down config after resource allocation ...................................................................... Patch Set 7: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/59051/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/14388/ : SUCCESS -- To view, visit https://review.coreboot.org/21030 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie66701d5bd8c8f389e23fb30c8595dd83cf6b1ae Gerrit-Change-Number: 21030 Gerrit-PatchSet: 7 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Barnali Sarkar <barnali.sarkar(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: dhaval v sharma <dhaval.v.sharma(a)intel.com> Gerrit-Comment-Date: Tue, 22 Aug 2017 06:14:57 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mb/google/soraka: Camera PMIC runtime power control
by Furquan Shaikh (Code Review) 22 Aug '17

22 Aug '17

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/20741 ) Change subject: mb/google/soraka: Camera PMIC runtime power control ...................................................................... Patch Set 8: (1 comment) Is https://review.coreboot.org/#/c/20741/8/src/mainboard/google/poppy/variants… File src/mainboard/google/poppy/variants/soraka/gpio.c: https://review.coreboot.org/#/c/20741/8/src/mainboard/google/poppy/variants… PS8, Line 146: PAD_CFG_GPO(GPP_C11, 0, DEEP), > this change should be done for poppy/gpio.c as well. Is there any update on this. We are currently waiting on this change to verify the behavior of camera on boot-up and confirm power consumption in suspend states. For now we can skip the about suggestion of separate gpio table. But we at least need following two things: 1. This gpio change needs to be done for poppy as well 2. Did you confirm the tests that Rajmohan mentioned along with the changes in this CL? -- To view, visit https://review.coreboot.org/20741 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I23b0c0a887c9eb5d29b89f14aebba273b01228e0 Gerrit-Change-Number: 20741 Gerrit-PatchSet: 8 Gerrit-Owner: Naresh Solanki <naresh.solanki(a)intel.com> Gerrit-Reviewer: Divagar Mohandass <divagar.mohandass(a)intel.corp-partner.google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Lakshmi G Prasad <lakshmi.g.prasad(a)intel.com> Gerrit-Reviewer: Naresh Solanki <naresh.solanki(a)intel.com> Gerrit-Reviewer: Rajmohan Mani <rajmohan.mani(a)intel.com> Gerrit-Reviewer: Ricky Liang <jcliang(a)google.com> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Tomasz Figa <tfiga(a)google.com> Gerrit-Reviewer: V Sowmya <v.sowmya(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 22 Aug 2017 06:14:45 +0000 Gerrit-HasComments: Yes

1 0

Change in coreboot[master]: soc/intel/skylake: Move LPC lock down config after resource allocation
by build bot (Jenkins) (Code Review) 22 Aug '17

22 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21000 ) Change subject: soc/intel/skylake: Move LPC lock down config after resource allocation ...................................................................... Patch Set 9: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/59049/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/14386/ : SUCCESS -- To view, visit https://review.coreboot.org/21000 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I705a3a3c6ddc72ae7895419442d67b82f541edee Gerrit-Change-Number: 21000 Gerrit-PatchSet: 9 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Barnali Sarkar <barnali.sarkar(a)intel.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: dhaval v sharma <dhaval.v.sharma(a)intel.com> Gerrit-Comment-Date: Tue, 22 Aug 2017 06:13:04 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/intel/skylake: Move PMC lock down config after resource allocation
by build bot (Jenkins) (Code Review) 22 Aug '17

22 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21029 ) Change subject: soc/intel/skylake: Move PMC lock down config after resource allocation ...................................................................... Patch Set 7: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/59050/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/14387/ : SUCCESS -- To view, visit https://review.coreboot.org/21029 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibd86a38fa78752ce007da63a9ccdd991ca21ab92 Gerrit-Change-Number: 21029 Gerrit-PatchSet: 7 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Barnali Sarkar <barnali.sarkar(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: dhaval v sharma <dhaval.v.sharma(a)intel.com> Gerrit-Comment-Date: Tue, 22 Aug 2017 06:12:41 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/intel/skylake: Add LPC and SPI lock down config option
by build bot (Jenkins) (Code Review) 22 Aug '17

22 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21068 ) Change subject: soc/intel/skylake: Add LPC and SPI lock down config option ...................................................................... Patch Set 6: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/59048/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/14385/ : SUCCESS -- To view, visit https://review.coreboot.org/21068 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If174915b4d0c581f36b54b2b8cd970a93c6454bc Gerrit-Change-Number: 21068 Gerrit-PatchSet: 6 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Barnali Sarkar <barnali.sarkar(a)intel.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: dhaval v sharma <dhaval.v.sharma(a)intel.com> Gerrit-Comment-Date: Tue, 22 Aug 2017 06:10:45 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/intel/common: Move update_mrc_cache after BS_DEV_ENUMERATE
by build bot (Jenkins) (Code Review) 22 Aug '17

22 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21028 ) Change subject: soc/intel/common: Move update_mrc_cache after BS_DEV_ENUMERATE ...................................................................... Patch Set 8: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/59047/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/14384/ : SUCCESS -- To view, visit https://review.coreboot.org/21028 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8ee26b5cc70433438cf4e45e707b8a54f89cf9b0 Gerrit-Change-Number: 21028 Gerrit-PatchSet: 8 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Barnali Sarkar <barnali.sarkar(a)intel.com> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Kin Wai Ng <kin.wai.ng(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: dhaval v sharma <dhaval.v.sharma(a)intel.com> Gerrit-Comment-Date: Tue, 22 Aug 2017 06:07:50 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: google/kahlee: Enable ALS connected to EC
by Akshu Agrawal (Code Review) 22 Aug '17

22 Aug '17

Akshu Agrawal has uploaded this change for review. ( https://review.coreboot.org/21146 Change subject: google/kahlee: Enable ALS connected to EC ...................................................................... google/kahlee: Enable ALS connected to EC Kahlee has an ambient light sensor connected to the EC Change-Id: Id1138a0fc5270489a734bdf8b1f4ac02d358c0df Signed-off-by: Akshu Agrawal <akshu.agrawal(a)amd.com> --- M src/mainboard/google/kahlee/ec.h 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/46/21146/1 diff --git a/src/mainboard/google/kahlee/ec.h b/src/mainboard/google/kahlee/ec.h index b8b5af8..deb2cb1 100644 --- a/src/mainboard/google/kahlee/ec.h +++ b/src/mainboard/google/kahlee/ec.h @@ -61,6 +61,9 @@ /* Enable LID switch */ #define EC_ENABLE_LID_SWITCH +/* Enable EC backed ALS device in ACPI */ +#define EC_ENABLE_ALS_DEVICE + #define SIO_EC_MEMMAP_ENABLE /* EC Memory Map Resources */ #define SIO_EC_HOST_ENABLE /* EC Host Interface Resources */ #define SIO_EC_ENABLE_PS2K /* Enable PS/2 Keyboard */ -- To view, visit https://review.coreboot.org/21146 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Id1138a0fc5270489a734bdf8b1f4ac02d358c0df Gerrit-Change-Number: 21146 Gerrit-PatchSet: 1 Gerrit-Owner: Akshu Agrawal <akshu.agrawal(a)amd.com>

1 0

Change in coreboot[master]: mb/google/soraka: Camera PMIC runtime power control
by build bot (Jenkins) (Code Review) 22 Aug '17

22 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20741 ) Change subject: mb/google/soraka: Camera PMIC runtime power control ...................................................................... Patch Set 8: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/59044/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/14381/ : SUCCESS -- To view, visit https://review.coreboot.org/20741 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I23b0c0a887c9eb5d29b89f14aebba273b01228e0 Gerrit-Change-Number: 20741 Gerrit-PatchSet: 8 Gerrit-Owner: Naresh Solanki <naresh.solanki(a)intel.com> Gerrit-Reviewer: Divagar Mohandass <divagar.mohandass(a)intel.corp-partner.google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Lakshmi G Prasad <lakshmi.g.prasad(a)intel.com> Gerrit-Reviewer: Naresh Solanki <naresh.solanki(a)intel.com> Gerrit-Reviewer: Rajmohan Mani <rajmohan.mani(a)intel.com> Gerrit-Reviewer: Ricky Liang <jcliang(a)google.com> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Tomasz Figa <tfiga(a)google.com> Gerrit-Reviewer: V Sowmya <v.sowmya(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 22 Aug 2017 05:52:15 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/intel/apollolake: Allow overriding FSP_S settings by board
by build bot (Jenkins) (Code Review) 22 Aug '17

22 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21142 ) Change subject: soc/intel/apollolake: Allow overriding FSP_S settings by board ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/59045/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/14382/ : SUCCESS -- To view, visit https://review.coreboot.org/21142 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I349b1678d9e66022b586b6c7f344b831ed631c74 Gerrit-Change-Number: 21142 Gerrit-PatchSet: 2 Gerrit-Owner: Kane Chen <kane.chen(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 22 Aug 2017 05:30:45 +0000 Gerrit-HasComments: No

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit August 2017