coreboot-gerrit August 2017

coreboot-gerrit@coreboot.org

1 participants
1999 discussions

Change in coreboot[master]: soc/inte/cannonlake: Define soc_intel_cannonlake_config
by build bot (Jenkins) (Code Review) 21 Aug '17

21 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21080 ) Change subject: soc/inte/cannonlake: Define soc_intel_cannonlake_config ...................................................................... Patch Set 4: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/59026/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/14365/ : SUCCESS -- To view, visit https://review.coreboot.org/21080 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2a6e737594da1e766b157a38942e19a4f7fb9dfa Gerrit-Change-Number: 21080 Gerrit-PatchSet: 4 Gerrit-Owner: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 21 Aug 2017 23:37:54 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: amd/padmelon: Add fintek superio to devicetree
by John E. Kabat Jr. (Code Review) 21 Aug '17

21 Aug '17

Hello Marshall Dawson, I'd like you to do a code review. Please visit https://review.coreboot.org/21138 to review the following change. Change subject: amd/padmelon: Add fintek superio to devicetree ...................................................................... amd/padmelon: Add fintek superio to devicetree Add the path to the device and enable the two UARTs. Leave other devices disabled. Change-Id: I10024d380f1d18e374ab309bc992749688c54e79 Signed-off-by: Marshall Dawson <marshalldawson3rd(a)gmail.com> Signed-off-by: John Kabat <john.kabat(a)scarletltd.com> --- M src/mainboard/amd/padmelon/devicetree.cb 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/38/21138/1 diff --git a/src/mainboard/amd/padmelon/devicetree.cb b/src/mainboard/amd/padmelon/devicetree.cb index 13366d7..8ea5c13 100644 --- a/src/mainboard/amd/padmelon/devicetree.cb +++ b/src/mainboard/amd/padmelon/devicetree.cb @@ -66,7 +66,7 @@ device pnp 4e.5 off end # KBC device pnp 4e.6 off end # GPIO device pnp 4e.7 off end # WDT - device pnp 4e.a on end # PME + device pnp 4e.a off end # PME end # f81803a end # LPC device pci 14.7 on end # SD -- To view, visit https://review.coreboot.org/21138 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I10024d380f1d18e374ab309bc992749688c54e79 Gerrit-Change-Number: 21138 Gerrit-PatchSet: 1 Gerrit-Owner: John E. Kabat Jr. <john.kabat(a)scarletltd.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com>

1 0

Change in coreboot[master]: [WIP] sb/intel: Fix flashconsole on older architectures
by build bot (Jenkins) (Code Review) 21 Aug '17

21 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21107 ) Change subject: [WIP] sb/intel: Fix flashconsole on older architectures ...................................................................... Patch Set 6: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/59025/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/14364/ : SUCCESS -- To view, visit https://review.coreboot.org/21107 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifd3e8621fa4cb349b7e0e07118cab0380f24ff55 Gerrit-Change-Number: 21107 Gerrit-PatchSet: 6 Gerrit-Owner: Nicola Corna <nicola(a)corna.info> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nicola Corna <nicola(a)corna.info> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Youness Alaoui <snifikino(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 21 Aug 2017 22:15:00 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: google/beltino: fix LED polarity for mccloud variant
by build bot (Jenkins) (Code Review) 21 Aug '17

21 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21102 ) Change subject: google/beltino: fix LED polarity for mccloud variant ...................................................................... Patch Set 2: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/59023/ : SUCCESS -- To view, visit https://review.coreboot.org/21102 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia1f63eebbccb48fcf8543188db390b23045d843e Gerrit-Change-Number: 21102 Gerrit-PatchSet: 2 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 21 Aug 2017 21:51:13 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: google/cyan: Fix touchscreen interrupt
by build bot (Jenkins) (Code Review) 21 Aug '17

21 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21122 ) Change subject: google/cyan: Fix touchscreen interrupt ...................................................................... Patch Set 2: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/59024/ : SUCCESS -- To view, visit https://review.coreboot.org/21122 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1c4b029851e321feeedf713186976fbec42dd82e Gerrit-Change-Number: 21122 Gerrit-PatchSet: 2 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Jagadish Krishnamoorthy <jagadish.krishnamoorthy(a)intel.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 21 Aug 2017 21:49:43 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: [WIP] sb/intel: Fix flashconsole on older architectures
by build bot (Jenkins) (Code Review) 21 Aug '17

21 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21107 ) Change subject: [WIP] sb/intel: Fix flashconsole on older architectures ...................................................................... Patch Set 5: Verified-1 Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/59022/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/14363/ : SUCCESS -- To view, visit https://review.coreboot.org/21107 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifd3e8621fa4cb349b7e0e07118cab0380f24ff55 Gerrit-Change-Number: 21107 Gerrit-PatchSet: 5 Gerrit-Owner: Nicola Corna <nicola(a)corna.info> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nicola Corna <nicola(a)corna.info> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Youness Alaoui <snifikino(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 21 Aug 2017 21:44:51 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: google/beltino: fix LED polarity for mccloud variant
by Matt DeVillier (Code Review) 21 Aug '17

21 Aug '17

Hello build bot (Jenkins), Martin Roth, I'd like you to reexamine a change. Please visit https://review.coreboot.org/21102 to look at the new patch set (#2). Change subject: google/beltino: fix LED polarity for mccloud variant ...................................................................... google/beltino: fix LED polarity for mccloud variant The LED polarity was set incorrectly, fix using values derived from original Chromium sources: branch firmware-mccloud-5827.B, ToT src/mainboard/google/mccloud/smihandler.c src/mainboard/google/mccloud/romstage.c TEST: boot google/mccloud, observe power LED on normally, blinking in S3/S4, and off in S5. Change-Id: Ia1f63eebbccb48fcf8543188db390b23045d843e Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com> --- M src/mainboard/google/beltino/variants/mccloud/led.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/21102/2 -- To view, visit https://review.coreboot.org/21102 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ia1f63eebbccb48fcf8543188db390b23045d843e Gerrit-Change-Number: 21102 Gerrit-PatchSet: 2 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: [WIP] sb/intel: Fix flashconsole on older architectures
by build bot (Jenkins) (Code Review) 21 Aug '17

21 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21107 ) Change subject: [WIP] sb/intel: Fix flashconsole on older architectures ...................................................................... Patch Set 4: Verified-1 Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/59021/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/14362/ : SUCCESS -- To view, visit https://review.coreboot.org/21107 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifd3e8621fa4cb349b7e0e07118cab0380f24ff55 Gerrit-Change-Number: 21107 Gerrit-PatchSet: 4 Gerrit-Owner: Nicola Corna <nicola(a)corna.info> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nicola Corna <nicola(a)corna.info> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Youness Alaoui <snifikino(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 21 Aug 2017 21:15:28 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mainboard/intel/cannonlake_rvp: remove redundant devicetree.cb
by build bot (Jenkins) (Code Review) 21 Aug '17

21 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21137 ) Change subject: mainboard/intel/cannonlake_rvp: remove redundant devicetree.cb ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/59020/ : SUCCESS -- To view, visit https://review.coreboot.org/21137 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I83f636c93407a6fe17114582506397c46d1b4e20 Gerrit-Change-Number: 21137 Gerrit-PatchSet: 2 Gerrit-Owner: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 21 Aug 2017 20:57:05 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mainboard/intel/cannonlake_rvp: remove redundant devicetree.cb
by Pratikkumar V Prajapati (Code Review) 21 Aug '17

21 Aug '17

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/21137 to look at the new patch set (#2). Change subject: mainboard/intel/cannonlake_rvp: remove redundant devicetree.cb ...................................................................... mainboard/intel/cannonlake_rvp: remove redundant devicetree.cb devicetree.cb of cannonlake-u and y variant gets picked up from src/mainboard/intel/cannonlake_rvp/variants/cnl_[u/y] Change-Id: I83f636c93407a6fe17114582506397c46d1b4e20 Signed-off-by: Pratik Prajapati <pratikkumar.v.prajapati(a)intel.com> --- D src/mainboard/intel/cannonlake_rvp/devicetree.cb 1 file changed, 0 insertions(+), 9 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/37/21137/2 -- To view, visit https://review.coreboot.org/21137 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I83f636c93407a6fe17114582506397c46d1b4e20 Gerrit-Change-Number: 21137 Gerrit-PatchSet: 2 Gerrit-Owner: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit August 2017