coreboot-gerrit August 2017

coreboot-gerrit@coreboot.org

1 participants
1999 discussions

Change in coreboot[master]: soc/intel/apollolake: Allow overriding FSP_S settings by board
by Kane Chen (Code Review) 22 Aug '17

22 Aug '17

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/21142 to look at the new patch set (#2). Change subject: soc/intel/apollolake: Allow overriding FSP_S settings by board ...................................................................... soc/intel/apollolake: Allow overriding FSP_S settings by board This change provides interface to override FSP_S settings per board due to many projects share same devicetree.cb BUG=b:64880573 TEST=Verify that FSP_S settings can be overridden in mainboard on coral Change-Id: I349b1678d9e66022b586b6c7f344b831ed631c74 Signed-off-by: Kane Chen <kane.chen(a)intel.com> --- M src/mainboard/google/reef/mainboard.c M src/mainboard/google/reef/variants/baseboard/include/baseboard/variants.h M src/mainboard/google/reef/variants/coral/mainboard.c M src/soc/intel/apollolake/chip.c 4 files changed, 21 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/42/21142/2 -- To view, visit https://review.coreboot.org/21142 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I349b1678d9e66022b586b6c7f344b831ed631c74 Gerrit-Change-Number: 21142 Gerrit-PatchSet: 2 Gerrit-Owner: Kane Chen <kane.chen(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: mb/google/soraka: Camera PMIC runtime power control
by Naresh Solanki (Code Review) 22 Aug '17

22 Aug '17

Hello Rizwan Qureshi, I'd like you to do a code review. Please visit https://review.coreboot.org/20741 to review the following change. Change subject: mb/google/soraka: Camera PMIC runtime power control ...................................................................... mb/google/soraka: Camera PMIC runtime power control Currently PMIC(tps68470) is in active state even when cameras are not in use. PMIC is put into SLEEP mode only when entering S3 via smihandler. With this change PMIC will be put into SLEEP mode as soon as sensors & VCM voltage outputs are turned off. This will allow runtime power saving when camera is not in use. PMIC will be reset in first boot & not in S3 & S0ix resume. Also remove the smihandler for PMIC power management & handle it as part of sensor and VCM ACPI PowerResource. BUG=b:63903239 TEST= Build for Saraka. Check Camera probe, Capture image before & after S3 & S0ix resume. Change-Id: I23b0c0a887c9eb5d29b89f14aebba273b01228e0 Signed-off-by: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Signed-off-by: Naresh G Solanki <naresh.solanki(a)intel.com> --- M src/mainboard/google/poppy/acpi/mipi_camera.asl M src/mainboard/google/poppy/smihandler.c M src/mainboard/google/poppy/variants/soraka/gpio.c 3 files changed, 52 insertions(+), 8 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/41/20741/8 diff --git a/src/mainboard/google/poppy/acpi/mipi_camera.asl b/src/mainboard/google/poppy/acpi/mipi_camera.asl index 5c75122..68122a6 100644 --- a/src/mainboard/google/poppy/acpi/mipi_camera.asl +++ b/src/mainboard/google/poppy/acpi/mipi_camera.asl @@ -27,6 +27,55 @@ Return (0x0F) } + Method (PMON, 0, Serialized) { + /* + * Turn on 3V3_VDD. It takes around 1 ms + * for volatge to settle to 3.3 Volt. + * Provide additional 2 ms before we + * enable regulators. + */ + STXS(EN_PP3300_DX_CAM) + Sleep (3) + } + + Method (PMOF, 0, Serialized) { + /* + * Make Sure all PMIC outputs are off. + */ + If (LEqual (VSIC, Zero)) { + CTXS(EN_PP3300_DX_CAM) + } + } + + Name (_PR0, Package (0x01) { CPMC }) + Name (_PR3, Package (0x01) { CPMC }) + + /* Power resource methods for PMIC */ + PowerResource (CPMC, 0, 0) { + Name (RSTO, 1) + Method (_ON, 0, Serialized) { + /* + * Reset PMIC once during first boot. + * This reset is avoided in S3 & S0ix resume. + */ + if (Lequal (RSTO, 1)) + { + CTXS(EN_CAM_PMIC_RST_L) + Sleep(1) + STXS(EN_CAM_PMIC_RST_L) + RSTO = 0 + } + PMON() + } + Method (_OFF, 0, Serialized) { + PMOF() + } + Method (_STA, 0, Serialized) { + Local0 = GTXS(EN_PP3300_DX_CAM) + Return (Local0) + } + } + /* Marks the availability of all the operation regions */ Name (AVBL, Zero) Name (AVGP, Zero) @@ -289,6 +338,7 @@ Decrement (VSIC) If (LEqual (VSIC, Zero)) { VSIO = 0 + PMOF() } } } ElseIf (LEqual (Arg0, 1)) { @@ -296,6 +346,7 @@ If (LLess (VSIC, 3)) { /* Turn on VSIO */ If (LEqual (VSIC, Zero)) { + PMON() VSIO = 3 } Increment (VSIC) diff --git a/src/mainboard/google/poppy/smihandler.c b/src/mainboard/google/poppy/smihandler.c index 1a86d0f..70d0ab4 100644 --- a/src/mainboard/google/poppy/smihandler.c +++ b/src/mainboard/google/poppy/smihandler.c @@ -27,17 +27,10 @@ chromeec_smi_process_events(); } -static void mainboard_gpio_smi_sleep(void) -{ - /* Power down camera PMIC */ - gpio_set(EN_PP3300_DX_CAM, 0); -} - void mainboard_smi_sleep(u8 slp_typ) { chromeec_smi_sleep(slp_typ, MAINBOARD_EC_S3_WAKE_EVENTS, MAINBOARD_EC_S5_WAKE_EVENTS); - mainboard_gpio_smi_sleep(); } int mainboard_smi_apmc(u8 apmc) diff --git a/src/mainboard/google/poppy/variants/soraka/gpio.c b/src/mainboard/google/poppy/variants/soraka/gpio.c index 6e0a54f..bf11894 100644 --- a/src/mainboard/google/poppy/variants/soraka/gpio.c +++ b/src/mainboard/google/poppy/variants/soraka/gpio.c @@ -143,7 +143,7 @@ /* C10 : UART0_RTS# ==> EC_CAM_PMIC_RST_L */ PAD_CFG_GPO(GPP_C10, 1, DEEP), /* C11 : UART0_CTS# ==> EN_PP3300_DX_CAM */ - PAD_CFG_GPO(GPP_C11, 1, DEEP), + PAD_CFG_GPO(GPP_C11, 0, DEEP), /* C12 : UART1_RXD ==> PCH_MEM_CONFIG[0] */ PAD_CFG_GPI(GPP_C12, NONE, DEEP), /* C13 : UART1_TXD ==> PCH_MEM_CONFIG[1] */ -- To view, visit https://review.coreboot.org/20741 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I23b0c0a887c9eb5d29b89f14aebba273b01228e0 Gerrit-Change-Number: 20741 Gerrit-PatchSet: 8 Gerrit-Owner: Naresh Solanki <naresh.solanki(a)intel.com> Gerrit-Reviewer: Divagar Mohandass <divagar.mohandass(a)intel.corp-partner.google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Lakshmi G Prasad <lakshmi.g.prasad(a)intel.com> Gerrit-Reviewer: Naresh Solanki <naresh.solanki(a)intel.com> Gerrit-Reviewer: Rajmohan Mani <rajmohan.mani(a)intel.com> Gerrit-Reviewer: Ricky Liang <jcliang(a)google.com> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Tomasz Figa <tfiga(a)google.com> Gerrit-Reviewer: V Sowmya <v.sowmya(a)intel.com>

1 0

Change in coreboot[master]: src/mainboard/intel/cannonlake: Add gpio support for cannonlake
by Pratikkumar V Prajapati (Code Review) 22 Aug '17

22 Aug '17

Pratikkumar V Prajapati has posted comments on this change. ( https://review.coreboot.org/21139 ) Change subject: src/mainboard/intel/cannonlake: Add gpio support for cannonlake ...................................................................... Patch Set 1: (7 comments) https://review.coreboot.org/#/c/21139/1/src/mainboard/intel/cannonlake_rvp/… File src/mainboard/intel/cannonlake_rvp/chromeos.c: https://review.coreboot.org/#/c/21139/1/src/mainboard/intel/cannonlake_rvp/… PS1, Line 21: #include <vendorcode/google/chromeos/chromeos.h> : : #include <variant/gpio.h> order? https://review.coreboot.org/#/c/21139/1/src/mainboard/intel/cannonlake_rvp/… File src/mainboard/intel/cannonlake_rvp/variants/baseboard/gpio.c: https://review.coreboot.org/#/c/21139/1/src/mainboard/intel/cannonlake_rvp/… PS1, Line 24: /* A1 : ESPI_IO_0 */ : /* A2 : ESPI_IO_1 */ : /* A3 : ESPI_IO_2 */ : /* A4 : ESPI_IO_3 */ : /* A5 : ESPI_CSB */ : /* A6 : SERIRQ */ tabs at beginning. https://review.coreboot.org/#/c/21139/1/src/mainboard/intel/cannonlake_rvp/… PS1, Line 30: /* A7 : PRIQAB_GSP10_CS1B */ : PAD_CFG_GPI_ACPI_SCI(GPP_A7, 20K_PU, PLTRST, NONE), i think you should put the comment after macro for the same pin. e.g. PAD_CFG_GPI_ACPI_SCI(GPP_A7, 20K_PU, PLTRST, NONE), /* A7 : PRIQAB_GSP10_CS1B */ https://review.coreboot.org/#/c/21139/1/src/mainboard/intel/cannonlake_rvp/… PS1, Line 71: /* B6 : SRCCLKREQB_1 */ : /* B7 : SRCCLKREQB_2 */ : /* B8 : SRCCLKREQB_3 */ : /* B9 : SRCCLKREQB_4 */ : /* B10 : SRCCLKREQB_5 */ : /* B11 : EXT_PWR_GATEB */ white chars at end of line https://review.coreboot.org/#/c/21139/1/src/mainboard/intel/cannonlake_rvp/… PS1, Line 133: remove extra tab https://review.coreboot.org/#/c/21139/1/src/mainboard/intel/cannonlake_rvp/… PS1, Line 261: white char https://review.coreboot.org/#/c/21139/1/src/mainboard/intel/cannonlake_rvp/… File src/mainboard/intel/cannonlake_rvp/variants/baseboard/include/baseboard/variants.h: https://review.coreboot.org/#/c/21139/1/src/mainboard/intel/cannonlake_rvp/… PS1, Line 23: /* : * The next set of functions return the gpio table and fill in the number of : * entries for each table. : */ /* The next set of functions return the gpio table and fill in the number of * entries for each table. */ -- To view, visit https://review.coreboot.org/21139 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia077a070979401fe7bd23bda110d2b66a038d9fc Gerrit-Change-Number: 21139 Gerrit-PatchSet: 1 Gerrit-Owner: John Zhao <john.zhao(a)intel.corp-partner.google.com> Gerrit-Reviewer: John Zhao <john.zhao(a)intel.com> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 22 Aug 2017 05:11:29 +0000 Gerrit-HasComments: Yes

1 0

Change in coreboot[master]: soc/intel/skylake: Disable PMC XRAM access
by build bot (Jenkins) (Code Review) 22 Aug '17

22 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21135 ) Change subject: soc/intel/skylake: Disable PMC XRAM access ...................................................................... Patch Set 5: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/59043/ : SUCCESS -- To view, visit https://review.coreboot.org/21135 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I69a7972bf083a2e376115c6a6a9eb11dd971188f Gerrit-Change-Number: 21135 Gerrit-PatchSet: 5 Gerrit-Owner: Naresh Solanki <naresh.solanki(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Naresh Solanki <naresh.solanki(a)intel.com> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 22 Aug 2017 04:42:22 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/intel/apollolake: Allow overriding FSP_S settings by board
by build bot (Jenkins) (Code Review) 22 Aug '17

22 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21142 ) Change subject: soc/intel/apollolake: Allow overriding FSP_S settings by board ...................................................................... Patch Set 1: Verified-1 Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/59036/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/14374/ : SUCCESS -- To view, visit https://review.coreboot.org/21142 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I349b1678d9e66022b586b6c7f344b831ed631c74 Gerrit-Change-Number: 21142 Gerrit-PatchSet: 1 Gerrit-Owner: Kane Chen <kane.chen(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 22 Aug 2017 04:20:18 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/intel/apollolake: Allow overriding FSP_S settings by board
by Kane Chen (Code Review) 22 Aug '17

22 Aug '17

Kane Chen has uploaded this change for review. ( https://review.coreboot.org/21142 Change subject: soc/intel/apollolake: Allow overriding FSP_S settings by board ...................................................................... soc/intel/apollolake: Allow overriding FSP_S settings by board This change provides interface to override FSP_S settings per board due to many projects share same devicetree.cb BUG=b:64880573 TEST=Verify that FSP_S settings can be overridden in mainboard on coral Change-Id: I349b1678d9e66022b586b6c7f344b831ed631c74 Signed-off-by: Kane Chen <kane.chen(a)intel.com> --- M src/mainboard/google/reef/mainboard.c M src/mainboard/google/reef/variants/baseboard/include/baseboard/variants.h M src/mainboard/google/reef/variants/coral/mainboard.c M src/soc/intel/apollolake/chip.c 4 files changed, 16 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/42/21142/1 diff --git a/src/mainboard/google/reef/mainboard.c b/src/mainboard/google/reef/mainboard.c index c6b1997..3c52ef0 100644 --- a/src/mainboard/google/reef/mainboard.c +++ b/src/mainboard/google/reef/mainboard.c @@ -82,6 +82,12 @@ *oem_revision = variant_board_sku(); } +void __attribute__((weak)) variant_slicon_config_overrides( + FSP_S_CONFIG *silconfig) +{ + /* Override the FSP_S settings by variant_board_sku() */ +} + static unsigned long mainboard_write_acpi_tables( device_t device, unsigned long current, acpi_rsdp_t *rsdp) { diff --git a/src/mainboard/google/reef/variants/baseboard/include/baseboard/variants.h b/src/mainboard/google/reef/variants/baseboard/include/baseboard/variants.h index 388397b..ad977e8 100644 --- a/src/mainboard/google/reef/variants/baseboard/include/baseboard/variants.h +++ b/src/mainboard/google/reef/variants/baseboard/include/baseboard/variants.h @@ -47,5 +47,6 @@ void variant_nhlt_oem_overrides(const char **oem_id, const char **oem_table_id, uint32_t *oem_revision); void variant_nhlt_init(struct nhlt *nhlt); +void variant_slicon_config_overrides(FSP_S_CONFIG *silconfig); #endif /* BASEBOARD_VARIANTS_H */ diff --git a/src/mainboard/google/reef/variants/coral/mainboard.c b/src/mainboard/google/reef/variants/coral/mainboard.c index 3da5456..cbbbaef 100644 --- a/src/mainboard/google/reef/variants/coral/mainboard.c +++ b/src/mainboard/google/reef/variants/coral/mainboard.c @@ -31,3 +31,8 @@ *oem_table_id = CONFIG_VARIANT_DIR; *oem_revision = variant_board_sku(); } + +void variant_slicon_config_overrides(FSP_S_CONFIG *silconfig) +{ + /* Override the FSP_S settings by variant_board_sku() */ +} diff --git a/src/soc/intel/apollolake/chip.c b/src/soc/intel/apollolake/chip.c index af625a1..23924ae 100644 --- a/src/soc/intel/apollolake/chip.c +++ b/src/soc/intel/apollolake/chip.c @@ -45,6 +45,7 @@ #include <soc/systemagent.h> #include "chip.h" +#include <baseboard/variants.h> static void *vbt; static struct region_device vbt_rdev; @@ -487,6 +488,9 @@ silconfig->PortUsb20HsNpreDrvSel[port] = cfg->usb2eye[port].Usb20HsNpreDrvSel; } + + /* interface to override FSP_S settings per board */ + variant_slicon_config_overrides(silconfig); #endif } -- To view, visit https://review.coreboot.org/21142 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I349b1678d9e66022b586b6c7f344b831ed631c74 Gerrit-Change-Number: 21142 Gerrit-PatchSet: 1 Gerrit-Owner: Kane Chen <kane.chen(a)intel.com>

1 0

Change in coreboot[master]: mainboard/google/coral: Overwrite family code for coral models.
by build bot (Jenkins) (Code Review) 22 Aug '17

22 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21136 ) Change subject: mainboard/google/coral: Overwrite family code for coral models. ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/59035/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/14373/ : SUCCESS -- To view, visit https://review.coreboot.org/21136 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1d8f8ca2166a1d80855608cf5b64b0cc7bf3dc93 Gerrit-Change-Number: 21136 Gerrit-PatchSet: 1 Gerrit-Owner: Harry Pan <harry.pan(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 22 Aug 2017 02:55:41 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mainboard/google/coral: Overwrite family code for coral models.
by Harry Pan (Code Review) 22 Aug '17

22 Aug '17

Harry Pan has uploaded this change for review. ( https://review.coreboot.org/21136 Change subject: mainboard/google/coral: Overwrite family code for coral models. ...................................................................... mainboard/google/coral: Overwrite family code for coral models. This patch assigns the code of coral family, such that, the 'mosys platform family' returns 'Google_Coral'. BUG=b:64467244, b:64501879 BRANCH=none TEST=Examine 'mosys platform family' w/ new firmware. Change-Id: I1d8f8ca2166a1d80855608cf5b64b0cc7bf3dc93 Signed-off-by: Harry Pan <harry.pan(a)intel.com> --- M src/mainboard/google/reef/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/36/21136/1 diff --git a/src/mainboard/google/reef/Kconfig b/src/mainboard/google/reef/Kconfig index f3360ca..61509b9 100644 --- a/src/mainboard/google/reef/Kconfig +++ b/src/mainboard/google/reef/Kconfig @@ -77,6 +77,7 @@ config MAINBOARD_FAMILY string + default "Google_Coral" if BOARD_GOOGLE_CORAL default "Google_Reef" config GBB_HWID -- To view, visit https://review.coreboot.org/21136 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I1d8f8ca2166a1d80855608cf5b64b0cc7bf3dc93 Gerrit-Change-Number: 21136 Gerrit-PatchSet: 1 Gerrit-Owner: Harry Pan <harry.pan(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>

1 0

Change in coreboot[master]: soc/intel/cannonlake: Add cpu.c and MP init support
by build bot (Jenkins) (Code Review) 22 Aug '17

22 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21081 ) Change subject: soc/intel/cannonlake: Add cpu.c and MP init support ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/59032/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/14370/ : SUCCESS -- To view, visit https://review.coreboot.org/21081 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia33691c17c663d704abf65320d4bf1262239524d Gerrit-Change-Number: 21081 Gerrit-PatchSet: 3 Gerrit-Owner: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 22 Aug 2017 02:09:33 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/intel/cannonlake: Define soc_intel_cannonlake_config
by build bot (Jenkins) (Code Review) 22 Aug '17

22 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21080 ) Change subject: soc/intel/cannonlake: Define soc_intel_cannonlake_config ...................................................................... Patch Set 6: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/59033/ : SUCCESS -- To view, visit https://review.coreboot.org/21080 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2a6e737594da1e766b157a38942e19a4f7fb9dfa Gerrit-Change-Number: 21080 Gerrit-PatchSet: 6 Gerrit-Owner: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 22 Aug 2017 01:59:30 +0000 Gerrit-HasComments: No

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit August 2017