coreboot-gerrit March 2017

coreboot-gerrit@coreboot.org

1 participants
2925 discussions

Change in coreboot[master]: siemens/mc_apl1: Activate PTN3460 eDP to LVDS bridge IC
by build bot (Jenkins) (Code Review) 30 Mar '17

30 Mar '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19043 ) Change subject: siemens/mc_apl1: Activate PTN3460 eDP to LVDS bridge IC ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/50959/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/6930/ : SUCCESS -- To view, visit https://review.coreboot.org/19043 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib8fa79bb608f1842f26c1af3d7bf4bb0513fa94d Gerrit-PatchSet: 3 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

Change in coreboot[master]: siemens/mc_apl1: Activate PTN3460 eDP to LVDS bridge IC
by Mario Scheithauer (Code Review) 30 Mar '17

30 Mar '17

1 0

Change in coreboot[master]: siemens/mc_apl1: Activate PTN3460 eDP to LVDS bridge IC
by Mario Scheithauer (Code Review) 30 Mar '17

30 Mar '17

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/19043 to look at the new patch set (#3). Change subject: siemens/mc_apl1: Activate PTN3460 eDP to LVDS bridge IC ...................................................................... siemens/mc_apl1: Activate PTN3460 eDP to LVDS bridge IC This mainboard uses a LVDS connection for LCD panels. Apollo Lake SoC provides a display controller with three independent pipes (1x eDP and 2x DP/HDMI). PTN3460 is an embedded DisplayPort to LVDS bridge device that enables connectivity between an eDP source and LVDS display panel (http://www.nxp.com/documents/data_sheet/PTN3460.pdf). The bridge contains an On-chip Extended Display Identification Data (EDIT) emulation for EDIT data structures. This patch sets up PTN3460 to be used with the appropriate LCD panel. Change-Id: Ib8fa79bb608f1842f26c1af3d7bf4bb0513fa94d Signed-off-by: Mario Scheithauer <mario.scheithauer(a)siemens.com> --- M src/mainboard/siemens/mc_apl1/Makefile.inc M src/mainboard/siemens/mc_apl1/mainboard.c A src/mainboard/siemens/mc_apl1/ptn3460.c A src/mainboard/siemens/mc_apl1/ptn3460.h 4 files changed, 276 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/43/19043/3 -- To view, visit https://review.coreboot.org/19043 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ib8fa79bb608f1842f26c1af3d7bf4bb0513fa94d Gerrit-PatchSet: 3 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins)

1 0

Change in coreboot[master]: siemens/mc_apl1: Activate PTN3460 eDP to LVDS bridge IC
by Mario Scheithauer (Code Review) 30 Mar '17

30 Mar '17

1 0

Change in coreboot[master]: siemens/mc_apl1: Activate PTN3460 eDP to LVDS bridge IC
by Mario Scheithauer (Code Review) 30 Mar '17

30 Mar '17

Mario Scheithauer has posted comments on this change. ( https://review.coreboot.org/19043 ) Change subject: siemens/mc_apl1: Activate PTN3460 eDP to LVDS bridge IC ...................................................................... Patch Set 2: (16 comments) PTN3460 is also included in another Siemens mainboard and we should alter this. But I would do this in a following patch. Thanks all for the review! https://review.coreboot.org/#/c/19043/1//COMMIT_MSG Commit Message: PS1, Line 13: ata_ > EDID? Done https://review.coreboot.org/#/c/19043/1/src/mainboard/siemens/mc_apl1/mainb… File src/mainboard/siemens/mc_apl1/mainboard.c: PS1, Line 116: t status; > Maybe move that into the function? Done PS1, Line 120: * ptn3460_init() > I would completely remove lcd_panel.{c,h} and move the call to ptn3460_init Changed to direct call of ptn3460_init("hwinfo.hex") https://review.coreboot.org/#/c/19043/1/src/mainboard/siemens/mc_apl1/ptn34… File src/mainboard/siemens/mc_apl1/ptn3460.c: PS1, Line 24: function > function Done Line 28: * @return CB_SUCCESS on success or error code. > We have CB_SUCCESS and CB_ERROR defined in `src/include/types.h`. Done PS1, Line 44: size > sizeof(edid_data) changed to sizeof(edid_data) PS1, Line 61: Her > is Done PS1, Line 72: PTN_CONFIG_OFF > This is 0x19 bytes == 24 bytes. You are smashing your stack since sizeof(s changed to sizeof(cfg) here and in the following PS1, Line 75: > skip the s Done PS1, Line 92: /* 250 ms from LVD > Please increase this value to 10 resulting in 500 ms backlight delay. There Done PS1, Line 85: : /* No clock spreading, 300 mV LVDS swing. */ : cfg.lvds_interface_ctrl2 = 0x03; : /* No LVDS signal swap. */ : cfg.lvds_interface_ctrl3 = 0x00; : /* Delay T2 (VDD to LVDS active) by 16 ms. */ : cfg.t2_delay = 1; : /* 250 ms from LVDS to backlight active. */ : cfg.t3_timing = 10; : /* 1 second re-power delay. */ : cfg.t12_timing = 20; : /* 150 ms backlight off to LVDS inactive. */ : cfg.t4_timing = 3; : /* Delay T5 (LVDS to VDD inactive) by 16 ms. */ : cfg.t5_delay = 1; : /* Enable backlight con > I guess this could be made configurable in the devicetree in the future? Yes, you are right. I would do this as part of the PTN driver implementation in a further patch. PS1, Line 106: PTN_CONFI > Cast not needed here as you already made it a uint8_t type. Yes, i2c_write_bytes isn’t available. PS1, Line 141: atus); > Extended Display Identification Data (EDID) I changed this into function description. PS1, Line 154: > DisplayPort Done https://review.coreboot.org/#/c/19043/1/src/mainboard/siemens/mc_apl1/ptn34… File src/mainboard/siemens/mc_apl1/ptn3460.h: PS1, Line 28: N 0x > Aren't you assuming this is ptn_3460_config? If so, then this should be siz deleted the define PS1, Line 90: id(u8 > This should be const char *. Done -- To view, visit https://review.coreboot.org/19043 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib8fa79bb608f1842f26c1af3d7bf4bb0513fa94d Gerrit-PatchSet: 2 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: Yes

1 0

Change in coreboot[master]: siemens/mc_apl1: Activate PTN3460 eDP to LVDS bridge IC
by Werner Zeh (Code Review) 30 Mar '17

30 Mar '17

Werner Zeh has posted comments on this change. ( https://review.coreboot.org/19043 ) Change subject: siemens/mc_apl1: Activate PTN3460 eDP to LVDS bridge IC ...................................................................... Patch Set 2: (1 comment) https://review.coreboot.org/#/c/19043/2/src/mainboard/siemens/mc_apl1/ptn34… File src/mainboard/siemens/mc_apl1/ptn3460.c: PS2, Line 28: CB_SUCCESS Then use it as return value instead of PTN_NO_ERROR. And once you are on this track use CB_ERROR for the "return 1" statements in this function. -- To view, visit https://review.coreboot.org/19043 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib8fa79bb608f1842f26c1af3d7bf4bb0513fa94d Gerrit-PatchSet: 2 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: Yes

1 0

Change in coreboot[master]: siemens/mc_apl1: Activate PTN3460 eDP to LVDS bridge IC
by build bot (Jenkins) (Code Review) 30 Mar '17

30 Mar '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19043 ) Change subject: siemens/mc_apl1: Activate PTN3460 eDP to LVDS bridge IC ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/50958/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/6929/ : SUCCESS -- To view, visit https://review.coreboot.org/19043 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib8fa79bb608f1842f26c1af3d7bf4bb0513fa94d Gerrit-PatchSet: 2 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

Change in coreboot[master]: siemens/mc_apl1: Activate PTN3460 eDP to LVDS bridge IC
by Mario Scheithauer (Code Review) 30 Mar '17

30 Mar '17

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/19043 to look at the new patch set (#2). Change subject: siemens/mc_apl1: Activate PTN3460 eDP to LVDS bridge IC ...................................................................... siemens/mc_apl1: Activate PTN3460 eDP to LVDS bridge IC This mainboard uses a LVDS connection for LCD panels. Apollo Lake SoC provides a display controller with three independent pipes (1x eDP and 2x DP/HDMI). PTN3460 is an embedded DisplayPort to LVDS bridge device that enables connectivity between an eDP source and LVDS display panel (http://www.nxp.com/documents/data_sheet/PTN3460.pdf). The bridge contains an On-chip Extended Display Identification Data (EDIT) emulation for EDIT data structures. This patch sets up PTN3460 to be used with the appropriate LCD panel. Change-Id: Ib8fa79bb608f1842f26c1af3d7bf4bb0513fa94d Signed-off-by: Mario Scheithauer <mario.scheithauer(a)siemens.com> --- M src/mainboard/siemens/mc_apl1/Makefile.inc M src/mainboard/siemens/mc_apl1/mainboard.c A src/mainboard/siemens/mc_apl1/ptn3460.c A src/mainboard/siemens/mc_apl1/ptn3460.h 4 files changed, 287 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/43/19043/2 -- To view, visit https://review.coreboot.org/19043 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ib8fa79bb608f1842f26c1af3d7bf4bb0513fa94d Gerrit-PatchSet: 2 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins)

1 0

Change in coreboot[master]: util/abuild: Save checksums of built rom files
by build bot (Jenkins) (Code Review) 30 Mar '17

30 Mar '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19033 ) Change subject: util/abuild: Save checksums of built rom files ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/50957/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/6928/ : SUCCESS -- To view, visit https://review.coreboot.org/19033 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id24dc4b10afbd35cdb8750f75b934419e6e80290 Gerrit-PatchSet: 2 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

Change in coreboot[master]: util/nvidia/cbootimage: Update to upstream master
by build bot (Jenkins) (Code Review) 30 Mar '17

30 Mar '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/18955 ) Change subject: util/nvidia/cbootimage: Update to upstream master ...................................................................... Patch Set 6: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/50956/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/6927/ : SUCCESS -- To view, visit https://review.coreboot.org/18955 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3b6c0c2c855044d7fce87eff9954bce5035ca966 Gerrit-PatchSet: 6 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit March 2017