Martin Roth has uploaded a new change for review. ( https://review.coreboot.org/19033 )
Change subject: util/abuild: Save checksums of built rom files
......................................................................
util/abuild: Save checksums of built rom files
- Save a sha256 checkum of each platform into a file in the
abuild target directory.
Change-Id: Id24dc4b10afbd35cdb8750f75b934419e6e80290
Signed-off-by: Martin Roth <gaumless(a)gmail.com>
---
M util/abuild/abuild
1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/19033/1
diff --git a/util/abuild/abuild b/util/abuild/abuild
index 95711a1..2783b6a 100755
--- a/util/abuild/abuild
+++ b/util/abuild/abuild
@@ -366,6 +366,7 @@
failed=1
fi
cd "$CURR" || return $?
+ sha256sum "${build_dir}/coreboot.rom" >> "$platform_checksum_file"
if [ "$clean_work" = "true" ]; then
rm -rf "${build_dir}"
fi
@@ -703,6 +704,8 @@
FAILED_BOARDS="$TOP/$TARGET/failed_boards"
+platform_checksum_file="$TOP/$TARGET/platform_checksums"
+
if [ "$recursive" = "false" ]; then
rm -f "$FAILED_BOARDS"
fi
--
To view, visit https://review.coreboot.org/19033
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id24dc4b10afbd35cdb8750f75b934419e6e80290
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Martin Roth <martinroth(a)google.com>
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/18669 )
Change subject: soc/intel/common/block: Add Intel common PCR support
......................................................................
Patch Set 5:
(3 comments)
https://review.coreboot.org/#/c/18669/5/src/soc/intel/common/block/include/…
File src/soc/intel/common/block/include/intelblocks/pcr.h:
PS5, Line 20: #include <stddef.h>
> What is this required for?
for size_t used in pcr.c
https://review.coreboot.org/#/c/18669/5/src/soc/intel/common/block/pcr/pcr.c
File src/soc/intel/common/block/pcr/pcr.c:
Line 112: read32(pcr_reg_address(pid, offset));
> Again, this is still wrong. offset could be misaligned. Therefore you shoul
as per PCH recommendation it should be a 32 bit dummy read, hence we could do something like this, to ensure its always a DWORD align address
read32(pcr_reg_address(pid, (offset & 0xFFFC)));
>> Also, why are you recalculating pcr_reg_address() ?
with above logic, now we again need to recalculate pcr address, isn't it?
PS5, Line 117: int
> The fact that pcr_read32() and pcr_write32() are returning return codes is
so, you are recommending to assert rather returning -1 because "caller" don't bother abut return parameter.
--
To view, visit https://review.coreboot.org/18669
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I78526a86b6d10f226570c08050327557e0bb2c78
Gerrit-PatchSet: 5
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com>
Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org>
Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com>
Gerrit-Reviewer: Barnali Sarkar <barnali.sarkar(a)intel.com>
Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: Shaunak Saha <shaunak.saha(a)intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-Reviewer: dhaval v sharma <dhaval.v.sharma(a)intel.com>
Gerrit-HasComments: Yes