coreboot-gerrit March 2017

coreboot-gerrit@coreboot.org

1 participants
2925 discussions

Change in coreboot[master]: libpayload-x86: Add PS2 mouse driver
by build bot (Jenkins) (Code Review) 30 Mar '17

30 Mar '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/18597 ) Change subject: libpayload-x86: Add PS2 mouse driver ...................................................................... Patch Set 2: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/50964/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/6935/ : SUCCESS -- To view, visit https://review.coreboot.org/18597 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4be9c74467596b94d64dfa510824d8722108fe9c Gerrit-PatchSet: 2 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

Change in coreboot[master]: libpayload-x86: keyboard: Use i8042 driver
by build bot (Jenkins) (Code Review) 30 Mar '17

30 Mar '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/18596 ) Change subject: libpayload-x86: keyboard: Use i8042 driver ...................................................................... Patch Set 2: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/50963/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/6934/ : SUCCESS -- To view, visit https://review.coreboot.org/18596 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If60b5ed922b8fc4b552d0bfd9fe20c0fd6c776bf Gerrit-PatchSet: 2 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

Change in coreboot[master]: nb/intel: Deduplicate vbt header
by Patrick Rudolph (Code Review) 30 Mar '17

30 Mar '17

Hello Paul Menzel, build bot (Jenkins), Nico Huber, I'd like you to reexamine a change. Please visit https://review.coreboot.org/18903 to look at the new patch set (#8). Change subject: nb/intel: Deduplicate vbt header ...................................................................... nb/intel: Deduplicate vbt header Move header and delete duplicates. Change-Id: I0e1f5d9082626062f95afe718f6ec62a68f0d828 Signed-off-by: Patrick Rudolph <siro(a)das-labor.org> --- M src/drivers/intel/gma/intel_bios.h R src/drivers/intel/gma/opregion.h M src/drivers/intel/gma/vbt.c D src/northbridge/intel/fsp_sandybridge/gma.h M src/northbridge/intel/fsp_sandybridge/northbridge.h D src/northbridge/intel/haswell/gma.h M src/northbridge/intel/haswell/haswell.h D src/northbridge/intel/nehalem/gma.h M src/northbridge/intel/nehalem/nehalem.h M src/northbridge/intel/sandybridge/gma.c M src/northbridge/intel/sandybridge/gma.h M src/northbridge/intel/sandybridge/sandybridge.h M src/soc/intel/common/opregion.c M src/soc/intel/common/opregion.h 14 files changed, 8 insertions(+), 608 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/03/18903/8 -- To view, visit https://review.coreboot.org/18903 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I0e1f5d9082626062f95afe718f6ec62a68f0d828 Gerrit-PatchSet: 8 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins)

1 0

Change in coreboot[master]: libpayload-x86: Add common i8042 driver
by build bot (Jenkins) (Code Review) 30 Mar '17

30 Mar '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/18594 ) Change subject: libpayload-x86: Add common i8042 driver ...................................................................... Patch Set 2: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/50961/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/6932/ : SUCCESS -- To view, visit https://review.coreboot.org/18594 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4ca803bfa3ed45111776eef1f4dccd3fab02ea39 Gerrit-PatchSet: 2 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

Change in coreboot[master]: nb/intel: Deduplicate vbt header
by Patrick Rudolph (Code Review) 30 Mar '17

30 Mar '17

Hello Paul Menzel, build bot (Jenkins), Nico Huber, I'd like you to reexamine a change. Please visit https://review.coreboot.org/18903 to look at the new patch set (#7). Change subject: nb/intel: Deduplicate vbt header ...................................................................... nb/intel: Deduplicate vbt header Place public VBT structs in src/drivers/intel/gma and remove duplicated code in src/nb/intel. Change-Id: I0e1f5d9082626062f95afe718f6ec62a68f0d828 Signed-off-by: Patrick Rudolph <siro(a)das-labor.org> --- M src/drivers/intel/gma/intel_bios.h M src/drivers/intel/gma/vbt.c R src/drivers/intel/gma/vbt.h D src/northbridge/intel/fsp_sandybridge/gma.h M src/northbridge/intel/fsp_sandybridge/northbridge.h D src/northbridge/intel/haswell/gma.h M src/northbridge/intel/haswell/haswell.h D src/northbridge/intel/nehalem/gma.h M src/northbridge/intel/nehalem/nehalem.h M src/northbridge/intel/sandybridge/gma.c M src/northbridge/intel/sandybridge/gma.h M src/northbridge/intel/sandybridge/sandybridge.h M src/soc/intel/apollolake/chip.c M src/soc/intel/common/opregion.c M src/soc/intel/common/vbt.c 15 files changed, 9 insertions(+), 609 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/03/18903/7 -- To view, visit https://review.coreboot.org/18903 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I0e1f5d9082626062f95afe718f6ec62a68f0d828 Gerrit-PatchSet: 7 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins)

1 0

Change in coreboot[master]: libpayload: Add mouse cursor driver
by build bot (Jenkins) (Code Review) 30 Mar '17

30 Mar '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/18593 ) Change subject: libpayload: Add mouse cursor driver ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/50960/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/6931/ : SUCCESS -- To view, visit https://review.coreboot.org/18593 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib7cec736631b8acf81a14d28daa29ff720777b10 Gerrit-PatchSet: 2 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

Change in coreboot[master]: libpayload-x86: Move keyboard.c
by build bot (Jenkins) (Code Review) 30 Mar '17

30 Mar '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/18595 ) Change subject: libpayload-x86: Move keyboard.c ...................................................................... Patch Set 2: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/50962/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/6933/ : SUCCESS -- To view, visit https://review.coreboot.org/18595 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idd30a9082e48a451d9fe5ead3f3dda4e6396b50c Gerrit-PatchSet: 2 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

Change in coreboot[master]: nb/intel/sandybridge/raminit: Use Ivybridge specific values
by Patrick Rudolph (Code Review) 30 Mar '17

30 Mar '17

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/17606 to look at the new patch set (#4). Change subject: nb/intel/sandybridge/raminit: Use Ivybridge specific values ...................................................................... nb/intel/sandybridge/raminit: Use Ivybridge specific values Use Ivybridge specific values on Ivybridge instead of Sandybridge values. The values are extracted from MRC.bin. Tested on Lenovo T430 (Intel Ivybridge) on DDR3-1600. Change-Id: I49fdfe5ae3e65704d22e083e8446e3f1069869bc Signed-off-by: Patrick Rudolph <siro(a)das-labor.org> --- M src/northbridge/intel/sandybridge/raminit_common.h M src/northbridge/intel/sandybridge/raminit_ivy.c M src/northbridge/intel/sandybridge/raminit_sandy.c 3 files changed, 255 insertions(+), 95 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/17606/4 -- To view, visit https://review.coreboot.org/17606 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I49fdfe5ae3e65704d22e083e8446e3f1069869bc Gerrit-PatchSet: 4 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins)

1 0

Change in coreboot[master]: libpayload: Add mouse cursor driver
by Patrick Rudolph (Code Review) 30 Mar '17

30 Mar '17

Hello build bot (Jenkins), Nico Huber, I'd like you to reexamine a change. Please visit https://review.coreboot.org/18593 to look at the new patch set (#2). Change subject: libpayload: Add mouse cursor driver ...................................................................... libpayload: Add mouse cursor driver Add a driver to handle multiple low level mouse drivers and provide basic cursor acceleration support. Tested on Lenovo T500. Change-Id: Ib7cec736631b8acf81a14d28daa29ff720777b10 Signed-off-by: Patrick Rudolph <siro(a)das-labor.org> --- M payloads/libpayload/Kconfig M payloads/libpayload/drivers/Makefile.inc A payloads/libpayload/drivers/mouse_cursor.c M payloads/libpayload/include/libpayload.h 4 files changed, 249 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/93/18593/2 -- To view, visit https://review.coreboot.org/18593 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ib7cec736631b8acf81a14d28daa29ff720777b10 Gerrit-PatchSet: 2 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins)

1 0

Change in coreboot[master]: siemens/mc_apl1: Activate PTN3460 eDP to LVDS bridge IC
by Mario Scheithauer (Code Review) 30 Mar '17

30 Mar '17

Mario Scheithauer has posted comments on this change. ( https://review.coreboot.org/19043 ) Change subject: siemens/mc_apl1: Activate PTN3460 eDP to LVDS bridge IC ...................................................................... Patch Set 3: (1 comment) https://review.coreboot.org/#/c/19043/1/src/mainboard/siemens/mc_apl1/ptn34… File src/mainboard/siemens/mc_apl1/ptn3460.c: Line 28: * @return CB_SUCCESS on success or CB_ERR on error. > Done I’ve start the change of the return value to the cb_err type. But after a short discussion with Werner we came to the conclusion that it would be better to use the previous version because of the possibility to make a distinction between different error messages. So we can faster see the current issue over debug message in a fault case. I would build it again back if you agree with that. -- To view, visit https://review.coreboot.org/19043 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib8fa79bb608f1842f26c1af3d7bf4bb0513fa94d Gerrit-PatchSet: 3 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: Yes

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit March 2017