coreboot-gerrit March 2017

coreboot-gerrit@coreboot.org

1 participants
2925 discussions

Change in coreboot[master]: util/nvidia/cbootimage: Update to upstream master
by build bot (Jenkins) (Code Review) 30 Mar '17

30 Mar '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/18955 ) Change subject: util/nvidia/cbootimage: Update to upstream master ...................................................................... Patch Set 6: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/50955/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/6926/ : SUCCESS -- To view, visit https://review.coreboot.org/18955 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3b6c0c2c855044d7fce87eff9954bce5035ca966 Gerrit-PatchSet: 6 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

Change in coreboot[master]: util/nvidia/cbootimage: Update to upstream master
by build bot (Jenkins) (Code Review) 30 Mar '17

30 Mar '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/18955 ) Change subject: util/nvidia/cbootimage: Update to upstream master ...................................................................... Patch Set 5: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-checkpatch/6925/ : FAILURE https://qa.coreboot.org/job/coreboot-gerrit/50954/ : SUCCESS -- To view, visit https://review.coreboot.org/18955 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3b6c0c2c855044d7fce87eff9954bce5035ca966 Gerrit-PatchSet: 5 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

Change in coreboot[master]: util/abuild: Save checksums of built rom files
by Martin Roth (Code Review) 30 Mar '17

30 Mar '17

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/19033 to look at the new patch set (#2). Change subject: util/abuild: Save checksums of built rom files ...................................................................... util/abuild: Save checksums of built rom files - Save a sha256 checkum of each platform into a file in the abuild target directory. Change-Id: Id24dc4b10afbd35cdb8750f75b934419e6e80290 Signed-off-by: Martin Roth <gaumless(a)gmail.com> --- M util/abuild/abuild 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/19033/2 -- To view, visit https://review.coreboot.org/19033 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Id24dc4b10afbd35cdb8750f75b934419e6e80290 Gerrit-PatchSet: 2 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins)

1 0

Change in coreboot[master]: util/nvidia/cbootimage: Update to upstream master
by build bot (Jenkins) (Code Review) 30 Mar '17

30 Mar '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/18955 ) Change subject: util/nvidia/cbootimage: Update to upstream master ...................................................................... Patch Set 3: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/50951/ : ABORTED https://qa.coreboot.org/job/coreboot-checkpatch/6922/ : SUCCESS -- To view, visit https://review.coreboot.org/18955 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3b6c0c2c855044d7fce87eff9954bce5035ca966 Gerrit-PatchSet: 3 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

Change in coreboot[master]: Revert "3rdparty/vboot: Update to upstream master"
by Martin Roth (Code Review) 30 Mar '17

30 Mar '17

Martin Roth has abandoned this change. ( https://review.coreboot.org/19052 ) Change subject: Revert "3rdparty/vboot: Update to upstream master" ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/19052 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I35a0829e796454382bbac1744dbd00f0e754de4f Gerrit-PatchSet: 1 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins)

1 0

Change in coreboot[master]: siemens/mc_apl1: Activate PTN3460 eDP to LVDS bridge IC
by Werner Zeh (Code Review) 30 Mar '17

30 Mar '17

Werner Zeh has posted comments on this change. ( https://review.coreboot.org/19043 ) Change subject: siemens/mc_apl1: Activate PTN3460 eDP to LVDS bridge IC ...................................................................... Patch Set 1: (8 comments) Let's get rid of lcd_panel.c and lcd_panel.h, they are not needed in your case. https://review.coreboot.org/#/c/19043/1/src/mainboard/siemens/mc_apl1/Makef… File src/mainboard/siemens/mc_apl1/Makefile.inc: PS1, Line 11: ramstage-y += lcd_panel.c I would drop lcd_panel.c completely while moving the init function for ptn3460 to mainboard_final. https://review.coreboot.org/#/c/19043/1/src/mainboard/siemens/mc_apl1/lcd_p… File src/mainboard/siemens/mc_apl1/lcd_panel.c: PS1, Line 34: strcpy(blockname, "hwinfo.hex"); You can skip this step as you only have one hwinfo block. You can simply use ptn3460_init("hwinfo.hex"). Thats it! Line 38: printk(BIOS_ERR, "LCD: Setup PTN with status 0x%x\n", status); > Isn’t the status now 0? If the status is _not_ 0, there was an error. This needs to be shown on the console with BIOS_ERR level. If status is 0, then the level would be BIOS_INFO. https://review.coreboot.org/#/c/19043/1/src/mainboard/siemens/mc_apl1/lcd_p… File src/mainboard/siemens/mc_apl1/lcd_panel.h: PS1, Line 1: /* : * This file is part of the coreboot project. : * : * Copyright (C) 2014-2017 Siemens AG : * : * This program is free software; you can redistribute it and/or modify : * it under the terms of the GNU General Public License as published by : * the Free Software Foundation; version 2 of the License. : * : * This program is distributed in the hope that it will be useful, : * but WITHOUT ANY WARRANTY; without even the implied warranty of : * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the : * GNU General Public License for more details. : */ : : #ifndef _LCD_PANEL_H_ : #define _LCD_PANEL_H_ : : /* This GPIOs are used for LCD panel type encoding. */ : #define LCD_TYPE_GPIO_BIT0 40 : #define LCD_TYPE_GPIO_BIT1 41 : #define LCD_TYPE_GPIO_BIT2 42 : #define LCD_TYPE_GPIO_BIT3 43 : : #define LCD_PANEL_TYPE_10_INCH 4 : #define LCD_PANEL_TYPE_12_INCH 7 : #define LCD_PANEL_TYPE_15_INCH 6 : #define LCD_PANEL_TYPE_19_INCH 1 : #define LCD_PANEL_TYPE_EDID 15 : : int setup_lcd_panel(void); : : #endif /* _LCD_PANEL_H_ */ Drop this file completely. https://review.coreboot.org/#/c/19043/1/src/mainboard/siemens/mc_apl1/mainb… File src/mainboard/siemens/mc_apl1/mainboard.c: PS1, Line 120: setup_lcd_panel(); I would completely remove lcd_panel.{c,h} and move the call to ptn3460_init() to mainbaord_final. As you only have one possible LCD panel, there is no need for a panel selection at all. https://review.coreboot.org/#/c/19043/1/src/mainboard/siemens/mc_apl1/ptn34… File src/mainboard/siemens/mc_apl1/ptn3460.c: PS1, Line 75: s skip the s PS1, Line 92: cfg.t3_timing = 5; Please increase this value to 10 resulting in 500 ms backlight delay. There are LCD panels out there which might need this longer time to avoid flicker. Line 127: int ptn3460_write_edid(u8 edid_num, u8 *data) > How do you know the data is right length? Actually this function is responsible for writing a complete EDID data set to the PTN and the length of the EDID data set is fixed to 128 bytes per definition. So the idea here is: the caller needs to ensure that the pointer passed in points to a proper buffer. -- To view, visit https://review.coreboot.org/19043 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib8fa79bb608f1842f26c1af3d7bf4bb0513fa94d Gerrit-PatchSet: 1 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: Yes

1 0

Change in coreboot[master]: util/abuild: Save checksums of built rom files
by build bot (Jenkins) (Code Review) 30 Mar '17

30 Mar '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19033 ) Change subject: util/abuild: Save checksums of built rom files ...................................................................... Patch Set 1: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/50949/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/6920/ : SUCCESS -- To view, visit https://review.coreboot.org/19033 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id24dc4b10afbd35cdb8750f75b934419e6e80290 Gerrit-PatchSet: 1 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

Change in coreboot[master]: Revert "3rdparty/vboot: Update to upstream master"
by Martin Roth (Code Review) 30 Mar '17

30 Mar '17

Hello Paul Menzel, build bot (Jenkins), Patrick Georgi, I'd like you to do a code review. Please visit https://review.coreboot.org/19052 to review the following change. Change subject: Revert "3rdparty/vboot: Update to upstream master" ...................................................................... Revert "3rdparty/vboot: Update to upstream master" This reverts commit ba2531c8a21c5e95cbed85b1a7bcccc795d3f52e. Change-Id: I35a0829e796454382bbac1744dbd00f0e754de4f Signed-off-by: Martin Roth <martinroth(a)google.com> --- M 3rdparty/vboot 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/19052/1 diff --git a/3rdparty/vboot b/3rdparty/vboot index a1c5f7c..adfafba 160000 --- a/3rdparty/vboot +++ b/3rdparty/vboot @@ -1 +1 @@ -Subproject commit a1c5f7c006b7bb3d5894f132f70ba3bbadfd9d6b +Subproject commit adfafba793684ed92965dfbd86b3fb3463975d8c -- To view, visit https://review.coreboot.org/19052 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I35a0829e796454382bbac1744dbd00f0e754de4f Gerrit-PatchSet: 1 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins)

1 0

Change in coreboot[master]: Revert "3rdparty/vboot: Update to upstream master"
by Martin Roth (Code Review) 30 Mar '17

30 Mar '17

Martin Roth has reverted this change. ( https://review.coreboot.org/19052 ) Change subject: Revert "3rdparty/vboot: Update to upstream master" ...................................................................... Uploaded patch set 1. -- To view, visit https://review.coreboot.org/19052 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: revert Gerrit-Change-Id: I35a0829e796454382bbac1744dbd00f0e754de4f Gerrit-PatchSet: 1 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins)

1 0

Change in coreboot[master]: util/nvidia/cbootimage: Update to upstream master
by build bot (Jenkins) (Code Review) 30 Mar '17

30 Mar '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/18955 ) Change subject: util/nvidia/cbootimage: Update to upstream master ...................................................................... Patch Set 2: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/50948/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/6919/ : SUCCESS -- To view, visit https://review.coreboot.org/18955 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3b6c0c2c855044d7fce87eff9954bce5035ca966 Gerrit-PatchSet: 2 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit March 2017