coreboot-gerrit March 2017

coreboot-gerrit@coreboot.org

1 participants
2925 discussions

Change in coreboot[master]: AGESA: Move romstage-ramstage splitline
by build bot (Jenkins) (Code Review) 29 Mar '17

29 Mar '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/18888 ) Change subject: AGESA: Move romstage-ramstage splitline ...................................................................... Patch Set 4: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/6895/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/50924/ : SUCCESS -- To view, visit https://review.coreboot.org/18888 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icc8d97b82df89e2480e601d5c2e094de0365b0a5 Gerrit-PatchSet: 4 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

Change in coreboot[master]: [NOTFORMERGE] AGESA f15tn f16kb: Revert invd to wbinvd change
by build bot (Jenkins) (Code Review) 29 Mar '17

29 Mar '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/18632 ) Change subject: [NOTFORMERGE] AGESA f15tn f16kb: Revert invd to wbinvd change ...................................................................... Patch Set 8: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/6899/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/50926/ : SUCCESS -- To view, visit https://review.coreboot.org/18632 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If750766cc7a9ecca4641a8f14e1ab15e9abb7ff5 Gerrit-PatchSet: 8 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

Change in coreboot[master]: AGESA: Introduce AGESA_LEGACY_WRAPPER and its counterpart
by build bot (Jenkins) (Code Review) 29 Mar '17

29 Mar '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/18628 ) Change subject: AGESA: Introduce AGESA_LEGACY_WRAPPER and its counterpart ...................................................................... Patch Set 8: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/6894/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/50923/ : SUCCESS -- To view, visit https://review.coreboot.org/18628 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iac3d7f8b0354e9f02c2625576f36fe06b05eb4ce Gerrit-PatchSet: 8 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

Change in coreboot[master]: [NOTFORMERGE] squashed no AGESA_LEGACY_WRAPPER
by build bot (Jenkins) (Code Review) 29 Mar '17

29 Mar '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/18629 ) Change subject: [NOTFORMERGE] squashed no AGESA_LEGACY_WRAPPER ...................................................................... Patch Set 8: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/6896/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/50925/ : SUCCESS -- To view, visit https://review.coreboot.org/18629 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib5b52d08875165dbf0dfefcc56a8913d607493c9 Gerrit-PatchSet: 8 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

Change in coreboot[master]: [Needs test] i945/raminit: Correct C0DRAMW & C1DRAMW for 4 D...
by HAOUAS Elyes (Code Review) 29 Mar '17

29 Mar '17

HAOUAS Elyes has abandoned this change. ( https://review.coreboot.org/18387 ) Change subject: [Needs test] i945/raminit: Correct C0DRAMW & C1DRAMW for 4 DIMMs ...................................................................... Abandoned unfortunately, I can't test it. -- To view, visit https://review.coreboot.org/18387 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: Ib1f999447b37a1524d589552ea2eec640c2a2c7e Gerrit-PatchSet: 6 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins)

1 0

Change in coreboot[master]: [Needs Test]nb/intel/i945: Programm proper ODT values
by HAOUAS Elyes (Code Review) 29 Mar '17

29 Mar '17

HAOUAS Elyes has abandoned this change. ( https://review.coreboot.org/18548 ) Change subject: [Needs Test]nb/intel/i945: Programm proper ODT values ...................................................................... Abandoned unfortunately, I can't test it. -- To view, visit https://review.coreboot.org/18548 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I7aec35f45250da554ddc5a68f5add157c313399c Gerrit-PatchSet: 10 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins)

1 0

Change in coreboot[master]: soc/intel/apollolake: Fix debug build booting issue
by Martin Roth (Code Review) 29 Mar '17

29 Mar '17

Martin Roth has submitted this change and it was merged. ( https://review.coreboot.org/19036 ) Change subject: soc/intel/apollolake: Fix debug build booting issue ...................................................................... soc/intel/apollolake: Fix debug build booting issue This patch fix apollolake devices unable to boot with coreboot debug image issue. Change-Id: I28943100ba19dec1e540fdbba1c1e110c6af1488 Signed-off-by: Subrata Banik <subrata.banik(a)intel.com> Reviewed-on: https://review.coreboot.org/19036 Tested-by: build bot (Jenkins) Reviewed-by: Aaron Durbin <adurbin(a)chromium.org> Reviewed-by: Martin Roth <martinroth(a)google.com> Reviewed-by: Furquan Shaikh <furquan(a)google.com> --- M src/soc/intel/apollolake/pmutil.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Aaron Durbin: Looks good to me, approved build bot (Jenkins): Verified Martin Roth: Looks good to me, approved Furquan Shaikh: Looks good to me, approved diff --git a/src/soc/intel/apollolake/pmutil.c b/src/soc/intel/apollolake/pmutil.c index 7d3cb07..9e57b28 100644 --- a/src/soc/intel/apollolake/pmutil.c +++ b/src/soc/intel/apollolake/pmutil.c @@ -505,7 +505,7 @@ ROMSTAGE_CONST struct soc_intel_apollolake_config *config; /* Look up the device in devicetree */ - ROMSTAGE_CONST struct device *dev = SA_DEV_ROOT; + ROMSTAGE_CONST struct device *dev = dev_find_slot(0, SA_DEVFN_ROOT); if (!dev || !dev->chip_info) { printk(BIOS_ERR, "BUG! Could not find SOC devicetree config\n"); return; -- To view, visit https://review.coreboot.org/19036 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I28943100ba19dec1e540fdbba1c1e110c6af1488 Gerrit-PatchSet: 2 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Barnali Sarkar <barnali.sarkar(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: build bot (Jenkins)

1 0

Change in coreboot[master]: soc/intel/apollolake: Code clean up by using common PCR module
by Furquan Shaikh (Code Review) 29 Mar '17

29 Mar '17

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/18673 ) Change subject: soc/intel/apollolake: Code clean up by using common PCR module ...................................................................... Patch Set 7: (3 comments) https://review.coreboot.org/#/c/18673/7/src/soc/intel/apollolake/bootblock/… File src/soc/intel/apollolake/bootblock/bootblock.c: PS7, Line 50: pcr_read32(PID_RTC, R_PCH_PCR_RTC_CONF, &reg); : reg |= B_PCH_PCR_RTC_CONF_UCMOS_EN; : pcr_write32(PID_RTC, R_PCH_PCR_RTC_CONF, reg); why not use pcr_and_then_or? https://review.coreboot.org/#/c/18673/7/src/soc/intel/apollolake/gpio.c File src/soc/intel/apollolake/gpio.c: PS7, Line 123: pcr_read32(port, hostsw_reg, &val); : val |= 1 << (pin % 32); : pcr_write32(port, hostsw_reg, val); pcr_and_then_or? PS7, Line 147: pcr_read32(port, en_reg, &value); : value |= 1 << (pin % GPIO_MAX_NUM_PER_GROUP); : pcr_write32(port, en_reg , value); pcr_and_then_or -- To view, visit https://review.coreboot.org/18673 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iacbf58dbd55bf3915676d875fcb484362d357a44 Gerrit-PatchSet: 7 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Barnali Sarkar <barnali.sarkar(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Shaunak Saha <shaunak.saha(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) Gerrit-Reviewer: dhaval v sharma <dhaval.v.sharma(a)intel.com> Gerrit-HasComments: Yes

1 0

Change in coreboot[master]: soc/intel/common/block: Add Intel common PCR support
by Furquan Shaikh (Code Review) 29 Mar '17

29 Mar '17

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/18669 ) Change subject: soc/intel/common/block: Add Intel common PCR support ...................................................................... Patch Set 5: (7 comments) https://review.coreboot.org/#/c/18669/5/src/soc/intel/common/block/include/… File src/soc/intel/common/block/include/intelblocks/pcr.h: PS5, Line 20: #include <stddef.h> What is this required for? https://review.coreboot.org/#/c/18669/5/src/soc/intel/common/block/pcr/pcr.c File src/soc/intel/common/block/pcr/pcr.c: PS5, Line 34: return pcr_reg_address(pid, offset); Can we just pull in the above pcr_reg_address code into this? This function isn't doing other than returning whatever pcr_reg_address returns. Line 112: read32(pcr_reg_address(pid, offset)); > Again, this is still wrong. offset could be misaligned. Therefore you shoul Maybe we could define the functions as: pch_pcr_read(void *addr, size_t size, void *data) pch_pcr_write(void *addr, size_t size, void *data) and within pch_pcr_write we can simply call pch_pcr_read(addr, size, data); as a dummy read that Aaron suggested. We wouldn't have to recalculate pcr_reg_address again in that case. PS5, Line 133: Write PCR register. (This is internal function) This might need a better explanation. Its a read-modify-write and not just a write. PS5, Line 140: pcr_and_then_or nitpick: We have two internal functions with prefix pch_ and one with pcr_. Might help to make it more consistent. PS5, Line 145: if (pch_pcr_read(pid, offset, size, &data32) != 0) : return -1; : : data32 &= anddata; : data32 |= ordata; : : return pch_pcr_write(pid, offset, size, data32); Right now this is recalculating pcr_reg_address three times. If we change to passing in void *addr to pch_pcr_read/pch_pcr_write, we can avoid doing that. PS5, Line 154: pcr_andthenor32 can we follow the same convention as above: pcr_and_then_or_32 or something? Its easier to read that way. -- To view, visit https://review.coreboot.org/18669 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I78526a86b6d10f226570c08050327557e0bb2c78 Gerrit-PatchSet: 5 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Barnali Sarkar <barnali.sarkar(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Shaunak Saha <shaunak.saha(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) Gerrit-Reviewer: dhaval v sharma <dhaval.v.sharma(a)intel.com> Gerrit-HasComments: Yes

1 0

Change in coreboot[master]: AGESA f14: Fix memory clock register decoding
by build bot (Jenkins) (Code Review) 29 Mar '17

29 Mar '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19042 ) Change subject: AGESA f14: Fix memory clock register decoding ...................................................................... Patch Set 1: Verified-1 Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/50922/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/6893/ : SUCCESS -- To view, visit https://review.coreboot.org/19042 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2dfcf1950883836499ea2ca95f9eb72ccdfb979c Gerrit-PatchSet: 1 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit March 2017