Andrey Petrov (andrey.petrov(a)intel.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/13322
-gerrit
commit 3a4436c8f1d682e7b2e3c79852feb08052a0dc0c
Author: Andrey Petrov <andrey.petrov(a)intel.com>
Date: Tue Oct 27 12:43:44 2015 -0700
soc/apollolake/bootblock: Add transition to romstage
This adds calling romstage. Since by default romstage is run from CAR,
a workaround is added as well to keep CAR executable.
Change-Id: Ied49a5695c6499ad0cfaf27e3ba6860a884a6684
Signed-off-by: Andrey Petrov <andrey.petrov(a)intel.com>
---
src/soc/intel/apollolake/bootblock/bootblock_car.c | 28 +++++++++++++++++++---
1 file changed, 25 insertions(+), 3 deletions(-)
diff --git a/src/soc/intel/apollolake/bootblock/bootblock_car.c b/src/soc/intel/apollolake/bootblock/bootblock_car.c
index e9cbb09..251d7b5 100644
--- a/src/soc/intel/apollolake/bootblock/bootblock_car.c
+++ b/src/soc/intel/apollolake/bootblock/bootblock_car.c
@@ -11,9 +11,11 @@
*/
#include <arch/io.h>
+#include <cbfs.h>
#include <console/console.h>
#include <device/pci.h>
#include <soc/bootblock.h>
+#include <soc/cpu.h>
#include <soc/uart.h>
static void disable_watchdog(void)
@@ -32,8 +34,18 @@ static void disable_watchdog(void)
outl(reg, 0x400 + 0x68);
}
+static void call_romstage(void *entry)
+{
+ __asm__ volatile (
+ "call *%0"
+ :: "r" (entry)
+ );
+}
+
void bootblock_car_main(void)
{
+ void *romstage_entry;
+
/* Quick post code to show we made it to C code */
outb(0x30, 0x80);
@@ -45,7 +57,17 @@ void bootblock_car_main(void)
/* Wait until after we have console to disable this */
disable_watchdog();
- /* Don't return, so we see the above post code */
- while (1)
- ;
+ romstage_entry = cbfs_boot_load_stage_by_name("fallback/romstage");
+ if (!romstage_entry) {
+ outb(POST_DIE, 0x80);
+ die("romstage not found\n");
+ }
+
+ /* APLK workaround: do this magic to keep cache executable on update */
+ bxt_remark_cache_exec();
+
+ /* Call the romstage entry point */
+ call_romstage(romstage_entry);
+
+ /* We should never reach this */
}
the following patch was just integrated into master:
commit e3f47eada383defcc31b41cc4931c3cf3234c37d
Author: Edward O'Callaghan <eocallaghan(a)alterapraxis.com>
Date: Tue Nov 18 18:27:29 2014 +1100
vendorcode/amd/agesa/f1{4,2,0} Sync Include directory
Sync and merge useless differences.
Change-Id: I4eea66c35af66d473dd56db9ccf105c878266f22
Signed-off-by: Edward O'Callaghan <eocallaghan(a)alterapraxis.com>
Reviewed-on: https://review.coreboot.org/7513
Tested-by: build bot (Jenkins)
Reviewed-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
See https://review.coreboot.org/7513 for details.
-gerrit
the following patch was just integrated into master:
commit c389635f6e5618b40279e823a46ae2ff50e620d1
Author: Edward O'Callaghan <eocallaghan(a)alterapraxis.com>
Date: Wed Nov 19 10:53:09 2014 +1100
vendorcode/amd/agesa/f15?tn: Strip false/redudant AMD ver tag
Strip out the AMD internal version tag, e.g.
* @e \$Revision: 63425 $ @e \$Date: 2011-12-22 11:24:10 -0600 (Thu, 22 Dec 2011) $
which are false/inconsistent and serve no real meaning or purpose now.
Change-Id: I4cca0899eba66a1c361ba784c5ac0222b0ee1aa6
Signed-off-by: Edward O'Callaghan <eocallaghan(a)alterapraxis.com>
Reviewed-on: https://review.coreboot.org/7516
Tested-by: build bot (Jenkins)
Reviewed-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
See https://review.coreboot.org/7516 for details.
-gerrit
the following patch was just integrated into master:
commit 11a262c86c426f49b6e77a3ca02ce584e2014510
Author: zbao <fishbaozi(a)gmail.com>
Date: Fri Jan 22 18:54:22 2016 +0800
util/kconfig:xconf(QT): Update QT version of xconf
Update the qconf.cc and qconf.h to upstream code, which added support
of QT5 and removed the support of QT3.
All code is ported from kernel.org, with only one line added to qconf.cc.
int kconfig_warnings = 0;
Change-Id: Ice77cddcc00e43375039379978e55f42acf867f7
Signed-off-by: Zheng Bao <fishbaozi(a)gmail.com>
Reviewed-on: https://review.coreboot.org/13130
Tested-by: build bot (Jenkins)
Reviewed-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
See https://review.coreboot.org/13130 for details.
-gerrit