the following patch was just integrated into master:
commit 23cc9b09c7b5d1d18432b2553e177aa61697b490
Author: Patrick Georgi <patrick(a)georgi-clan.de>
Date: Wed Jan 27 08:19:36 2016 +0100
via/cx700: Use zeroptr over 0
This eliminates all "ud2" instances from romstage disassembly.
Change-Id: I3b0c8322a4ca4a851b0cce8f3941425d9cb30383
Signed-off-by: Patrick Georgi <patrick(a)georgi-clan.de>
Reviewed-on: https://review.coreboot.org/13488
Tested-by: build bot (Jenkins)
Reviewed-by: Martin Roth <martinroth(a)google.com>
See https://review.coreboot.org/13488 for details.
-gerrit
the following patch was just integrated into master:
commit ff8076d75ace8da247b927f7de37f3ed5081b55e
Author: Patrick Georgi <patrick(a)georgi-clan.de>
Date: Wed Jan 27 08:18:16 2016 +0100
Provide a gcc-safe zero pointer
zeroptr is a linker object pointing at 0 that can be used to thwart
GCC's (and other compilers') "dereferencing NULL is undefined"
optimization strategy when it gets in the way.
Change-Id: I6aa6f28283281ebae73d6349811e290bf1b99483
Signed-off-by: Patrick Georgi <patrick(a)georgi-clan.de>
Reviewed-on: https://review.coreboot.org/12294
Tested-by: Raptor Engineering Automated Test Stand <noreply(a)raptorengineeringinc.com>
Tested-by: build bot (Jenkins)
Reviewed-by: Martin Roth <martinroth(a)google.com>
See https://review.coreboot.org/12294 for details.
-gerrit
Hannah Williams (hannah.williams(a)intel.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/13506
-gerrit
commit 6aa723a8450d10ccfe312cee76f9150b2ace5012
Author: Hannah Williams <hannah.williams(a)intel.com>
Date: Thu Jan 28 14:25:32 2016 -0800
soc/braswell: Fix Global NVS base address
TEST=Boot to OS
Signed-off-by: Hannah Williams <hannah.williams(a)intel.com>
Change-Id: I9b43eb4f6f7af62a8a0bbe7bfa08feee1eaca24e
---
src/soc/intel/braswell/acpi/globalnvs.asl | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/soc/intel/braswell/acpi/globalnvs.asl b/src/soc/intel/braswell/acpi/globalnvs.asl
index 5c8a75f..a53834a 100644
--- a/src/soc/intel/braswell/acpi/globalnvs.asl
+++ b/src/soc/intel/braswell/acpi/globalnvs.asl
@@ -25,8 +25,9 @@ Name(\PICM, 0) /* IOAPIC/8259 */
* we have to fix it up in coreboot's ACPI creation phase.
*/
+External (NVSA)
-OperationRegion (GNVS, SystemMemory, 0xC0DEBABE, 0x2000)
+OperationRegion (GNVS, SystemMemory, NVSA, 0x2000)
Field (GNVS, ByteAcc, NoLock, Preserve)
{
/* Miscellaneous */
Patrick Georgi (pgeorgi(a)google.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/13505
-gerrit
commit 31ab1d95cea5b6eff91ee65feec50abdf457b1ae
Author: Patrick Georgi <pgeorgi(a)chromium.org>
Date: Thu Jan 28 22:34:50 2016 +0100
build system: allow modifying cbfstool options for files-in-regions
By implementing a more complex options-for-region function, special
needs for certain files in certain regions can be dealt with.
Change-Id: I2e1e08d5357b717011c41675f76908bf2319f91d
Signed-off-by: Patrick Georgi <pgeorgi(a)chromium.org>
---
Makefile.inc | 14 +++++++++++---
1 file changed, 11 insertions(+), 3 deletions(-)
diff --git a/Makefile.inc b/Makefile.inc
index 8b69109..122b83a 100644
--- a/Makefile.inc
+++ b/Makefile.inc
@@ -645,6 +645,13 @@ extract_nth=$(subst *,$(spc),$(patsubst -%-,%,$(word $(1), $(subst |,- -,-$(2)-)
# multiple CBFSes in fmap regions, override it.
regions-for-file ?= COREBOOT
+# options-for-region
+# $(call options-for-region,$(filename),$(region),$(options))
+#
+# Returns potentially modified options, depending on file and region.
+# Default is to return it unmodified
+options-for-region ?= $(3)
+
ifeq ($(CONFIG_CBFS_AUTOGEN_ATTRIBUTES),y)
cbfs-autogen-attributes=-g
endif
@@ -660,9 +667,10 @@ define cbfs-add-cmd-for-region
$(if $(call extract_nth,4,$(1)),-c $(call extract_nth,4,$(1))) \
$(cbfs-autogen-attributes) \
-r $(2) \
- $(if $(call extract_nth,6,$(1)),-a $(call extract_nth,6,$(file)), \
- $(if $(call extract_nth,5,$(file)),-b $(call extract_nth,5,$(file)))) \
- $(call extract_nth,7,$(1))
+ $(call options-for-region,$(call extract_nth,2,$(1)),$(2), \
+ $(if $(call extract_nth,6,$(1)),-a $(call extract_nth,6,$(file)), \
+ $(if $(call extract_nth,5,$(file)),-b $(call extract_nth,5,$(file)))) \
+ $(call extract_nth,7,$(1)))
endef
# Empty line before endef is necessary so cbfs-add-cmd-for-region ends in a