New subject: Change in ...coreboot[master]: WIP: google/kukui: Elaborate panel support for Kukui family boards.

29 Apr 2019

Kaka Ni has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32511
Change subject: WIP: google/kukui: elaborate panel support for Kukui family boards.
......................................................................
WIP: google/kukui: elaborate panel support for Kukui family boards.
There are two boards based on Kukui: Flapjack & Krane.
Now the edid inf and init commands for panels of Kukui are in
mainbard.c.
This CL would elabrate panel support for Kukui family. Each board has
it's own  source file to support it's panels.
BUG=Nne
BRANCH=none
TEST=build pass
Change-Id: I19213aee1ac0f69f42e73be9e5ab72394f412a01
Signed-off-by: Kaka Ni nigang@huaqin.corp-partner.google.com
---
M src/mainboard/google/kukui/Makefile.inc
A src/mainboard/google/kukui/display.c
A src/mainboard/google/kukui/display.h
M src/mainboard/google/kukui/mainboard.c
A src/mainboard/google/kukui/panel_kukui.c
5 files changed, 451 insertions(+), 172 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/11/32511/1

diff --git a/src/mainboard/google/kukui/Makefile.inc b/src/mainboard/google/kukui/Makefile.inc
index a0556c1..ef52031 100644
--- a/src/mainboard/google/kukui/Makefile.inc
+++ b/src/mainboard/google/kukui/Makefile.inc
@@ -22,6 +22,8 @@
ramstage-y += boardid.c
 ramstage-y += chromeos.c
+ramstage-y += display.c
+ramstage-y += panel_kukui.c
 ramstage-y += mainboard.c
 ramstage-y += memlayout.ld
 ramstage-y += reset.c
diff --git a/src/mainboard/google/kukui/display.c b/src/mainboard/google/kukui/display.c
new file mode 100644
index 0000000..5ec6ccd
--- /dev/null
+++ b/src/mainboard/google/kukui/display.c
@@ -0,0 +1,137 @@
+/*
+ * This file is part of the coreboot project.
+ *
+ * Copyright 2019 Huaqin Telecom Inc.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; version 2 of the License.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ */
+
+#include <console/console.h>
+#include <delay.h>
+#include <device/device.h>
+#include <edid.h>
+#include <gpio.h>
+#include <soc/auxadc.h>
+#include <soc/ddp.h>
+#include <soc/dsi.h>
+#include <soc/gpio.h>
+#include <boardid.h>
+
+#include "display.h"
+#include "gpio.h"
+
+static void _display_startup(struct edid *edid,
+			     struct lcm_init_table *init_table,
+			     u32 init_table_size)
+{
+	int ret = 0;
+	u32 mipi_dsi_flags;
+
+	if ((edid == NULL) || (init_table == NULL)) {
+		printk(BIOS_ERR, "%s: wrong parameters\n", __func__);
+		return;
+	}
+
+	mipi_dsi_flags = MIPI_DSI_MODE_VIDEO |
+	    MIPI_DSI_MODE_VIDEO_SYNC_PULSE | MIPI_DSI_MODE_LPM;
+
+	edid_set_framebuffer_bits_per_pixel(edid, 32, 0);
+
+	mtk_ddp_init();
+	ret = mtk_dsi_init(mipi_dsi_flags, MIPI_DSI_FMT_RGB888, 4,
+			   false, edid, init_table, init_table_size);
+
+	if (ret < 0) {
+		printk(BIOS_ERR, "dsi init fail\n");
+		return;
+	}
+
+	mtk_ddp_mode_set(edid);
+
+	set_vbe_mode_info_valid(edid, (uintptr_t) 0);
+}
+
+static struct edid *get_edid(struct board_display_intf *intf)
+{
+	struct panel_info *info = intf->cur_panel_info;
+
+	if (info)
+		return info->edid;
+	return NULL;
+}
+
+static struct lcm_init_table *get_panel_init_table(struct board_display_intf
+						  *intf, u32 *table_size)
+{
+
+	struct panel_info *info = intf->cur_panel_info;
+
+	if (info) {
+		*table_size = info->table_size;
+		return info->init_table;
+	}
+
+	*table_size = 0;
+	return NULL;
+}
+
+static const char *get_panel_name(struct board_display_intf *intf)
+{
+	struct panel_info *info = intf->cur_panel_info;
+
+	if (info)
+		return info->panel_name;
+	return NULL;
+}
+
+/* Exported Functions */
+
+struct board_display_intf *get_current_display_intf(void)
+{
+	if (CONFIG(BOARD_GOOGLE_KUKUI))
+		return &kukui_display_intf;
+	else
+		return NULL;
+}
+
+int update_panel_info(struct board_display_intf *intf)
+{
+	int i;
+	union panel_id id = intf->get_panel_id(intf);
+	if (intf->is_panel_id_valid(id)) {
+		for (i = 0; i < intf->all_panel_info_size; ++i) {
+			if (id.value == intf->all_panel_info[i].disp_id.value) {
+				intf->cur_panel_info = &intf->all_panel_info[i];
+				return 0;
+			}
+		}
+	}
+	return ERR;
+}
+
+void configure_backlight(void)
+{
+	/* Configure PANEL_LCD_POWER_EN */
+	gpio_output(GPIO(PERIPHERAL_EN13), 1);
+	gpio_output(GPIO(DISP_PWM), 1);	/* DISP_PWM0 */
+}
+
+void display_startup(struct board_display_intf *intf)
+{
+	struct edid *edid;
+	u32 init_table_size;
+	struct lcm_init_table *init_table;
+
+	edid = get_edid(intf);
+	init_table = get_panel_init_table(intf, &init_table_size);
+	printk(BIOS_INFO, "%s: name:%s init_table_size:%d\n",
+	       __func__, get_panel_name(intf), init_table_size);
+	_display_startup(edid, init_table, init_table_size);
+}
diff --git a/src/mainboard/google/kukui/display.h b/src/mainboard/google/kukui/display.h
new file mode 100644
index 0000000..33cc997
--- /dev/null
+++ b/src/mainboard/google/kukui/display.h
@@ -0,0 +1,95 @@
+/*
+ * This file is part of the coreboot project.
+ *
+ * Copyright 2019 Huaqin Telecom Inc.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; version 2 of the License.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ */
+
+#ifndef __MAINBOARD_GOOGLE_DISPLAY_H__
+#define __MAINBOARD_GOOGLE_DISPLAY_H__
+
+#include <soc/dsi.h>
+#include <soc/gpio.h>
+
+#define ERR  (-1)
+#define OK   (1)
+
+#define MAKE_AS_A_STRING(arg) #arg
+
+enum kukui_panel_id {
+	PANEL_KUKUI_FIRST = 0,
+	PANEL_KUKUI_INNOLUX = 0,
+	PANEL_KUKUI_P097PFG_SSD2858,
+	PANEL_KUKUI_UNKNOWN,
+	PANEL_KUKUI_COUNT,
+	PANEL_KUKUI_UNINITIALIZED
+};
+
+
+union panel_id {
+	enum kukui_panel_id kukui_panel;
+	int value;
+};
+
+struct panel_info {
+	union panel_id disp_id;			/* the ID for panel */
+	const char *panel_name;			/* display panel name */
+	int voltage;				/* voltage of LCM_ID */
+	struct edid *edid;			/* edid info of this panel */
+	struct lcm_init_table *init_table;	/* init command table */
+	u32 table_size;				/* init command table size */
+};
+
+#define PANEL(_panel_id, _voltage, _edid, _init_table) \
+	{ \
+	 .disp_id = {_panel_id},\
+	 .panel_name = MAKE_AS_A_STRING(_panel_id),\
+	 .voltage = _voltage,\
+	 .edid = &_edid,\
+	 .init_table = _init_table,\
+	 .table_size = ARRAY_SIZE(_init_table)} \
+
+
+struct board_display_intf {
+	const char *board;			/* board name */
+	struct panel_info *all_panel_info;	/* all supported panel info */
+	u32 all_panel_info_size;		/* num of supported panel */
+	/*
+	 * Runtime member
+	 */
+	struct panel_info *cur_panel_info;	/* detected panel info */
+	/*
+	 * board related functions
+	 */
+
+	union panel_id (*get_panel_id)(struct board_display_intf *intf);
+	bool (*is_panel_id_valid)(union panel_id id);
+	int (*backlight)(struct board_display_intf *intf);
+	int (*power)(struct board_display_intf *intf);
+};
+
+/*
+ * Exported functions
+ */
+
+struct board_display_intf *get_current_display_intf(void);
+int update_panel_info(struct board_display_intf *intf);
+void configure_backlight(void);
+void display_startup(struct board_display_intf *intf);
+
+
+/*
+ * Panel Interface for boards
+ */
+extern struct board_display_intf kukui_display_intf;
+
+#endif
+
diff --git a/src/mainboard/google/kukui/mainboard.c b/src/mainboard/google/kukui/mainboard.c
index 7b1897d..af6ed30 100644
--- a/src/mainboard/google/kukui/mainboard.c
+++ b/src/mainboard/google/kukui/mainboard.c
@@ -27,6 +27,9 @@
 #include <soc/mtcmos.h>
 #include <soc/usb.h>
+#include "display.h"
+#include "gpio.h"
+
 static void configure_emmc(void)
 {
    const gpio_t emmc_pin[] = {
@@ -46,181 +49,29 @@
    setup_usb_host();
 }
-/* Setup backlight control pins as output pin and power-off by default */
-static void configure_backlight(void)
-{
-	/* Configure PANEL_LCD_POWER_EN */
-	gpio_output(GPIO(PERIPHERAL_EN13), 1);
-	gpio_output(GPIO(DISP_PWM), 1);	/* DISP_PWM0 */
-}
-
-static void configure_display(void)
-{
-	if (board_id() < 2) {
-		/* board from p1 */
-		gpio_output(GPIO(LCM_RST), 0);
-		udelay(100);
-		gpio_output(GPIO(LCM_RST), 1);
-		mdelay(20);
-	} else {
-		/* board from p2 */
-		gpio_output(GPIO(LCM_RST), 0);
-		gpio_output(GPIO(BPI_BUS3), 0);
-		gpio_output(GPIO(MISC_BSI_CK_3), 1);
-		gpio_output(GPIO(PERIPHERAL_EN9), 1);
-		gpio_output(GPIO(SIM2_SRST), 1);
-		gpio_output(GPIO(SIM2_SIO), 1);
-		gpio_output(GPIO(BPI_OLAT1), 1);
-		gpio_output(GPIO(SIM2_SCLK), 1);
-		mdelay(20);
-		gpio_output(GPIO(LCM_RST), 1);
-		mdelay(20);
-		gpio_output(GPIO(BPI_BUS3), 1);
-		mdelay(20);
-	}
-}
-
-static const struct edid kukui_innolux_edid = {
-	.panel_bits_per_color = 8,
-	.panel_bits_per_pixel = 24,
-	.mode = {
-		.name = "768x1024@60Hz",
-		.pixel_clock = 56900,
-		.lvds_dual_channel = 0,
-		.refresh = 60,
-		.ha = 768, .hbl = 120, .hso = 40, .hspw = 40, .hborder = 0,
-		.va = 1024, .vbl = 44, .vso = 20, .vspw = 4, .vborder = 0,
-		.phsync = '-', .pvsync = '-',
-		.x_mm = 120, .y_mm = 160,
-	},
-};
-
-struct lcm_init_table lcm_init_cmd[] = {
-	{INIT_DCS_CMD, 1, {MIPI_DCS_EXIT_SLEEP_MODE} },
-	{DELAY_CMD, 120, {} },
-	{INIT_DCS_CMD, 1, {MIPI_DCS_SET_DISPLAY_ON} },
-	{DELAY_CMD, 120, {} },
-};
-
-static const struct edid kukui_p097pfg_ssd2858_edid = {
-	.panel_bits_per_color = 8,
-	.panel_bits_per_pixel = 24,
-	.mode = {
-		.name = "1536x2048@60Hz",
-		.pixel_clock = 229000,
-		.lvds_dual_channel = 0,
-		.refresh = 60,
-		.ha = 1536, .hbl = 160, .hso = 80, .hspw = 26, .hborder = 0,
-		.va = 2048, .vbl = 32, .vso = 20, .vspw = 2, .vborder = 0,
-		.phsync = '-', .pvsync = '-',
-		.x_mm = 147, .y_mm = 196,
-	},
-};
-
-struct lcm_init_table lcm_p097pfg_ssd2858_init_cmd[] = {
-	/* SSD2858 config */
-	{INIT_GENENIC_CMD, 2, {0xff, 0x00} },
-	/* LOCKCNT=0x1f4, MRX=0, POSTDIV=1 (/2} }, MULT=0x49
-	 * 27 Mhz => 985.5 Mhz */
-	{INIT_GENENIC_CMD, 6, {0x00, 0x08, 0x01, 0xf4, 0x01, 0x49} },
-	/* MTXDIV=1, SYSDIV=3 (=> 4) */
-	{INIT_GENENIC_CMD, 6, {0x00, 0x0c, 0x00, 0x00, 0x00, 0x03} },
-	/* MTXVPF=24bpp, MRXLS=4 lanes, MRXVB=bypass, MRXECC=1, MRXEOT=1
-	 * MRXEE=1 */
-	{INIT_GENENIC_CMD, 6, {0x00, 0x14, 0x0c, 0x3d, 0x80, 0x0f} },
-	{INIT_GENENIC_CMD, 6, {0x00, 0x20, 0x15, 0x92, 0x56, 0x7d} },
-	{INIT_GENENIC_CMD, 6, {0x00, 0x24, 0x00, 0x00, 0x30, 0x00} },
-
-	{INIT_GENENIC_CMD, 6, {0x10, 0x08, 0x01, 0x20, 0x08, 0x45} },
-	{INIT_GENENIC_CMD, 6, {0x10, 0x1c, 0x00, 0x00, 0x00, 0x00} },
-	{INIT_GENENIC_CMD, 6, {0x20, 0x0c, 0x00, 0x00, 0x00, 0x04} },
-	/* Pixel clock 985.5 Mhz * 0x49/0x4b = 959 Mhz */
-	{INIT_GENENIC_CMD, 6, {0x20, 0x10, 0x00, 0x4b, 0x00, 0x49} },
-	{INIT_GENENIC_CMD, 6, {0x20, 0xa0, 0x00, 0x00, 0x00, 0x00} },
-	/* EOT=1, LPE = 0, LSOUT=4 lanes, LPD=25 */
-	{INIT_GENENIC_CMD, 6, {0x60, 0x08, 0x00, 0xd9, 0x00, 0x08} },
-	{INIT_GENENIC_CMD, 6, {0x60, 0x14, 0x01, 0x00, 0x01, 0x06} },
-	/* DSI0 enable (default: probably not needed) */
-	{INIT_GENENIC_CMD, 6, {0x60, 0x80, 0x00, 0x00, 0x00, 0x0f} },
-	/* DSI1 enable */
-	{INIT_GENENIC_CMD, 6, {0x60, 0xa0, 0x00, 0x00, 0x00, 0x0f} },
-
-	/* HSA=0x18, VSA=0x02, HBP=0x50, VBP=0x0c */
-	{INIT_GENENIC_CMD, 6, {0x60, 0x0c, 0x0c, 0x50, 0x02, 0x18} },
-	/* VACT= 0x800 (2048} }, VFP= 0x14, HFP=0x50 */
-	{INIT_GENENIC_CMD, 6, {0x60, 0x10, 0x08, 0x00, 0x14, 0x50} },
-	/* HACT=0x300 (768) */
-	{INIT_GENENIC_CMD, 6, {0x60, 0x84, 0x00, 0x00, 0x03, 0x00} },
-	{INIT_GENENIC_CMD, 6, {0x60, 0xa4, 0x00, 0x00, 0x03, 0x00} },
-
-	/* Take panel out of sleep. */
-	{INIT_GENENIC_CMD, 2, {0xff, 0x01} },
-	{INIT_DCS_CMD, 1, {0x11} },
-	{DELAY_CMD, 120, {} },
-	{INIT_DCS_CMD, 1, {0x29} },
-	{DELAY_CMD, 20, {} },
-	{INIT_GENENIC_CMD, 2, {0xff, 0x00} },
-
-	{DELAY_CMD, 120, {} },
-	{INIT_DCS_CMD, 1, {0x11} },
-	{DELAY_CMD, 120, {} },
-	{INIT_DCS_CMD, 1, {0x29} },
-	{DELAY_CMD, 20, {} },
-};
-
-static void display_startup(void)
-{
-	int ret = 0;
-	u32 mipi_dsi_flags;
-	struct edid edid;
-
-	if (board_id() < 2) {
-		edid = kukui_innolux_edid;
-		mipi_dsi_flags = MIPI_DSI_MODE_VIDEO |
-				 MIPI_DSI_MODE_VIDEO_SYNC_PULSE |
-				 MIPI_DSI_MODE_LPM;
-	} else {
-		edid = kukui_p097pfg_ssd2858_edid;
-		mipi_dsi_flags = MIPI_DSI_MODE_VIDEO |
-				 MIPI_DSI_MODE_VIDEO_BURST |
-				 MIPI_DSI_MODE_LPM;
-	}
-
-	edid_set_framebuffer_bits_per_pixel(&edid, 32, 0);
-
-	mtk_ddp_init();
-	if (board_id() < 2)
-		ret = mtk_dsi_init(mipi_dsi_flags, MIPI_DSI_FMT_RGB888, 4,
-				   false, &edid, lcm_init_cmd,
-				   ARRAY_SIZE(lcm_init_cmd));
-	else {
-		ret = mtk_dsi_init(mipi_dsi_flags, MIPI_DSI_FMT_RGB888, 4,
-				   false, &edid, lcm_p097pfg_ssd2858_init_cmd,
-				   ARRAY_SIZE(lcm_p097pfg_ssd2858_init_cmd));
-	}
-
-	if (ret < 0) {
-		printk(BIOS_ERR, "dsi init fail\n");
-		return;
-	}
-
-	mtk_ddp_mode_set(&edid);
-
-	set_vbe_mode_info_valid(&edid, (uintptr_t)0);
-}
-
 static void mainboard_init(struct device *dev)
 {
-	if (display_init_required()) {
-		mtcmos_display_power_on();
-		mtcmos_protect_display_bus();
+	struct board_display_intf *cur_disp_intf = NULL;
-		configure_backlight();
-		configure_display();
-		display_startup();
-	} else {
-		printk(BIOS_INFO, "Skipping display init.\n");
-	}
+	if (display_init_required()) {
+		printk(BIOS_INFO, "Starting display init.\n");
+
+		cur_disp_intf = get_current_display_intf();
+		if (cur_disp_intf && !update_panel_info(cur_disp_intf)) {
+			mtcmos_display_power_on();
+			mtcmos_protect_display_bus();
+
+			cur_disp_intf->backlight(cur_disp_intf);
+			cur_disp_intf->power(cur_disp_intf);
+			display_startup(cur_disp_intf);
+		} else {
+			printk(BIOS_ERR,
+				"%s: Can't find correct display interface\n",
+				__func__);
+		}
+
+	} else
+		printk(BIOS_ERR, "Skipping display init.\n");
configure_emmc();
    configure_usb();
diff --git a/src/mainboard/google/kukui/panel_kukui.c b/src/mainboard/google/kukui/panel_kukui.c
new file mode 100644
index 0000000..28fe742
--- /dev/null
+++ b/src/mainboard/google/kukui/panel_kukui.c
@@ -0,0 +1,194 @@
+/*
+ * This file is part of the coreboot project.
+ *
+ * Copyright 2019 Huaqin Telecom Inc.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; version 2 of the License.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ */
+
+#include <console/console.h>
+#include <delay.h>
+#include <device/device.h>
+#include <edid.h>
+#include <gpio.h>
+#include <soc/auxadc.h>
+#include <soc/ddp.h>
+#include <soc/dsi.h>
+#include <soc/gpio.h>
+#include <boardid.h>
+
+#include "display.h"
+#include "gpio.h"
+
+static struct edid kukui_innolux_edid = {
+	.panel_bits_per_color = 8,
+	.panel_bits_per_pixel = 24,
+	.mode = {
+		.name = "768x1024@60Hz",
+		.pixel_clock = 56900,
+		.lvds_dual_channel = 0,
+		.refresh = 60,
+		.ha = 768, .hbl = 120, .hso = 40, .hspw = 40, .hborder = 0,
+		.va = 1024, .vbl = 44, .vso = 20, .vspw = 4, .vborder = 0,
+		.phsync = '-', .pvsync = '-',
+		.x_mm = 120, .y_mm = 160,
+	},
+};
+
+static struct lcm_init_table lcm_init_cmd[] = {
+	{INIT_DCS_CMD, 1, {MIPI_DCS_EXIT_SLEEP_MODE} },
+	{DELAY_CMD, 120, {} },
+	{INIT_DCS_CMD, 1, {MIPI_DCS_SET_DISPLAY_ON} },
+	{DELAY_CMD, 120, {} },
+};
+
+static struct edid kukui_p097pfg_ssd2858_edid = {
+	.panel_bits_per_color = 8,
+	.panel_bits_per_pixel = 24,
+	.mode = {
+		.name = "1536x2048@60Hz",
+		.pixel_clock = 229000,
+		.lvds_dual_channel = 0,
+		.refresh = 60,
+		.ha = 1536, .hbl = 160, .hso = 80, .hspw = 26, .hborder = 0,
+		.va = 2048, .vbl = 32, .vso = 20, .vspw = 2, .vborder = 0,
+		.phsync = '-', .pvsync = '-',
+		.x_mm = 147, .y_mm = 196,
+	},
+};
+
+struct lcm_init_table lcm_p097pfg_ssd2858_init_cmd[] = {
+	/* SSD2858 config */
+	{INIT_GENENIC_CMD, 2, {0xff, 0x00} },
+	/* LOCKCNT=0x1f4, MRX=0, POSTDIV=1 (/2} }, MULT=0x49
+	 * 27 Mhz => 985.5 Mhz
+	 */
+	{INIT_GENENIC_CMD, 6, {0x00, 0x08, 0x01, 0xf4, 0x01, 0x49} },
+	/* MTXDIV=1, SYSDIV=3 (=> 4) */
+	{INIT_GENENIC_CMD, 6, {0x00, 0x0c, 0x00, 0x00, 0x00, 0x03} },
+	/* MTXVPF=24bpp, MRXLS=4 lanes, MRXVB=bypass, MRXECC=1, MRXEOT=1
+	 * MRXEE=1
+	 */
+	{INIT_GENENIC_CMD, 6, {0x00, 0x14, 0x0c, 0x3d, 0x80, 0x0f} },
+	{INIT_GENENIC_CMD, 6, {0x00, 0x20, 0x15, 0x92, 0x56, 0x7d} },
+	{INIT_GENENIC_CMD, 6, {0x00, 0x24, 0x00, 0x00, 0x30, 0x00} },
+
+	{INIT_GENENIC_CMD, 6, {0x10, 0x08, 0x01, 0x20, 0x08, 0x45} },
+	{INIT_GENENIC_CMD, 6, {0x10, 0x1c, 0x00, 0x00, 0x00, 0x00} },
+	{INIT_GENENIC_CMD, 6, {0x20, 0x0c, 0x00, 0x00, 0x00, 0x04} },
+	/* Pixel clock 985.5 Mhz * 0x49/0x4b = 959 Mhz */
+	{INIT_GENENIC_CMD, 6, {0x20, 0x10, 0x00, 0x4b, 0x00, 0x49} },
+	{INIT_GENENIC_CMD, 6, {0x20, 0xa0, 0x00, 0x00, 0x00, 0x00} },
+	/* EOT=1, LPE = 0, LSOUT=4 lanes, LPD=25 */
+	{INIT_GENENIC_CMD, 6, {0x60, 0x08, 0x00, 0xd9, 0x00, 0x08} },
+	{INIT_GENENIC_CMD, 6, {0x60, 0x14, 0x01, 0x00, 0x01, 0x06} },
+	/* DSI0 enable (default: probably not needed) */
+	{INIT_GENENIC_CMD, 6, {0x60, 0x80, 0x00, 0x00, 0x00, 0x0f} },
+	/* DSI1 enable */
+	{INIT_GENENIC_CMD, 6, {0x60, 0xa0, 0x00, 0x00, 0x00, 0x0f} },
+
+	/* HSA=0x18, VSA=0x02, HBP=0x50, VBP=0x0c */
+	{INIT_GENENIC_CMD, 6, {0x60, 0x0c, 0x0c, 0x50, 0x02, 0x18} },
+	/* VACT= 0x800 (2048} }, VFP= 0x14, HFP=0x50 */
+	{INIT_GENENIC_CMD, 6, {0x60, 0x10, 0x08, 0x00, 0x14, 0x50} },
+	/* HACT=0x300 (768) */
+	{INIT_GENENIC_CMD, 6, {0x60, 0x84, 0x00, 0x00, 0x03, 0x00} },
+	{INIT_GENENIC_CMD, 6, {0x60, 0xa4, 0x00, 0x00, 0x03, 0x00} },
+
+	/* Take panel out of sleep. */
+	{INIT_GENENIC_CMD, 2, {0xff, 0x01} },
+	{INIT_DCS_CMD, 1, {0x11} },
+	{DELAY_CMD, 120, {} },
+	{INIT_DCS_CMD, 1, {0x29} },
+	{DELAY_CMD, 20, {} },
+	{INIT_GENENIC_CMD, 2, {0xff, 0x00} },
+
+	{DELAY_CMD, 120, {} },
+	{INIT_DCS_CMD, 1, {0x11} },
+	{DELAY_CMD, 120, {} },
+	{INIT_DCS_CMD, 1, {0x29} },
+	{DELAY_CMD, 20, {} },
+};
+
+struct panel_info kukui_panel_info[] = {
+	PANEL(PANEL_KUKUI_INNOLUX,
+	      74000,
+	      kukui_innolux_edid,
+	      lcm_init_cmd),
+	PANEL(PANEL_KUKUI_P097PFG_SSD2858,
+	      212000,
+	      kukui_p097pfg_ssd2858_edid,
+	      lcm_p097pfg_ssd2858_init_cmd),
+	{{PANEL_KUKUI_UNKNOWN}, "PANEL_KUKUI_UNKNOWN",
+	      0, NULL, NULL, 0},
+};
+
+
+static union panel_id kukui_get_panel_id(struct board_display_intf *intf)
+{
+	if (board_id() < 2)
+		return (union panel_id)PANEL_KUKUI_INNOLUX;
+	else
+		return (union panel_id)PANEL_KUKUI_P097PFG_SSD2858;
+};
+
+static bool kukui_is_panel_id_valid(union panel_id id)
+{
+	if (id.value < PANEL_KUKUI_UNKNOWN)
+		return true;
+	return false;
+};
+
+static int kukui_backlight(struct board_display_intf *intf)
+{
+	configure_backlight();
+	return 0;
+};
+
+static int kukui_power(struct board_display_intf *intf)
+{
+
+	if (board_id() < 2) {
+		/* board from p1 */
+		gpio_output(GPIO(LCM_RST), 0);
+		udelay(100);
+		gpio_output(GPIO(LCM_RST), 1);
+		mdelay(20);
+	} else {
+		/* board from p2 */
+		gpio_output(GPIO(LCM_RST), 0);
+		gpio_output(GPIO(BPI_BUS3), 0);
+		gpio_output(GPIO(MISC_BSI_CK_3), 1);
+		gpio_output(GPIO(PERIPHERAL_EN9), 1);
+		gpio_output(GPIO(SIM2_SRST), 1);
+		gpio_output(GPIO(SIM2_SIO), 1);
+		gpio_output(GPIO(BPI_OLAT1), 1);
+		gpio_output(GPIO(SIM2_SCLK), 1);
+		mdelay(20);
+		gpio_output(GPIO(LCM_RST), 1);
+		mdelay(20);
+		gpio_output(GPIO(BPI_BUS3), 1);
+		mdelay(20);
+	}
+
+	return 0;
+
+};
+
+struct board_display_intf kukui_display_intf = {
+	.board			= "kukui",
+	.all_panel_info		= kukui_panel_info,
+	.all_panel_info_size	= ARRAY_SIZE(kukui_panel_info),
+	.cur_panel_info		= NULL,
+	.get_panel_id		= &kukui_get_panel_id,
+	.is_panel_id_valid	= &kukui_is_panel_id_valid,
+	.backlight		= &kukui_backlight,
+	.power			= &kukui_power,
+};
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/32511
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I19213aee1ac0f69f42e73be9e5ab72394f412a01
Gerrit-Change-Number: 32511
Gerrit-PatchSet: 1
Gerrit-Owner: Kaka Ni nigang@huaqin.corp-partner.google.com
Gerrit-MessageType: newchange



    

Change in ...coreboot[master]: WIP: google/kukui: elaborate panel support for Kukui family boards.