3 comments:
File src/mainboard/google/kukui/panel.h:
Patch Set #54, Line 23: const char *name; /* human readable name */
Why don't we just use edid. […]
ascii_string currently holds only 13 chars, which can't fit manufacturer name + panel ID.
in fact I think the EDID parser should be refactored to always contain manufacturer name, but that's another story.
for now a pure larger char buffer would be the better idea.
File src/mainboard/google/kukui/panel.h:
Patch Set #38, Line 32: _INIT_DCS_CMD
Let's not start the thing that we actually want to use in the panel file with an underscore (undersc […]
I'm trying to make this compatible with kernel implementation. But well, removing a underline is fine.
Patch Set #38, Line 34: .len = sizeof((u8[]){__VA_ARGS__}), \
Nice, that's way more clever than what I said!
Ack
To view, visit change 32511. To unsubscribe, or for help writing mail filters, visit settings.