12 comments:
Patch Set #14, Line 7: google/kukui: Elaborate panel support for Kukui family boards.
Please remove the dot/period at the end.
information?
its
its
one space
File src/mainboard/google/kukui/display.h:
/*
* board related functions
*/
Are these comments needed?
File src/mainboard/google/kukui/display.c:
Did you run this through clang-format?
Patch Set #14, Line 38: printk(BIOS_ERR, "%s: wrong parameters\n", __func__);
Error messages should be more elaborate, so a user can understand it.
Patch Set #14, Line 52: printk(BIOS_ERR, "dsi init fail\n");
Maybe?
DSI initialization failed. Continue without.
Patch Set #14, Line 93: /* Exported Functions */
Are these comments neeeded?
We have error codes in coreboot. CB_SUCCESS, …
File src/mainboard/google/kukui/panel_kukui.c:
Patch Set #14, Line 34: .name = "768x1024@60Hz",
Isn’t it landscape?
To view, visit change 32511. To unsubscribe, or for help writing mail filters, visit settings.